nfs-utils.git
7 years agonfsdcld: make it watch for inotify events in the containing directory
Jeff Layton [Thu, 26 Apr 2012 15:54:37 +0000 (11:54 -0400)]
nfsdcld: make it watch for inotify events in the containing directory

Before opening the pipe, set an inotify watch on the containing dir and
then try to open the pipe. If it succeeds, then set up pipe and inotify
events and return success. If it fails with -ENOENT, then just set up
the inotify event and return success. If it fails with any other error
then return the error and the caller can then abort the program.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsdcld: add function to remove unreclaimed client records
Jeff Layton [Thu, 26 Apr 2012 15:48:52 +0000 (11:48 -0400)]
nfsdcld: add function to remove unreclaimed client records

This should remove any client record that has a timestamp prior to
the given time.

Eventually, this call will need to be made cluster aware when this is
run in a clustered configuration. For now, this is only suitable for
single-host configurations.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsdcld: add check/update functionality
Jeff Layton [Thu, 26 Apr 2012 15:47:58 +0000 (11:47 -0400)]
nfsdcld: add check/update functionality

Add functions to check whether a client is allowed to reclaim, and
update its timestamp in the DB if so. If either the query or update
fails, then the host is not allowed to reclaim state.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsdcld: add remove functionality
Jeff Layton [Thu, 26 Apr 2012 15:46:14 +0000 (11:46 -0400)]
nfsdcld: add remove functionality

Allow the kernel to ask for removal of a client record.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsdcld: add routines for a sqlite backend database
Jeff Layton [Thu, 26 Apr 2012 15:43:30 +0000 (11:43 -0400)]
nfsdcld: add routines for a sqlite backend database

Rather than roll our own "storage engine", use sqlite instead. It fits
the bill nicely as it does:

- durable on-disk storage
- the ability to constrain record uniqueness
- a facility for collating and searching the host records

...it does add a build dependency to nfs-utils, but almost all modern
distros provide those packages.

The current incarnation of this code dynamically links against a
provided sqlite library, but we could also consider including their
single-file "amalgamation" to reduce dependencies (though with all
the caveats that that entails).

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsdcld: add autoconf goop for sqlite
Jeff Layton [Thu, 26 Apr 2012 15:29:22 +0000 (11:29 -0400)]
nfsdcld: add autoconf goop for sqlite

Mostly cribbed from Chuck Lever's new-statd rewrite a few years ago...

This adds an autoconf test for the sqlite3 library and includes. If
they're not working properly and nfsdcld was enabled, then configure
will error out.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsdcld: add client tracking daemon stub
Jeff Layton [Thu, 26 Apr 2012 15:22:46 +0000 (11:22 -0400)]
nfsdcld: add client tracking daemon stub

This program opens and "listens" on the new nfsd/cld rpc_pipefs pipe.
The code here doesn't actually do anything on stable storage yet. That
will be added in a later patch.

The patch also adds a autoconf enable switch for the new daemon that
defaults to "no", and a test for the upcall description header file.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoAdd -l option to gssd to force legacy behaviour
Michael Weiser [Mon, 16 Apr 2012 10:49:21 +0000 (06:49 -0400)]
Add -l option to gssd to force legacy behaviour

Implement a new option -l to force gssd to ignore its kernel's crypto
capabilities and use just the Single DES legacy encryption types to be
compatible with old servers. This is only relevant if those servers have
strong keys in their keytab.

Signed-off-by: Steve Dickson <steved@redhat.com>
Tested-by: Michael Weiser <weiser@science-computing.de>
7 years agorpc.gssd: Links directly with libgssapi_krb5 which not needed.
Steve Dickson [Thu, 26 Jan 2012 19:56:13 +0000 (14:56 -0500)]
rpc.gssd: Links directly with libgssapi_krb5 which not needed.

rpc.gssd and rpc.svcgssd both link with the libgssapi_krb5 and
libgssglue libraries which is not needed since libgssglue
will dynamically load the gssapi interface defined in the
/etc/gssapi_mech.conf. Most likely the libgssapi_krb5 library.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agogssd: Look for user creds in user defined directory
Steve Dickson [Thu, 22 Mar 2012 15:02:46 +0000 (11:02 -0400)]
gssd: Look for user creds in user defined directory

The user credential cache currently is kept in /tmp.
In upcoming Kerberos release that will be moved to
/run/user/<username>/. This patch enables gssd to
look in both the old and new caches

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsd: Bump up the default to 8 nprocs
Steve Dickson [Fri, 16 Mar 2012 13:34:43 +0000 (09:34 -0400)]
nfsd: Bump up the default to 8 nprocs

When the nproc argument is not given the rpc.nfsd
a default number of processes is created. This
patch bumps that default up from 1 to 8.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agorpc.idmap: Hide global symbols from libidmap plugins
Noah Friedman [Thu, 15 Mar 2012 16:52:50 +0000 (12:52 -0400)]
rpc.idmap: Hide global symbols from libidmap plugins

This patch limits the visibility of the symbols in the nfs-utils
conffile.c so that they are only visible to programs linked directly to
it.  This forces the objects dynamically loaded via libnfsidmap to use
the functions defined in that shared library instead.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoKill SPKM3: Remove also the dependent lipkey mechanism
Simo Sorce [Mon, 12 Mar 2012 21:06:41 +0000 (17:06 -0400)]
Kill SPKM3: Remove also the dependent lipkey mechanism

Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoKill SPKM3: Remove mentions of SPKM3 from README
Simo Sorce [Mon, 12 Mar 2012 19:52:09 +0000 (15:52 -0400)]
Kill SPKM3: Remove mentions of SPKM3 from README

Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoKill SPKM3: Stop checking for spkm3.h in configure
Simo Sorce [Mon, 12 Mar 2012 19:51:33 +0000 (15:51 -0400)]
Kill SPKM3: Stop checking for spkm3.h in configure

Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoKill SPKM3: Remove spkm3 support from exports
Simo Sorce [Mon, 12 Mar 2012 19:49:50 +0000 (15:49 -0400)]
Kill SPKM3: Remove spkm3 support from exports

signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoKill SPKM3: Remove spkm3 support from nfs.mount
Simo Sorce [Mon, 12 Mar 2012 19:48:50 +0000 (15:48 -0400)]
Kill SPKM3: Remove spkm3 support from nfs.mount

Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoKill SPKM3: remove spkm3 from common gssd code
Simo Sorce [Mon, 12 Mar 2012 19:48:04 +0000 (15:48 -0400)]
Kill SPKM3: remove spkm3 from common gssd code

Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoKill SPKM3: Remove spkm3 support from gssd
Simo Sorce [Mon, 12 Mar 2012 19:44:26 +0000 (15:44 -0400)]
Kill SPKM3: Remove spkm3 support from gssd

Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoKill SPKM3: Remove spkm3 references from svcgssd
Simo Sorce [Mon, 12 Mar 2012 19:43:22 +0000 (15:43 -0400)]
Kill SPKM3: Remove spkm3 references from svcgssd

Signed-off-by: Simo Sorce <simo@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoexportfs: Removed warnings about routines not being prototyped
Steve Dickson [Mon, 12 Mar 2012 19:39:19 +0000 (15:39 -0400)]
exportfs: Removed warnings about routines not being prototyped

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoexportfs: Stop racing exportfs on clusters
Steve Dickson [Mon, 12 Mar 2012 17:17:15 +0000 (13:17 -0400)]
exportfs: Stop racing exportfs on clusters

This problem can occur when multiple cluster services fail over
at the same time, causing missing high-available exports.
Having a lot of nfs-exports will trigger this issue easier.

https://bugzilla.linux-nfs.org/show_bug.cgi?id=224

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsmount: Fixed parsing error in the nfsmount.conf code.
Steve Dickson [Tue, 6 Mar 2012 16:03:38 +0000 (11:03 -0500)]
nfsmount: Fixed parsing error in the nfsmount.conf code.

When the options where prefixed with spaces (instead of tabs)
the second option in the list was missed to so a miscalculation
the the nfsmount.conf parsing code.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfs-utils: exports man page: no_acl is not supported
Harshula Jayasuriya [Wed, 29 Feb 2012 20:41:17 +0000 (15:41 -0500)]
nfs-utils: exports man page: no_acl is not supported

The inclusion of no_acl in the exports man page is confusing since it is
not actually supported (v3.3-rc3):

1090 static struct flags {
1091         int flag;
1092         char *name[2];
1093 } expflags[] = {
1094         { NFSEXP_READONLY, {"ro", "rw"}},
1095         { NFSEXP_INSECURE_PORT, {"insecure", ""}},
1096         { NFSEXP_ROOTSQUASH, {"root_squash", "no_root_squash"}},
1097         { NFSEXP_ALLSQUASH, {"all_squash", ""}},
1098         { NFSEXP_ASYNC, {"async", "sync"}},
1099         { NFSEXP_GATHERED_WRITES, {"wdelay", "no_wdelay"}},
1100         { NFSEXP_NOHIDE, {"nohide", ""}},
1101         { NFSEXP_CROSSMOUNT, {"crossmnt", ""}},
1102         { NFSEXP_NOSUBTREECHECK, {"no_subtree_check", ""}},
1103         { NFSEXP_NOAUTHNLM, {"insecure_locks", ""}},
1104         { NFSEXP_V4ROOT, {"v4root", ""}},
1105         { 0, {"", ""}}
1106 };

Signed-off-by: Harshula Jayasuriya <harshula@redhat.com>
Acked-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoautoconf: only link binaries that need it to libtirpc nfs-utils-1-2-6-rc6
Jeff Layton [Mon, 16 Jan 2012 19:39:25 +0000 (14:39 -0500)]
autoconf: only link binaries that need it to libtirpc

This patch is essentially the same as the previous version, but has
been respun to fix up some merge conflicts with some of Chuck's
recent changes.

When we first added tirpc support, we took a "big hammer" approach, and
had it add libtirpc to $LIBS. That had the effect of making it so that
that library was linked into every binary. That's unnecessary, and
wasteful with memory.

Don't let AC_CHECK_LIB add -ltirpc to $LIBS. Instead, have the autoconf
tests set $(LIBTIRPC) in the makefiles, and have the programs that
need it explicitly include that library. In the event that we're not
using libtirpc, then set $LIBTIRPC to a blank string.

This necessitates a change to the bindresvport_sa check too. Since that
library is no longer included in $LIBS, we need to convert that check
to use AC_CHECK_LIB instead of AC_CHECK_FUNCS.

This patch also fixes a subtle bug. If the library was usable, but the
includes were not, the test would set $enable_tirpc to "no", but
HAVE_LIBTIRPC would still be true. That configuration would likely
fail to build.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsidmap: Purge the keyring when its full.
Steve Dickson [Thu, 12 Jan 2012 20:09:49 +0000 (15:09 -0500)]
nfsidmap: Purge the keyring when its full.

When a key can not be added to a keyring because
the keyring is full or there is no memory for
the playload, keyctl_instantiate() will fail
and set the errno to -EDQUOT, -ENFILE or
-ENOMEM

When this happens, purge the keyring to
free things up and then try to re-add
the key.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agomountd: Support junction management plug-ins nfs-utils-1-2-6-rc5
Chuck Lever [Thu, 5 Jan 2012 21:24:16 +0000 (16:24 -0500)]
mountd: Support junction management plug-ins

To support FedFS and NFS junctions without introducing additional
build-time or run-time dependencies on nfs-utils, the community has
chosen to use a dynamically loadable library to handle junction
resolution.

There is one plug-in library for mountd that will handle any NFS-
related junction type.  Currently there are two types:

  o nfs-basic locally stored file set location data, and

  o nfs-fedfs file set location data stored on an LDAP server

mountd's support for this library is enabled at build time by the
presence of the junction API definition header:

  /usr/include/nfs-plugin.h

If this header is not found on the build system, mountd will build
without junction support, and will operate as before.

Note that mountd does not cache junction resolution results.  NFSD
already caches these results in its exports cache.  Thus each time
NFSD calls up to mountd, it is, in essence, requesting a fresh
junction resolution operation, not a cached response.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agomountd: remove newline from xlog() format specifier strings
Chuck Lever [Thu, 5 Jan 2012 21:03:08 +0000 (16:03 -0500)]
mountd: remove newline from xlog() format specifier strings

Clean up: xlog() already adds a newline to the end of each line of
output.  Remove the superfluous newline from a number of xlog()
call sites in mountd.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agomountd: Plug v4root memory leak
Chuck Lever [Thu, 5 Jan 2012 21:01:22 +0000 (16:01 -0500)]
mountd: Plug v4root memory leak

Valgrind reports that the memory allocated for eep's e_hostname field
was not being freed.  eep is not visible outside of v4root_create(),
so we don't need to strdup() that string.

Introduced by commit 3b777b0 "exports: NFSv4 pseudoroot support
routines" (Dec 1, 2009).

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoconfigure.ac: Don't check for AI_ADDRCONFIG
Chuck Lever [Thu, 5 Jan 2012 20:54:00 +0000 (15:54 -0500)]
configure.ac: Don't check for AI_ADDRCONFIG

Commit 1ea2c3be: "nfs-utils: Remove all uses of AI_ADDRCONFIG,"
(October 28, 2010) removed the last use of AI_ADDRCONFIG.  Even so,
ipv6.m4 uses this check to ensure that the local getaddrinfo(3)
implementation is recent.  Maybe we shouldn't bother.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoconfigure.ac: Clean up help string for --with-statdpath
Chuck Lever [Thu, 5 Jan 2012 20:51:42 +0000 (15:51 -0500)]
configure.ac: Clean up help string for --with-statdpath

Neither m4 nor the vim colorizer like unbalanced single quotes.
Similar change as commit 34ee5730.

Also, the default value of the command line option is conventionally
listed in the right-hand side argument of AC_HELP_STRING.

Introduced by commit 5c3e2665: "statd: Decouple statd's state
directory from the NFS state directory," (September 20, 2011).

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agoautoconf: don't let libnfsidmap test add -lnfsidmap to $LIBS
Jeff Layton [Fri, 23 Dec 2011 19:41:11 +0000 (14:41 -0500)]
autoconf: don't let libnfsidmap test add -lnfsidmap to $LIBS

...as that makes that library get linked into every binary. Also,
replace "hardcoded" -lnfsidmap linker flag in Makefiles with
a AC_SUBST variable.

This fixes a regression introduced in commit d7c64dd.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
7 years agoautoconf: fix up libevent autoconf test
Jeff Layton [Fri, 23 Dec 2011 14:04:54 +0000 (09:04 -0500)]
autoconf: fix up libevent autoconf test

Have it set LIBEVENT to -levent and use that in the Makefiles instead
of hardcoding it.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
7 years agogssd: avoid double-free upon write failure
Jim Meyering [Thu, 5 Jan 2012 18:37:04 +0000 (13:37 -0500)]
gssd: avoid double-free upon write failure

Free just calloc'd enc_key.data from one place, unconditionally,
after calling write_lucid_keyblock, rather than from three places.

Coverity spotted the possible double free.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agomount.nfs: don't overwrite mount options from /etc/nfsmount.conf
Karel Zak [Thu, 5 Jan 2012 18:32:26 +0000 (13:32 -0500)]
mount.nfs: don't overwrite mount options from /etc/nfsmount.conf

The libmount (as well as mount(8)) ignores mount options from command
line if running in restricted mode (suid, non-root-user) and all
options are read from fstab only.

It means that all options are replaced with stuff from fstab,
including mount options from nfsmount.conf. This is bug.

We have to apply fstab and then nfsmount.conf.

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsctl: fix building with newer arches
Mike Frysinger [Thu, 5 Jan 2012 18:21:24 +0000 (13:21 -0500)]
nfsctl: fix building with newer arches

Newer arches omitting both nfsctl and nfsservctl which breaks nfsctl.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsidmap: Stack variable not being initialized. nfs-utils-1-2-6-rc4
Steve Dickson [Tue, 13 Dec 2011 19:49:00 +0000 (14:49 -0500)]
nfsidmap: Stack variable not being initialized.

The 'clearing' variable was not being initialized
to zero which was cause the default key ring to
always be cleared.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agomount.nfs: Background mounts failing on time out errors.
Steve Dickson [Mon, 5 Dec 2011 14:48:46 +0000 (09:48 -0500)]
mount.nfs: Background mounts failing on time out errors.

Mounting with the "-o v3,bg,proto=udp" options will
fail, instead of retrying, when the server is down.
The reason being nfs_rewrite_pmap_mount_options()
does not interrupt RPC timeouts correctly.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsidmap: Allow a particular key to be revoked.
Steve Dickson [Thu, 17 Nov 2011 19:39:43 +0000 (14:39 -0500)]
nfsidmap: Allow a particular key to be revoked.

Introducing three new command line arguments
that allow particular keys to be revoke

  -u will remove a uid key
  -g will revoke a gid key
  -r will revoke both the uid and gid keys

A user name has also needs to be supply with
these new flags.

Signed-off-by: Steve Dickson <steved@redhat.com>
7 years agonfsidmap: Allow keys to be cleared from the keyring
Steve Dickson [Thu, 17 Nov 2011 18:02:38 +0000 (13:02 -0500)]
nfsidmap: Allow keys to be cleared from the keyring

Added the '-c' command line argument that will
clear all the keys from the keyring.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agorpc.idmapd: Sections in idmapd.conf are ignored. nfs-utils-1-2-6-rc3
Steve Dickson [Mon, 14 Nov 2011 14:54:47 +0000 (09:54 -0500)]
rpc.idmapd: Sections in idmapd.conf are ignored.

In the parsing routine, conf_parse_line(), a string
is not being null terminated which is causing
section of the config file to be ignored.

https://bugzilla.linux-nfs.org/show_bug.cgi?id=205

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsidmap: Added -v and -t flags
Steve Dickson [Mon, 14 Nov 2011 14:47:21 +0000 (09:47 -0500)]
nfsidmap: Added -v and -t flags

To aid in debugging, the -v flag can now be specified,
multiple time, on the command line to enable verbose
logging in both the nfsidmap command and libnfsidmap
library routines.

Also converted the timeout argument to use a -t flag.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsidmap: Added Error Logging
Steve Dickson [Fri, 11 Nov 2011 18:11:17 +0000 (13:11 -0500)]
nfsidmap: Added Error Logging

Since this binary is being called by the kernel, errors
need to be logged to the syslog for help in debugging problems.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agorpcdebug: Add missing debug flags
Steve Dickson [Wed, 19 Oct 2011 20:37:34 +0000 (16:37 -0400)]
rpcdebug: Add missing debug flags

This patch added the following debug flags:

fscache - enable FSCache debugging
pnfs - enable general pNFS debugging
pnfs_ld - enable pNFS layout debugging

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agomount.nfs: Mount should really return from errno test nfs-utils-1-2-6-rc2
Yang Bai [Tue, 18 Oct 2011 15:53:11 +0000 (11:53 -0400)]
mount.nfs: Mount should really return from errno test

We should only try next address family if we meet ECONNREFUSED or
EHOSTUNREACH for v4 or ECONNREFUSED or EOPNOTSUPP or EHOSTUNREACH for v3v2.
Before, only a break in swich can not make the program out of for loop.

Signed-off-by: Yang Bai <hamo.by@gmail.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agorpc.idmapd: Dies with 'I/O possible'
Luca Giuzzi [Tue, 4 Oct 2011 17:35:06 +0000 (13:35 -0400)]
rpc.idmapd: Dies with 'I/O possible'

We have had problems on some of our machines (all Fedora 14), where
rpc.idmapd used to die with an `I/O possible' message at (basically)
random times. A strace suggested the issue being in nfsopen() where a
signal type is reset before notification is disabled; a signal at just
the right time might be the cause of the problem; see
https://bugzilla.redhat.com/show_bug.cgi?id=684308

Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoman pages: fixed a few typos in a couple man pages
Steve Dickson [Tue, 4 Oct 2011 16:39:08 +0000 (12:39 -0400)]
man pages: fixed a few typos in a couple man pages

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfs.man: Fix macro use nfs-utils-1-2-6-rc1
Luk Claes [Mon, 3 Oct 2011 12:46:54 +0000 (08:46 -0400)]
nfs.man: Fix macro use

The groff macros for filling (word-wrapping) and tabulation control are
lower-case, but are written in upper-case here and so have been ignored.

Change the .NF and .FI lines to lower-case.

Change the .TA lines to lower-case and fix the tab stops to work both
on a terminal and in Postscript output.

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoblkmapd: Use getconf(_SC_PAGE_SIZE)
Luk Claes [Mon, 3 Oct 2011 12:42:20 +0000 (08:42 -0400)]
blkmapd: Use getconf(_SC_PAGE_SIZE)

PAGE_SIZE is not exported by all architectures as it is not fixed: it
can depend on the model of the machine. So it's better to query the
system configuration for the actual page size on the machine.

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoconfigure.ac: Add dependency on devmapper for blkmapd
Jim Rees [Mon, 26 Sep 2011 19:21:16 +0000 (15:21 -0400)]
configure.ac: Add dependency on devmapper for blkmapd

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoRelease 1.2.5 nfs-utils-1-2-5
Steve Dickson [Fri, 23 Sep 2011 13:17:19 +0000 (09:17 -0400)]
Release 1.2.5

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoconfigure.ac: Added a v4.1 dependency on v4.0
Steve Dickson [Fri, 23 Sep 2011 13:16:31 +0000 (09:16 -0400)]
configure.ac: Added a v4.1 dependency on v4.0

Make sure v4.0 is enabled when v4.1 is enabled.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoconfigure.ac: Removed unused defines in config.h
Steve Dickson [Fri, 23 Sep 2011 13:16:00 +0000 (09:16 -0400)]
configure.ac: Removed unused defines in config.h

Cleaned out 3 unused defines from config.h

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoconfigure.ac: Remove the NFS v3 enable flag
Steve Dickson [Fri, 23 Sep 2011 13:15:25 +0000 (09:15 -0400)]
configure.ac: Remove the NFS v3 enable flag

Removed the unused macros that enable and disable V3.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoblkmapd: Add complex block layout discovery and mapping daemon
Steve Dickson [Thu, 22 Sep 2011 18:47:09 +0000 (14:47 -0400)]
blkmapd: Add complex block layout discovery and mapping daemon

This daemon is required to handle upcalls from the kernel pnfs block
layout driver.

Signed-off-by: Jim Rees <rees@umich.edu>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agomountstats: Breaks on 3.1 kernels nfs-utils-1-2-5-rc3
Steve Dickson [Wed, 21 Sep 2011 18:05:07 +0000 (14:05 -0400)]
mountstats: Breaks on 3.1 kernels

mountstats depend on all devices entries in /proc/self/mountstats
to start with the word 'device'. With 3.1 kernels, NFS entries
start with the actual device (i.e. server:/export) not
the word 'device'. This change confused mountstats parsing.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsiostat: Breaks on 3.1 kernels
Steve Dickson [Wed, 21 Sep 2011 17:52:49 +0000 (13:52 -0400)]
nfsiostat: Breaks on 3.1 kernels

nfsiostat depend on all devices entries in /proc/self/mountstats
to start with the word 'device'. With 3.1 kernels, NFS entries
start with the actual device (i.e. server:/export) not
the word 'device'. This change confused nfsiostat parsing.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoidmapd: Fix decoding of octal encoded fields
Jan-Marek Glogowski [Tue, 20 Sep 2011 18:33:22 +0000 (14:33 -0400)]
idmapd: Fix decoding of octal encoded fields

The decoded octal will always be positive and (char) -1 is negative. Any
field containing an encoded octal will be rejected.

As the encoded value should be an unsigned char, fix the check to reject
all values > (unsigned char) -1 = UCHAR_MAX, as this indicate an error
in the encoding.

Signed-off-by: Jan-Marek Glogowski <glogow@fbihome.de>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agostatd: Decouple statd's state directory from the NFS state directory
Steve Dickson [Tue, 20 Sep 2011 16:52:46 +0000 (12:52 -0400)]
statd: Decouple statd's state directory from the NFS state directory

To allow greater flexibility to where statd's state is kept,
statd's state path can now be decoupled from the normal
NFS state directory.

In configure.ac, the NSM_DEFAULT_STATEDIR definition will now define
the path to where the state information is kept.  The default
value, /var/lib/nfs, can be redefined with the --with-statdpath
flag.

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsd: allow choosing server 41 support at runtime
J. Bruce Fields [Tue, 20 Sep 2011 11:40:15 +0000 (07:40 -0400)]
nfsd: allow choosing server 41 support at runtime

In the case where -N 4.1 is left off the commandline, the current code
explicitly turns it on or off anyway, depending on configure options.

Instead, just leave 4.1 support alone.  This allows a user to add an
"echo +4.1 >/proc/fs/nfsd/versions" to their init scripts, if they want.
Otherwise they will get the kernel's default (currently to leave 4.1
off, as long as 4.1 support is experimental).

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agosm-notify: sm-notify leaves monitor records in sm.bak
Chuck Lever [Mon, 19 Sep 2011 18:23:54 +0000 (14:23 -0400)]
sm-notify: sm-notify leaves monitor records in sm.bak

sm-notify fails to remove monitor records from sm.bak when it has
finally notified a host.  This is because of a recent change to send
two SM_NOTIFY requests for each monitored peer: one with the local
host's FQDN, and one with an unqualified version of same.  This was
commit baa41b2c: "sm-notify: Send fully-qualified and unqualified
mon_names" (March 19, 2010).

Because of the March 2010 commit, sm-notify modifies the "my_name"
string during notification, but then uses this modified string to try
to find the monitor record to remove.  Of course the search for the
record fails.  So a persistent monitor record is left in sm.bak.

Aside from leaving trash around, this causes the same hosts to be
notified after every reboot, even if they successfully responded to
the previous SM_NOTIFY and they had no contact with us during the last
boot.

I also noticed that the trick of truncating the argument of SM_NOTIFY
doesn't work at all if a substitute "my_name" was specified via the "-v"
command line option.  This patch attempts to address that as well.

sm-notify should preserve the original my_name string so that
nsm_delete_host() can find the correct monitor record to delete.  Also
add some degree of protection to the mon_name and my_name strings in
each nsm_host record to prevent a future change from breaking this
dependency.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agosm-notify: Avoid extra rpcbind queries
Chuck Lever [Mon, 19 Sep 2011 18:20:25 +0000 (14:20 -0400)]
sm-notify: Avoid extra rpcbind queries

The logic in notify_host() watches the host->retries counter to see if
progress is not being made.  If progress stalls, notify_host() tries
another IP address.  This means sm-notify will generate a fresh
rpcbind query.

After an RPC succeeds, be sure to reset host->retries so sm-notify
doesn't start walking down the host's addrinfo list when we _are_
making progress.  In the common case, if the host responds, we avoid
extra rpcbind queries and send all requests for the host to the same
IP address.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agosm-notify: Use correct retransmit timeout when sending a fresh RPC
Chuck Lever [Mon, 19 Sep 2011 18:18:47 +0000 (14:18 -0400)]
sm-notify: Use correct retransmit timeout when sending a fresh RPC

An RPC retransmit timeout should start out the same for each new RPC
request.  Don't increase the retransmit timeout after receiving the
reply to the rpcbind query.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agosm-notify: Refactor insert_host() and recv_rpcbind_reply()
Chuck Lever [Mon, 19 Sep 2011 18:17:02 +0000 (14:17 -0400)]
sm-notify: Refactor insert_host() and recv_rpcbind_reply()

Clean up: refactor the logic in recv_rpcbind_reply() that re-schedules
an nsm_host into a separate helper function

Adjust debugging messages so it's always apparent when an nsm_host is
rescheduled.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsumount: Squelch compiler warning
Chuck Lever [Mon, 19 Sep 2011 18:10:08 +0000 (14:10 -0400)]
nfsumount: Squelch compiler warning

nfsumount.c: In function nfs_umount_is_vers4:
nfsumount.c:164: warning: conversion to int from size_t may alter its value
nfsumount.c:173: warning: conversion to ?size_t? from int may change the sign of the result

Introduced by commit 3564ebbf.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoconfigure.ac: Clean up help string for --enable-mount
Chuck Lever [Mon, 19 Sep 2011 18:03:40 +0000 (14:03 -0400)]
configure.ac: Clean up help string for --enable-mount

Clean up a nit: The vim colorizer stumbles on the single quote in
"don't", so replace it with "do not".

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoconfigure.ac: Fix help string for --with-statedir= option
Chuck Lever [Mon, 19 Sep 2011 18:02:10 +0000 (14:02 -0400)]
configure.ac: Fix help string for --with-statedir= option

The help string for --with-statedir attempts to show "/var/lib/nfs" in
square brackets, but they don't appear on my system (Fedora 13).  Use
the AC_HELP_STRING macro to display the help string properly, like all
the other "with" and "enable" options specified in our configure.ac.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsidmap: auto disable when keyutils is not found
Mike Frysinger [Wed, 14 Sep 2011 18:22:21 +0000 (14:22 -0400)]
nfsidmap: auto disable when keyutils is not found

Since we already auto-disable based on libnfsidmap capabilities, don't
make keyutils a hard failure.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agomount.nfs: Preserve any explicit port=2049 option
Ben Hutchings [Wed, 14 Sep 2011 17:25:19 +0000 (13:25 -0400)]
mount.nfs: Preserve any explicit port=2049 option

If NFS port (2049) is supplied explicitly, don't ignore this setting
by requesting it to portmapper again.

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoexportfs: do not warn if /etc/exports.d/ does not exist
Mike Frysinger [Thu, 1 Sep 2011 15:34:25 +0000 (11:34 -0400)]
exportfs: do not warn if /etc/exports.d/ does not exist

It isn't uncommon for /etc/exports.d/ to not exist, and imo, it's not
that big of a deal as often times, a simple /etc/exports is sufficient.
So silently skip the case where the dir is missing.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoexportfs: drop extra newline in xlog
Mike Frysinger [Thu, 1 Sep 2011 15:33:06 +0000 (11:33 -0400)]
exportfs: drop extra newline in xlog

Since xlog() itself appends a newline, we don't want to add our own
otherwise we get extra in the output.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoUpdate nfs(5) manpage - timeo for NFS/TCP
Max Matveev [Tue, 30 Aug 2011 12:40:33 +0000 (08:40 -0400)]
Update nfs(5) manpage - timeo for NFS/TCP

NFS/TCP does linear backoff then retransmiting - the manpage
was mistakenly asserting the "no backoff" theory.

Signed-off-by: Max Matveev <makc@redhat.com>
Signed-off-by: Jim Rees <rees@umich.edu>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agosm-notify: sm-notify doesn't handle localhost properly nfs-utils-1-2-5-rc2
Chuck Lever [Mon, 29 Aug 2011 17:22:21 +0000 (13:22 -0400)]
sm-notify: sm-notify doesn't handle localhost properly

It looks like the existing algorithm for verifying the passed-in bind
address is as broken as statd_matchhostname() used to be: for IP
addresses, AI_CANONNAME is useless.  We need to have getnameinfo(3) or
equivalent in there.

Clean up: extract the logic that verifies the command line bind
address into its own function, and make it handle canonical name
lookup correctly.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoexportfs: matchhostname() doesn't handle localhost properly
Chuck Lever [Mon, 29 Aug 2011 17:20:22 +0000 (13:20 -0400)]
exportfs: matchhostname() doesn't handle localhost properly

Same change as statd_matchhostname() is necessary for the logic in
exportfs.

Recall that these are "separate but nearly equal" because the exportfs
version requires extra expensive string checking that would be onerous
for statd.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agostatd: statd_matchhostname() doesn't handle localhost properly
Chuck Lever [Mon, 29 Aug 2011 17:18:25 +0000 (13:18 -0400)]
statd: statd_matchhostname() doesn't handle localhost properly

The job of statd_matchhostname() is to work hard at matching two
hostnames or presentation IP addresses that may refer to the same
host.

statd_matchhostname() turns the hostname of the local system into a
list of addresses containing only the loopback address.  The actual
DNS registered address of the system does not appear in that list.

Presentation IP addresses, on the other hand, are soundly ignored by
the AI_CANONNAME option of getaddrinfo(3).  The ai_canonname string
that is returned is just the same presentation IP address.  And the
resulting list of addresses contains just that IP address.

So if the DNS registered IP address of the local host is passed in as
one argument, and the local hostname is passed as the other argument,
statd_matchhostname() whiffs and believes there is no match.  To fix
this, the logic needs to be smarter about deriving a hostname from an
IP address.

This appears to cause no end of trouble: monitor records pile up in
/var/lib/nfs/sm and sm.bak, notifications are missed, and so on.  This
has likely been around since commit cbd3a131 "statd: Introduce statd
version of matchhostname()" (Jan 14, 2010).

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agosm-notify: Disable syslog messages when debugging is enabled
Chuck Lever [Mon, 29 Aug 2011 17:13:15 +0000 (13:13 -0400)]
sm-notify: Disable syslog messages when debugging is enabled

statd's "-F" flag disables syslog output, and specifies sm-notify's
"-d" option when it runs it.  sm-notify's "-d" option should therefore
also disable syslog output.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agostatd: Report count of loaded hosts correctly
Chuck Lever [Mon, 29 Aug 2011 17:11:58 +0000 (13:11 -0400)]
statd: Report count of loaded hosts correctly

Fix a debugging message to report correctly the count of hosts loaded
when statd starts up.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agopdate addres for Free Software Foundation
NeilBrown [Mon, 29 Aug 2011 16:56:17 +0000 (12:56 -0400)]
pdate addres for Free Software Foundation

License texts contain multiple address for FSF, some wrong.
So update them and  replace COPYING file with
http://www.gnu.org/licenses/gpl-2.0.txt
which has a few changes to preamble and commentary.

Also remove extra COPYING file from utils/statd/

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoumount.nfs: fix nfs4 check
Ian Kent [Mon, 29 Aug 2011 16:29:36 +0000 (12:29 -0400)]
umount.nfs: fix nfs4 check

From: Ian Kent <ikent@redhat.com>

nfs_umount_is_vers4() doesn't take acount of the escaping of characters
seen in /proc/mounts and /etc/mtab as the functions in fstab.c do. This
leads to an inability to umount a mount containing any of these escaped
characters (like spaces).

This patch changes nfs_umount_is_vers4() to use functions in fstab.c and
adds a function to fstab.c to read /proc/mounts specifically, as it was
used  for the check in nfs_umount_is_vers4() previously.

Signed-off-by: Ian Kent <ikent@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agostart-statd: Use bash as -p is no POSIX
Luk Claes [Mon, 29 Aug 2011 16:04:25 +0000 (12:04 -0400)]
start-statd: Use bash as -p is no POSIX

sh -p is not guaranteed to be provided by POSIX shells. dash for
instance does not provide this, so use bash explicitly.

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfs.man: Fix macro use for fstab examples
Luk Claes [Mon, 29 Aug 2011 15:51:46 +0000 (11:51 -0400)]
nfs.man: Fix macro use for fstab examples

The groff macros for filling (word-wrapping) and tabulation control are
lower-case, but are written in upper-case here and so have been ignored.

Change the .NF and .FI lines to lower-case.

Change the .TA lines to lower-case and fix the tab stops to work both
on a terminal and in Postscript output.

Delete the .SP line where .sp would be redundant.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoexports.man: Fix comment syntax
Luk Claes [Mon, 29 Aug 2011 15:46:17 +0000 (11:46 -0400)]
exports.man: Fix comment syntax

Using three single-quotes for a comment sort of works because it
results in invoking a nonexistent macro, but it results in a huge
number of warnings when trying to validate the man page.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsiostat.man: Fix missing I in ".I <interval>"
Luk Claes [Mon, 29 Aug 2011 15:44:14 +0000 (11:44 -0400)]
nfsiostat.man: Fix missing I in ".I <interval>"

Fix syntax for missing I in .I according to a patch from Simon Paillard
<spaillard@debian.org> in Debian bug #624261.

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agostatd.man: man complains about lines starting with '
Luk Claes [Mon, 29 Aug 2011 15:41:36 +0000 (11:41 -0400)]
statd.man: man complains about lines starting with '

Fix syntax for line starting with 'visible' according to a patch from
Simon Paillard <spaillard@debian.org> in Debian bug #624261.

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfs.man: man complains when line starts with quote
Luk Claes [Mon, 29 Aug 2011 15:40:12 +0000 (11:40 -0400)]
nfs.man: man complains when line starts with quote

Fix "macro `local_lock=flock'.' not defined" by avoiding to put a quote
at the beginning of the line.

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoexports.man: "\* d lets man complain
Luk Claes [Mon, 29 Aug 2011 15:36:37 +0000 (11:36 -0400)]
exports.man: "\* d lets man complain

man complains with "macro `d' not defined", so remove these seemingly
unneeded characters

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agomount.nfs: submarvellous messages from mount.nfs
Max Matveev [Tue, 16 Aug 2011 11:57:43 +0000 (07:57 -0400)]
mount.nfs: submarvellous messages from mount.nfs

Consider a setup where mountd on the server is controlled via
tcp_wrappers (usual RHEL setup) and will not process calls from a
particular client because of something in /etc/hosts.deny.

When such client attempts to do v3 mount, the error message printed
by mount.nfs is misleading.

This patch changes that error message from:
    mount.nfs: Argument list too long
to
    mount.nfs: access denied by server while mounting server:/export

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agomount: fix for libmount from util-linux >= 2.20
Karel Zak [Wed, 3 Aug 2011 19:12:53 +0000 (15:12 -0400)]
mount: fix for libmount from util-linux >= 2.20

The function mnt_fs_set_fs_options() has been removed from the final
version of the libmount API.

Signed-off-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agorpc.statd: Bind downcall socket to loopback address
Chuck Lever [Wed, 3 Aug 2011 17:22:52 +0000 (13:22 -0400)]
rpc.statd: Bind downcall socket to loopback address

In the past, rpc.statd posted SM_NOTIFY requests using the same socket
it used for sending downcalls to the kernel.  To receive replies from
remote hosts, the socket was bound to INADDR_ANY.

With commit f113db52 "Remove notify functionality from statd in
favour of sm-notify" (Mar 20, 2007), the downcall socket is no longer
used for sending requests to remote hosts.  However, the downcall
socket is still bound to INADDR_ANY.

Thus a remote host can inject data on this socket since it is an
unconnected UDP socket listening for RPC replies.  Thanks to f113db52,
the port number of this socket is no longer controlled by a command
line option, making it difficult to firewall.

We have demonstrated that data injection on this socket can result in
a DoS by causing rpc.statd to consume CPU and log bandwidth, but so
far we have not found a breach.

To prevent unwanted data injection, bind this socket to the loopback
address.

BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=177
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agomountd: Fixed strcmp usage in in insert groups.
Matthew Treinish [Wed, 3 Aug 2011 17:10:14 +0000 (13:10 -0400)]
mountd: Fixed strcmp usage in in insert groups.

Fixed the usage of strcmp in the duplicate check in insert groups.
Fixes an issue with showmount and other commands that required
the group information.

Signed-off-by: Matthew Treinish <treinish@linux.vnet.ibm.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoA problem with the --enable-libmount-mount configure option
Paul Bender [Wed, 3 Aug 2011 17:06:56 +0000 (13:06 -0400)]
A problem with the --enable-libmount-mount configure option

nfs-utils' configure script assumes that when either
--enable-libmount-mount or --disable-libmount-mount
is specified, that libmount should be used.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoA problem with running configure with the dash shell
Paul Bender [Wed, 3 Aug 2011 17:03:18 +0000 (13:03 -0400)]
A problem with running configure with the dash shell

nfs-utils' configure script fails to run when /bin/sh is
the dash shell.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agorpc.mountd: let mountd consult /etc/services for port
Mi Jinlong [Wed, 3 Aug 2011 16:52:48 +0000 (12:52 -0400)]
rpc.mountd: let mountd consult /etc/services for port

At RHEL, if user set port for mountd at /etc/services as
"mount   12345/tcp", mountd should be bind to 12345, but the
latest nfs-utils, mountd get a rand port, not 12345.

This patch make sure mountd be bind to the port which was set
at /etc/service.

Signed-off-by: Mi Jinlong <mijinlong@cn.fujitsu.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsidmap: Configuration regression nfs-utils-1-2-5-rc1
Steve Dickson [Thu, 21 Jul 2011 18:47:39 +0000 (14:47 -0400)]
nfsidmap: Configuration regression

Commit f3d38a7c introduce a configuration regression
that cause the nfsidmap code to never get enabled.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoStatd should always 'chdir' to its state directory.
NeilBrown [Thu, 21 Jul 2011 18:23:00 +0000 (14:23 -0400)]
Statd should always 'chdir' to its state directory.

s statd can be started by 'mount' which can sometimes be run by a
normal user, the current-working-directory could be anything.  In
partcular it could be in a mounted filesystem.  As 'statd' continues
running as a daemon it could keep prevent that filesystem from being
unmounted.

statd does currently 'chdir' to the state directory, but only if the
state directory is not owned by root.  This is wrong - it should check
for root after the chdir, not before.

So swap the two if statements around.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agogssd: Fix typo in debug string
Benjamin Coddington [Thu, 21 Jul 2011 18:19:52 +0000 (14:19 -0400)]
gssd: Fix typo in debug string

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agosvcgssd: use correct defaults in call to gss_set_allowable_enctypes
Kevin Coffman [Thu, 21 Jul 2011 18:16:59 +0000 (14:16 -0400)]
svcgssd: use correct defaults in call to gss_set_allowable_enctypes

For the window of kernels between 2.6.35 (when the support
for newer encryption was added) and 2.6.39 (when the ability
to read the supported enctypes from the kernel was added),
use a default of all enctypes when the kernel supported
enctypes file cannot be read.

For kernels before 2.6.35, continue to use a default of
only DES enctypes.

Note that the version of Kerberos must also support the use of
gss_set_allowable_enctypes for service-side negotiations.

See also: http://bugzilla.redhat.com/show_bug.cgi?id=719776

Signed-off-by: Kevin Coffman <kwc@citi.umich.edu>
Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agonfsidmap: Manpage corrections
Michael Guntsche [Wed, 13 Jul 2011 17:26:57 +0000 (13:26 -0400)]
nfsidmap: Manpage corrections

I recently upgraded to 1.2.4 to use the new nfsidmap feature. While
following the manpage and the kernel documentation I noticed a
difference. Kernel docs mention key TYPE id_resolver while the manpage
states nfs_idmap. The following patch changes the manpage to the proper
type.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agoMake sure CONFIG_NFSIDMAP is always defined.
Steve Dickson [Tue, 12 Jul 2011 21:21:09 +0000 (17:21 -0400)]
Make sure CONFIG_NFSIDMAP is always defined.

CONFIG_NFSIDMAP always need to be define either
negatively or positive whether nfsv4 is or is not
defined.

Signed-off-by: Steve Dickson <steved@redhat.com>
8 years agomount.nfs: Do not segfault because of kernel version
Luk Claes [Tue, 12 Jul 2011 14:38:03 +0000 (10:38 -0400)]
mount.nfs: Do not segfault because of kernel version

mount.nfs segfaults if kernel version number does not contain
at least 3 components delimited with a dot.

Avoid this by matching up to three unsigned integers inialised
to zero, separated by dots.

A version that does not start with an integer is probably a future
version where the versioning evolved to another scheme.
Return UINT_MAX which is guaranteed to be higher than existing
versions. This would also make it possible to easily identify
versions that do not start with an integer.

Signed-off-by: Luk Claes <luk@debian.org>
Signed-off-by: Steve Dickson <steved@redhat.com>