3 years agoImport Debian version 1:1.2.8-7 debian/1%1.2.8-7
Ben Hutchings [Fri, 11 Mar 2016 04:04:12 +0000 (04:04 +0000)]
Import Debian version 1:1.2.8-7

6 years agoreleasing package nfs-utils version 1:1.2.8-6 debian/1%1.2.8-6
Steve Langasek [Mon, 24 Feb 2014 18:11:25 +0000 (10:11 -0800)]
releasing package nfs-utils version 1:1.2.8-6

6 years agoProvide quoted entries by default in debian/nfs-kernel-server.default, consistent...
Steve Langasek [Mon, 24 Feb 2014 18:10:54 +0000 (10:10 -0800)]
Provide quoted entries by default in debian/nfs-kernel-server.default, consistent with other default files, so that users who edit the file to add multiple options don't accidentally cause shell syntax bugs.

6 years agodebian/nfs-kernel-server.init: don't try to check for nfsv3 configuration in nfsd...
Steve Langasek [Mon, 24 Feb 2014 18:05:13 +0000 (10:05 -0800)]
debian/nfs-kernel-server.init: don't try to check for nfsv3 configuration in nfsd and pass --no-nfs-version 3 to mountd if absent; the check is buggy and impossible to make reliable, and there's no reason to single out NFSv3 here (and the original rationale for this behavior is lost). Closes LP: #897644, LP: #1284210.

6 years agoTweak nfs-common preinst to not remove nfs state files except on package removal...
Steve Langasek [Sat, 1 Feb 2014 16:56:26 +0000 (11:56 -0500)]
Tweak nfs-common preinst to not remove nfs state files except on package removal (i.e., these should not be removed when the package is deconfigured temporarily).

6 years agoFix obsolete invocations of update-rc.d by switching nfs-common to use dh_installinit...
Steve Langasek [Sat, 1 Feb 2014 16:51:58 +0000 (11:51 -0500)]
Fix obsolete invocations of update-rc.d by switching nfs-common to use dh_installinit.  Closes: #736059.

6 years agoDocument a bug closure
Steve Langasek [Mon, 13 Jan 2014 22:58:41 +0000 (22:58 +0000)]
Document a bug closure

6 years agoOnly start nfs-common in runlevel S; it doesn't need to be started more than once...
Steve Langasek [Mon, 13 Jan 2014 22:58:17 +0000 (22:58 +0000)]
Only start nfs-common in runlevel S; it doesn't need to be started more than once (and startpar won't actually run it more than once, anyway).  Closes: #510528.

6 years agoMove the rpc.svcgssd(8) symlink to nfs-common along with the rest of it, and add...
Steve Langasek [Mon, 13 Jan 2014 22:35:14 +0000 (22:35 +0000)]
Move the rpc.svcgssd(8) symlink to nfs-common along with the rest of it, and add the Replaces: on old versions of nfs-kernel-server to support upgrades properly.

6 years agoFix the sec=krb5* handling in debian/nfs-common.init to properly match all cases...
Steve Langasek [Mon, 13 Jan 2014 22:28:01 +0000 (14:28 -0800)]
Fix the sec=krb5* handling in debian/nfs-common.init to properly match all cases.  Closes: #715478.

6 years agoreleasing package nfs-utils version 1:1.2.8-5
Steve Langasek [Mon, 13 Jan 2014 22:08:51 +0000 (22:08 +0000)]
releasing package nfs-utils version 1:1.2.8-5

6 years agoAdd the actual patch to git :P
Steve Langasek [Mon, 13 Jan 2014 22:10:14 +0000 (14:10 -0800)]
Add the actual patch to git :P

6 years agodebian/patches/21-no-more-var-run.patch: PID files should be in /run, not /var/run...
Steve Langasek [Mon, 13 Jan 2014 22:02:06 +0000 (14:02 -0800)]
debian/patches/21-no-more-var-run.patch: PID files should be in /run, not /var/run. Closes LP: #1157171.

6 years agoDon't start the nfs-common init script from the nfs-kernel-server maintainer script...
Steve Langasek [Sun, 11 Aug 2013 03:45:45 +0000 (05:45 +0200)]
Don't start the nfs-common init script from the nfs-kernel-server maintainer script, this is entirely redundant.

6 years agoSimplify handling of idmapd, which in recent releases is always enabled
Steve Langasek [Sun, 11 Aug 2013 03:41:43 +0000 (05:41 +0200)]
Simplify handling of idmapd, which in recent releases is always enabled

6 years agoMigrate the rpc_pipefs mount out of /var/lib to /run, to better support /var on NFS.
Steve Langasek [Sun, 11 Aug 2013 03:18:25 +0000 (05:18 +0200)]
Migrate the rpc_pipefs mount out of /var/lib to /run, to better support /var on NFS.

6 years agoRemove Luk Claes from uploaders (Closes: #723602)
Ben Hutchings [Mon, 23 Sep 2013 03:01:10 +0000 (04:01 +0100)]
Remove Luk Claes from uploaders (Closes: #723602)

6 years agoMeh, revert accidental autotools diff in the git tree
Steve Langasek [Sat, 1 Jun 2013 17:37:57 +0000 (10:37 -0700)]
Meh, revert accidental autotools diff in the git tree

6 years agoreleasing version 1:1.2.8-4 debian/1%1.2.8-4
Steve Langasek [Sat, 1 Jun 2013 17:29:37 +0000 (10:29 -0700)]
releasing version 1:1.2.8-4

6 years agoThe configure option name is --with-gssglue, not --with-libgssglue. Fix this, so...
Steve Langasek [Sat, 1 Jun 2013 17:29:27 +0000 (10:29 -0700)]
The configure option name is --with-gssglue, not --with-libgssglue. Fix this, so that rpc.gssd really works.  Really closes: #707960.

6 years agoreleasing version 1:1.2.8-3 debian/1%1.2.8-3
Steve Langasek [Sat, 1 Jun 2013 01:00:02 +0000 (18:00 -0700)]
releasing version 1:1.2.8-3

6 years agoBuild --with-libgssglue, which was the default prior to 1.2.8; this fixes a regressio...
Steve Langasek [Sat, 1 Jun 2013 00:43:11 +0000 (00:43 +0000)]
Build --with-libgssglue, which was the default prior to 1.2.8; this fixes a regression that makes rpc.gssd (and hence, all Kerberos-authenticated mounts) completely useless, because objects are being incorrectly passed between multiple gss implementations (by way of libtirpc).  Closes: #707960.

6 years agoAdd myself as comaintainer, per <>.
Steve Langasek [Sat, 1 Jun 2013 00:41:38 +0000 (00:41 +0000)]
Add myself as comaintainer, per <>.

6 years agoreleasing version 1:1.2.8-2
Luk Claes [Mon, 13 May 2013 17:47:03 +0000 (19:47 +0200)]
releasing version 1:1.2.8-2

6 years agoRemove autogenerated roff as is meant to be used as the actual source...
Luk Claes [Mon, 13 May 2013 17:37:14 +0000 (19:37 +0200)]
Remove autogenerated roff as is meant to be used as the actual source according to author (Closes: #707908).

6 years agoAdd id_resolver.conf to fix nfsidmap invocation (Closes: #708156, #638157, #707960).
Luk Claes [Mon, 13 May 2013 17:34:10 +0000 (19:34 +0200)]
Add id_resolver.conf to fix nfsidmap invocation (Closes: #708156, #638157, #707960).

6 years agoundo
Luk Claes [Mon, 13 May 2013 17:22:36 +0000 (19:22 +0200)]

6 years agoFix reportbug scripts to use rpcinfo in /usr/sbin.
Luk Claes [Sun, 12 May 2013 13:40:34 +0000 (15:40 +0200)]
Fix reportbug scripts to use rpcinfo in /usr/sbin.

6 years agoreleasing version 1:1.2.8-1 debian/1%1.2.8-1
Luk Claes [Fri, 10 May 2013 12:28:02 +0000 (14:28 +0200)]
releasing version 1:1.2.8-1

6 years agoAdjust version of replaces due to manpage move.
Luk Claes [Fri, 10 May 2013 12:25:42 +0000 (14:25 +0200)]
Adjust version of replaces due to manpage move.

6 years agoDo not try to install dropped ChangeLog.
Luk Claes [Fri, 10 May 2013 12:23:55 +0000 (14:23 +0200)]
Do not try to install dropped ChangeLog.

6 years agoAdd nfsdcltrack to nfs-kernel-server.
Luk Claes [Fri, 10 May 2013 12:17:13 +0000 (14:17 +0200)]
Add nfsdcltrack to nfs-kernel-server.

6 years agoAdd libsqlite3-dev build dependency for nfsdcltrack.
Luk Claes [Fri, 10 May 2013 12:01:20 +0000 (14:01 +0200)]
Add libsqlite3-dev build dependency for nfsdcltrack.

6 years agodo not complain about generated files
Luk Claes [Fri, 10 May 2013 11:57:00 +0000 (13:57 +0200)]
do not complain about generated files

6 years agodrop patch
Luk Claes [Fri, 10 May 2013 08:58:15 +0000 (08:58 +0000)]
drop patch

6 years agoRefresh 11-532048-reduce-verbosity.
Luk Claes [Fri, 10 May 2013 08:55:07 +0000 (08:55 +0000)]
Refresh 11-532048-reduce-verbosity.

6 years agoauth_unix_ip should downcall on error (Closes: #682709).
Luk Claes [Fri, 10 May 2013 08:39:50 +0000 (10:39 +0200)]
auth_unix_ip should downcall on error (Closes: #682709).

6 years agoAvoid DNS reverse lookups on server names (Closes: #707401).
Luk Claes [Fri, 10 May 2013 08:21:14 +0000 (10:21 +0200)]
Avoid DNS reverse lookups on server names (Closes: #707401).

6 years agoNew upstream version (Closes: #707258).
Luk Claes [Fri, 10 May 2013 08:13:53 +0000 (10:13 +0200)]
New upstream version (Closes: #707258).

* New upstream version (Closes: #707258).
  - Only amend extra-options on a successful vers=4 mount
    (Closes: #690181).
  - Use default domain (Closes: #657188).
  - Fix is-subdirectory to understand '/' (Closes: #685306).
  - Drop 18-osd_login-sbindir: incorporated upstream.

6 years agoMerge branch 'upstream'
Luk Claes [Fri, 10 May 2013 08:09:21 +0000 (10:09 +0200)]
Merge branch 'upstream'

6 years agoImported Upstream version 1.2.8 upstream/1.2.8
Steve Langasek [Sat, 1 Jun 2013 17:59:42 +0000 (17:59 +0000)]
Imported Upstream version 1.2.8

6 years agoupdate git ignored files
Luk Claes [Fri, 10 May 2013 11:27:38 +0000 (13:27 +0200)]
update git ignored files

6 years agoImported upstream 1.2.8
Luk Claes [Fri, 10 May 2013 08:01:25 +0000 (10:01 +0200)]
Imported upstream 1.2.8

6 years agoUse rpcbind's rpcinfo everywhere (Closes: #707589).
Luk Claes [Fri, 10 May 2013 07:15:26 +0000 (09:15 +0200)]
Use rpcbind's rpcinfo everywhere (Closes: #707589).

6 years agoRelease 1.2.8
Steve Dickson [Thu, 2 May 2013 12:21:12 +0000 (08:21 -0400)]
Release 1.2.8

Signed-off-by: Steve Dickson <>
6 years agoAvoid DNS reverse resolution for server names (take 3)
Simo Sorce [Fri, 19 Apr 2013 14:10:33 +0000 (10:10 -0400)]
Avoid DNS reverse resolution for server names (take 3)

A NFS client should be able to work properly even if the DNS Reverse
record for the server is not set. This means a DNS lookup should not be
done on server names at are passed to GSSAPI. This patch changes the default
behavior to no longer do those types of lookups

This change default behavior could negatively impact some current
environments, so the -D option is also being added that will re-enable
the DNS reverse looks on server names, which are passed to GSSAPI.

Signed-off-by: Simo Sorce <>
Signed-off-by: Steve Dickson <>
6 years ago.gitignore: ignore more generated files
Mike Frysinger [Fri, 19 Apr 2013 17:27:57 +0000 (13:27 -0400)]
.gitignore: ignore more generated files

Signed-off-by: Steve Dickson <>
6 years do not fail sqlite check when cross-compiling
Mike Frysinger [Fri, 19 Apr 2013 17:21:47 +0000 (13:21 -0400)] do not fail sqlite check when cross-compiling

If we're cross-compiling, we can't do a runtime test of sqlite,
so just assume that the user has a good enough version rather
than falling over.

Signed-off-by: Mike Frysinger <>
Signed-off-by: Steve Dickson <>
6 years agosm-notify: "-v hostname" doesn't work when IPV6_SUPPORT is enabled
Chuck Lever [Fri, 19 Apr 2013 17:13:57 +0000 (13:13 -0400)]
sm-notify: "-v hostname" doesn't work when IPV6_SUPPORT is enabled

Marc Eshel reports that using the -v command line option on the
sm-notify command stopped working after nfs-utils 1.2.2, when IPv6
support was added.  If nfs-utils is built without IPv6 support, it
still works.  Marc specified a hostname with a single A record.

smn_bind_address() must construct a bind address with the same
family as the RPC socket's protocol family.  Add an AI_V4MAPPED hint
so an appropriate IPv6 bind address is constructed even if -v
specifies an IPv4 presentation address, or a hostname with only IPv4

We still use an IPv4 bind address if IPv6 support is compiled out or
the host does not support IPv6.

Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
Cc: Marc Eshel <>
6 years agomount: No longer negotiate to v2
Steve Dickson [Fri, 19 Apr 2013 17:11:43 +0000 (13:11 -0400)]
mount: No longer negotiate to v2

This patch remove the ability of negotiating to the v2
protocol. Explicitly setting the version on the command
line will be the only way to use v2.

Signed-off-by: Steve Dickson <>
Signed-off-by: Steve Dickson <>
6 years agomountd: fix exporting of "/" with sec= setting.
NeilBrown [Fri, 19 Apr 2013 17:09:27 +0000 (13:09 -0400)]
mountd: fix exporting of "/" with sec= setting.

Commit 91bb95f2689e84856ecdf6fac365489d36709cf9
   4set_root: force "fsid=0" for all exports of '/'

set NFSEXP_FSID for the export of "/" if nothing else had any fsid set,
however it didn't also set the flag for all security flavours.  So the
kernel complains that the flags on the security flavours don't match and
it rejects the export.

So call fix_pseudoflavor_flags() in write_secinfo() to make sure that
any fiddling that has been done to e_flags gets copied to e_secinfo.

Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Allow GSSAPI to try to acquire credentials first.
Simo Sorce [Fri, 19 Apr 2013 17:02:36 +0000 (13:02 -0400)]
gssd: Allow GSSAPI to try to acquire credentials first.

GSSAPI can be given a uid number as a special name, and then
gss_acquire_cred() can use the name to try to find credentials for
the user.

Give GSSAPI a chance to do it on its own, then fallback to the classic
method of trolling through the file system to find a credential cache.

This patch uses a little know feature of GSSAPI that permits to acquire
crdentials specifying the user's UID. Normally GSSAPI will simply
perform a getpwuid() call and use the user name to generate a principal name and
then see if it can find a TGT for that principal in the local ccache.

This feature is vital to allow the GSS-Proxy to be able to initiate
crdentials on behalf of rpc.gssd using client keytabs stored in the filsystem.

GSS-Proxy works through an interposer-type plugin (new feature in MIT 1.11)
that allows to intercept all GSSAPI requestes and relay them to a system
daemon via a socket. This daemon (GSS-Proxy) then can perform operations
on behalf of other applications with additional logic.

In the rpc.gssd case the GSS-Proxy daemon allows applications running as
system users to properly access krb5 protected shares by creating a
credential cache on the fly when necessary.

This way all applications that need access to krb5 protected shares do not need
to be taught how to initiate crdentials on their own, nor they need to be
wrapped in additional init scripts like k5start or use wasteful cronjobs to
keep credentials fresh. All is needed is to drop a keytab with the right keys
in a special location on the system and gss-proxy will do the rest.

Signed-off-by: Simo Sorce <>
Signed-off-by: Steve Dickson <>
6 years agomountd: Add the missing '$' in auth_unix_ip()
Jose Castillo [Fri, 19 Apr 2013 14:51:57 +0000 (10:51 -0400)]
mountd: Add the missing '$' in auth_unix_ip()

We found this problem because NFS clients to a RHEL6 NFS server were
experiencing periods of ESTALE errors after being mounted and initially
working successfully. Tests were run which snapshotted the nfs/sunrpc
caches before and after the issue, and it was found that the '$'
at the beginning of the ID strings, used when in use_ipaddr mode, was

GOOD, while mount was working:
nfsd $

BAD, after mount started returning ESTALE:

This would then cause the export checks to fail by passing ''
instead of '$' up to rpc.mountd.

The problem appears to be in the auth_unix_ip() function when renewing
the auth.unix.ip cache entry.  It would fail to add the '$' character
back to the beginning of the string used for the domain string,
breaking the use_ipaddr mode.

Signed-off-by: Jose Castillo <>
Signed-off-by: Steve Dickson <>
6 years agonfs(5): Update description of sec= mount option
Chuck Lever [Wed, 10 Apr 2013 15:43:31 +0000 (11:43 -0400)]
nfs(5): Update description of sec= mount option

Bryan recently added SECINFO support, and I've beefed up the NFSv3
MNT processing in kernel to do some security flavor negotiation.

Thus the kernel can perform additional security flavor negotiation
now.  Update the description of the sec= mount option and the
SECURITY CONSIDERATIONS section to reflect this change.

Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Fix double free when exporting lucid context
Simo Sorce [Wed, 10 Apr 2013 15:34:41 +0000 (11:34 -0400)]
gssd: Fix double free when exporting lucid context

When using GSSAPI's gss_krb5_export_lucid_context the context passed
into the function is actually deleted during the export (to avoid
reuse as the context contains state that depends on its usage).

Change the code to pass in a pointer to the context so that it can be
properly NULLed if we are using the GSSAPI context and following calls to
gss_delete_sec_context will not cause double free errors and segfaults.

Signed-off-by: Simo Sorce <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Fix segfault when using -R option
Simo Sorce [Tue, 2 Apr 2013 19:06:13 +0000 (15:06 -0400)]
gssd: Fix segfault when using -R option

The getopt string did not add : after the R option resulting in a
sefgault whenever -R was used as optarg is NULL and it is dereferenced.

Signed-off-by: Simo Sorce <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Switch to use standard GSSAPI by default
Simo Sorce [Tue, 2 Apr 2013 19:04:37 +0000 (15:04 -0400)]
gssd: Switch to use standard GSSAPI by default

Make libgssglue configurable still but disabled by default.
There is no reason to use libgssglue anymore, and modern gssapi
supports all needed features for nfs-utils.

Signed-off-by: Simo Sorce <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Add configure check for gss_krb5_free_lucid_sec_context().
Simo Sorce [Tue, 2 Apr 2013 18:41:39 +0000 (14:41 -0400)]
gssd: Add configure check for gss_krb5_free_lucid_sec_context().

Signed-off-by: Simo Sorce <>
Signed-off-by: GÃnther Deschner <>
Signed-off-by: Steve Dickson <>
6 years agonfsd: Add support for the -V and --nfs-version optional arguments
Trond Myklebust [Mon, 25 Mar 2013 20:07:59 +0000 (16:07 -0400)]
nfsd: Add support for the -V and --nfs-version optional arguments

Add command line options to enable those NFS versions that are
currently disabled by default. We choose to use the options '-V'
and '--nfs-version' for compatibility with rpc.mountd.

Acked-by: J. Bruce Fields <>
Signed-off-by: Trond Myklebust <>
Signed-off-by: Steve Dickson <>
6 years agorpcdebug: do not use build toolchain
Mike Frysinger [Mon, 25 Mar 2013 12:35:37 +0000 (08:35 -0400)]
rpcdebug: do not use build toolchain

The rpcdebug program gets installed, so we don't want to use the build
toolchain to compile it.  I can't find any scripts in the build system
that try to execute it, so this shouldn't be a problem.

Signed-off-by: Mike Frysinger <>
Signed-off-by: Steve Dickson <>
6 years agoconfigure: check for libio.h availability
Mike Frysinger [Mon, 25 Mar 2013 12:31:31 +0000 (08:31 -0400)]
configure: check for libio.h availability

On some systems (like uClibc), there isn't a libio.h header.  But it
isn't also needed on them.  So check for the header first.

Signed-off-by: Mike Frysinger <>
Signed-off-by: Steve Dickson <>
6 years agoREADME: drop version from file
Mike Frysinger [Mon, 25 Mar 2013 12:27:58 +0000 (08:27 -0400)]
README: drop version from file

It clearly doesn't get maintained, so punt it.

Signed-off-by: Mike Frysinger <>
Signed-off-by: Steve Dickson <>
6 years agonfsiostat: make it work w/python3
Mike Frysinger [Mon, 25 Mar 2013 12:26:40 +0000 (08:26 -0400)]
nfsiostat: make it work w/python3

Simple fixes here to work with python 2 & 3:
 - use print() everywhere
 - dict.iteritems() -> dict.items()
 - file() -> open()
 - sys.maxint -> sys.maxsize

Signed-off-by: Mike Frysinger <>
Signed-off-by: Steve Dickson <>
6 years agomountd: regression in crossmounts
Steve Dickson [Sat, 23 Mar 2013 14:30:17 +0000 (10:30 -0400)]
mountd: regression in crossmounts

commit 8e2fb3fc cause a regression in mount export
that are on different local file system.
Exports like (all on different filesystems)

/home *(rw,fsid=0,crossmnt)
/home/fs1 *(rw,crossmnt)
/home/fs1/fs2/fs3 *(rw,nohide)

and then a mount of the root 'mount /home /mnt'
would end up mounting /home/fs1/fs2/fs3 not /home

Reverting the logic of commit 8e2fb3fc until
a better solution can be found for the original

Signed-off-by: Steve Dickson <>
6 years agoAdd a default flavor to an export's e_secinfo list
Chuck Lever [Sat, 23 Mar 2013 12:25:39 +0000 (08:25 -0400)]
Add a default flavor to an export's e_secinfo list

The list of security flavors that mountd allows for the NFSv4
pseudo-fs is constructed from the union of flavors of all current

exports(5) documents that the default security flavor for an
export, if "sec=" is not specified, is "sys".  Suppose
/etc/exports contains:

/a  *(rw)
/b  *(rw,sec=krb5:krb5i:krb5p)

The resulting security flavor list for the pseudo-fs is missing
"sec=sys".  /proc/net/rpc/nfsd.export/content contains:

/a  *(rw,root_squash,sync,wdelay,no_subtree_check,
/b  *(rw,root_squash,sync,wdelay,no_subtree_check,
/   *(ro,root_squash,sync,no_wdelay,v4root,fsid=0,

The root entry is not correct, as there does exist an export whose
unspecified default security flavor is "sys".  The security settings
on the root cause sec=sys mount attempts to be incorrectly rejected.

The reason is that when the line in /etc/exports for "/a" is parsed,
the e_secinfo list for that exportent is left empty.  Thus the union
of e_secinfo lists created by set_pseudofs_security() is

I fixed this by ensuring that if no "sec=" option is specified for
an export, its e_secinfo list gets at least an entry for AUTH_UNIX.

[ Yes, we could make the security flavors allowed for the pseudo-fs
a fixed list of all flavors the server supports.  That becomes
complicated by the special meaning of AUTH_NULL, and we still have
to check /etc/exports for whether Kerberos flavors should be listed.
I opted for a simple approach for now. ]

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agoNFS man page patch that moves nordirplus/rdirplus
Chris Vogan [Sat, 23 Mar 2013 12:22:41 +0000 (08:22 -0400)]
NFS man page patch that moves nordirplus/rdirplus

NFS man page patch that moves nordirplus/rdirplus from "Options for NFS
versions 2 and 3 only" to "Options supported by all versions".  Its a
better fit here since this option is also needed for some NFSv4 servers.

Signed-off-by: Chris Vogan <>
Signed-off-by: Steve Dickson <>
6 years agogssd: gethostname(3) returns zero or -1, not an errno
Chuck Lever [Sat, 23 Mar 2013 12:13:22 +0000 (08:13 -0400)]
gssd: gethostname(3) returns zero or -1, not an errno

According to "man gethostname," gssd is handling the return value of
gethostname(3) incorrectly.  It looks like other gethostname(3) call
sites in nfs-utils are already correct.

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Fix whitespace nits
Chuck Lever [Sat, 23 Mar 2013 12:12:16 +0000 (08:12 -0400)]
gssd: Fix whitespace nits

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Clean up gssd_setup_krb5_user_gss_ccache()
Chuck Lever [Sat, 23 Mar 2013 12:11:28 +0000 (08:11 -0400)]
gssd: Clean up gssd_setup_krb5_user_gss_ccache()

Remove a contradictory portion of the block comment documenting
gssd_find_existing_krb5_ccache().  This should have been removed by
commit 289ad31e, which reversed the meaning of the function's return

Note that, in user space, typically errno's are positive.  But here
we follow the kernel convention of using negative values to return
error codes.  Make the documenting comments explicit about the sign
of an error return -- it will never be positive in the case of an

And a nit: At the last return statement in
gssd_setup_krb5_user_gss_ccache(), "err" always contains zero, as
far as I can tell.  Make it explicit (to human readers) that when
execution reaches this point, gssd_setup_krb5_user_gss_ccache() is
going to return "success."

Reviewed-by: Jeff Layton <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Update description of "-l" option
Chuck Lever [Sat, 23 Mar 2013 12:09:42 +0000 (08:09 -0400)]
gssd: Update description of "-l" option

Move most of the text in the description of the "-l" option up to
the DESCRIPTION section, to match what was done for "-n" and "-k".

The discussion is then less restricted by formatting, and we can
take the space to introduce a few concepts before describing the
behavior of rpc.gssd.

Fix a few misspellings and grammar issues while here.

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Clarify use of the term "machine credentials" in rpc.gssd(8)
Chuck Lever [Sat, 23 Mar 2013 12:08:36 +0000 (08:08 -0400)]
gssd: Clarify use of the term "machine credentials" in rpc.gssd(8)

Our NFSv4 implementation uses machine credentials for operations
that manage state on behalf of the whole client (for example,
SETCLIENTID or RENEW).  The rpc.gssd man page is missing a
description of this usage, especially in the discussion of the "-n"

The issue is that rpc.gssd's "-n" option requires root to acquire a
user credential.  In the absense of a system keytab (for instance,
if the system is diskless) root's credential is not to be used as
the machine credential that manages NFSv4 state.

Group the discussion of machine credentials and UID 0 in one place
to help clarify the discussion and simplify the description of
several of these options.

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Provide an introduction in gssd(8)
Chuck Lever [Sat, 23 Mar 2013 12:07:46 +0000 (08:07 -0400)]
gssd: Provide an introduction in gssd(8)

It's good practice in user documentation to define terms before they
are used.  Add an INTRODUCTION section that defines important terms
that are used in the DESCRIPTION and OPTIONS sections.  The key
concepts are GSS context, user credential, machine credential, and

The RFCs I looked at capitalize both "gss" and "rpcsec_gss".  For
consistency I changed this throughout the man page.

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agogssd: is missing a description of the "-M" option
Chuck Lever [Sat, 23 Mar 2013 12:06:29 +0000 (08:06 -0400)]
gssd: is missing a description of the "-M" option

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agogssd: Use italics for option values and pathnames
Chuck Lever [Sat, 23 Mar 2013 12:05:30 +0000 (08:05 -0400)]
gssd: Use italics for option values and pathnames

Clean up: The usual convention for the values of command line
options and for pathnames is for them to appear italicized,
rather than emboldened or in double quotes.

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agomountd: make local functions in v4root.c static
Chuck Lever [Sat, 23 Mar 2013 12:03:56 +0000 (08:03 -0400)]
mountd: make local functions in v4root.c static

Clean up.  set_pseudofs_security() and pseudofs_update() have no
call sites outside of v4root.c, and there are no header declarations
for either function.  Define both as static.

Acked-by: J. Bruce Fields <>
Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
6 years agomountd: remove unused variable
Chuck Lever [Sat, 23 Mar 2013 12:02:50 +0000 (08:02 -0400)]
mountd: remove unused variable

Making all in mountd
cache.c: In function 'subexport':
cache.c:374:9: warning: unused variable 'l2' [-Wunused-variable]

Commit 8e2fb3fc removed the last use of "l2" in the subexport()

Signed-off-by: Chuck Lever <>
Acked-by: J. Bruce Fields <>
Signed-off-by: Steve Dickson <>
6 years agogssd - expired credentials problem
Lukas Hejtmanek [Wed, 20 Mar 2013 17:24:02 +0000 (13:24 -0400)]
gssd - expired credentials problem

I noticed that there is a problem with expired credentials if NFS
client's time is even few seconds behind KDC's or NFS server's time.
Client's kernel requests new GSS context but rpc.gssd is happy with
existing krb cache as it valid according to local time.

Signed-off-by: Steve Dickson <>
6 years agogssd: don't krb5_free_context if krb5_init_context fails
NeilBrown [Wed, 20 Mar 2013 17:03:58 +0000 (13:03 -0400)]
gssd: don't krb5_free_context if krb5_init_context fails

Most places that call krb5_init_context() abort cleanly on failure.
However these two then try to free the non-existent context, which
doesn't end well.

Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
6 years agogssd: use correct test for success of getrlimit()
NeilBrown [Wed, 20 Mar 2013 17:03:17 +0000 (13:03 -0400)]
gssd:  use correct test for success of getrlimit()

commit 7c5cb5e732a4b8704f8c79ec819c5d271e040339
    gssd: base the size of the fd array on the RLIMIT_NOFILE limit.

didn't actually work as claimed.  It only uses the returned value
if getrlimit() returns -1  -- which of course it only does when
there was an error.

So change the test to "== 0".

Reported-by: Leonardo Chiquitto<>
Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
7 years agogssd: Call authgss_free_private_data() if library provides it.
NeilBrown [Wed, 13 Feb 2013 20:11:05 +0000 (15:11 -0500)]
gssd: Call authgss_free_private_data() if library provides it.

librpcsecgss provides authgss_free_private_data() as a pair to
authgss_get_private_data().  libtirpc does not - until recently.

This ommision results in authgss_destroy_context() sending an
incorrect RPCSEC_GSS_DESTROY request when gssd calls AUTH_DESTROY().

The call has been added to libtirpc, so this patch updates nfs-utils
to check for the presense of the function in libtirpc and to set
This is also set unconditionally if librpcsecgss is used.

gssd is changed to test this value rather than HAVE_LIBTIRPC when
chosing whether to call authgss_free_private_data().

Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
7 years agorpc.statd: Fix socket binding loop.
Hemmo Nieminen [Wed, 16 Jan 2013 20:29:14 +0000 (15:29 -0500)]
rpc.statd: Fix socket binding loop.

From: Hemmo Nieminen <>

Instead of closing the sockets before requesting a new one, keep them
open until a suitable one is found. Otherwise bindresvport will return
the same port over and over again.

Signed-off-by: Steve Dickson <>
7 years agorpc.idmapd: Ignore open failures in dirscancb()
David Jeffery [Wed, 16 Jan 2013 20:21:55 +0000 (15:21 -0500)]
rpc.idmapd: Ignore open failures in dirscancb()

From: David Jeffery <>

The daemon "rpc.idmapd" scans the /var/lib/nfs/rpc_pipefs/nfs/ directory
periodically looking for NFS client mounts to communicate to. The daemon
tried to open communication with a client mount but it disappeared in
between looking for directory entries and opening them. NFS mount was
umounted just before rpc.idmapd tried to communicate with it. This
behavior is usually seen when autofs is configured on the system.

Signed-off-by: Steve Dickson <>
7 years agoidmapd: allow non-ASCII characters (UTF-8) in NFSv4 domain name
Suresh Jayaraman [Mon, 17 Dec 2012 21:29:44 +0000 (16:29 -0500)]
idmapd: allow non-ASCII characters (UTF-8) in NFSv4 domain name

The validateascii() check in imconv() maps NFSv4 domain names with
non-ASCII characters to 'nobody'. In setups where Active directory
or LDAP is used this causes names with UTF-8 characters to being
mapped to 'nobody' because of this check.

As Bruce Fields puts it:

"idmapd doesn't seem like the right place to enforce restrictions on
names.  Once the system has allowed a name it's too late to be
complaining about it here."

Replace the validateascii() call in imconv() with a check for
null-termination just to be extra-careful and remove the validateascii()
function itself as the only user of that function is being
removed by this patch.

Acked-by: J. Bruce Fields <>
Signed-off-by: Suresh Jayaraman <>
Signed-off-by: Steve Dickson <>
7 years agomountd: fix is_subdirectory to understand '/'
NeilBrown [Mon, 17 Dec 2012 21:21:15 +0000 (16:21 -0500)]
mountd: fix is_subdirectory to understand '/'

The is_subdirectory() function checks if a given 'child' is a
subdirectory of the given 'parent'.  However it always fails
if 'parent' == "/" (because 'child' doesn't begin with 'parent'
followed by "/").

So change is_subdirectory() to special-case "/".

subexport() also tests if one directory is a subdirectory of the
other, and contains the same bug.  So change it to use

Finally, move is_subdirectory() and related path_matches() and
export_matches() earlier in the file to avoid a forward-reference.

This patch fixes a bug wherein if you export "/" with 'crossmnt', the
crossmnt flag is ineffective and you can only access the root
filesystem, not any descendants.

Acked-by: J. Bruce Fields <>
Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
7 years agomountd: fix checking for errors when exporting filesystems
NeilBrown [Mon, 17 Dec 2012 21:19:09 +0000 (16:19 -0500)]
mountd: fix checking for errors when exporting filesystems

commit 5604b35a61e22930873ffc4e9971002f578e7978
  nfs-utils: Increase the stdio file buffer size for procfs files

changed writes to some sysfs files to be line buffered (_IOLBF) where
they weren't before.  While this probably makes sense, it introduced a

With fully buffered streams, you don't expect to get an error until you
call fflush(). With line buffered streams you can get the error
from fprintf() et al.

qword_eol() only tests the return from fflush(), not from fprintf().
Consequently errors were not noticed.

One result of this is that if you export, with crossmnt, a filesystem
underneath which are mounted non-exportable filesystems (e.g. /proc)
then an 'ls -l' on the client will block indefinitely waiting for a
meaningful 'yes' or 'no' from the server, but will never get one.

This patch changes qword_eol to test both fprintf and fflush.

Acked-by: J. Bruce Fields <>
Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
7 years agomountd: Report the absolute path used to load the junction plug-in
Chuck Lever [Wed, 12 Dec 2012 15:31:06 +0000 (10:31 -0500)]
mountd: Report the absolute path used to load the junction plug-in

As a debugging feature, report the absolute pathname of the plug-in
library that mountd loads to resolve junctions.

Since mountd passes a relative path to dlopen(3), dlopen(3) must
search for the right library.  Displaying the absolute pathname of
the object that it found verifies that mountd loaded the correct

Note: dlinfo(3) is provided by libdl, but there doesn't seem to be a
man page on Fedora 16 for dlinfo(3).  Instead, see:

Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
7 years agolibexport.a: xtab.c no longer needs #include xmalloc.h
Chuck Lever [Wed, 12 Dec 2012 15:30:25 +0000 (10:30 -0500)]
libexport.a: xtab.c no longer needs #include xmalloc.h

Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
7 years agolibexport.a: rmtab.c no longer needs #include xmalloc.h
Chuck Lever [Wed, 12 Dec 2012 15:29:40 +0000 (10:29 -0500)]
libexport.a: rmtab.c no longer needs #include xmalloc.h

Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
7 years agomountd: cache.c no longer needs #include xmalloc.h
Chuck Lever [Wed, 12 Dec 2012 15:26:59 +0000 (10:26 -0500)]
mountd: cache.c no longer needs #include xmalloc.h

Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
7 years agomountd: auth.c no longer needs #include xmalloc.h
Chuck Lever [Wed, 12 Dec 2012 15:26:09 +0000 (10:26 -0500)]
mountd: auth.c no longer needs #include xmalloc.h

Signed-off-by: Chuck Lever <>
Signed-off-by: Steve Dickson <>
7 years agogssd: base the size of the fd array on the RLIMIT_NOFILE limit.
NeilBrown [Wed, 28 Nov 2012 19:35:25 +0000 (14:35 -0500)]
gssd: base the size of the fd array on the RLIMIT_NOFILE limit.

We have previously raised the size of the 'pollarray' once (32 -> 256)
and I have had another request to make it bigger.
Rather than changing the hard-coded value, make it depend on
RLIMIT_NOFILE.  This is an upper limit on the size of the array
that can be passed to poll() anyway.

Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
7 years agogssd_proc: remove pointless test against FD_ALLOC_BLOCK in process_pipedir
NeilBrown [Wed, 28 Nov 2012 19:33:59 +0000 (14:33 -0500)]
gssd_proc: remove pointless test against FD_ALLOC_BLOCK in process_pipedir

I can see no possible point for this test against FD_ALLOC_BLOCK,
so just remove the test.

Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
7 years agogssd_proc: use pollsize, not FD_ALLOC_BLOCK, in get_poll_index()
NeilBrown [Wed, 28 Nov 2012 19:32:00 +0000 (14:32 -0500)]
gssd_proc: use pollsize, not FD_ALLOC_BLOCK, in get_poll_index()

get_poll_index wants to walk the entire "pollarray", but uses
the constant FD_ALLOC_BLOCK, rather than the variable
pollsize (which has the same value).  If we want to make the
size of the array variable, it is best not to use the constant.

As pollsize is 'unsigned long', 'i' should be too.

Signed-off-by: NeilBrown <>
Signed-off-by: Steve Dickson <>
7 years agogssd: Handle the target name correctly
Trond Myklebust [Wed, 28 Nov 2012 19:30:07 +0000 (14:30 -0500)]
gssd: Handle the target name correctly

The target name contains a hostname in the realm that we are
to. Since we may be authenticating to a different realm than the default
realm for the server, we should not assume that the target name and host
name point to the same string.
In fact, the kernel NFS client will always use its own hostname as the
target name, since it is always authenticating to its own default realm.
On the other hand, the NFS server's callback channel will pass the
of the NFS client that it is authenticating too (Section 3.4, RFC3530).

This patch fixes the handling of the target name in process_krb5_upcall,
and ensures that it gets passed to find_keytab_entry().

Signed-off-by: Trond Myklebust <>
Signed-off-by: Steve Dickson <>
7 years agogssd: Remove insane sanity checks of the service name
Trond Myklebust [Wed, 28 Nov 2012 19:25:33 +0000 (14:25 -0500)]
gssd: Remove insane sanity checks of the service name

Either we trust the info file, or we don't. The current
'checks' only work for the combination 'nfs', '100003' and
a version number between 2 and 4.
The problem is that the callback channel also wants to use
'nfs' in combination with a different program number and
version number.

This patch throws the bogus checks out altogether and lets the
kernel use whatever combination it wants....

Signed-off-by: Trond Myklebust <>
Signed-off-by: Steve Dickson <>
7 years agonfsdcltrack: skip "." and ".." when trying to clean out legacy recdir
Jeff Layton [Wed, 28 Nov 2012 19:03:55 +0000 (14:03 -0500)]
nfsdcltrack: skip "." and ".." when trying to clean out legacy recdir

readdir picks up these two entries as "normal" dentries, but rmdir'ing
them won't work (and we wouldn't want to remove them anyway).

Signed-off-by: Jeff Layton <>
Signed-off-by: Steve Dickson <>
7 years agomount.nfs: error message clean up.
Steve Dickson [Wed, 28 Nov 2012 14:26:18 +0000 (09:26 -0500)]
mount.nfs: error message clean up.

Remove a unnecessary newline in an error message.

Signed-off-by: Steve Dickson <>
7 years agomount.nfs: Continue to trying address when the server return EACCES
Steve Dickson [Wed, 28 Nov 2012 14:20:15 +0000 (09:20 -0500)]
mount.nfs: Continue to trying address when the server return EACCES

With recent changes to the /etc/hosts file, the 'localhost'
host name is now multiply defined as both an IPv4 address (127.0.01)
and an IPv6 address (::1). This causes first address returned
by getaddrinfo('localhost') to be the IPv6 address instead of
the IPv4 address.

The change in the default 'localhost' address type causes
existing exports using '' to fail, because the
'::1' address is tried first and fails. The problem is
not all the addresses in the address list are being tried.

So this patch allows that address list to continue to be
process when a 'EACCES' error is returned by the server.

Signed-off-by: Steve Dickson <>
7 years agomountd: auth_unix_ip should downcall on error to prevent hangs
J. Bruce Fields [Wed, 28 Nov 2012 14:11:29 +0000 (09:11 -0500)]
mountd: auth_unix_ip should downcall on error to prevent hangs

Since bf6a4febaa78bf188896b7b5b02c46562dd08b70 "mountd: handle
allocation failures in auth_unix_ip upcall", a failure to map the
address of an incoming client to a name could result in a hang.

We should be responding with an error in the case, not just skipping the
downcall and leaving everybody hanging.

Signed-off-by: J. Bruce Fields <>
Signed-off-by: Steve Dickson <>
7 years agosvcgssd: Encryption types not being parsed correctly
Steve Dickson [Sat, 17 Nov 2012 13:50:09 +0000 (08:50 -0500)]
svcgssd: Encryption types not being parsed correctly

When svcgssd reads the supported encrytion types from the
kernel, they are prefixed with a 'enctypes='. That prefix
has to be ignored to correctly parse the rest of the types.

Signed-off-by: Steve Dickson <>