idmapd: allow non-ASCII characters (UTF-8) in NFSv4 domain name
authorSuresh Jayaraman <sjayaraman@suse.com>
Mon, 17 Dec 2012 21:29:44 +0000 (16:29 -0500)
committerSteve Dickson <steved@redhat.com>
Mon, 17 Dec 2012 21:33:17 +0000 (16:33 -0500)
commit96892b29a50af1055bfc3ca74930e9782ead6c71
tree3e01cb14218c8c2ad745755c10ec88cb517ebec4
parent8e2fb3fc8e46e61eeba7978a03c9fb50ff01b666
idmapd: allow non-ASCII characters (UTF-8) in NFSv4 domain name

The validateascii() check in imconv() maps NFSv4 domain names with
non-ASCII characters to 'nobody'. In setups where Active directory
or LDAP is used this causes names with UTF-8 characters to being
mapped to 'nobody' because of this check.

As Bruce Fields puts it:

"idmapd doesn't seem like the right place to enforce restrictions on
names.  Once the system has allowed a name it's too late to be
complaining about it here."

Replace the validateascii() call in imconv() with a check for
null-termination just to be extra-careful and remove the validateascii()
function itself as the only user of that function is being
removed by this patch.

Acked-by: J. Bruce Fields <bfields@fieldses.org>
Signed-off-by: Suresh Jayaraman <sjayaraman@suse.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
utils/idmapd/idmapd.c