daklib/rm.py

   1 """General purpose package removal code for ftpmaster
   2
   3 @contact: Debian FTP Master <ftpmaster@debian.org>
   4 @copyright: 2000, 2001, 2002, 2003, 2004, 2006  James Troup <james@nocrew.org>
   5 @copyright: 2010 Alexander Reichle-Schmehl <tolimar@debian.org>
   6 @copyright: 2015      Niels Thykier <niels@thykier.net>
   7 @license: GNU General Public License version 2 or later
   8 """
   9 # Copyright (C) 2000, 2001, 2002, 2003, 2004, 2006  James Troup <james@nocrew.org>
  10 # Copyright (C) 2010 Alexander Reichle-Schmehl <tolimar@debian.org>
  11
  12 # This program is free software; you can redistribute it and/or modify
  13 # it under the terms of the GNU General Public License as published by
  14 # the Free Software Foundation; either version 2 of the License, or
  15 # (at your option) any later version.
  16
  17 # This program is distributed in the hope that it will be useful,
  18 # but WITHOUT ANY WARRANTY; without even the implied warranty of
  19 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  20 # GNU General Public License for more details.
  21
  22 # You should have received a copy of the GNU General Public License
  23 # along with this program; if not, write to the Free Software
  24 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  25
  26 ################################################################################
  27
  28 # From: Andrew Morton <akpm@osdl.org>
  29 # Subject: 2.6.6-mm5
  30 # To: linux-kernel@vger.kernel.org
  31 # Date: Sat, 22 May 2004 01:36:36 -0700
  32 # X-Mailer: Sylpheed version 0.9.7 (GTK+ 1.2.10; i386-redhat-linux-gnu)
  33 #
  34 # [...]
  35 #
  36 # Although this feature has been around for a while it is new code, and the
  37 # usual cautions apply.  If it munches all your files please tell Jens and
  38 # he'll type them in again for you.
  39
  40 ################################################################################
  41
  42 import commands
  43 import apt_pkg
  44 from re import sub
  45 from collections import defaultdict
  46 from regexes import re_build_dep_arch
  47
  48 from daklib.dbconn import *
  49 from daklib import utils
  50 from daklib.regexes import re_bin_only_nmu
  51 import debianbts as bts
  52
  53 ################################################################################
  54
  55
  56 class ReverseDependencyChecker(object):
  57     """A bulk tester for reverse dependency checks
  58
  59     This class is similar to the check_reverse_depends method from "utils".  However,
  60     it is primarily focused on facilitating bulk testing of reverse dependencies.
  61     It caches the state of the suite and then uses that as basis for answering queries.
  62     This saves a significant amount of time if multiple reverse dependency checks are
  63     required.
  64     """
  65
  66     def __init__(self, session, suite):
  67         """Creates a new ReverseDependencyChecker instance
  68
  69         This will spend a significant amount of time caching data.
  70
  71         @type session: SQLA Session
  72         @param session: The database session in use
  73
  74         @type suite: str
  75         @param suite: The name of the suite that is used as basis for removal tests.
  76         """
  77         self._session = session
  78         dbsuite = get_suite(suite, session)
  79         suite_archs2id = dict((x.arch_string, x.arch_id) for x in get_suite_architectures(suite))
  80         package_dependencies, arch_providors_of, arch_provided_by = self._load_package_information(session,
  81                                                                                                    dbsuite.suite_id,
  82                                                                                                    suite_archs2id)
  83         self._package_dependencies = package_dependencies
  84         self._arch_providors_of = arch_providors_of
  85         self._arch_provided_by = arch_provided_by
  86         self._archs_in_suite = set(suite_archs2id)
  87
  88     @staticmethod
  89     def _load_package_information(session, suite_id, suite_archs2id):
  90         package_dependencies = defaultdict(lambda: defaultdict(set))
  91         arch_providors_of = defaultdict(lambda: defaultdict(set))
  92         arch_provided_by = defaultdict(lambda: defaultdict(set))
  93         source_deps = defaultdict(set)
  94         metakey_d = get_or_set_metadatakey("Depends", session)
  95         metakey_p = get_or_set_metadatakey("Provides", session)
  96         params = {
  97             'suite_id':     suite_id,
  98             'arch_all_id':  suite_archs2id['all'],
  99             'metakey_d_id': metakey_d.key_id,
 100             'metakey_p_id': metakey_p.key_id,
 101         }
 102         all_arches = set(suite_archs2id)
 103         all_arches.discard('source')
 104
 105         package_dependencies['source'] = source_deps
 106
 107         for architecture in all_arches:
 108             deps = defaultdict(set)
 109             providers_of = defaultdict(set)
 110             provided_by = defaultdict(set)
 111             arch_providors_of[architecture] = providers_of
 112             arch_provided_by[architecture] = provided_by
 113             package_dependencies[architecture] = deps
 114
 115             params['arch_id'] = suite_archs2id[architecture]
 116
 117             statement = '''
 118                     SELECT b.package,
 119                         (SELECT bmd.value FROM binaries_metadata bmd WHERE bmd.bin_id = b.id AND bmd.key_id = :metakey_d_id) AS depends,
 120                         (SELECT bmp.value FROM binaries_metadata bmp WHERE bmp.bin_id = b.id AND bmp.key_id = :metakey_p_id) AS provides
 121                         FROM binaries b
 122                         JOIN bin_associations ba ON b.id = ba.bin AND ba.suite = :suite_id
 123                         WHERE b.architecture = :arch_id OR b.architecture = :arch_all_id'''
 124             query = session.query('package', 'depends', 'provides'). \
 125                 from_statement(statement).params(params)
 126             for package, depends, provides in query:
 127
 128                 if depends is not None:
 129                     try:
 130                         parsed_dep = []
 131                         for dep in apt_pkg.parse_depends(depends):
 132                             parsed_dep.append(frozenset(d[0] for d in dep))
 133                         deps[package].update(parsed_dep)
 134                     except ValueError as e:
 135                         print "Error for package %s: %s" % (package, e)
 136                 # Maintain a counter for each virtual package.  If a
 137                 # Provides: exists, set the counter to 0 and count all
 138                 # provides by a package not in the list for removal.
 139                 # If the counter stays 0 at the end, we know that only
 140                 # the to-be-removed packages provided this virtual
 141                 # package.
 142                 if provides is not None:
 143                     for virtual_pkg in provides.split(","):
 144                         virtual_pkg = virtual_pkg.strip()
 145                         if virtual_pkg == package:
 146                             continue
 147                         provided_by[virtual_pkg].add(package)
 148                         providers_of[package].add(virtual_pkg)
 149
 150         # Check source dependencies (Build-Depends and Build-Depends-Indep)
 151         metakey_bd = get_or_set_metadatakey("Build-Depends", session)
 152         metakey_bdi = get_or_set_metadatakey("Build-Depends-Indep", session)
 153         params = {
 154             'suite_id':    suite_id,
 155             'metakey_ids': (metakey_bd.key_id, metakey_bdi.key_id),
 156         }
 157         statement = '''
 158             SELECT s.source, string_agg(sm.value, ', ') as build_dep
 159                FROM source s
 160                JOIN source_metadata sm ON s.id = sm.src_id
 161                WHERE s.id in
 162                    (SELECT source FROM src_associations
 163                        WHERE suite = :suite_id)
 164                    AND sm.key_id in :metakey_ids
 165                GROUP BY s.id, s.source'''
 166         query = session.query('source', 'build_dep').from_statement(statement). \
 167             params(params)
 168         for source, build_dep in query:
 169             if build_dep is not None:
 170                 # Remove [arch] information since we want to see breakage on all arches
 171                 build_dep = re_build_dep_arch.sub("", build_dep)
 172                 try:
 173                     parsed_dep = []
 174                     for dep in apt_pkg.parse_src_depends(build_dep):
 175                         parsed_dep.append(frozenset(d[0] for d in dep))
 176                     source_deps[source].update(parsed_dep)
 177                 except ValueError as e:
 178                     print "Error for package %s: %s" % (source, e)
 179
 180         return package_dependencies, arch_providors_of, arch_provided_by
 181
 182     def check_reverse_depends(self, removal_requests):
 183         """Bulk check reverse dependencies
 184
 185         Example:
 186           removal_request = {
 187             "eclipse-rcp": None, # means ALL architectures (incl. source)
 188             "eclipse": None, # means ALL architectures (incl. source)
 189             "lintian": ["source", "all"], # Only these two "architectures".
 190           }
 191           obj.check_reverse_depends(removal_request)
 192
 193         @type removal_requests: dict (or a list of tuples)
 194         @param removal_requests: A dictionary mapping a package name to a list of architectures.  The list of
 195           architectures decides from which the package will be removed - if the list is empty the package will
 196           be removed on ALL architectures in the suite (including "source").
 197
 198         @rtype: dict
 199         @return: A mapping of "removed package" (as a "(pkg, arch)"-tuple) to a set of broken
 200           broken packages (also as "(pkg, arch)"-tuple).  Note that the architecture values
 201           in these tuples /can/ be "source" to reflect a breakage in build-dependencies.
 202         """
 203
 204         archs_in_suite = self._archs_in_suite
 205         removals_by_arch = defaultdict(set)
 206         affected_virtual_by_arch = defaultdict(set)
 207         package_dependencies = self._package_dependencies
 208         arch_providors_of = self._arch_providors_of
 209         arch_provided_by = self._arch_provided_by
 210         arch_provides2removal = defaultdict(lambda: defaultdict(set))
 211         dep_problems = defaultdict(set)
 212         src_deps = package_dependencies['source']
 213         src_removals = set()
 214         arch_all_removals = set()
 215
 216         if isinstance(removal_requests, dict):
 217             removal_requests = removal_requests.iteritems()
 218
 219         for pkg, arch_list in removal_requests:
 220             if not arch_list:
 221                 arch_list = archs_in_suite
 222             for arch in arch_list:
 223                 if arch == 'source':
 224                     src_removals.add(pkg)
 225                     continue
 226                 if arch == 'all':
 227                     arch_all_removals.add(pkg)
 228                     continue
 229                 removals_by_arch[arch].add(pkg)
 230                 if pkg in arch_providors_of[arch]:
 231                     affected_virtual_by_arch[arch].add(pkg)
 232
 233         if arch_all_removals:
 234             for arch in archs_in_suite:
 235                 if arch in ('all', 'source'):
 236                     continue
 237                 removals_by_arch[arch].update(arch_all_removals)
 238                 for pkg in arch_all_removals:
 239                     if pkg in arch_providors_of[arch]:
 240                         affected_virtual_by_arch[arch].add(pkg)
 241
 242         if not removals_by_arch:
 243             # Nothing to remove => no problems
 244             return dep_problems
 245
 246         for arch, removed_providers in affected_virtual_by_arch.iteritems():
 247             provides2removal = arch_provides2removal[arch]
 248             removals = removals_by_arch[arch]
 249             for virtual_pkg, virtual_providers in arch_provided_by[arch].iteritems():
 250                 v = virtual_providers & removed_providers
 251                 if len(v) == len(virtual_providers):
 252                     # We removed all the providers of virtual_pkg
 253                     removals.add(virtual_pkg)
 254                     # Pick one to take the blame for the removal
 255                     # - we sort for determinism, optimally we would prefer to blame the same package
 256                     #   to minimise the number of blamed packages.
 257                     provides2removal[virtual_pkg] = sorted(v)[0]
 258
 259         for arch, removals in removals_by_arch.iteritems():
 260             deps = package_dependencies[arch]
 261             provides2removal = arch_provides2removal[arch]
 262
 263             # Check binary dependencies (Depends)
 264             for package, dependencies in deps.iteritems():
 265                 if package in removals:
 266                     continue
 267                 for clause in dependencies:
 268                     if not (clause <= removals):
 269                         # Something probably still satisfies this relation
 270                         continue
 271                     # whoops, we seemed to have removed all packages that could possibly satisfy
 272                     # this relation.  Lets blame something for it
 273                     for dep_package in clause:
 274                         removal = dep_package
 275                         if dep_package in provides2removal:
 276                             removal = provides2removal[dep_package]
 277                         dep_problems[(removal, arch)].add((package, arch))
 278
 279             for source, build_dependencies in src_deps.iteritems():
 280                 if source in src_removals:
 281                     continue
 282                 for clause in build_dependencies:
 283                     if not (clause <= removals):
 284                         # Something probably still satisfies this relation
 285                         continue
 286                     # whoops, we seemed to have removed all packages that could possibly satisfy
 287                     # this relation.  Lets blame something for it
 288                     for dep_package in clause:
 289                         removal = dep_package
 290                         if dep_package in provides2removal:
 291                             removal = provides2removal[dep_package]
 292                         dep_problems[(removal, arch)].add((source, 'source'))
 293
 294         return dep_problems
 295
 296
 297 def remove(session, reason, suites, removals,
 298            whoami=None, partial=False, components=None, done_bugs=None, date=None,
 299            carbon_copy=None, close_related_bugs=False):
 300     """Batch remove a number of packages
 301     Verify that the files listed in the Files field of the .dsc are
 302     those expected given the announced Format.
 303
 304     @type session: SQLA Session
 305     @param session: The database session in use
 306
 307     @type reason: string
 308     @param reason: The reason for the removal (e.g. "[auto-cruft] NBS (no longer built by <source>)")
 309
 310     @type suites: list
 311     @param suites: A list of the suite names in which the removal should occur
 312
 313     @type removals: list
 314     @param removals: A list of the removals.  Each element should be a tuple (or list) of at least the following
 315         for 4 items from the database (in order): package, version, architecture, (database) id.
 316         For source packages, the "architecture" should be set to "source".
 317
 318     @type partial: bool
 319     @param partial: Whether the removal is "partial" (e.g. architecture specific).
 320
 321     @type components: list
 322     @param components: List of components involved in a partial removal.  Can be an empty list to not restrict the
 323         removal to any components.
 324
 325     @type whoami: string
 326     @param whoami: The person (or entity) doing the removal.  Defaults to utils.whoami()
 327
 328     @type date: string
 329     @param date: The date of the removal. Defaults to commands.getoutput("date -R")
 330
 331     @type done_bugs: list
 332     @param done_bugs: A list of bugs to be closed when doing this removal.
 333
 334     @type close_related_bugs: bool
 335     @param done_bugs: Whether bugs related to the package being removed should be closed as well.  NB: Not implemented
 336       for more than one suite.
 337
 338     @type carbon_copy: list
 339     @param carbon_copy: A list of mail addresses to CC when doing removals.  NB: all items are taken "as-is" unlike
 340         "dak rm".
 341
 342     @rtype: None
 343     @return: Nothing
 344     """
 345     # Generate the summary of what's to be removed
 346     d = {}
 347     summary = ""
 348     sources = []
 349     binaries = []
 350     whitelists = []
 351     versions = []
 352     suite_ids_list = []
 353     suites_list = utils.join_with_commas_and(suites)
 354     cnf = utils.get_conf()
 355     con_components = None
 356
 357     #######################################################################################################
 358
 359     if not reason:
 360         raise ValueError("Empty removal reason not permitted")
 361
 362     if not removals:
 363         raise ValueError("Nothing to remove!?")
 364
 365     if not suites:
 366         raise ValueError("Removals without a suite!?")
 367
 368     if whoami is None:
 369         whoami = utils.whoami()
 370
 371     if date is None:
 372         date = commands.getoutput("date -R")
 373
 374     if partial:
 375
 376         component_ids_list = []
 377         for componentname in components:
 378             component = get_component(componentname, session=session)
 379             if component is None:
 380                 raise ValueError("component '%s' not recognised." % componentname)
 381             else:
 382                 component_ids_list.append(component.component_id)
 383         con_components = "AND component IN (%s)" % ", ".join([str(i) for i in component_ids_list])
 384
 385     for i in removals:
 386         package = i[0]
 387         version = i[1]
 388         architecture = i[2]
 389         if package not in d:
 390             d[package] = {}
 391         if version not in d[package]:
 392             d[package][version] = []
 393         if architecture not in d[package][version]:
 394             d[package][version].append(architecture)
 395
 396     for package in sorted(removals):
 397         versions = sorted(d[package], cmp=apt_pkg.version_compare)
 398         for version in versions:
 399             d[package][version].sort(utils.arch_compare_sw)
 400             summary += "%10s | %10s | %s\n" % (package, version, ", ".join(d[package][version]))
 401
 402     for package in summary.split("\n"):
 403         for row in package.split("\n"):
 404             element = row.split("|")
 405             if len(element) == 3:
 406                 if element[2].find("source") > 0:
 407                     sources.append("%s_%s" % tuple(elem.strip(" ") for elem in element[:2]))
 408                     element[2] = sub("source\s?,?", "", element[2]).strip(" ")
 409                 if element[2]:
 410                     binaries.append("%s_%s [%s]" % tuple(elem.strip(" ") for elem in element))
 411
 412     dsc_type_id = get_override_type('dsc', session).overridetype_id
 413     deb_type_id = get_override_type('deb', session).overridetype_id
 414
 415     for suite in suites:
 416         s = get_suite(suite, session=session)
 417         if s is not None:
 418             suite_ids_list.append(s.suite_id)
 419             whitelists.append(s.mail_whitelist)
 420
 421     #######################################################################################################
 422     log_filename = cnf["Rm::LogFile"]
 423     log822_filename = cnf["Rm::LogFile822"]
 424     with utils.open_file(log_filename, "a") as logfile, utils.open_file(log822_filename, "a") as logfile822:
 425         logfile.write("=========================================================================\n")
 426         logfile.write("[Date: %s] [ftpmaster: %s]\n" % (date, whoami))
 427         logfile.write("Removed the following packages from %s:\n\n%s" % (suites_list, summary))
 428         if done_bugs:
 429             logfile.write("Closed bugs: %s\n" % (", ".join(done_bugs)))
 430         logfile.write("\n------------------- Reason -------------------\n%s\n" % reason)
 431         logfile.write("----------------------------------------------\n")
 432
 433         logfile822.write("Date: %s\n" % date)
 434         logfile822.write("Ftpmaster: %s\n" % whoami)
 435         logfile822.write("Suite: %s\n" % suites_list)
 436
 437         if sources:
 438             logfile822.write("Sources:\n")
 439             for source in sources:
 440                 logfile822.write(" %s\n" % source)
 441
 442         if binaries:
 443             logfile822.write("Binaries:\n")
 444             for binary in binaries:
 445                 logfile822.write(" %s\n" % binary)
 446
 447         logfile822.write("Reason: %s\n" % reason.replace('\n', '\n '))
 448         if done_bugs:
 449             logfile822.write("Bug: %s\n" % (", ".join(done_bugs)))
 450
 451         for i in removals:
 452             package = i[0]
 453             architecture = i[2]
 454             package_id = i[3]
 455             for suite_id in suite_ids_list:
 456                 if architecture == "source":
 457                     session.execute("DELETE FROM src_associations WHERE source = :packageid AND suite = :suiteid",
 458                                     {'packageid': package_id, 'suiteid': suite_id})
 459                 else:
 460                     session.execute("DELETE FROM bin_associations WHERE bin = :packageid AND suite = :suiteid",
 461                                     {'packageid': package_id, 'suiteid': suite_id})
 462                 # Delete from the override file
 463                 if partial:
 464                     if architecture == "source":
 465                         type_id = dsc_type_id
 466                     else:
 467                         type_id = deb_type_id
 468                     # TODO: Fix this properly to remove the remaining non-bind argument
 469                     session.execute("DELETE FROM override WHERE package = :package AND type = :typeid AND suite = :suiteid %s" % (con_components), {'package': package, 'typeid': type_id, 'suiteid': suite_id})
 470
 471         session.commit()
 472         # ### REMOVAL COMPLETE - send mail time ### #
 473
 474         # If we don't have a Bug server configured, we're done
 475         if "Dinstall::BugServer" not in cnf:
 476             if done_bugs or close_related_bugs:
 477                 utils.warn("Cannot send mail to BugServer as Dinstall::BugServer is not configured")
 478
 479             logfile.write("=========================================================================\n")
 480             logfile822.write("\n")
 481             return
 482
 483         # read common subst variables for all bug closure mails
 484         Subst_common = {}
 485         Subst_common["__RM_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
 486         Subst_common["__BUG_SERVER__"] = cnf["Dinstall::BugServer"]
 487         Subst_common["__CC__"] = "X-DAK: dak rm"
 488         if carbon_copy:
 489             Subst_common["__CC__"] += "\nCc: " + ", ".join(carbon_copy)
 490         Subst_common["__SUITE_LIST__"] = suites_list
 491         Subst_common["__SUBJECT__"] = "Removed package(s) from %s" % (suites_list)
 492         Subst_common["__ADMIN_ADDRESS__"] = cnf["Dinstall::MyAdminAddress"]
 493         Subst_common["__DISTRO__"] = cnf["Dinstall::MyDistribution"]
 494         Subst_common["__WHOAMI__"] = whoami
 495
 496         # Send the bug closing messages
 497         if done_bugs:
 498             Subst_close_rm = Subst_common
 499             bcc = []
 500             if cnf.find("Dinstall::Bcc") != "":
 501                 bcc.append(cnf["Dinstall::Bcc"])
 502             if cnf.find("Rm::Bcc") != "":
 503                 bcc.append(cnf["Rm::Bcc"])
 504             if bcc:
 505                 Subst_close_rm["__BCC__"] = "Bcc: " + ", ".join(bcc)
 506             else:
 507                 Subst_close_rm["__BCC__"] = "X-Filler: 42"
 508             summarymail = "%s\n------------------- Reason -------------------\n%s\n" % (summary, reason)
 509             summarymail += "----------------------------------------------\n"
 510             Subst_close_rm["__SUMMARY__"] = summarymail
 511
 512             for bug in done_bugs:
 513                 Subst_close_rm["__BUG_NUMBER__"] = bug
 514                 if close_related_bugs:
 515                     mail_message = utils.TemplateSubst(Subst_close_rm,cnf["Dir::Templates"]+"/rm.bug-close-with-related")
 516                 else:
 517                     mail_message = utils.TemplateSubst(Subst_close_rm,cnf["Dir::Templates"]+"/rm.bug-close")
 518                 utils.send_mail(mail_message, whitelists=whitelists)
 519
 520         # close associated bug reports
 521         if close_related_bugs:
 522             Subst_close_other = Subst_common
 523             bcc = []
 524             wnpp = utils.parse_wnpp_bug_file()
 525             versions = list(set([re_bin_only_nmu.sub('', v) for v in versions]))
 526             if len(versions) == 1:
 527                 Subst_close_other["__VERSION__"] = versions[0]
 528             else:
 529                 logfile.write("=========================================================================\n")
 530                 logfile822.write("\n")
 531                 raise ValueError("Closing bugs with multiple package versions is not supported.  Do it yourself.")
 532             if bcc:
 533                 Subst_close_other["__BCC__"] = "Bcc: " + ", ".join(bcc)
 534             else:
 535                 Subst_close_other["__BCC__"] = "X-Filler: 42"
 536             # at this point, I just assume, that the first closed bug gives
 537             # some useful information on why the package got removed
 538             Subst_close_other["__BUG_NUMBER__"] = done_bugs[0]
 539             if len(sources) == 1:
 540                 source_pkg = source.split("_", 1)[0]
 541             else:
 542                 logfile.write("=========================================================================\n")
 543                 logfile822.write("\n")
 544                 raise ValueError("Closing bugs for multiple source packages is not supported.  Please do it yourself.")
 545             Subst_close_other["__BUG_NUMBER_ALSO__"] = ""
 546             Subst_close_other["__SOURCE__"] = source_pkg
 547             merged_bugs = set()
 548             other_bugs = bts.get_bugs('src', source_pkg, 'status', 'open', 'status', 'forwarded')
 549             if other_bugs:
 550                 for bugno in other_bugs:
 551                     if bugno not in merged_bugs:
 552                         for bug in bts.get_status(bugno):
 553                             for merged in bug.mergedwith:
 554                                 other_bugs.remove(merged)
 555                                 merged_bugs.add(merged)
 556                 logfile.write("Also closing bug(s):")
 557                 logfile822.write("Also-Bugs:")
 558                 for bug in other_bugs:
 559                     Subst_close_other["__BUG_NUMBER_ALSO__"] += str(bug) + "-done@" + cnf["Dinstall::BugServer"] + ","
 560                     logfile.write(" " + str(bug))
 561                     logfile822.write(" " + str(bug))
 562                 logfile.write("\n")
 563                 logfile822.write("\n")
 564             if source_pkg in wnpp:
 565                 logfile.write("Also closing WNPP bug(s):")
 566                 logfile822.write("Also-WNPP:")
 567                 for bug in wnpp[source_pkg]:
 568                     # the wnpp-rm file we parse also contains our removal
 569                     # bugs, filtering that out
 570                     if bug != Subst_close_other["__BUG_NUMBER__"]:
 571                         Subst_close_other["__BUG_NUMBER_ALSO__"] += str(bug) + "-done@" + cnf["Dinstall::BugServer"] + ","
 572                         logfile.write(" " + str(bug))
 573                         logfile822.write(" " + str(bug))
 574                 logfile.write("\n")
 575                 logfile822.write("\n")
 576
 577             mail_message = utils.TemplateSubst(Subst_close_other, cnf["Dir::Templates"]+"/rm.bug-close-related")
 578             if Subst_close_other["__BUG_NUMBER_ALSO__"]:
 579                 utils.send_mail(mail_message)
 580
 581         logfile.write("=========================================================================\n")
 582         logfile822.write("\n")