daklib/queue.py

   1 #!/usr/bin/env python
   2 # vim:set et sw=4:
   3
   4 """
   5 Queue utility functions for dak
   6
   7 @contact: Debian FTP Master <ftpmaster@debian.org>
   8 @copyright: 2001 - 2006 James Troup <james@nocrew.org>
   9 @copyright: 2009, 2010  Joerg Jaspert <joerg@debian.org>
  10 @license: GNU General Public License version 2 or later
  11 """
  12
  13 # This program is free software; you can redistribute it and/or modify
  14 # it under the terms of the GNU General Public License as published by
  15 # the Free Software Foundation; either version 2 of the License, or
  16 # (at your option) any later version.
  17
  18 # This program is distributed in the hope that it will be useful,
  19 # but WITHOUT ANY WARRANTY; without even the implied warranty of
  20 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  21 # GNU General Public License for more details.
  22
  23 # You should have received a copy of the GNU General Public License
  24 # along with this program; if not, write to the Free Software
  25 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
  26
  27 ###############################################################################
  28
  29 import errno
  30 import os
  31 import stat
  32 import sys
  33 import time
  34 import apt_inst
  35 import apt_pkg
  36 import utils
  37 import commands
  38 import shutil
  39 import textwrap
  40 from types import *
  41 from sqlalchemy.sql.expression import desc
  42 from sqlalchemy.orm.exc import NoResultFound
  43
  44 import yaml
  45
  46 from dak_exceptions import *
  47 from changes import *
  48 from regexes import *
  49 from config import Config
  50 from holding import Holding
  51 from urgencylog import UrgencyLog
  52 from dbconn import *
  53 from summarystats import SummaryStats
  54 from utils import parse_changes, check_dsc_files, build_package_set
  55 from textutils import fix_maintainer
  56 from lintian import parse_lintian_output, generate_reject_messages
  57 from contents import UnpackedSource
  58
  59 ###############################################################################
  60
  61 def get_type(f, session):
  62     """
  63     Get the file type of C{f}
  64
  65     @type f: dict
  66     @param f: file entry from Changes object
  67
  68     @type session: SQLA Session
  69     @param session: SQL Alchemy session object
  70
  71     @rtype: string
  72     @return: filetype
  73
  74     """
  75     # Determine the type
  76     if f.has_key("dbtype"):
  77         file_type = f["dbtype"]
  78     elif re_source_ext.match(f["type"]):
  79         file_type = "dsc"
  80     elif f['architecture'] == 'source' and f["type"] == 'unreadable':
  81         utils.warn('unreadable source file (will continue and hope for the best)')
  82         return f["type"]
  83     else:
  84         file_type = f["type"]
  85         utils.fubar("invalid type (%s) for new.  Dazed, confused and sure as heck not continuing." % (file_type))
  86
  87     # Validate the override type
  88     type_id = get_override_type(file_type, session)
  89     if type_id is None:
  90         utils.fubar("invalid type (%s) for new.  Say wha?" % (file_type))
  91
  92     return file_type
  93
  94 ################################################################################
  95
  96 # Determine what parts in a .changes are NEW
  97
  98 def determine_new(filename, changes, files, warn=1, session = None, dsc = None, new = None):
  99     """
 100     Determine what parts in a C{changes} file are NEW.
 101
 102     @type filename: str
 103     @param filename: changes filename
 104
 105     @type changes: Upload.Pkg.changes dict
 106     @param changes: Changes dictionary
 107
 108     @type files: Upload.Pkg.files dict
 109     @param files: Files dictionary
 110
 111     @type warn: bool
 112     @param warn: Warn if overrides are added for (old)stable
 113
 114     @type dsc: Upload.Pkg.dsc dict
 115     @param dsc: (optional); Dsc dictionary
 116
 117     @type new: dict
 118     @param new: new packages as returned by a previous call to this function, but override information may have changed
 119
 120     @rtype: dict
 121     @return: dictionary of NEW components.
 122
 123     """
 124     # TODO: This should all use the database instead of parsing the changes
 125     # file again
 126     byhand = {}
 127     if new is None:
 128         new = {}
 129
 130     dbchg = get_dbchange(filename, session)
 131     if dbchg is None:
 132         print "Warning: cannot find changes file in database; won't check byhand"
 133
 134     # Try to get the Package-Set field from an included .dsc file (if possible).
 135     if dsc:
 136         for package, entry in build_package_set(dsc, session).items():
 137             if not new.has_key(package):
 138                 new[package] = entry
 139
 140     # Build up a list of potentially new things
 141     for name, f in files.items():
 142         # Keep a record of byhand elements
 143         if f["section"] == "byhand":
 144             byhand[name] = 1
 145             continue
 146
 147         pkg = f["package"]
 148         priority = f["priority"]
 149         section = f["section"]
 150         file_type = get_type(f, session)
 151         component = f["component"]
 152
 153         if file_type == "dsc":
 154             priority = "source"
 155
 156         if not new.has_key(pkg):
 157             new[pkg] = {}
 158             new[pkg]["priority"] = priority
 159             new[pkg]["section"] = section
 160             new[pkg]["type"] = file_type
 161             new[pkg]["component"] = component
 162             new[pkg]["files"] = []
 163         else:
 164             old_type = new[pkg]["type"]
 165             if old_type != file_type:
 166                 # source gets trumped by deb or udeb
 167                 if old_type == "dsc":
 168                     new[pkg]["priority"] = priority
 169                     new[pkg]["section"] = section
 170                     new[pkg]["type"] = file_type
 171                     new[pkg]["component"] = component
 172
 173         new[pkg]["files"].append(name)
 174
 175         if f.has_key("othercomponents"):
 176             new[pkg]["othercomponents"] = f["othercomponents"]
 177
 178     # Fix up the list of target suites
 179     cnf = Config()
 180     for suite in changes["suite"].keys():
 181         oldsuite = get_suite(suite, session)
 182         if not oldsuite:
 183             print "WARNING: Invalid suite %s found" % suite
 184             continue
 185
 186         if oldsuite.overridesuite:
 187             newsuite = get_suite(oldsuite.overridesuite, session)
 188
 189             if newsuite:
 190                 print "INFORMATION: Using overrides from suite %s instead of suite %s" % (
 191                     oldsuite.overridesuite, suite)
 192                 del changes["suite"][suite]
 193                 changes["suite"][oldsuite.overridesuite] = 1
 194             else:
 195                 print "WARNING: Told to use overridesuite %s for %s but it doesn't exist.  Bugger" % (
 196                     oldsuite.overridesuite, suite)
 197
 198     # Check for unprocessed byhand files
 199     if dbchg is not None:
 200         for b in byhand.keys():
 201             # Find the file entry in the database
 202             found = False
 203             for f in dbchg.files:
 204                 if f.filename == b:
 205                     found = True
 206                     # If it's processed, we can ignore it
 207                     if f.processed:
 208                         del byhand[b]
 209                     break
 210
 211             if not found:
 212                 print "Warning: Couldn't find BYHAND item %s in the database; assuming unprocessed"
 213
 214     # Check for new stuff
 215     for suite in changes["suite"].keys():
 216         for pkg in new.keys():
 217             ql = get_override(pkg, suite, new[pkg]["component"], new[pkg]["type"], session)
 218             if len(ql) > 0:
 219                 for file_entry in new[pkg]["files"]:
 220                     if files[file_entry].has_key("new"):
 221                         del files[file_entry]["new"]
 222                 del new[pkg]
 223
 224     if warn:
 225         for s in ['stable', 'oldstable']:
 226             if changes["suite"].has_key(s):
 227                 print "WARNING: overrides will be added for %s!" % s
 228         for pkg in new.keys():
 229             if new[pkg].has_key("othercomponents"):
 230                 print "WARNING: %s already present in %s distribution." % (pkg, new[pkg]["othercomponents"])
 231
 232     return new, byhand
 233
 234 ################################################################################
 235
 236 def check_valid(new, session = None):
 237     """
 238     Check if section and priority for NEW packages exist in database.
 239     Additionally does sanity checks:
 240       - debian-installer packages have to be udeb (or source)
 241       - non debian-installer packages can not be udeb
 242       - source priority can only be assigned to dsc file types
 243
 244     @type new: dict
 245     @param new: Dict of new packages with their section, priority and type.
 246
 247     """
 248     for pkg in new.keys():
 249         section_name = new[pkg]["section"]
 250         priority_name = new[pkg]["priority"]
 251         file_type = new[pkg]["type"]
 252
 253         section = get_section(section_name, session)
 254         if section is None:
 255             new[pkg]["section id"] = -1
 256         else:
 257             new[pkg]["section id"] = section.section_id
 258
 259         priority = get_priority(priority_name, session)
 260         if priority is None:
 261             new[pkg]["priority id"] = -1
 262         else:
 263             new[pkg]["priority id"] = priority.priority_id
 264
 265         # Sanity checks
 266         di = section_name.find("debian-installer") != -1
 267
 268         # If d-i, we must be udeb and vice-versa
 269         if     (di and file_type not in ("udeb", "dsc")) or \
 270            (not di and file_type == "udeb"):
 271             new[pkg]["section id"] = -1
 272
 273         # If dsc we need to be source and vice-versa
 274         if (priority == "source" and file_type != "dsc") or \
 275            (priority != "source" and file_type == "dsc"):
 276             new[pkg]["priority id"] = -1
 277
 278 ###############################################################################
 279
 280 # Used by Upload.check_timestamps
 281 class TarTime(object):
 282     def __init__(self, future_cutoff, past_cutoff):
 283         self.reset()
 284         self.future_cutoff = future_cutoff
 285         self.past_cutoff = past_cutoff
 286
 287     def reset(self):
 288         self.future_files = {}
 289         self.ancient_files = {}
 290
 291     def callback(self, member, data):
 292         if member.mtime > self.future_cutoff:
 293             self.future_files[Name] = MTime
 294         if member.mtime < self.past_cutoff:
 295             self.ancient_files[Name] = MTime
 296
 297 ###############################################################################
 298
 299 def prod_maintainer(notes, upload):
 300     cnf = Config()
 301
 302     # Here we prepare an editor and get them ready to prod...
 303     (fd, temp_filename) = utils.temp_filename()
 304     temp_file = os.fdopen(fd, 'w')
 305     for note in notes:
 306         temp_file.write(note.comment)
 307     temp_file.close()
 308     editor = os.environ.get("EDITOR","vi")
 309     answer = 'E'
 310     while answer == 'E':
 311         os.system("%s %s" % (editor, temp_filename))
 312         temp_fh = utils.open_file(temp_filename)
 313         prod_message = "".join(temp_fh.readlines())
 314         temp_fh.close()
 315         print "Prod message:"
 316         print utils.prefix_multi_line_string(prod_message,"  ",include_blank_lines=1)
 317         prompt = "[P]rod, Edit, Abandon, Quit ?"
 318         answer = "XXX"
 319         while prompt.find(answer) == -1:
 320             answer = utils.our_raw_input(prompt)
 321             m = re_default_answer.search(prompt)
 322             if answer == "":
 323                 answer = m.group(1)
 324             answer = answer[:1].upper()
 325     os.unlink(temp_filename)
 326     if answer == 'A':
 327         return
 328     elif answer == 'Q':
 329         end()
 330         sys.exit(0)
 331     # Otherwise, do the proding...
 332     user_email_address = utils.whoami() + " <%s>" % (
 333         cnf["Dinstall::MyAdminAddress"])
 334
 335     Subst = upload.Subst
 336
 337     Subst["__FROM_ADDRESS__"] = user_email_address
 338     Subst["__PROD_MESSAGE__"] = prod_message
 339     Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
 340
 341     prod_mail_message = utils.TemplateSubst(
 342         Subst,cnf["Dir::Templates"]+"/process-new.prod")
 343
 344     # Send the prod mail
 345     utils.send_mail(prod_mail_message)
 346
 347     print "Sent prodding message"
 348
 349 ################################################################################
 350
 351 def edit_note(note, upload, session, trainee=False):
 352     # Write the current data to a temporary file
 353     (fd, temp_filename) = utils.temp_filename()
 354     editor = os.environ.get("EDITOR","vi")
 355     answer = 'E'
 356     while answer == 'E':
 357         os.system("%s %s" % (editor, temp_filename))
 358         temp_file = utils.open_file(temp_filename)
 359         newnote = temp_file.read().rstrip()
 360         temp_file.close()
 361         print "New Note:"
 362         print utils.prefix_multi_line_string(newnote,"  ")
 363         prompt = "[D]one, Edit, Abandon, Quit ?"
 364         answer = "XXX"
 365         while prompt.find(answer) == -1:
 366             answer = utils.our_raw_input(prompt)
 367             m = re_default_answer.search(prompt)
 368             if answer == "":
 369                 answer = m.group(1)
 370             answer = answer[:1].upper()
 371     os.unlink(temp_filename)
 372     if answer == 'A':
 373         return
 374     elif answer == 'Q':
 375         end()
 376         sys.exit(0)
 377
 378     comment = NewComment()
 379     comment.package = upload.pkg.changes["source"]
 380     comment.version = upload.pkg.changes["version"]
 381     comment.comment = newnote
 382     comment.author  = utils.whoami()
 383     comment.trainee = trainee
 384     session.add(comment)
 385     session.commit()
 386
 387 ###############################################################################
 388
 389 # suite names DMs can upload to
 390 dm_suites = ['unstable', 'experimental']
 391
 392 def get_newest_source(source, session):
 393     'returns the newest DBSource object in dm_suites'
 394     ## the most recent version of the package uploaded to unstable or
 395     ## experimental includes the field "DM-Upload-Allowed: yes" in the source
 396     ## section of its control file
 397     q = session.query(DBSource).filter_by(source = source). \
 398         filter(DBSource.suites.any(Suite.suite_name.in_(dm_suites))). \
 399         order_by(desc('source.version'))
 400     return q.first()
 401
 402 def get_suite_version_by_source(source, session):
 403     'returns a list of tuples (suite_name, version) for source package'
 404     q = session.query(Suite.suite_name, DBSource.version). \
 405         join(Suite.sources).filter_by(source = source)
 406     return q.all()
 407
 408 def get_source_by_package_and_suite(package, suite_name, session):
 409     '''
 410     returns a DBSource query filtered by DBBinary.package and this package's
 411     suite_name
 412     '''
 413     return session.query(DBSource). \
 414         join(DBSource.binaries).filter_by(package = package). \
 415         join(DBBinary.suites).filter_by(suite_name = suite_name)
 416
 417 def get_suite_version_by_package(package, arch_string, session):
 418     '''
 419     returns a list of tuples (suite_name, version) for binary package and
 420     arch_string
 421     '''
 422     return session.query(Suite.suite_name, DBBinary.version). \
 423         join(Suite.binaries).filter_by(package = package). \
 424         join(DBBinary.architecture). \
 425         filter(Architecture.arch_string.in_([arch_string, 'all'])).all()
 426
 427 class Upload(object):
 428     """
 429     Everything that has to do with an upload processed.
 430
 431     """
 432     def __init__(self):
 433         self.logger = None
 434         self.pkg = Changes()
 435         self.reset()
 436
 437     ###########################################################################
 438
 439     def reset (self):
 440         """ Reset a number of internal variables."""
 441
 442         # Initialize the substitution template map
 443         cnf = Config()
 444         self.Subst = {}
 445         self.Subst["__ADMIN_ADDRESS__"] = cnf["Dinstall::MyAdminAddress"]
 446         if cnf.has_key("Dinstall::BugServer"):
 447             self.Subst["__BUG_SERVER__"] = cnf["Dinstall::BugServer"]
 448         self.Subst["__DISTRO__"] = cnf["Dinstall::MyDistribution"]
 449         self.Subst["__DAK_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
 450
 451         self.rejects = []
 452         self.warnings = []
 453         self.notes = []
 454
 455         self.later_check_files = []
 456
 457         self.pkg.reset()
 458
 459     def package_info(self):
 460         """
 461         Format various messages from this Upload to send to the maintainer.
 462         """
 463
 464         msgs = (
 465             ('Reject Reasons', self.rejects),
 466             ('Warnings', self.warnings),
 467             ('Notes', self.notes),
 468         )
 469
 470         msg = ''
 471         for title, messages in msgs:
 472             if messages:
 473                 msg += '\n\n%s:\n%s' % (title, '\n'.join(messages))
 474         msg += '\n\n'
 475
 476         return msg
 477
 478     ###########################################################################
 479     def update_subst(self):
 480         """ Set up the per-package template substitution mappings """
 481
 482         cnf = Config()
 483
 484         # If 'dak process-unchecked' crashed out in the right place, architecture may still be a string.
 485         if not self.pkg.changes.has_key("architecture") or not \
 486            isinstance(self.pkg.changes["architecture"], dict):
 487             self.pkg.changes["architecture"] = { "Unknown" : "" }
 488
 489         # and maintainer2047 may not exist.
 490         if not self.pkg.changes.has_key("maintainer2047"):
 491             self.pkg.changes["maintainer2047"] = cnf["Dinstall::MyEmailAddress"]
 492
 493         self.Subst["__ARCHITECTURE__"] = " ".join(self.pkg.changes["architecture"].keys())
 494         self.Subst["__CHANGES_FILENAME__"] = os.path.basename(self.pkg.changes_file)
 495         self.Subst["__FILE_CONTENTS__"] = self.pkg.changes.get("filecontents", "")
 496
 497         # For source uploads the Changed-By field wins; otherwise Maintainer wins.
 498         if self.pkg.changes["architecture"].has_key("source") and \
 499            self.pkg.changes["changedby822"] != "" and \
 500            (self.pkg.changes["changedby822"] != self.pkg.changes["maintainer822"]):
 501
 502             self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["changedby2047"]
 503             self.Subst["__MAINTAINER_TO__"] = "%s, %s" % (self.pkg.changes["changedby2047"], self.pkg.changes["maintainer2047"])
 504             self.Subst["__MAINTAINER__"] = self.pkg.changes.get("changed-by", "Unknown")
 505         else:
 506             self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["maintainer2047"]
 507             self.Subst["__MAINTAINER_TO__"] = self.pkg.changes["maintainer2047"]
 508             self.Subst["__MAINTAINER__"] = self.pkg.changes.get("maintainer", "Unknown")
 509
 510         # Process policy doesn't set the fingerprint field and I don't want to make it
 511         # do it for now as I don't want to have to deal with the case where we accepted
 512         # the package into PU-NEW, but the fingerprint has gone away from the keyring in
 513         # the meantime so the package will be remarked as rejectable.  Urgh.
 514         # TODO: Fix this properly
 515         if self.pkg.changes.has_key('fingerprint'):
 516             session = DBConn().session()
 517             fpr = get_fingerprint(self.pkg.changes['fingerprint'], session)
 518             if fpr and self.check_if_upload_is_sponsored("%s@debian.org" % fpr.uid.uid, fpr.uid.name):
 519                 if self.pkg.changes.has_key("sponsoremail"):
 520                     self.Subst["__MAINTAINER_TO__"] += ", %s" % self.pkg.changes["sponsoremail"]
 521             session.close()
 522
 523         if cnf.has_key("Dinstall::TrackingServer") and self.pkg.changes.has_key("source"):
 524             self.Subst["__MAINTAINER_TO__"] += "\nBcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
 525
 526         # Apply any global override of the Maintainer field
 527         if cnf.get("Dinstall::OverrideMaintainer"):
 528             self.Subst["__MAINTAINER_TO__"] = cnf["Dinstall::OverrideMaintainer"]
 529             self.Subst["__MAINTAINER_FROM__"] = cnf["Dinstall::OverrideMaintainer"]
 530
 531         self.Subst["__REJECT_MESSAGE__"] = self.package_info()
 532         self.Subst["__SOURCE__"] = self.pkg.changes.get("source", "Unknown")
 533         self.Subst["__VERSION__"] = self.pkg.changes.get("version", "Unknown")
 534         self.Subst["__SUITE__"] = ", ".join(self.pkg.changes["distribution"])
 535
 536     ###########################################################################
 537     def load_changes(self, filename):
 538         """
 539         Load a changes file and setup a dictionary around it. Also checks for mandantory
 540         fields  within.
 541
 542         @type filename: string
 543         @param filename: Changes filename, full path.
 544
 545         @rtype: boolean
 546         @return: whether the changes file was valid or not.  We may want to
 547                  reject even if this is True (see what gets put in self.rejects).
 548                  This is simply to prevent us even trying things later which will
 549                  fail because we couldn't properly parse the file.
 550         """
 551         Cnf = Config()
 552         self.pkg.changes_file = filename
 553
 554         # Parse the .changes field into a dictionary
 555         try:
 556             self.pkg.changes.update(parse_changes(filename))
 557         except CantOpenError:
 558             self.rejects.append("%s: can't read file." % (filename))
 559             return False
 560         except ParseChangesError, line:
 561             self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
 562             return False
 563         except ChangesUnicodeError:
 564             self.rejects.append("%s: changes file not proper utf-8" % (filename))
 565             return False
 566
 567         # Parse the Files field from the .changes into another dictionary
 568         try:
 569             self.pkg.files.update(utils.build_file_list(self.pkg.changes))
 570         except ParseChangesError, line:
 571             self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
 572             return False
 573         except UnknownFormatError, format:
 574             self.rejects.append("%s: unknown format '%s'." % (filename, format))
 575             return False
 576
 577         # Check for mandatory fields
 578         for i in ("distribution", "source", "binary", "architecture",
 579                   "version", "maintainer", "files", "changes", "description"):
 580             if not self.pkg.changes.has_key(i):
 581                 # Avoid undefined errors later
 582                 self.rejects.append("%s: Missing mandatory field `%s'." % (filename, i))
 583                 return False
 584
 585         # Strip a source version in brackets from the source field
 586         if re_strip_srcver.search(self.pkg.changes["source"]):
 587             self.pkg.changes["source"] = re_strip_srcver.sub('', self.pkg.changes["source"])
 588
 589         # Ensure the source field is a valid package name.
 590         if not re_valid_pkg_name.match(self.pkg.changes["source"]):
 591             self.rejects.append("%s: invalid source name '%s'." % (filename, self.pkg.changes["source"]))
 592
 593         # Split multi-value fields into a lower-level dictionary
 594         for i in ("architecture", "distribution", "binary", "closes"):
 595             o = self.pkg.changes.get(i, "")
 596             if o != "":
 597                 del self.pkg.changes[i]
 598
 599             self.pkg.changes[i] = {}
 600
 601             for j in o.split():
 602                 self.pkg.changes[i][j] = 1
 603
 604         # Fix the Maintainer: field to be RFC822/2047 compatible
 605         try:
 606             (self.pkg.changes["maintainer822"],
 607              self.pkg.changes["maintainer2047"],
 608              self.pkg.changes["maintainername"],
 609              self.pkg.changes["maintaineremail"]) = \
 610                    fix_maintainer (self.pkg.changes["maintainer"])
 611         except ParseMaintError, msg:
 612             self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
 613                    % (filename, self.pkg.changes["maintainer"], msg))
 614
 615         # ...likewise for the Changed-By: field if it exists.
 616         try:
 617             (self.pkg.changes["changedby822"],
 618              self.pkg.changes["changedby2047"],
 619              self.pkg.changes["changedbyname"],
 620              self.pkg.changes["changedbyemail"]) = \
 621                    fix_maintainer (self.pkg.changes.get("changed-by", ""))
 622         except ParseMaintError, msg:
 623             self.pkg.changes["changedby822"] = ""
 624             self.pkg.changes["changedby2047"] = ""
 625             self.pkg.changes["changedbyname"] = ""
 626             self.pkg.changes["changedbyemail"] = ""
 627
 628             self.rejects.append("%s: Changed-By field ('%s') failed to parse: %s" \
 629                    % (filename, self.pkg.changes["changed-by"], msg))
 630
 631         # Ensure all the values in Closes: are numbers
 632         if self.pkg.changes.has_key("closes"):
 633             for i in self.pkg.changes["closes"].keys():
 634                 if re_isanum.match (i) == None:
 635                     self.rejects.append(("%s: `%s' from Closes field isn't a number." % (filename, i)))
 636
 637         # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
 638         self.pkg.changes["chopversion"] = re_no_epoch.sub('', self.pkg.changes["version"])
 639         self.pkg.changes["chopversion2"] = re_no_revision.sub('', self.pkg.changes["chopversion"])
 640
 641         # Check the .changes is non-empty
 642         if not self.pkg.files:
 643             self.rejects.append("%s: nothing to do (Files field is empty)." % (os.path.basename(self.pkg.changes_file)))
 644             return False
 645
 646         # Changes was syntactically valid even if we'll reject
 647         return True
 648
 649     ###########################################################################
 650
 651     def check_distributions(self):
 652         "Check and map the Distribution field"
 653
 654         Cnf = Config()
 655
 656         # Handle suite mappings
 657         for m in Cnf.ValueList("SuiteMappings"):
 658             args = m.split()
 659             mtype = args[0]
 660             if mtype == "map" or mtype == "silent-map":
 661                 (source, dest) = args[1:3]
 662                 if self.pkg.changes["distribution"].has_key(source):
 663                     del self.pkg.changes["distribution"][source]
 664                     self.pkg.changes["distribution"][dest] = 1
 665                     if mtype != "silent-map":
 666                         self.notes.append("Mapping %s to %s." % (source, dest))
 667                 if self.pkg.changes.has_key("distribution-version"):
 668                     if self.pkg.changes["distribution-version"].has_key(source):
 669                         self.pkg.changes["distribution-version"][source]=dest
 670             elif mtype == "map-unreleased":
 671                 (source, dest) = args[1:3]
 672                 if self.pkg.changes["distribution"].has_key(source):
 673                     for arch in self.pkg.changes["architecture"].keys():
 674                         if arch not in [ a.arch_string for a in get_suite_architectures(source) ]:
 675                             self.notes.append("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch))
 676                             del self.pkg.changes["distribution"][source]
 677                             self.pkg.changes["distribution"][dest] = 1
 678                             break
 679             elif mtype == "ignore":
 680                 suite = args[1]
 681                 if self.pkg.changes["distribution"].has_key(suite):
 682                     del self.pkg.changes["distribution"][suite]
 683                     self.warnings.append("Ignoring %s as a target suite." % (suite))
 684             elif mtype == "reject":
 685                 suite = args[1]
 686                 if self.pkg.changes["distribution"].has_key(suite):
 687                     self.rejects.append("Uploads to %s are not accepted." % (suite))
 688             elif mtype == "propup-version":
 689                 # give these as "uploaded-to(non-mapped) suites-to-add-when-upload-obsoletes"
 690                 #
 691                 # changes["distribution-version"] looks like: {'testing': 'testing-proposed-updates'}
 692                 if self.pkg.changes["distribution"].has_key(args[1]):
 693                     self.pkg.changes.setdefault("distribution-version", {})
 694                     for suite in args[2:]:
 695                         self.pkg.changes["distribution-version"][suite] = suite
 696
 697         # Ensure there is (still) a target distribution
 698         if len(self.pkg.changes["distribution"].keys()) < 1:
 699             self.rejects.append("No valid distribution remaining.")
 700
 701         # Ensure target distributions exist
 702         for suite in self.pkg.changes["distribution"].keys():
 703             if not get_suite(suite.lower()):
 704                 self.rejects.append("Unknown distribution `%s'." % (suite))
 705
 706     ###########################################################################
 707
 708     def binary_file_checks(self, f, session):
 709         cnf = Config()
 710         entry = self.pkg.files[f]
 711
 712         # Extract package control information
 713         deb_file = utils.open_file(f)
 714         try:
 715             control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))
 716         except:
 717             self.rejects.append("%s: debExtractControl() raised %s." % (f, sys.exc_type))
 718             deb_file.close()
 719             # Can't continue, none of the checks on control would work.
 720             return
 721
 722         # Check for mandantory "Description:"
 723         deb_file.seek(0)
 724         try:
 725             apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))["Description"] + '\n'
 726         except:
 727             self.rejects.append("%s: Missing Description in binary package" % (f))
 728             return
 729
 730         deb_file.close()
 731
 732         # Check for mandatory fields
 733         for field in [ "Package", "Architecture", "Version" ]:
 734             if control.Find(field) == None:
 735                 # Can't continue
 736                 self.rejects.append("%s: No %s field in control." % (f, field))
 737                 return
 738
 739         # Ensure the package name matches the one give in the .changes
 740         if not self.pkg.changes["binary"].has_key(control.Find("Package", "")):
 741             self.rejects.append("%s: control file lists name as `%s', which isn't in changes file." % (f, control.Find("Package", "")))
 742
 743         # Validate the package field
 744         package = control.Find("Package")
 745         if not re_valid_pkg_name.match(package):
 746             self.rejects.append("%s: invalid package name '%s'." % (f, package))
 747
 748         # Validate the version field
 749         version = control.Find("Version")
 750         if not re_valid_version.match(version):
 751             self.rejects.append("%s: invalid version number '%s'." % (f, version))
 752
 753         # Ensure the architecture of the .deb is one we know about.
 754         default_suite = cnf.get("Dinstall::DefaultSuite", "unstable")
 755         architecture = control.Find("Architecture")
 756         upload_suite = self.pkg.changes["distribution"].keys()[0]
 757
 758         if      architecture not in [a.arch_string for a in get_suite_architectures(default_suite, session = session)] \
 759             and architecture not in [a.arch_string for a in get_suite_architectures(upload_suite, session = session)]:
 760             self.rejects.append("Unknown architecture '%s'." % (architecture))
 761
 762         # Ensure the architecture of the .deb is one of the ones
 763         # listed in the .changes.
 764         if not self.pkg.changes["architecture"].has_key(architecture):
 765             self.rejects.append("%s: control file lists arch as `%s', which isn't in changes file." % (f, architecture))
 766
 767         # Sanity-check the Depends field
 768         depends = control.Find("Depends")
 769         if depends == '':
 770             self.rejects.append("%s: Depends field is empty." % (f))
 771
 772         # Sanity-check the Provides field
 773         provides = control.Find("Provides")
 774         if provides:
 775             provide = re_spacestrip.sub('', provides)
 776             if provide == '':
 777                 self.rejects.append("%s: Provides field is empty." % (f))
 778             prov_list = provide.split(",")
 779             for prov in prov_list:
 780                 if not re_valid_pkg_name.match(prov):
 781                     self.rejects.append("%s: Invalid Provides field content %s." % (f, prov))
 782
 783         # If there is a Built-Using field, we need to check we can find the
 784         # exact source version
 785         built_using = control.Find("Built-Using")
 786         if built_using:
 787             try:
 788                 entry["built-using"] = []
 789                 for dep in apt_pkg.parse_depends(built_using):
 790                     bu_s, bu_v, bu_e = dep[0]
 791                     # Check that it's an exact match dependency and we have
 792                     # some form of version
 793                     if bu_e != "=" or len(bu_v) < 1:
 794                         self.rejects.append("%s: Built-Using contains non strict dependency (%s %s %s)" % (f, bu_s, bu_e, bu_v))
 795                     else:
 796                         # Find the source id for this version
 797                         bu_so = get_sources_from_name(bu_s, version=bu_v, session = session)
 798                         if len(bu_so) != 1:
 799                             self.rejects.append("%s: Built-Using (%s = %s): Cannot find source package" % (f, bu_s, bu_v))
 800                         else:
 801                             entry["built-using"].append( (bu_so[0].source, bu_so[0].version, ) )
 802
 803             except ValueError, e:
 804                 self.rejects.append("%s: Cannot parse Built-Using field: %s" % (f, str(e)))
 805
 806
 807         # Check the section & priority match those given in the .changes (non-fatal)
 808         if     control.Find("Section") and entry["section"] != "" \
 809            and entry["section"] != control.Find("Section"):
 810             self.warnings.append("%s control file lists section as `%s', but changes file has `%s'." % \
 811                                 (f, control.Find("Section", ""), entry["section"]))
 812         if control.Find("Priority") and entry["priority"] != "" \
 813            and entry["priority"] != control.Find("Priority"):
 814             self.warnings.append("%s control file lists priority as `%s', but changes file has `%s'." % \
 815                                 (f, control.Find("Priority", ""), entry["priority"]))
 816
 817         entry["package"] = package
 818         entry["architecture"] = architecture
 819         entry["version"] = version
 820         entry["maintainer"] = control.Find("Maintainer", "")
 821
 822         if f.endswith(".udeb"):
 823             self.pkg.files[f]["dbtype"] = "udeb"
 824         elif f.endswith(".deb"):
 825             self.pkg.files[f]["dbtype"] = "deb"
 826         else:
 827             self.rejects.append("%s is neither a .deb or a .udeb." % (f))
 828
 829         entry["source"] = control.Find("Source", entry["package"])
 830
 831         # Get the source version
 832         source = entry["source"]
 833         source_version = ""
 834
 835         if source.find("(") != -1:
 836             m = re_extract_src_version.match(source)
 837             source = m.group(1)
 838             source_version = m.group(2)
 839
 840         if not source_version:
 841             source_version = self.pkg.files[f]["version"]
 842
 843         entry["source package"] = source
 844         entry["source version"] = source_version
 845
 846         # Ensure the filename matches the contents of the .deb
 847         m = re_isadeb.match(f)
 848
 849         #  package name
 850         file_package = m.group(1)
 851         if entry["package"] != file_package:
 852             self.rejects.append("%s: package part of filename (%s) does not match package name in the %s (%s)." % \
 853                                 (f, file_package, entry["dbtype"], entry["package"]))
 854         epochless_version = re_no_epoch.sub('', control.Find("Version"))
 855
 856         #  version
 857         file_version = m.group(2)
 858         if epochless_version != file_version:
 859             self.rejects.append("%s: version part of filename (%s) does not match package version in the %s (%s)." % \
 860                                 (f, file_version, entry["dbtype"], epochless_version))
 861
 862         #  architecture
 863         file_architecture = m.group(3)
 864         if entry["architecture"] != file_architecture:
 865             self.rejects.append("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % \
 866                                 (f, file_architecture, entry["dbtype"], entry["architecture"]))
 867
 868         # Check for existent source
 869         source_version = entry["source version"]
 870         source_package = entry["source package"]
 871         if self.pkg.changes["architecture"].has_key("source"):
 872             if source_version != self.pkg.changes["version"]:
 873                 self.rejects.append("source version (%s) for %s doesn't match changes version %s." % \
 874                                     (source_version, f, self.pkg.changes["version"]))
 875         else:
 876             # Check in the SQL database
 877             if not source_exists(source_package, source_version, suites = \
 878                 self.pkg.changes["distribution"].keys(), session = session):
 879                 # Check in one of the other directories
 880                 source_epochless_version = re_no_epoch.sub('', source_version)
 881                 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
 882
 883                 byhand_dir = get_policy_queue('byhand', session).path
 884                 new_dir = get_policy_queue('new', session).path
 885
 886                 if os.path.exists(os.path.join(byhand_dir, dsc_filename)):
 887                     entry["byhand"] = 1
 888                 elif os.path.exists(os.path.join(new_dir, dsc_filename)):
 889                     entry["new"] = 1
 890                 else:
 891                     dsc_file_exists = False
 892                     # TODO: Don't hardcode this list: use all relevant queues
 893                     #       The question is how to determine what is relevant
 894                     for queue_name in ["embargoed", "unembargoed", "proposedupdates", "oldproposedupdates"]:
 895                         queue = get_policy_queue(queue_name, session)
 896                         if queue:
 897                             if os.path.exists(os.path.join(queue.path, dsc_filename)):
 898                                 dsc_file_exists = True
 899                                 break
 900
 901                     if not dsc_file_exists:
 902                         self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))
 903
 904         # Check the version and for file overwrites
 905         self.check_binary_against_db(f, session)
 906
 907     def source_file_checks(self, f, session):
 908         entry = self.pkg.files[f]
 909
 910         m = re_issource.match(f)
 911         if not m:
 912             return
 913
 914         entry["package"] = m.group(1)
 915         entry["version"] = m.group(2)
 916         entry["type"] = m.group(3)
 917
 918         # Ensure the source package name matches the Source filed in the .changes
 919         if self.pkg.changes["source"] != entry["package"]:
 920             self.rejects.append("%s: changes file doesn't say %s for Source" % (f, entry["package"]))
 921
 922         # Ensure the source version matches the version in the .changes file
 923         if re_is_orig_source.match(f):
 924             changes_version = self.pkg.changes["chopversion2"]
 925         else:
 926             changes_version = self.pkg.changes["chopversion"]
 927
 928         if changes_version != entry["version"]:
 929             self.rejects.append("%s: should be %s according to changes file." % (f, changes_version))
 930
 931         # Ensure the .changes lists source in the Architecture field
 932         if not self.pkg.changes["architecture"].has_key("source"):
 933             self.rejects.append("%s: changes file doesn't list `source' in Architecture field." % (f))
 934
 935         # Check the signature of a .dsc file
 936         if entry["type"] == "dsc":
 937             # check_signature returns either:
 938             #  (None, [list, of, rejects]) or (signature, [])
 939             (self.pkg.dsc["fingerprint"], rejects) = utils.check_signature(f)
 940             for j in rejects:
 941                 self.rejects.append(j)
 942
 943         entry["architecture"] = "source"
 944
 945     def per_suite_file_checks(self, f, suite, session):
 946         cnf = Config()
 947         entry = self.pkg.files[f]
 948
 949         # Skip byhand
 950         if entry.has_key("byhand"):
 951             return
 952
 953         # Check we have fields we need to do these checks
 954         oktogo = True
 955         for m in ['component', 'package', 'priority', 'size', 'md5sum']:
 956             if not entry.has_key(m):
 957                 self.rejects.append("file '%s' does not have field %s set" % (f, m))
 958                 oktogo = False
 959
 960         if not oktogo:
 961             return
 962
 963         # Handle component mappings
 964         for m in cnf.ValueList("ComponentMappings"):
 965             (source, dest) = m.split()
 966             if entry["component"] == source:
 967                 entry["original component"] = source
 968                 entry["component"] = dest
 969
 970         # Ensure the component is valid for the target suite
 971         if entry["component"] not in get_component_names(session):
 972             self.rejects.append("unknown component `%s' for suite `%s'." % (entry["component"], suite))
 973             return
 974
 975         # Validate the component
 976         if not get_component(entry["component"], session):
 977             self.rejects.append("file '%s' has unknown component '%s'." % (f, entry["component"]))
 978             return
 979
 980         # See if the package is NEW
 981         if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), f, session):
 982             entry["new"] = 1
 983
 984         # Validate the priority
 985         if entry["priority"].find('/') != -1:
 986             self.rejects.append("file '%s' has invalid priority '%s' [contains '/']." % (f, entry["priority"]))
 987
 988         # Determine the location
 989         location = cnf["Dir::Pool"]
 990         l = get_location(location, entry["component"], session=session)
 991         if l is None:
 992             self.rejects.append("[INTERNAL ERROR] couldn't determine location (Component: %s)" % entry["component"])
 993             entry["location id"] = -1
 994         else:
 995             entry["location id"] = l.location_id
 996
 997         # Check the md5sum & size against existing files (if any)
 998         entry["pool name"] = utils.poolify(self.pkg.changes["source"], entry["component"])
 999
1000         found, poolfile = check_poolfile(os.path.join(entry["pool name"], f),
1001                                          entry["size"], entry["md5sum"], entry["location id"])
1002
1003         if found is None:
1004             self.rejects.append("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (f))
1005         elif found is False and poolfile is not None:
1006             self.rejects.append("md5sum and/or size mismatch on existing copy of %s." % (f))
1007         else:
1008             if poolfile is None:
1009                 entry["files id"] = None
1010             else:
1011                 entry["files id"] = poolfile.file_id
1012
1013         # Check for packages that have moved from one component to another
1014         entry['suite'] = suite
1015         arch_list = [entry["architecture"], 'all']
1016         component = get_component_by_package_suite(self.pkg.files[f]['package'], \
1017             [suite], arch_list = arch_list, session = session)
1018         if component is not None:
1019             entry["othercomponents"] = component
1020
1021     def check_files(self, action=True):
1022         file_keys = self.pkg.files.keys()
1023         holding = Holding()
1024         cnf = Config()
1025
1026         if action:
1027             cwd = os.getcwd()
1028             os.chdir(self.pkg.directory)
1029             for f in file_keys:
1030                 ret = holding.copy_to_holding(f)
1031                 if ret is not None:
1032                     self.warnings.append('Could not copy %s to holding; will attempt to find in DB later' % f)
1033
1034             os.chdir(cwd)
1035
1036         # check we already know the changes file
1037         # [NB: this check must be done post-suite mapping]
1038         base_filename = os.path.basename(self.pkg.changes_file)
1039
1040         session = DBConn().session()
1041
1042         try:
1043             dbc = session.query(DBChange).filter_by(changesname=base_filename).one()
1044             # if in the pool or in a queue other than unchecked, reject
1045             if (dbc.in_queue is None) \
1046                    or (dbc.in_queue is not None
1047                        and dbc.in_queue.queue_name not in ["unchecked", "newstage"]):
1048                 self.rejects.append("%s file already known to dak" % base_filename)
1049         except NoResultFound, e:
1050             # not known, good
1051             pass
1052
1053         has_binaries = False
1054         has_source = False
1055
1056         for f, entry in self.pkg.files.items():
1057             # Ensure the file does not already exist in one of the accepted directories
1058             # TODO: Dynamically generate this list
1059             for queue_name in [ "byhand", "new", "proposedupdates", "oldproposedupdates", "embargoed", "unembargoed" ]:
1060                 queue = get_policy_queue(queue_name, session)
1061                 if queue and os.path.exists(os.path.join(queue.path, f)):
1062                     self.rejects.append("%s file already exists in the %s queue." % (f, queue_name))
1063
1064             if not re_taint_free.match(f):
1065                 self.rejects.append("!!WARNING!! tainted filename: '%s'." % (f))
1066
1067             # Check the file is readable
1068             if os.access(f, os.R_OK) == 0:
1069                 # When running in -n, copy_to_holding() won't have
1070                 # generated the reject_message, so we need to.
1071                 if action:
1072                     if os.path.exists(f):
1073                         self.rejects.append("Can't read `%s'. [permission denied]" % (f))
1074                     else:
1075                         # Don't directly reject, mark to check later to deal with orig's
1076                         # we can find in the pool
1077                         self.later_check_files.append(f)
1078                 entry["type"] = "unreadable"
1079                 continue
1080
1081             # If it's byhand skip remaining checks
1082             if entry["section"] == "byhand" or entry["section"][:4] == "raw-":
1083                 entry["byhand"] = 1
1084                 entry["type"] = "byhand"
1085
1086             # Checks for a binary package...
1087             elif re_isadeb.match(f):
1088                 has_binaries = True
1089                 entry["type"] = "deb"
1090
1091                 # This routine appends to self.rejects/warnings as appropriate
1092                 self.binary_file_checks(f, session)
1093
1094             # Checks for a source package...
1095             elif re_issource.match(f):
1096                 has_source = True
1097
1098                 # This routine appends to self.rejects/warnings as appropriate
1099                 self.source_file_checks(f, session)
1100
1101             # Not a binary or source package?  Assume byhand...
1102             else:
1103                 entry["byhand"] = 1
1104                 entry["type"] = "byhand"
1105
1106             # Per-suite file checks
1107             entry["oldfiles"] = {}
1108             for suite in self.pkg.changes["distribution"].keys():
1109                 self.per_suite_file_checks(f, suite, session)
1110
1111         session.close()
1112
1113         # If the .changes file says it has source, it must have source.
1114         if self.pkg.changes["architecture"].has_key("source"):
1115             if not has_source:
1116                 self.rejects.append("no source found and Architecture line in changes mention source.")
1117
1118             if (not has_binaries) and (not cnf.FindB("Dinstall::AllowSourceOnlyUploads")):
1119                 self.rejects.append("source only uploads are not supported.")
1120
1121     ###########################################################################
1122
1123     def __dsc_filename(self):
1124         """
1125         Returns: (Status, Dsc_Filename)
1126         where
1127           Status: Boolean; True when there was no error, False otherwise
1128           Dsc_Filename: String; name of the dsc file if Status is True, reason for the error otherwise
1129         """
1130         dsc_filename = None
1131
1132         # find the dsc
1133         for name, entry in self.pkg.files.items():
1134             if entry.has_key("type") and entry["type"] == "dsc":
1135                 if dsc_filename:
1136                     return False, "cannot process a .changes file with multiple .dsc's."
1137                 else:
1138                     dsc_filename = name
1139
1140         if not dsc_filename:
1141             return False, "source uploads must contain a dsc file"
1142
1143         return True, dsc_filename
1144
1145     def load_dsc(self, action=True, signing_rules=1):
1146         """
1147         Find and load the dsc from self.pkg.files into self.dsc
1148
1149         Returns: (Status, Reason)
1150         where
1151           Status: Boolean; True when there was no error, False otherwise
1152           Reason: String; When Status is False this describes the error
1153         """
1154
1155         # find the dsc
1156         (status, dsc_filename) = self.__dsc_filename()
1157         if not status:
1158             # If status is false, dsc_filename has the reason
1159             return False, dsc_filename
1160
1161         try:
1162             self.pkg.dsc.update(utils.parse_changes(dsc_filename, signing_rules=signing_rules, dsc_file=1))
1163         except CantOpenError:
1164             if not action:
1165                 return False, "%s: can't read file." % (dsc_filename)
1166         except ParseChangesError, line:
1167             return False, "%s: parse error, can't grok: %s." % (dsc_filename, line)
1168         except InvalidDscError, line:
1169             return False, "%s: syntax error on line %s." % (dsc_filename, line)
1170         except ChangesUnicodeError:
1171             return False, "%s: dsc file not proper utf-8." % (dsc_filename)
1172
1173         return True, None
1174
1175     ###########################################################################
1176
1177     def check_dsc(self, action=True, session=None):
1178         """Returns bool indicating whether or not the source changes are valid"""
1179         # Ensure there is source to check
1180         if not self.pkg.changes["architecture"].has_key("source"):
1181             return True
1182
1183         if session is None:
1184             session = DBConn().session()
1185
1186         (status, reason) = self.load_dsc(action=action)
1187         if not status:
1188             self.rejects.append(reason)
1189             return False
1190         (status, dsc_filename) = self.__dsc_filename()
1191         if not status:
1192             # If status is false, dsc_filename has the reason
1193             self.rejects.append(dsc_filename)
1194             return False
1195
1196         # Build up the file list of files mentioned by the .dsc
1197         try:
1198             self.pkg.dsc_files.update(utils.build_file_list(self.pkg.dsc, is_a_dsc=1))
1199         except NoFilesFieldError:
1200             self.rejects.append("%s: no Files: field." % (dsc_filename))
1201             return False
1202         except UnknownFormatError, format:
1203             self.rejects.append("%s: unknown format '%s'." % (dsc_filename, format))
1204             return False
1205         except ParseChangesError, line:
1206             self.rejects.append("%s: parse error, can't grok: %s." % (dsc_filename, line))
1207             return False
1208
1209         # Enforce mandatory fields
1210         for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
1211             if not self.pkg.dsc.has_key(i):
1212                 self.rejects.append("%s: missing mandatory field `%s'." % (dsc_filename, i))
1213                 return False
1214
1215         # Validate the source and version fields
1216         if not re_valid_pkg_name.match(self.pkg.dsc["source"]):
1217             self.rejects.append("%s: invalid source name '%s'." % (dsc_filename, self.pkg.dsc["source"]))
1218         if not re_valid_version.match(self.pkg.dsc["version"]):
1219             self.rejects.append("%s: invalid version number '%s'." % (dsc_filename, self.pkg.dsc["version"]))
1220
1221         # Only a limited list of source formats are allowed in each suite
1222         for dist in self.pkg.changes["distribution"].keys():
1223             suite = get_suite(dist, session=session)
1224             if not suite:
1225                 self.rejects.append("%s: cannot find suite %s when checking source formats" % (dsc_filename, dist))
1226                 continue
1227             allowed = [ x.format_name for x in suite.srcformats ]
1228             if self.pkg.dsc["format"] not in allowed:
1229                 self.rejects.append("%s: source format '%s' not allowed in %s (accepted: %s) " % (dsc_filename, self.pkg.dsc["format"], dist, ", ".join(allowed)))
1230
1231         # Validate the Maintainer field
1232         try:
1233             # We ignore the return value
1234             fix_maintainer(self.pkg.dsc["maintainer"])
1235         except ParseMaintError, msg:
1236             self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
1237                                  % (dsc_filename, self.pkg.dsc["maintainer"], msg))
1238
1239         # Validate the build-depends field(s)
1240         for field_name in [ "build-depends", "build-depends-indep" ]:
1241             field = self.pkg.dsc.get(field_name)
1242             if field:
1243                 # Have apt try to parse them...
1244                 try:
1245                     apt_pkg.ParseSrcDepends(field)
1246                 except:
1247                     self.rejects.append("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()))
1248
1249         # Ensure the version number in the .dsc matches the version number in the .changes
1250         epochless_dsc_version = re_no_epoch.sub('', self.pkg.dsc["version"])
1251         changes_version = self.pkg.files[dsc_filename]["version"]
1252
1253         if epochless_dsc_version != self.pkg.files[dsc_filename]["version"]:
1254             self.rejects.append("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version))
1255
1256         # Ensure the Files field contain only what's expected
1257         self.rejects.extend(check_dsc_files(dsc_filename, self.pkg.dsc, self.pkg.dsc_files))
1258
1259         # Ensure source is newer than existing source in target suites
1260         session = DBConn().session()
1261         self.check_source_against_db(dsc_filename, session)
1262         self.check_dsc_against_db(dsc_filename, session)
1263
1264         dbchg = get_dbchange(self.pkg.changes_file, session)
1265
1266         # Finally, check if we're missing any files
1267         for f in self.later_check_files:
1268             print 'XXX: %s' % f
1269             # Check if we've already processed this file if we have a dbchg object
1270             ok = False
1271             if dbchg:
1272                 for pf in dbchg.files:
1273                     if pf.filename == f and pf.processed:
1274                         self.notes.append('%s was already processed so we can go ahead' % f)
1275                         ok = True
1276                         del self.pkg.files[f]
1277             if not ok:
1278                 self.rejects.append("Could not find file %s references in changes" % f)
1279
1280         session.close()
1281
1282         return (len(self.rejects) == 0)
1283
1284     ###########################################################################
1285
1286     def get_changelog_versions(self, source_dir):
1287         """Extracts a the source package and (optionally) grabs the
1288         version history out of debian/changelog for the BTS."""
1289
1290         cnf = Config()
1291
1292         # Find the .dsc (again)
1293         dsc_filename = None
1294         for f in self.pkg.files.keys():
1295             if self.pkg.files[f]["type"] == "dsc":
1296                 dsc_filename = f
1297
1298         # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
1299         if not dsc_filename:
1300             return
1301
1302         # Create a symlink mirror of the source files in our temporary directory
1303         for f in self.pkg.files.keys():
1304             m = re_issource.match(f)
1305             if m:
1306                 src = os.path.join(source_dir, f)
1307                 # If a file is missing for whatever reason, give up.
1308                 if not os.path.exists(src):
1309                     return
1310                 ftype = m.group(3)
1311                 if re_is_orig_source.match(f) and self.pkg.orig_files.has_key(f) and \
1312                    self.pkg.orig_files[f].has_key("path"):
1313                     continue
1314                 dest = os.path.join(os.getcwd(), f)
1315                 os.symlink(src, dest)
1316
1317         # If the orig files are not a part of the upload, create symlinks to the
1318         # existing copies.
1319         for orig_file in self.pkg.orig_files.keys():
1320             if not self.pkg.orig_files[orig_file].has_key("path"):
1321                 continue
1322             dest = os.path.join(os.getcwd(), os.path.basename(orig_file))
1323             os.symlink(self.pkg.orig_files[orig_file]["path"], dest)
1324
1325         # Extract the source
1326         try:
1327             unpacked = UnpackedSource(dsc_filename)
1328         except Exception, e:
1329             self.rejects.append("'dpkg-source -x' failed for %s. (%s)" % (dsc_filename, str(e)))
1330             return
1331
1332         if not cnf.Find("Dir::BTSVersionTrack"):
1333             return
1334
1335         # Get the upstream version
1336         upstr_version = re_no_epoch.sub('', self.pkg.dsc["version"])
1337         if re_strip_revision.search(upstr_version):
1338             upstr_version = re_strip_revision.sub('', upstr_version)
1339
1340         # Ensure the changelog file exists
1341         changelog_file = unpacked.get_changelog_file()
1342         if changelog_file is None:
1343             self.rejects.append("%s: debian/changelog not found in extracted source." % (dsc_filename))
1344             return
1345
1346         # Parse the changelog
1347         self.pkg.dsc["bts changelog"] = ""
1348         for line in changelog_file.readlines():
1349             m = re_changelog_versions.match(line)
1350             if m:
1351                 self.pkg.dsc["bts changelog"] += line
1352         changelog_file.close()
1353         unpacked.cleanup()
1354
1355         # Check we found at least one revision in the changelog
1356         if not self.pkg.dsc["bts changelog"]:
1357             self.rejects.append("%s: changelog format not recognised (empty version tree)." % (dsc_filename))
1358
1359     def check_source(self):
1360         # Bail out if:
1361         #    a) there's no source
1362         if not self.pkg.changes["architecture"].has_key("source"):
1363             return
1364
1365         tmpdir = utils.temp_dirname()
1366
1367         # Move into the temporary directory
1368         cwd = os.getcwd()
1369         os.chdir(tmpdir)
1370
1371         # Get the changelog version history
1372         self.get_changelog_versions(cwd)
1373
1374         # Move back and cleanup the temporary tree
1375         os.chdir(cwd)
1376
1377         try:
1378             shutil.rmtree(tmpdir)
1379         except OSError, e:
1380             if e.errno != errno.EACCES:
1381                 print "foobar"
1382                 utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))
1383
1384             self.rejects.append("%s: source tree could not be cleanly removed." % (self.pkg.dsc["source"]))
1385             # We probably have u-r or u-w directories so chmod everything
1386             # and try again.
1387             cmd = "chmod -R u+rwx %s" % (tmpdir)
1388             result = os.system(cmd)
1389             if result != 0:
1390                 utils.fubar("'%s' failed with result %s." % (cmd, result))
1391             shutil.rmtree(tmpdir)
1392         except Exception, e:
1393             print "foobar2 (%s)" % e
1394             utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))
1395
1396     ###########################################################################
1397     def ensure_hashes(self):
1398         # Make sure we recognise the format of the Files: field in the .changes
1399         format = self.pkg.changes.get("format", "0.0").split(".", 1)
1400         if len(format) == 2:
1401             format = int(format[0]), int(format[1])
1402         else:
1403             format = int(float(format[0])), 0
1404
1405         # We need to deal with the original changes blob, as the fields we need
1406         # might not be in the changes dict serialised into the .dak anymore.
1407         orig_changes = utils.parse_deb822(self.pkg.changes['filecontents'])
1408
1409         # Copy the checksums over to the current changes dict.  This will keep
1410         # the existing modifications to it intact.
1411         for field in orig_changes:
1412             if field.startswith('checksums-'):
1413                 self.pkg.changes[field] = orig_changes[field]
1414
1415         # Check for unsupported hashes
1416         for j in utils.check_hash_fields(".changes", self.pkg.changes):
1417             self.rejects.append(j)
1418
1419         for j in utils.check_hash_fields(".dsc", self.pkg.dsc):
1420             self.rejects.append(j)
1421
1422         # We have to calculate the hash if we have an earlier changes version than
1423         # the hash appears in rather than require it exist in the changes file
1424         for hashname, hashfunc, version in utils.known_hashes:
1425             # TODO: Move _ensure_changes_hash into this class
1426             for j in utils._ensure_changes_hash(self.pkg.changes, format, version, self.pkg.files, hashname, hashfunc):
1427                 self.rejects.append(j)
1428             if "source" in self.pkg.changes["architecture"]:
1429                 # TODO: Move _ensure_dsc_hash into this class
1430                 for j in utils._ensure_dsc_hash(self.pkg.dsc, self.pkg.dsc_files, hashname, hashfunc):
1431                     self.rejects.append(j)
1432
1433     def check_hashes(self):
1434         for m in utils.check_hash(".changes", self.pkg.files, "md5", apt_pkg.md5sum):
1435             self.rejects.append(m)
1436
1437         for m in utils.check_size(".changes", self.pkg.files):
1438             self.rejects.append(m)
1439
1440         for m in utils.check_hash(".dsc", self.pkg.dsc_files, "md5", apt_pkg.md5sum):
1441             self.rejects.append(m)
1442
1443         for m in utils.check_size(".dsc", self.pkg.dsc_files):
1444             self.rejects.append(m)
1445
1446         self.ensure_hashes()
1447
1448     ###########################################################################
1449
1450     def ensure_orig(self, target_dir='.', session=None):
1451         """
1452         Ensures that all orig files mentioned in the changes file are present
1453         in target_dir. If they do not exist, they are symlinked into place.
1454
1455         An list containing the symlinks that were created are returned (so they
1456         can be removed).
1457         """
1458
1459         symlinked = []
1460         cnf = Config()
1461
1462         for filename, entry in self.pkg.dsc_files.iteritems():
1463             if not re_is_orig_source.match(filename):
1464                 # File is not an orig; ignore
1465                 continue
1466
1467             if os.path.exists(filename):
1468                 # File exists, no need to continue
1469                 continue
1470
1471             def symlink_if_valid(path):
1472                 f = utils.open_file(path)
1473                 md5sum = apt_pkg.md5sum(f)
1474                 f.close()
1475
1476                 fingerprint = (os.stat(path)[stat.ST_SIZE], md5sum)
1477                 expected = (int(entry['size']), entry['md5sum'])
1478
1479                 if fingerprint != expected:
1480                     return False
1481
1482                 dest = os.path.join(target_dir, filename)
1483
1484                 os.symlink(path, dest)
1485                 symlinked.append(dest)
1486
1487                 return True
1488
1489             session_ = session
1490             if session is None:
1491                 session_ = DBConn().session()
1492
1493             found = False
1494
1495             # Look in the pool
1496             for poolfile in get_poolfile_like_name('%s' % filename, session_):
1497                 poolfile_path = os.path.join(
1498                     poolfile.location.path, poolfile.filename
1499                 )
1500
1501                 if symlink_if_valid(poolfile_path):
1502                     found = True
1503                     break
1504
1505             if session is None:
1506                 session_.close()
1507
1508             if found:
1509                 continue
1510
1511             # Look in some other queues for the file
1512             queue_names = ['new', 'byhand',
1513                            'proposedupdates', 'oldproposedupdates',
1514                            'embargoed', 'unembargoed']
1515
1516             for queue_name in queue_names:
1517                 queue = get_policy_queue(queue_name, session)
1518                 if not queue:
1519                     continue
1520
1521                 queuefile_path = os.path.join(queue.path, filename)
1522
1523                 if not os.path.exists(queuefile_path):
1524                     # Does not exist in this queue
1525                     continue
1526
1527                 if symlink_if_valid(queuefile_path):
1528                     break
1529
1530         return symlinked
1531
1532     ###########################################################################
1533
1534     def check_lintian(self):
1535         """
1536         Extends self.rejects by checking the output of lintian against tags
1537         specified in Dinstall::LintianTags.
1538         """
1539
1540         cnf = Config()
1541
1542         # Don't reject binary uploads
1543         if not self.pkg.changes['architecture'].has_key('source'):
1544             return
1545
1546         # Only check some distributions
1547         for dist in ('unstable', 'experimental'):
1548             if dist in self.pkg.changes['distribution']:
1549                 break
1550         else:
1551             return
1552
1553         # If we do not have a tagfile, don't do anything
1554         tagfile = cnf.get("Dinstall::LintianTags")
1555         if not tagfile:
1556             return
1557
1558         # Parse the yaml file
1559         sourcefile = file(tagfile, 'r')
1560         sourcecontent = sourcefile.read()
1561         sourcefile.close()
1562
1563         try:
1564             lintiantags = yaml.load(sourcecontent)['lintian']
1565         except yaml.YAMLError, msg:
1566             utils.fubar("Can not read the lintian tags file %s, YAML error: %s." % (tagfile, msg))
1567             return
1568
1569         # Try and find all orig mentioned in the .dsc
1570         symlinked = self.ensure_orig()
1571
1572         # Setup the input file for lintian
1573         fd, temp_filename = utils.temp_filename()
1574         temptagfile = os.fdopen(fd, 'w')
1575         for tags in lintiantags.values():
1576             temptagfile.writelines(['%s\n' % x for x in tags])
1577         temptagfile.close()
1578
1579         try:
1580             cmd = "lintian --show-overrides --tags-from-file %s %s" % \
1581                 (temp_filename, self.pkg.changes_file)
1582
1583             result, output = commands.getstatusoutput(cmd)
1584         finally:
1585             # Remove our tempfile and any symlinks we created
1586             os.unlink(temp_filename)
1587
1588             for symlink in symlinked:
1589                 os.unlink(symlink)
1590
1591         if result == 2:
1592             utils.warn("lintian failed for %s [return code: %s]." % \
1593                 (self.pkg.changes_file, result))
1594             utils.warn(utils.prefix_multi_line_string(output, \
1595                 " [possible output:] "))
1596
1597         def log(*txt):
1598             if self.logger:
1599                 self.logger.log(
1600                     [self.pkg.changes_file, "check_lintian"] + list(txt)
1601                 )
1602
1603         # Generate messages
1604         parsed_tags = parse_lintian_output(output)
1605         self.rejects.extend(
1606             generate_reject_messages(parsed_tags, lintiantags, log=log)
1607         )
1608
1609     ###########################################################################
1610     def check_urgency(self):
1611         cnf = Config()
1612         if self.pkg.changes["architecture"].has_key("source"):
1613             if not self.pkg.changes.has_key("urgency"):
1614                 self.pkg.changes["urgency"] = cnf["Urgency::Default"]
1615             self.pkg.changes["urgency"] = self.pkg.changes["urgency"].lower()
1616             if self.pkg.changes["urgency"] not in cnf.ValueList("Urgency::Valid"):
1617                 self.warnings.append("%s is not a valid urgency; it will be treated as %s by testing." % \
1618                                      (self.pkg.changes["urgency"], cnf["Urgency::Default"]))
1619                 self.pkg.changes["urgency"] = cnf["Urgency::Default"]
1620
1621     ###########################################################################
1622
1623     # Sanity check the time stamps of files inside debs.
1624     # [Files in the near future cause ugly warnings and extreme time
1625     #  travel can cause errors on extraction]
1626
1627     def check_timestamps(self):
1628         Cnf = Config()
1629
1630         future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"])
1631         past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"))
1632         tar = TarTime(future_cutoff, past_cutoff)
1633
1634         for filename, entry in self.pkg.files.items():
1635             if entry["type"] == "deb":
1636                 tar.reset()
1637                 try:
1638                     deb = apt_inst.DebFile(filename)
1639                     deb.control.go(tar.callback)
1640
1641                     future_files = tar.future_files.keys()
1642                     if future_files:
1643                         num_future_files = len(future_files)
1644                         future_file = future_files[0]
1645                         future_date = tar.future_files[future_file]
1646                         self.rejects.append("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
1647                                % (filename, num_future_files, future_file, time.ctime(future_date)))
1648
1649                     ancient_files = tar.ancient_files.keys()
1650                     if ancient_files:
1651                         num_ancient_files = len(ancient_files)
1652                         ancient_file = ancient_files[0]
1653                         ancient_date = tar.ancient_files[ancient_file]
1654                         self.rejects.append("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
1655                                % (filename, num_ancient_files, ancient_file, time.ctime(ancient_date)))
1656                 except:
1657                     self.rejects.append("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value))
1658
1659     def check_if_upload_is_sponsored(self, uid_email, uid_name):
1660         uid_email = '@'.join(uid_email.split('@')[:2])
1661         if uid_email in [self.pkg.changes["maintaineremail"], self.pkg.changes["changedbyemail"]]:
1662             sponsored = False
1663         elif uid_name in [self.pkg.changes["maintainername"], self.pkg.changes["changedbyname"]]:
1664             sponsored = False
1665             if uid_name == "":
1666                 sponsored = True
1667         else:
1668             sponsored = True
1669             if ("source" in self.pkg.changes["architecture"] and uid_email and utils.is_email_alias(uid_email)):
1670                 sponsor_addresses = utils.gpg_get_key_addresses(self.pkg.changes["fingerprint"])
1671                 if (self.pkg.changes["maintaineremail"] not in sponsor_addresses and
1672                     self.pkg.changes["changedbyemail"] not in sponsor_addresses):
1673                         self.pkg.changes["sponsoremail"] = uid_email
1674
1675         return sponsored
1676
1677
1678     ###########################################################################
1679     # check_signed_by_key checks
1680     ###########################################################################
1681
1682     def check_signed_by_key(self):
1683         """Ensure the .changes is signed by an authorized uploader."""
1684         session = DBConn().session()
1685
1686         # First of all we check that the person has proper upload permissions
1687         # and that this upload isn't blocked
1688         fpr = get_fingerprint(self.pkg.changes['fingerprint'], session=session)
1689
1690         if fpr is None:
1691             self.rejects.append("Cannot find fingerprint %s" % self.pkg.changes["fingerprint"])
1692             return
1693
1694         # TODO: Check that import-keyring adds UIDs properly
1695         if not fpr.uid:
1696             self.rejects.append("Cannot find uid for fingerprint %s.  Please contact ftpmaster@debian.org" % fpr.fingerprint)
1697             return
1698
1699         # Check that the fingerprint which uploaded has permission to do so
1700         self.check_upload_permissions(fpr, session)
1701
1702         # Check that this package is not in a transition
1703         self.check_transition(session)
1704
1705         session.close()
1706
1707
1708     def check_upload_permissions(self, fpr, session):
1709         # Check any one-off upload blocks
1710         self.check_upload_blocks(fpr, session)
1711
1712         # If the source_acl is None, source is never allowed
1713         if fpr.source_acl is None:
1714             if self.pkg.changes["architecture"].has_key("source"):
1715                 rej = 'Fingerprint %s may not upload source' % fpr.fingerprint
1716                 rej += '\nPlease contact ftpmaster if you think this is incorrect'
1717                 self.rejects.append(rej)
1718                 return
1719         # Do DM as a special case
1720         # DM is a special case unfortunately, so we check it first
1721         # (keys with no source access get more access than DMs in one
1722         #  way; DMs can only upload for their packages whether source
1723         #  or binary, whereas keys with no access might be able to
1724         #  upload some binaries)
1725         elif fpr.source_acl.access_level == 'dm':
1726             self.check_dm_upload(fpr, session)
1727         else:
1728             # If not a DM, we allow full upload rights
1729             uid_email = "%s@debian.org" % (fpr.uid.uid)
1730             self.check_if_upload_is_sponsored(uid_email, fpr.uid.name)
1731
1732
1733         # Check binary upload permissions
1734         # By this point we know that DMs can't have got here unless they
1735         # are allowed to deal with the package concerned so just apply
1736         # normal checks
1737         if fpr.binary_acl.access_level == 'full':
1738             return
1739
1740         # Otherwise we're in the map case
1741         tmparches = self.pkg.changes["architecture"].copy()
1742         tmparches.pop('source', None)
1743
1744         for bam in fpr.binary_acl_map:
1745             tmparches.pop(bam.architecture.arch_string, None)
1746
1747         if len(tmparches.keys()) > 0:
1748             if fpr.binary_reject:
1749                 rej = "changes file contains files of architectures not permitted for fingerprint %s" % fpr.fingerprint
1750                 if len(tmparches.keys()) == 1:
1751                     rej += "\n\narchitecture involved is: %s" % ",".join(tmparches.keys())
1752                 else:
1753                     rej += "\n\narchitectures involved are: %s" % ",".join(tmparches.keys())
1754                 self.rejects.append(rej)
1755             else:
1756                 # TODO: This is where we'll implement reject vs throw away binaries later
1757                 rej = "Uhm.  I'm meant to throw away the binaries now but that's not implemented yet"
1758                 rej += "\nPlease complain to ftpmaster@debian.org as this shouldn't have been turned on"
1759                 rej += "\nFingerprint: %s", (fpr.fingerprint)
1760                 self.rejects.append(rej)
1761
1762
1763     def check_upload_blocks(self, fpr, session):
1764         """Check whether any upload blocks apply to this source, source
1765            version, uid / fpr combination"""
1766
1767         def block_rej_template(fb):
1768             rej = 'Manual upload block in place for package %s' % fb.source
1769             if fb.version is not None:
1770                 rej += ', version %s' % fb.version
1771             return rej
1772
1773         for fb in session.query(UploadBlock).filter_by(source = self.pkg.changes['source']).all():
1774             # version is None if the block applies to all versions
1775             if fb.version is None or fb.version == self.pkg.changes['version']:
1776                 # Check both fpr and uid - either is enough to cause a reject
1777                 if fb.fpr is not None:
1778                     if fb.fpr.fingerprint == fpr.fingerprint:
1779                         self.rejects.append(block_rej_template(fb) + ' for fingerprint %s\nReason: %s' % (fpr.fingerprint, fb.reason))
1780                 if fb.uid is not None:
1781                     if fb.uid == fpr.uid:
1782                         self.rejects.append(block_rej_template(fb) + ' for uid %s\nReason: %s' % (fb.uid.uid, fb.reason))
1783
1784
1785     def check_dm_upload(self, fpr, session):
1786         # Quoth the GR (http://www.debian.org/vote/2007/vote_003):
1787         ## none of the uploaded packages are NEW
1788         rej = False
1789         for f in self.pkg.files.keys():
1790             if self.pkg.files[f].has_key("byhand"):
1791                 self.rejects.append("%s may not upload BYHAND file %s" % (fpr.uid.uid, f))
1792                 rej = True
1793             if self.pkg.files[f].has_key("new"):
1794                 self.rejects.append("%s may not upload NEW file %s" % (fpr.uid.uid, f))
1795                 rej = True
1796
1797         if rej:
1798             return
1799
1800         r = get_newest_source(self.pkg.changes["source"], session)
1801
1802         if r is None:
1803             rej = "Could not find existing source package %s in unstable or experimental and this is a DM upload" % self.pkg.changes["source"]
1804             self.rejects.append(rej)
1805             return
1806
1807         if not r.dm_upload_allowed:
1808             rej = "Source package %s does not have 'DM-Upload-Allowed: yes' in its most recent version (%s)" % (self.pkg.changes["source"], r.version)
1809             self.rejects.append(rej)
1810             return
1811
1812         ## the Maintainer: field of the uploaded .changes file corresponds with
1813         ## the owner of the key used (ie, non-developer maintainers may not sponsor
1814         ## uploads)
1815         if self.check_if_upload_is_sponsored(fpr.uid.uid, fpr.uid.name):
1816             self.rejects.append("%s (%s) is not authorised to sponsor uploads" % (fpr.uid.uid, fpr.fingerprint))
1817
1818         ## the most recent version of the package uploaded to unstable or
1819         ## experimental lists the uploader in the Maintainer: or Uploaders: fields (ie,
1820         ## non-developer maintainers cannot NMU or hijack packages)
1821
1822         # uploader includes the maintainer
1823         accept = False
1824         for uploader in r.uploaders:
1825             (rfc822, rfc2047, name, email) = uploader.get_split_maintainer()
1826             # Eww - I hope we never have two people with the same name in Debian
1827             if email == fpr.uid.uid or name == fpr.uid.name:
1828                 accept = True
1829                 break
1830
1831         if not accept:
1832             self.rejects.append("%s is not in Maintainer or Uploaders of source package %s" % (fpr.uid.uid, self.pkg.changes["source"]))
1833             return
1834
1835         ## none of the packages are being taken over from other source packages
1836         for b in self.pkg.changes["binary"].keys():
1837             for suite in self.pkg.changes["distribution"].keys():
1838                 for s in get_source_by_package_and_suite(b, suite, session):
1839                     if s.source != self.pkg.changes["source"]:
1840                         self.rejects.append("%s may not hijack %s from source package %s in suite %s" % (fpr.uid.uid, b, s, suite))
1841
1842
1843
1844     def check_transition(self, session):
1845         cnf = Config()
1846
1847         sourcepkg = self.pkg.changes["source"]
1848
1849         # No sourceful upload -> no need to do anything else, direct return
1850         # We also work with unstable uploads, not experimental or those going to some
1851         # proposed-updates queue
1852         if "source" not in self.pkg.changes["architecture"] or \
1853            "unstable" not in self.pkg.changes["distribution"]:
1854             return
1855
1856         # Also only check if there is a file defined (and existant) with
1857         # checks.
1858         transpath = cnf.get("Dinstall::ReleaseTransitions", "")
1859         if transpath == "" or not os.path.exists(transpath):
1860             return
1861
1862         # Parse the yaml file
1863         sourcefile = file(transpath, 'r')
1864         sourcecontent = sourcefile.read()
1865         try:
1866             transitions = yaml.load(sourcecontent)
1867         except yaml.YAMLError, msg:
1868             # This shouldn't happen, there is a wrapper to edit the file which
1869             # checks it, but we prefer to be safe than ending up rejecting
1870             # everything.
1871             utils.warn("Not checking transitions, the transitions file is broken: %s." % (msg))
1872             return
1873
1874         # Now look through all defined transitions
1875         for trans in transitions:
1876             t = transitions[trans]
1877             source = t["source"]
1878             expected = t["new"]
1879
1880             # Will be None if nothing is in testing.
1881             current = get_source_in_suite(source, "testing", session)
1882             if current is not None:
1883                 compare = apt_pkg.VersionCompare(current.version, expected)
1884
1885             if current is None or compare < 0:
1886                 # This is still valid, the current version in testing is older than
1887                 # the new version we wait for, or there is none in testing yet
1888
1889                 # Check if the source we look at is affected by this.
1890                 if sourcepkg in t['packages']:
1891                     # The source is affected, lets reject it.
1892
1893                     rejectmsg = "%s: part of the %s transition.\n\n" % (
1894                         sourcepkg, trans)
1895
1896                     if current is not None:
1897                         currentlymsg = "at version %s" % (current.version)
1898                     else:
1899                         currentlymsg = "not present in testing"
1900
1901                     rejectmsg += "Transition description: %s\n\n" % (t["reason"])
1902
1903                     rejectmsg += "\n".join(textwrap.wrap("""Your package
1904 is part of a testing transition designed to get %s migrated (it is
1905 currently %s, we need version %s).  This transition is managed by the
1906 Release Team, and %s is the Release-Team member responsible for it.
1907 Please mail debian-release@lists.debian.org or contact %s directly if you
1908 need further assistance.  You might want to upload to experimental until this
1909 transition is done."""
1910                             % (source, currentlymsg, expected,t["rm"], t["rm"])))
1911
1912                     self.rejects.append(rejectmsg)
1913                     return
1914
1915     ###########################################################################
1916     # End check_signed_by_key checks
1917     ###########################################################################
1918
1919     def build_summaries(self):
1920         """ Build a summary of changes the upload introduces. """
1921
1922         (byhand, new, summary, override_summary) = self.pkg.file_summary()
1923
1924         short_summary = summary
1925
1926         # This is for direport's benefit...
1927         f = re_fdnic.sub("\n .\n", self.pkg.changes.get("changes", ""))
1928
1929         if byhand or new:
1930             summary += "Changes: " + f
1931
1932         summary += "\n\nOverride entries for your package:\n" + override_summary + "\n"
1933
1934         summary += self.announce(short_summary, 0)
1935
1936         return (summary, short_summary)
1937
1938     ###########################################################################
1939
1940     def close_bugs(self, summary, action):
1941         """
1942         Send mail to close bugs as instructed by the closes field in the changes file.
1943         Also add a line to summary if any work was done.
1944
1945         @type summary: string
1946         @param summary: summary text, as given by L{build_summaries}
1947
1948         @type action: bool
1949         @param action: Set to false no real action will be done.
1950
1951         @rtype: string
1952         @return: summary. If action was taken, extended by the list of closed bugs.
1953
1954         """
1955
1956         template = os.path.join(Config()["Dir::Templates"], 'process-unchecked.bug-close')
1957
1958         bugs = self.pkg.changes["closes"].keys()
1959
1960         if not bugs:
1961             return summary
1962
1963         bugs.sort()
1964         summary += "Closing bugs: "
1965         for bug in bugs:
1966             summary += "%s " % (bug)
1967             if action:
1968                 self.update_subst()
1969                 self.Subst["__BUG_NUMBER__"] = bug
1970                 if self.pkg.changes["distribution"].has_key("stable"):
1971                     self.Subst["__STABLE_WARNING__"] = """
1972 Note that this package is not part of the released stable Debian
1973 distribution.  It may have dependencies on other unreleased software,
1974 or other instabilities.  Please take care if you wish to install it.
1975 The update will eventually make its way into the next released Debian
1976 distribution."""
1977                 else:
1978                     self.Subst["__STABLE_WARNING__"] = ""
1979                 mail_message = utils.TemplateSubst(self.Subst, template)
1980                 utils.send_mail(mail_message)
1981
1982                 # Clear up after ourselves
1983                 del self.Subst["__BUG_NUMBER__"]
1984                 del self.Subst["__STABLE_WARNING__"]
1985
1986         if action and self.logger:
1987             self.logger.log(["closing bugs"] + bugs)
1988
1989         summary += "\n"
1990
1991         return summary
1992
1993     ###########################################################################
1994
1995     def announce(self, short_summary, action):
1996         """
1997         Send an announce mail about a new upload.
1998
1999         @type short_summary: string
2000         @param short_summary: Short summary text to include in the mail
2001
2002         @type action: bool
2003         @param action: Set to false no real action will be done.
2004
2005         @rtype: string
2006         @return: Textstring about action taken.
2007
2008         """
2009
2010         cnf = Config()
2011
2012         # Skip all of this if not sending mail to avoid confusing people
2013         if cnf.has_key("Dinstall::Options::No-Mail") and cnf["Dinstall::Options::No-Mail"]:
2014             return ""
2015
2016         # Only do announcements for source uploads with a recent dpkg-dev installed
2017         if float(self.pkg.changes.get("format", 0)) < 1.6 or not \
2018            self.pkg.changes["architecture"].has_key("source"):
2019             return ""
2020
2021         announcetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.announce')
2022
2023         lists_todo = {}
2024         summary = ""
2025
2026         # Get a unique list of target lists
2027         for dist in self.pkg.changes["distribution"].keys():
2028             suite = get_suite(dist)
2029             if suite is None: continue
2030             for tgt in suite.announce:
2031                 lists_todo[tgt] = 1
2032
2033         self.Subst["__SHORT_SUMMARY__"] = short_summary
2034
2035         for announce_list in lists_todo.keys():
2036             summary += "Announcing to %s\n" % (announce_list)
2037
2038             if action:
2039                 self.update_subst()
2040                 self.Subst["__ANNOUNCE_LIST_ADDRESS__"] = announce_list
2041                 if cnf.get("Dinstall::TrackingServer") and \
2042                    self.pkg.changes["architecture"].has_key("source"):
2043                     trackingsendto = "Bcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
2044                     self.Subst["__ANNOUNCE_LIST_ADDRESS__"] += "\n" + trackingsendto
2045
2046                 mail_message = utils.TemplateSubst(self.Subst, announcetemplate)
2047                 utils.send_mail(mail_message)
2048
2049                 del self.Subst["__ANNOUNCE_LIST_ADDRESS__"]
2050
2051         if cnf.FindB("Dinstall::CloseBugs") and cnf.has_key("Dinstall::BugServer"):
2052             summary = self.close_bugs(summary, action)
2053
2054         del self.Subst["__SHORT_SUMMARY__"]
2055
2056         return summary
2057
2058     ###########################################################################
2059     @session_wrapper
2060     def accept (self, summary, short_summary, session=None):
2061         """
2062         Accept an upload.
2063
2064         This moves all files referenced from the .changes into the pool,
2065         sends the accepted mail, announces to lists, closes bugs and
2066         also checks for override disparities. If enabled it will write out
2067         the version history for the BTS Version Tracking and will finally call
2068         L{queue_build}.
2069
2070         @type summary: string
2071         @param summary: Summary text
2072
2073         @type short_summary: string
2074         @param short_summary: Short summary
2075         """
2076
2077         cnf = Config()
2078         stats = SummaryStats()
2079
2080         print "Installing."
2081         self.logger.log(["installing changes", self.pkg.changes_file])
2082
2083         binaries = []
2084         poolfiles = []
2085
2086         # Add the .dsc file to the DB first
2087         for newfile, entry in self.pkg.files.items():
2088             if entry["type"] == "dsc":
2089                 source, dsc_component, dsc_location_id, pfs = add_dsc_to_db(self, newfile, session)
2090                 for j in pfs:
2091                     poolfiles.append(j)
2092
2093         # Add .deb / .udeb files to the DB (type is always deb, dbtype is udeb/deb)
2094         for newfile, entry in self.pkg.files.items():
2095             if entry["type"] == "deb":
2096                 b, pf = add_deb_to_db(self, newfile, session)
2097                 binaries.append(b)
2098                 poolfiles.append(pf)
2099
2100         # If this is a sourceful diff only upload that is moving
2101         # cross-component we need to copy the .orig files into the new
2102         # component too for the same reasons as above.
2103         # XXX: mhy: I think this should be in add_dsc_to_db
2104         if self.pkg.changes["architecture"].has_key("source"):
2105             for orig_file in self.pkg.orig_files.keys():
2106                 if not self.pkg.orig_files[orig_file].has_key("id"):
2107                     continue # Skip if it's not in the pool
2108                 orig_file_id = self.pkg.orig_files[orig_file]["id"]
2109                 if self.pkg.orig_files[orig_file]["location"] == dsc_location_id:
2110                     continue # Skip if the location didn't change
2111
2112                 # Do the move
2113                 oldf = get_poolfile_by_id(orig_file_id, session)
2114                 old_filename = os.path.join(oldf.location.path, oldf.filename)
2115                 old_dat = {'size': oldf.filesize,   'md5sum': oldf.md5sum,
2116                            'sha1sum': oldf.sha1sum, 'sha256sum': oldf.sha256sum}
2117
2118                 new_filename = os.path.join(utils.poolify(self.pkg.changes["source"], dsc_component), os.path.basename(old_filename))
2119
2120                 # TODO: Care about size/md5sum collisions etc
2121                 (found, newf) = check_poolfile(new_filename, old_dat['size'], old_dat['md5sum'], dsc_location_id, session)
2122
2123                 # TODO: Uhm, what happens if newf isn't None - something has gone badly and we should cope
2124                 if newf is None:
2125                     utils.copy(old_filename, os.path.join(cnf["Dir::Pool"], new_filename))
2126                     newf = add_poolfile(new_filename, old_dat, dsc_location_id, session)
2127
2128                     session.flush()
2129
2130                     # Don't reference the old file from this changes
2131                     for p in poolfiles:
2132                         if p.file_id == oldf.file_id:
2133                             poolfiles.remove(p)
2134
2135                     poolfiles.append(newf)
2136
2137                     # Fix up the DSC references
2138                     toremove = []
2139
2140                     for df in source.srcfiles:
2141                         if df.poolfile.file_id == oldf.file_id:
2142                             # Add a new DSC entry and mark the old one for deletion
2143                             # Don't do it in the loop so we don't change the thing we're iterating over
2144                             newdscf = DSCFile()
2145                             newdscf.source_id = source.source_id
2146                             newdscf.poolfile_id = newf.file_id
2147                             session.add(newdscf)
2148
2149                             toremove.append(df)
2150
2151                     for df in toremove:
2152                         session.delete(df)
2153
2154                     # Flush our changes
2155                     session.flush()
2156
2157                     # Make sure that our source object is up-to-date
2158                     session.expire(source)
2159
2160         # Add changelog information to the database
2161         self.store_changelog()
2162
2163         # Install the files into the pool
2164         for newfile, entry in self.pkg.files.items():
2165             destination = os.path.join(cnf["Dir::Pool"], entry["pool name"], newfile)
2166             utils.move(newfile, destination)
2167             self.logger.log(["installed", newfile, entry["type"], entry["size"], entry["architecture"]])
2168             stats.accept_bytes += float(entry["size"])
2169
2170         # Copy the .changes file across for suite which need it.
2171         copy_changes = dict([(x.copychanges, '')
2172                              for x in session.query(Suite).filter(Suite.suite_name.in_(self.pkg.changes["distribution"].keys())).all()
2173                              if x.copychanges is not None])
2174
2175         for dest in copy_changes.keys():
2176             utils.copy(self.pkg.changes_file, os.path.join(cnf["Dir::Root"], dest))
2177
2178         # We're done - commit the database changes
2179         session.commit()
2180         # Our SQL session will automatically start a new transaction after
2181         # the last commit
2182
2183         # Now ensure that the metadata has been added
2184         # This has to be done after we copy the files into the pool
2185         # For source if we have it:
2186         if self.pkg.changes["architecture"].has_key("source"):
2187             import_metadata_into_db(source, session)
2188
2189         # Now for any of our binaries
2190         for b in binaries:
2191             import_metadata_into_db(b, session)
2192
2193         session.commit()
2194
2195         # Move the .changes into the 'done' directory
2196         ye, mo, da = time.gmtime()[0:3]
2197         donedir = os.path.join(cnf["Dir::Done"], str(ye), "%0.2d" % mo, "%0.2d" % da)
2198         if not os.path.isdir(donedir):
2199             os.makedirs(donedir)
2200
2201         utils.move(self.pkg.changes_file,
2202                    os.path.join(donedir, os.path.basename(self.pkg.changes_file)))
2203
2204         if self.pkg.changes["architecture"].has_key("source"):
2205             UrgencyLog().log(self.pkg.dsc["source"], self.pkg.dsc["version"], self.pkg.changes["urgency"])
2206
2207         self.update_subst()
2208         self.Subst["__SUMMARY__"] = summary
2209         mail_message = utils.TemplateSubst(self.Subst,
2210                                            os.path.join(cnf["Dir::Templates"], 'process-unchecked.accepted'))
2211         utils.send_mail(mail_message)
2212         self.announce(short_summary, 1)
2213
2214         ## Helper stuff for DebBugs Version Tracking
2215         if cnf.Find("Dir::BTSVersionTrack"):
2216             if self.pkg.changes["architecture"].has_key("source"):
2217                 (fd, temp_filename) = utils.temp_filename(cnf["Dir::BTSVersionTrack"], prefix=".")
2218                 version_history = os.fdopen(fd, 'w')
2219                 version_history.write(self.pkg.dsc["bts changelog"])
2220                 version_history.close()
2221                 filename = "%s/%s" % (cnf["Dir::BTSVersionTrack"],
2222                                       self.pkg.changes_file[:-8]+".versions")
2223                 os.rename(temp_filename, filename)
2224                 os.chmod(filename, 0644)
2225
2226             # Write out the binary -> source mapping.
2227             (fd, temp_filename) = utils.temp_filename(cnf["Dir::BTSVersionTrack"], prefix=".")
2228             debinfo = os.fdopen(fd, 'w')
2229             for name, entry in sorted(self.pkg.files.items()):
2230                 if entry["type"] == "deb":
2231                     line = " ".join([entry["package"], entry["version"],
2232                                      entry["architecture"], entry["source package"],
2233                                      entry["source version"]])
2234                     debinfo.write(line+"\n")
2235             debinfo.close()
2236             filename = "%s/%s" % (cnf["Dir::BTSVersionTrack"],
2237                                   self.pkg.changes_file[:-8]+".debinfo")
2238             os.rename(temp_filename, filename)
2239             os.chmod(filename, 0644)
2240
2241         session.commit()
2242
2243         # Set up our copy queues (e.g. buildd queues)
2244         for suite_name in self.pkg.changes["distribution"].keys():
2245             suite = get_suite(suite_name, session)
2246             for q in suite.copy_queues:
2247                 for f in poolfiles:
2248                     q.add_file_from_pool(f)
2249
2250         session.commit()
2251
2252         # Finally...
2253         stats.accept_count += 1
2254
2255     def check_override(self):
2256         """
2257         Checks override entries for validity. Mails "Override disparity" warnings,
2258         if that feature is enabled.
2259
2260         Abandons the check if
2261           - override disparity checks are disabled
2262           - mail sending is disabled
2263         """
2264
2265         cnf = Config()
2266
2267         # Abandon the check if override disparity checks have been disabled
2268         if not cnf.FindB("Dinstall::OverrideDisparityCheck"):
2269             return
2270
2271         summary = self.pkg.check_override()
2272
2273         if summary == "":
2274             return
2275
2276         overridetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.override-disparity')
2277
2278         self.update_subst()
2279         self.Subst["__SUMMARY__"] = summary
2280         mail_message = utils.TemplateSubst(self.Subst, overridetemplate)
2281         utils.send_mail(mail_message)
2282         del self.Subst["__SUMMARY__"]
2283
2284     ###########################################################################
2285
2286     def remove(self, from_dir=None):
2287         """
2288         Used (for instance) in p-u to remove the package from unchecked
2289
2290         Also removes the package from holding area.
2291         """
2292         if from_dir is None:
2293             from_dir = self.pkg.directory
2294         h = Holding()
2295
2296         for f in self.pkg.files.keys():
2297             os.unlink(os.path.join(from_dir, f))
2298             if os.path.exists(os.path.join(h.holding_dir, f)):
2299                 os.unlink(os.path.join(h.holding_dir, f))
2300
2301         os.unlink(os.path.join(from_dir, self.pkg.changes_file))
2302         if os.path.exists(os.path.join(h.holding_dir, self.pkg.changes_file)):
2303             os.unlink(os.path.join(h.holding_dir, self.pkg.changes_file))
2304
2305     ###########################################################################
2306
2307     def move_to_queue (self, queue):
2308         """
2309         Move files to a destination queue using the permissions in the table
2310         """
2311         h = Holding()
2312         utils.move(os.path.join(h.holding_dir, self.pkg.changes_file),
2313                    queue.path, perms=int(queue.change_perms, 8))
2314         for f in self.pkg.files.keys():
2315             utils.move(os.path.join(h.holding_dir, f), queue.path, perms=int(queue.perms, 8))
2316
2317     ###########################################################################
2318
2319     def force_reject(self, reject_files):
2320         """
2321         Forcefully move files from the current directory to the
2322         reject directory.  If any file already exists in the reject
2323         directory it will be moved to the morgue to make way for
2324         the new file.
2325
2326         @type reject_files: dict
2327         @param reject_files: file dictionary
2328
2329         """
2330
2331         cnf = Config()
2332
2333         for file_entry in reject_files:
2334             # Skip any files which don't exist or which we don't have permission to copy.
2335             if os.access(file_entry, os.R_OK) == 0:
2336                 continue
2337
2338             dest_file = os.path.join(cnf["Dir::Reject"], file_entry)
2339
2340             try:
2341                 dest_fd = os.open(dest_file, os.O_RDWR | os.O_CREAT | os.O_EXCL, 0644)
2342             except OSError, e:
2343                 # File exists?  Let's find a new name by adding a number
2344                 if e.errno == errno.EEXIST:
2345                     try:
2346                         dest_file = utils.find_next_free(dest_file, 255)
2347                     except NoFreeFilenameError:
2348                         # Something's either gone badly Pete Tong, or
2349                         # someone is trying to exploit us.
2350                         utils.warn("**WARNING** failed to find a free filename for %s in %s." % (file_entry, cnf["Dir::Reject"]))
2351                         return
2352
2353                     # Make sure we really got it
2354                     try:
2355                         dest_fd = os.open(dest_file, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
2356                     except OSError, e:
2357                         # Likewise
2358                         utils.warn("**WARNING** failed to claim %s in the reject directory." % (file_entry))
2359                         return
2360                 else:
2361                     raise
2362             # If we got here, we own the destination file, so we can
2363             # safely overwrite it.
2364             utils.move(file_entry, dest_file, 1, perms=0660)
2365             os.close(dest_fd)
2366
2367     ###########################################################################
2368     def do_reject (self, manual=0, reject_message="", notes=""):
2369         """
2370         Reject an upload. If called without a reject message or C{manual} is
2371         true, spawn an editor so the user can write one.
2372
2373         @type manual: bool
2374         @param manual: manual or automated rejection
2375
2376         @type reject_message: string
2377         @param reject_message: A reject message
2378
2379         @return: 0
2380
2381         """
2382         # If we weren't given a manual rejection message, spawn an
2383         # editor so the user can add one in...
2384         if manual and not reject_message:
2385             (fd, temp_filename) = utils.temp_filename()
2386             temp_file = os.fdopen(fd, 'w')
2387             if len(notes) > 0:
2388                 for note in notes:
2389                     temp_file.write("\nAuthor: %s\nVersion: %s\nTimestamp: %s\n\n%s" \
2390                                     % (note.author, note.version, note.notedate, note.comment))
2391             temp_file.close()
2392             editor = os.environ.get("EDITOR","vi")
2393             answer = 'E'
2394             while answer == 'E':
2395                 os.system("%s %s" % (editor, temp_filename))
2396                 temp_fh = utils.open_file(temp_filename)
2397                 reject_message = "".join(temp_fh.readlines())
2398                 temp_fh.close()
2399                 print "Reject message:"
2400                 print utils.prefix_multi_line_string(reject_message,"  ",include_blank_lines=1)
2401                 prompt = "[R]eject, Edit, Abandon, Quit ?"
2402                 answer = "XXX"
2403                 while prompt.find(answer) == -1:
2404                     answer = utils.our_raw_input(prompt)
2405                     m = re_default_answer.search(prompt)
2406                     if answer == "":
2407                         answer = m.group(1)
2408                     answer = answer[:1].upper()
2409             os.unlink(temp_filename)
2410             if answer == 'A':
2411                 return 1
2412             elif answer == 'Q':
2413                 sys.exit(0)
2414
2415         print "Rejecting.\n"
2416
2417         cnf = Config()
2418
2419         reason_filename = self.pkg.changes_file[:-8] + ".reason"
2420         reason_filename = os.path.join(cnf["Dir::Reject"], reason_filename)
2421
2422         # Move all the files into the reject directory
2423         reject_files = self.pkg.files.keys() + [self.pkg.changes_file]
2424         self.force_reject(reject_files)
2425
2426         # If we fail here someone is probably trying to exploit the race
2427         # so let's just raise an exception ...
2428         if os.path.exists(reason_filename):
2429             os.unlink(reason_filename)
2430         reason_fd = os.open(reason_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
2431
2432         rej_template = os.path.join(cnf["Dir::Templates"], "queue.rejected")
2433
2434         self.update_subst()
2435         if not manual:
2436             self.Subst["__REJECTOR_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
2437             self.Subst["__MANUAL_REJECT_MESSAGE__"] = ""
2438             self.Subst["__CC__"] = "X-DAK-Rejection: automatic (moo)"
2439             os.write(reason_fd, reject_message)
2440             reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
2441         else:
2442             # Build up the rejection email
2443             user_email_address = utils.whoami() + " <%s>" % (cnf["Dinstall::MyAdminAddress"])
2444             self.Subst["__REJECTOR_ADDRESS__"] = user_email_address
2445             self.Subst["__MANUAL_REJECT_MESSAGE__"] = reject_message
2446             self.Subst["__REJECT_MESSAGE__"] = ""
2447             self.Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
2448             reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
2449             # Write the rejection email out as the <foo>.reason file
2450             os.write(reason_fd, reject_mail_message)
2451
2452         del self.Subst["__REJECTOR_ADDRESS__"]
2453         del self.Subst["__MANUAL_REJECT_MESSAGE__"]
2454         del self.Subst["__CC__"]
2455
2456         os.close(reason_fd)
2457
2458         # Send the rejection mail
2459         utils.send_mail(reject_mail_message)
2460
2461         if self.logger:
2462             self.logger.log(["rejected", self.pkg.changes_file])
2463
2464         stats = SummaryStats()
2465         stats.reject_count += 1
2466         return 0
2467
2468     ################################################################################
2469     def in_override_p(self, package, component, suite, binary_type, filename, session):
2470         """
2471         Check if a package already has override entries in the DB
2472
2473         @type package: string
2474         @param package: package name
2475
2476         @type component: string
2477         @param component: database id of the component
2478
2479         @type suite: int
2480         @param suite: database id of the suite
2481
2482         @type binary_type: string
2483         @param binary_type: type of the package
2484
2485         @type filename: string
2486         @param filename: filename we check
2487
2488         @return: the database result. But noone cares anyway.
2489
2490         """
2491
2492         cnf = Config()
2493
2494         if binary_type == "": # must be source
2495             file_type = "dsc"
2496         else:
2497             file_type = binary_type
2498
2499         # Override suite name; used for example with proposed-updates
2500         oldsuite = get_suite(suite, session)
2501         if (not oldsuite is None) and oldsuite.overridesuite:
2502             suite = oldsuite.overridesuite
2503
2504         result = get_override(package, suite, component, file_type, session)
2505
2506         # If checking for a source package fall back on the binary override type
2507         if file_type == "dsc" and len(result) < 1:
2508             result = get_override(package, suite, component, ['deb', 'udeb'], session)
2509
2510         # Remember the section and priority so we can check them later if appropriate
2511         if len(result) > 0:
2512             result = result[0]
2513             self.pkg.files[filename]["override section"] = result.section.section
2514             self.pkg.files[filename]["override priority"] = result.priority.priority
2515             return result
2516
2517         return None
2518
2519     ################################################################################
2520     def get_anyversion(self, sv_list, suite):
2521         """
2522         @type sv_list: list
2523         @param sv_list: list of (suite, version) tuples to check
2524
2525         @type suite: string
2526         @param suite: suite name
2527
2528         Description: TODO
2529         """
2530         Cnf = Config()
2531         anyversion = None
2532         anysuite = [suite] + [ vc.reference.suite_name for vc in get_version_checks(suite, "Enhances") ]
2533         for (s, v) in sv_list:
2534             if s in [ x.lower() for x in anysuite ]:
2535                 if not anyversion or apt_pkg.VersionCompare(anyversion, v) <= 0:
2536                     anyversion = v
2537
2538         return anyversion
2539
2540     ################################################################################
2541
2542     def cross_suite_version_check(self, sv_list, filename, new_version, sourceful=False):
2543         """
2544         @type sv_list: list
2545         @param sv_list: list of (suite, version) tuples to check
2546
2547         @type filename: string
2548         @param filename: XXX
2549
2550         @type new_version: string
2551         @param new_version: XXX
2552
2553         Ensure versions are newer than existing packages in target
2554         suites and that cross-suite version checking rules as
2555         set out in the conf file are satisfied.
2556         """
2557
2558         cnf = Config()
2559
2560         # Check versions for each target suite
2561         for target_suite in self.pkg.changes["distribution"].keys():
2562             # Check we can find the target suite
2563             ts = get_suite(target_suite)
2564             if ts is None:
2565                 self.rejects.append("Cannot find target suite %s to perform version checks" % target_suite)
2566                 continue
2567
2568             must_be_newer_than = [ vc.reference.suite_name for vc in get_version_checks(target_suite, "MustBeNewerThan") ]
2569             must_be_older_than = [ vc.reference.suite_name for vc in get_version_checks(target_suite, "MustBeOlderThan") ]
2570
2571             # Enforce "must be newer than target suite" even if conffile omits it
2572             if target_suite not in must_be_newer_than:
2573                 must_be_newer_than.append(target_suite)
2574
2575             for (suite, existent_version) in sv_list:
2576                 vercmp = apt_pkg.VersionCompare(new_version, existent_version)
2577
2578                 if suite in must_be_newer_than and sourceful and vercmp < 1:
2579                     self.rejects.append("%s: old version (%s) in %s >= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2580
2581                 if suite in must_be_older_than and vercmp > -1:
2582                     cansave = 0
2583
2584                     if self.pkg.changes.get('distribution-version', {}).has_key(suite):
2585                         # we really use the other suite, ignoring the conflicting one ...
2586                         addsuite = self.pkg.changes["distribution-version"][suite]
2587
2588                         add_version = self.get_anyversion(sv_list, addsuite)
2589                         target_version = self.get_anyversion(sv_list, target_suite)
2590
2591                         if not add_version:
2592                             # not add_version can only happen if we map to a suite
2593                             # that doesn't enhance the suite we're propup'ing from.
2594                             # so "propup-ver x a b c; map a d" is a problem only if
2595                             # d doesn't enhance a.
2596                             #
2597                             # i think we could always propagate in this case, rather
2598                             # than complaining. either way, this isn't a REJECT issue
2599                             #
2600                             # And - we really should complain to the dorks who configured dak
2601                             self.warnings.append("%s is mapped to, but not enhanced by %s - adding anyways" % (suite, addsuite))
2602                             self.pkg.changes.setdefault("propdistribution", {})
2603                             self.pkg.changes["propdistribution"][addsuite] = 1
2604                             cansave = 1
2605                         elif not target_version:
2606                             # not targets_version is true when the package is NEW
2607                             # we could just stick with the "...old version..." REJECT
2608                             # for this, I think.
2609                             self.rejects.append("Won't propogate NEW packages.")
2610                         elif apt_pkg.VersionCompare(new_version, add_version) < 0:
2611                             # propogation would be redundant. no need to reject though.
2612                             self.warnings.append("ignoring versionconflict: %s: old version (%s) in %s <= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2613                             cansave = 1
2614                         elif apt_pkg.VersionCompare(new_version, add_version) > 0 and \
2615                              apt_pkg.VersionCompare(add_version, target_version) >= 0:
2616                             # propogate!!
2617                             self.warnings.append("Propogating upload to %s" % (addsuite))
2618                             self.pkg.changes.setdefault("propdistribution", {})
2619                             self.pkg.changes["propdistribution"][addsuite] = 1
2620                             cansave = 1
2621
2622                     if not cansave:
2623                         self.rejects.append("%s: old version (%s) in %s <= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2624
2625     ################################################################################
2626     def check_binary_against_db(self, filename, session):
2627         # Ensure version is sane
2628         self.cross_suite_version_check( \
2629             get_suite_version_by_package(self.pkg.files[filename]["package"], \
2630                 self.pkg.files[filename]["architecture"], session),
2631             filename, self.pkg.files[filename]["version"], sourceful=False)
2632
2633         # Check for any existing copies of the file
2634         q = session.query(DBBinary).filter_by(package=self.pkg.files[filename]["package"])
2635         q = q.filter_by(version=self.pkg.files[filename]["version"])
2636         q = q.join(Architecture).filter_by(arch_string=self.pkg.files[filename]["architecture"])
2637
2638         if q.count() > 0:
2639             self.rejects.append("%s: can not overwrite existing copy already in the archive." % filename)
2640
2641     ################################################################################
2642
2643     def check_source_against_db(self, filename, session):
2644         source = self.pkg.dsc.get("source")
2645         version = self.pkg.dsc.get("version")
2646
2647         # Ensure version is sane
2648         self.cross_suite_version_check( \
2649             get_suite_version_by_source(source, session), filename, version,
2650             sourceful=True)
2651
2652     ################################################################################
2653     def check_dsc_against_db(self, filename, session):
2654         """
2655
2656         @warning: NB: this function can remove entries from the 'files' index [if
2657          the orig tarball is a duplicate of the one in the archive]; if
2658          you're iterating over 'files' and call this function as part of
2659          the loop, be sure to add a check to the top of the loop to
2660          ensure you haven't just tried to dereference the deleted entry.
2661
2662         """
2663
2664         Cnf = Config()
2665         self.pkg.orig_files = {} # XXX: do we need to clear it?
2666         orig_files = self.pkg.orig_files
2667
2668         # Try and find all files mentioned in the .dsc.  This has
2669         # to work harder to cope with the multiple possible
2670         # locations of an .orig.tar.gz.
2671         # The ordering on the select is needed to pick the newest orig
2672         # when it exists in multiple places.
2673         for dsc_name, dsc_entry in self.pkg.dsc_files.items():
2674             found = None
2675             if self.pkg.files.has_key(dsc_name):
2676                 actual_md5 = self.pkg.files[dsc_name]["md5sum"]
2677                 actual_size = int(self.pkg.files[dsc_name]["size"])
2678                 found = "%s in incoming" % (dsc_name)
2679
2680                 # Check the file does not already exist in the archive
2681                 ql = get_poolfile_like_name(dsc_name, session)
2682
2683                 # Strip out anything that isn't '%s' or '/%s$'
2684                 for i in ql:
2685                     if not i.filename.endswith(dsc_name):
2686                         ql.remove(i)
2687
2688                 # "[dak] has not broken them.  [dak] has fixed a
2689                 # brokenness.  Your crappy hack exploited a bug in
2690                 # the old dinstall.
2691                 #
2692                 # "(Come on!  I thought it was always obvious that
2693                 # one just doesn't release different files with
2694                 # the same name and version.)"
2695                 #                        -- ajk@ on d-devel@l.d.o
2696
2697                 if len(ql) > 0:
2698                     # Ignore exact matches for .orig.tar.gz
2699                     match = 0
2700                     if re_is_orig_source.match(dsc_name):
2701                         for i in ql:
2702                             if self.pkg.files.has_key(dsc_name) and \
2703                                int(self.pkg.files[dsc_name]["size"]) == int(i.filesize) and \
2704                                self.pkg.files[dsc_name]["md5sum"] == i.md5sum:
2705                                 self.warnings.append("ignoring %s, since it's already in the archive." % (dsc_name))
2706                                 # TODO: Don't delete the entry, just mark it as not needed
2707                                 # This would fix the stupidity of changing something we often iterate over
2708                                 # whilst we're doing it
2709                                 del self.pkg.files[dsc_name]
2710                                 dsc_entry["files id"] = i.file_id
2711                                 if not orig_files.has_key(dsc_name):
2712                                     orig_files[dsc_name] = {}
2713                                 orig_files[dsc_name]["path"] = os.path.join(i.location.path, i.filename)
2714                                 match = 1
2715
2716                                 # Don't bitch that we couldn't find this file later
2717                                 try:
2718                                     self.later_check_files.remove(dsc_name)
2719                                 except ValueError:
2720                                     pass
2721
2722
2723                     if not match:
2724                         self.rejects.append("can not overwrite existing copy of '%s' already in the archive." % (dsc_name))
2725
2726             elif re_is_orig_source.match(dsc_name):
2727                 # Check in the pool
2728                 ql = get_poolfile_like_name(dsc_name, session)
2729
2730                 # Strip out anything that isn't '%s' or '/%s$'
2731                 # TODO: Shouldn't we just search for things which end with our string explicitly in the SQL?
2732                 for i in ql:
2733                     if not i.filename.endswith(dsc_name):
2734                         ql.remove(i)
2735
2736                 if len(ql) > 0:
2737                     # Unfortunately, we may get more than one match here if,
2738                     # for example, the package was in potato but had an -sa
2739                     # upload in woody.  So we need to choose the right one.
2740
2741                     # default to something sane in case we don't match any or have only one
2742                     x = ql[0]
2743
2744                     if len(ql) > 1:
2745                         for i in ql:
2746                             old_file = os.path.join(i.location.path, i.filename)
2747                             old_file_fh = utils.open_file(old_file)
2748                             actual_md5 = apt_pkg.md5sum(old_file_fh)
2749                             old_file_fh.close()
2750                             actual_size = os.stat(old_file)[stat.ST_SIZE]
2751                             if actual_md5 == dsc_entry["md5sum"] and actual_size == int(dsc_entry["size"]):
2752                                 x = i
2753
2754                     old_file = os.path.join(i.location.path, i.filename)
2755                     old_file_fh = utils.open_file(old_file)
2756                     actual_md5 = apt_pkg.md5sum(old_file_fh)
2757                     old_file_fh.close()
2758                     actual_size = os.stat(old_file)[stat.ST_SIZE]
2759                     found = old_file
2760                     suite_type = x.location.archive_type
2761                     # need this for updating dsc_files in install()
2762                     dsc_entry["files id"] = x.file_id
2763                     # See install() in process-accepted...
2764                     if not orig_files.has_key(dsc_name):
2765                         orig_files[dsc_name] = {}
2766                     orig_files[dsc_name]["id"] = x.file_id
2767                     orig_files[dsc_name]["path"] = old_file
2768                     orig_files[dsc_name]["location"] = x.location.location_id
2769                 else:
2770                     # TODO: Determine queue list dynamically
2771                     # Not there? Check the queue directories...
2772                     for queue_name in [ "byhand", "new", "proposedupdates", "oldproposedupdates", "embargoed", "unembargoed" ]:
2773                         queue = get_policy_queue(queue_name, session)
2774                         if not queue:
2775                             continue
2776
2777                         in_otherdir = os.path.join(queue.path, dsc_name)
2778
2779                         if os.path.exists(in_otherdir):
2780                             in_otherdir_fh = utils.open_file(in_otherdir)
2781                             actual_md5 = apt_pkg.md5sum(in_otherdir_fh)
2782                             in_otherdir_fh.close()
2783                             actual_size = os.stat(in_otherdir)[stat.ST_SIZE]
2784                             found = in_otherdir
2785                             if not orig_files.has_key(dsc_name):
2786                                 orig_files[dsc_name] = {}
2787                             orig_files[dsc_name]["path"] = in_otherdir
2788
2789                     if not found:
2790                         self.rejects.append("%s refers to %s, but I can't find it in the queue or in the pool." % (filename, dsc_name))
2791                         continue
2792             else:
2793                 self.rejects.append("%s refers to %s, but I can't find it in the queue." % (filename, dsc_name))
2794                 continue
2795             if actual_md5 != dsc_entry["md5sum"]:
2796                 self.rejects.append("md5sum for %s doesn't match %s." % (found, filename))
2797             if actual_size != int(dsc_entry["size"]):
2798                 self.rejects.append("size for %s doesn't match %s." % (found, filename))
2799
2800     ################################################################################
2801     # This is used by process-new and process-holding to recheck a changes file
2802     # at the time we're running.  It mainly wraps various other internal functions
2803     # and is similar to accepted_checks - these should probably be tidied up
2804     # and combined
2805     def recheck(self, session):
2806         cnf = Config()
2807         for f in self.pkg.files.keys():
2808             # The .orig.tar.gz can disappear out from under us is it's a
2809             # duplicate of one in the archive.
2810             if not self.pkg.files.has_key(f):
2811                 continue
2812
2813             entry = self.pkg.files[f]
2814
2815             # Check that the source still exists
2816             if entry["type"] == "deb":
2817                 source_version = entry["source version"]
2818                 source_package = entry["source package"]
2819                 if not self.pkg.changes["architecture"].has_key("source") \
2820                    and not source_exists(source_package, source_version, \
2821                     suites = self.pkg.changes["distribution"].keys(), session = session):
2822                     source_epochless_version = re_no_epoch.sub('', source_version)
2823                     dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
2824                     found = False
2825                     for queue_name in ["embargoed", "unembargoed", "newstage"]:
2826                         queue = get_policy_queue(queue_name, session)
2827                         if queue and os.path.exists(os.path.join(queue.path, dsc_filename)):
2828                             found = True
2829                     if not found:
2830                         self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))
2831
2832             # Version and file overwrite checks
2833             if entry["type"] == "deb":
2834                 self.check_binary_against_db(f, session)
2835             elif entry["type"] == "dsc":
2836                 self.check_source_against_db(f, session)
2837                 self.check_dsc_against_db(f, session)
2838
2839     ################################################################################
2840     def accepted_checks(self, overwrite_checks, session):
2841         # Recheck anything that relies on the database; since that's not
2842         # frozen between accept and our run time when called from p-a.
2843
2844         # overwrite_checks is set to False when installing to stable/oldstable
2845
2846         propogate={}
2847         nopropogate={}
2848
2849         # Find the .dsc (again)
2850         dsc_filename = None
2851         for f in self.pkg.files.keys():
2852             if self.pkg.files[f]["type"] == "dsc":
2853                 dsc_filename = f
2854
2855         for checkfile in self.pkg.files.keys():
2856             # The .orig.tar.gz can disappear out from under us is it's a
2857             # duplicate of one in the archive.
2858             if not self.pkg.files.has_key(checkfile):
2859                 continue
2860
2861             entry = self.pkg.files[checkfile]
2862
2863             # Check that the source still exists
2864             if entry["type"] == "deb":
2865                 source_version = entry["source version"]
2866                 source_package = entry["source package"]
2867                 if not self.pkg.changes["architecture"].has_key("source") \
2868                    and not source_exists(source_package, source_version, \
2869                     suites = self.pkg.changes["distribution"].keys(), \
2870                     session = session):
2871                     self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, checkfile))
2872
2873             # Version and file overwrite checks
2874             if overwrite_checks:
2875                 if entry["type"] == "deb":
2876                     self.check_binary_against_db(checkfile, session)
2877                 elif entry["type"] == "dsc":
2878                     self.check_source_against_db(checkfile, session)
2879                     self.check_dsc_against_db(dsc_filename, session)
2880
2881             # propogate in the case it is in the override tables:
2882             for suite in self.pkg.changes.get("propdistribution", {}).keys():
2883                 if self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
2884                     propogate[suite] = 1
2885                 else:
2886                     nopropogate[suite] = 1
2887
2888         for suite in propogate.keys():
2889             if suite in nopropogate:
2890                 continue
2891             self.pkg.changes["distribution"][suite] = 1
2892
2893         for checkfile in self.pkg.files.keys():
2894             # Check the package is still in the override tables
2895             for suite in self.pkg.changes["distribution"].keys():
2896                 if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
2897                     self.rejects.append("%s is NEW for %s." % (checkfile, suite))
2898
2899     ################################################################################
2900     # If any file of an upload has a recent mtime then chances are good
2901     # the file is still being uploaded.
2902
2903     def upload_too_new(self):
2904         cnf = Config()
2905         too_new = False
2906         # Move back to the original directory to get accurate time stamps
2907         cwd = os.getcwd()
2908         os.chdir(self.pkg.directory)
2909         file_list = self.pkg.files.keys()
2910         file_list.extend(self.pkg.dsc_files.keys())
2911         file_list.append(self.pkg.changes_file)
2912         for f in file_list:
2913             try:
2914                 last_modified = time.time()-os.path.getmtime(f)
2915                 if last_modified < int(cnf["Dinstall::SkipTime"]):
2916                     too_new = True
2917                     break
2918             except:
2919                 pass
2920
2921         os.chdir(cwd)
2922         return too_new
2923
2924     def store_changelog(self):
2925
2926         # Skip binary-only upload if it is not a bin-NMU
2927         if not self.pkg.changes['architecture'].has_key('source'):
2928             from daklib.regexes import re_bin_only_nmu
2929             if not re_bin_only_nmu.search(self.pkg.changes['version']):
2930                 return
2931
2932         session = DBConn().session()
2933
2934         # Check if upload already has a changelog entry
2935         query = """SELECT changelog_id FROM changes WHERE source = :source
2936                    AND version = :version AND architecture = :architecture AND changelog_id != 0"""
2937         if session.execute(query, {'source': self.pkg.changes['source'], \
2938                                    'version': self.pkg.changes['version'], \
2939                                    'architecture': " ".join(self.pkg.changes['architecture'].keys())}).rowcount:
2940             session.commit()
2941             return
2942
2943         # Add current changelog text into changelogs_text table, return created ID
2944         query = "INSERT INTO changelogs_text (changelog) VALUES (:changelog) RETURNING id"
2945         ID = session.execute(query, {'changelog': self.pkg.changes['changes']}).fetchone()[0]
2946
2947         # Link ID to the upload available in changes table
2948         query = """UPDATE changes SET changelog_id = :id WHERE source = :source
2949                    AND version = :version AND architecture = :architecture"""
2950         session.execute(query, {'id': ID, 'source': self.pkg.changes['source'], \
2951                                 'version': self.pkg.changes['version'], \
2952                                 'architecture': " ".join(self.pkg.changes['architecture'].keys())})
2953
2954         session.commit()