]> git.decadent.org.uk Git - nfs-utils.git/commitdiff
getport: RPCB_GETADDR r_owner should be an empty string
authorChuck Lever <chuck.lever@oracle.com>
Tue, 14 Jul 2009 20:07:35 +0000 (16:07 -0400)
committerSteve Dickson <steved@redhat.com>
Tue, 14 Jul 2009 20:07:35 +0000 (16:07 -0400)
Some servers reject RPCB_GETADDR requests with a non-empty r_owner
field.  "RPC: Server can't decode arguments"

An empty string is already used by libtirpc and the kernel
for RPCB_GETADDR requests.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
support/nfs/getport.c

index cf1677e78650869a284c8ca550f02ff83845f2bf..926bab8aa74856584bc04e347affea57103a1613 100644 (file)
@@ -458,10 +458,6 @@ static int nfs_gp_ping(CLIENT *client, struct timeval timeout)
 /*
  * Initialize the rpcb argument for a GETADDR request.
  *
- * The rpcbind daemon ignores the parms.r_owner field in GETADDR
- * requests, but we plant an eye-catcher to help distinguish these
- * requests in network traces.
- *
  * Returns 1 if successful, and caller must free strings pointed
  * to by r_netid and r_addr; otherwise 0.
  */
@@ -489,7 +485,7 @@ static int nfs_gp_init_rpcb_parms(const struct sockaddr *sap,
        parms->r_vers   = version;
        parms->r_netid  = netid;
        parms->r_addr   = addr;
-       parms->r_owner  = "nfs-utils";  /* eye-catcher */
+       parms->r_owner  = "";
 
        return 1;
 }