From: Chuck Lever Date: Tue, 14 Jul 2009 20:07:35 +0000 (-0400) Subject: getport: RPCB_GETADDR r_owner should be an empty string X-Git-Tag: nfs-utils-1-2-1-rc2~32 X-Git-Url: https://git.decadent.org.uk/gitweb/?p=nfs-utils.git;a=commitdiff_plain;h=8f859912e786859d21c341bb8a9b4effbdadb941;hp=1aa4121ba599de836702d7b2d38cad63e6a09044 getport: RPCB_GETADDR r_owner should be an empty string Some servers reject RPCB_GETADDR requests with a non-empty r_owner field. "RPC: Server can't decode arguments" An empty string is already used by libtirpc and the kernel for RPCB_GETADDR requests. Signed-off-by: Chuck Lever Signed-off-by: Steve Dickson --- diff --git a/support/nfs/getport.c b/support/nfs/getport.c index cf1677e..926bab8 100644 --- a/support/nfs/getport.c +++ b/support/nfs/getport.c @@ -458,10 +458,6 @@ static int nfs_gp_ping(CLIENT *client, struct timeval timeout) /* * Initialize the rpcb argument for a GETADDR request. * - * The rpcbind daemon ignores the parms.r_owner field in GETADDR - * requests, but we plant an eye-catcher to help distinguish these - * requests in network traces. - * * Returns 1 if successful, and caller must free strings pointed * to by r_netid and r_addr; otherwise 0. */ @@ -489,7 +485,7 @@ static int nfs_gp_init_rpcb_parms(const struct sockaddr *sap, parms->r_vers = version; parms->r_netid = netid; parms->r_addr = addr; - parms->r_owner = "nfs-utils"; /* eye-catcher */ + parms->r_owner = ""; return 1; }