autodecruft: Make function look a bit nicer.

diff --git a/config/debian/dinstall.functions b/config/debian/dinstall.functions
index 281d428782391cea5c8042c1acf492dc51a3ca48..33931b2b29c3a67d8fae347191ab8fbefef4282d 100644 (file)
--- a/config/debian/dinstall.functions
+++ b/config/debian/dinstall.functions
@@ -109,14 +109,15 @@ function dominate() {
 
 function autocruft() {
     log "Check for obsolete binary packages"
-    suites=${1:-"unstable experimental"}
+    local suites=${1:-"unstable experimental"}
     # Initially only run with -n and output into a file, to check.
-    dstamp=$(date -u +"%Y-%m-%d_%H:%M")
-    echo "Report for ${dstamp}" > $webdir/auto-cruft-report_${dstamp}.txt
+    local dstamp=$(date -u +"%Y-%m-%d_%H:%M")
+    local report=${webdir}/auto-cruft-report_${dstamp}.txt
+    echo "Report for ${dstamp}" > ${report}
     for suite in ${suites}; do
-        dak auto-decruft -n -s ${suite} >> $webdir/auto-cruft-report_${dstamp}.txt
+        dak auto-decruft -n -s ${suite} >> ${report}
     done
-    cat $webdir/auto-cruft-report_${dstamp}.txt | mail -a "X-Debian: DAK" -e -s "Debian archive AUTOMATIC cruft report for ${dstamp}" -a "From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>" -c niels@thykier.net ftpmaster@ftp-master.debian.org
+    cat ${report} | mail -a "X-Debian: DAK" -e -s "Debian archive AUTOMATIC cruft report for ${dstamp}" -a "From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>" -c niels@thykier.net ftpmaster@ftp-master.debian.org
 }
 
 function fingerprints() {