Use set -u in cron scripts.

diff --git a/ChangeLog b/ChangeLog
index 7dd06e2b494a0030e45a2a41d01217efee91e144..3d7e01063709d537c49e5afbb74f5f154a167b28 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2006-06-11  James Troup  <james@nocrew.org>
 
+       * config/debian/cron.unchecked: set -u to error out on undefined
+       variables.  Preset LOCKDAILY to "" accordingly.
+       * config/debian/cron.hourly: likewise.
+       * config/debian/cron.monthly: likewise.
+       * config/debian/cron.weekly: likewise.
+
        * config/debian/vars (configdir): add new variable pointing to
        this directory.
 

diff --git a/config/debian/cron.hourly b/config/debian/cron.hourly
index 8efa0e09cb19c07181161efb98f859ef79be0e1d..59104c3a202aca13109b8d8a189f40bc2520dc5e 100644 (file)
--- a/config/debian/cron.hourly
+++ b/config/debian/cron.hourly
@@ -3,6 +3,7 @@
 # Executed hourly via cron, out of troup's crontab.
 
 set -e
+set -u
 export SCRIPTVARS=/org/ftp.debian.org/dak/config/debian/vars
 . $SCRIPTVARS
 

diff --git a/config/debian/cron.monthly b/config/debian/cron.monthly
index ac4bf7dd5517b7c30f4a02ae5f993c35f10473d0..9d7a68ba9abcdd227b23d20c23db36717391d151 100755 (executable)
--- a/config/debian/cron.monthly
+++ b/config/debian/cron.monthly
@@ -3,6 +3,7 @@
 # Run at the beginning of the month via cron, out of dak's crontab.
 
 set -e
+set -u
 export SCRIPTVARS=/org/ftp.debian.org/dak/config/debian/vars
 . $SCRIPTVARS
 

diff --git a/config/debian/cron.unchecked b/config/debian/cron.unchecked
index c018d51f0cce9da6ab74b2365a5c26c9f3ecb558..1282b60e8700143fd7de77a6ab7ffaf9c07fea3e 100644 (file)
--- a/config/debian/cron.unchecked
+++ b/config/debian/cron.unchecked
@@ -1,9 +1,11 @@
 #! /bin/sh
 
 set -e
+set -u
 export SCRIPTVARS=/org/ftp.debian.org/dak/config/debian/vars
 . $SCRIPTVARS
 
+LOCKDAILY=""
 LOCKFILE="$lockdir/unchecked.lock"
 NOTICE="$lockdir/daily.lock"
 

diff --git a/config/debian/cron.weekly b/config/debian/cron.weekly
index 3624336c2829f8a9fa080ee8ee681eb33325971f..2c159380bc0014a82261d57a4712d38323cd5448 100755 (executable)
--- a/config/debian/cron.weekly
+++ b/config/debian/cron.weekly
@@ -3,6 +3,7 @@
 # Run once a week via cron, out of dak's crontab.
 
 set -e
+set -u
 export SCRIPTVARS=/org/ftp.debian.org/dak/config/debian/vars
 . $SCRIPTVARS