sanity check Depends

[dak.git] / jennifer

diff --git a/jennifer b/jennifer
index f23d62a5997cd1ebee598ddad28ca1fc1fcbb359..2106c34f11e6894fcb21036d4d3c7ef8d23be4e8 100755 (executable)
--- a/jennifer
+++ b/jennifer
@@ -2,7 +2,7 @@
 
 # Checks Debian packages from Incoming
 # Copyright (C) 2000, 2001, 2002  James Troup <james@nocrew.org>
-# $Id: jennifer,v 1.27 2002-10-16 02:47:32 troup Exp $
+# $Id: jennifer,v 1.29 2002-12-10 21:48:30 troup Exp $
 
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -45,7 +45,7 @@ re_valid_pkg_name = re.compile(r"^[\dA-Za-z][\dA-Za-z\+\-\.]+$");
 ################################################################################
 
 # Globals
-jennifer_version = "$Revision: 1.27 $";
+jennifer_version = "$Revision: 1.29 $";
 
 Cnf = None;
 Options = None;
@@ -337,7 +337,7 @@ def clean_holding():
     os.chdir(Cnf["Dir::Queue::Holding"]);
     for file in in_holding.keys():
         if os.path.exists(file):
-            if file.find(file, '/') != -1:
+            if file.find('/') != -1:
                 utils.fubar("WTF? clean_holding() got a file ('%s') with / in it!" % (file));
             else:
                 os.unlink(file);
@@ -543,6 +543,11 @@ def check_files():
             if not changes["architecture"].has_key(architecture):
                 reject("%s: control file lists arch as `%s', which isn't in changes file." % (file, architecture));
 
+            # Sanity-check the Depends field
+            depends = control.Find("Depends");
+            if depends == '':
+                reject("%s: Depends field is empty." % (file));
+
             # Check the section & priority match those given in the .changes (non-fatal)
             if control.Find("Section") != None and files[file]["section"] != "" and files[file]["section"] != control.Find("Section"):
                 reject("%s control file lists section as `%s', but changes file has `%s'." % (file, control.Find("Section", ""), files[file]["section"]), "Warning: ");