Merge branch 'master' into deb-src-3.0-sqla

[dak.git] / daklib / utils.py

diff --git a/daklib/utils.py b/daklib/utils.py
index c4f93fe5f651cc2b8bc5c6b82861a548f554aebc..cfee2c7eb148bcd67b292b3e0fed3166e6ee175a 100755 (executable)
--- a/daklib/utils.py
+++ b/daklib/utils.py
@@ -365,38 +365,42 @@ def check_dsc_files(dsc_filename, dsc=None, dsc_files=None):
     # announced
     has = defaultdict(lambda: 0)
 
+    ftype_lookup = (
+        (r'orig.tar.gz',                    ('orig_tar_gz', 'orig_tar')),
+        (r'diff.gz',                        ('debian_diff',)),
+        (r'tar.gz',                         ('native_tar_gz', 'native_tar')),
+        (r'debian\.tar\.(gz|bz2|lzma)',     ('debian_tar',)),
+        (r'orig\.tar\.(gz|bz2|lzma)',       ('orig_tar',)),
+        (r'tar\.(gz|bz2|lzma)',             ('native_tar',)),
+        (r'orig-.+\.tar\.(gz|bz2|lzma)',    ('more_orig_tar',)),
+    )
+
     for f in dsc_files.keys():
         m = re_issource.match(f)
         if not m:
             rejmsg.append("%s: %s in Files field not recognised as source."
                           % (dsc_filename, f))
             continue
-        ftype = m.group(3)
-        if ftype == "orig.tar.gz":
-            has['orig_tar_gz'] += 1
-            has['orig_tar'] += 1
-        elif ftype == "diff.gz":
-            has['debian_diff'] += 1
-        elif ftype == "tar.gz":
-            has['native_tar_gz'] += 1
-            has['native_tar'] += 1
-        elif re.match(r"debian\.tar\.(gz|bz2|lzma)", ftype):
-            has['debian_tar'] += 1
-        elif re.match(r"orig\.tar\.(gz|bz2|lzma)", ftype):
-            has['orig_tar'] += 1
-        elif re.match(r"tar\.(gz|bz2|lzma)", ftype):
-            has['native_tar'] += 1
-        elif re.match(r"orig-.+\.tar\.(gz|bz2|lzma)", ftype):
-            has['more_orig_tar'] += 1
-        else:
+
+        # Populate 'has' dictionary by resolving keys in lookup table
+        matched = False
+        for regex, keys in ftype_lookup:
+            if re.match(regex, m.group(3)):
+                matched = True
+                for key in keys:
+                    has[key] += 1
+                break
+
+        # File does not match anything in lookup table; reject
+        if not matched:
             reject("%s: unexpected source file '%s'" % (dsc_filename, f))
-    if has['orig_tar'] > 1:
-        rejmsg.append("%s: lists multiple .orig tarballs." % (dsc_filename))
-    if has['native_tar'] > 1:
-        rejmsg.append("%s: lists multiple native tarballs." % (dsc_filename))
-    if has['debian_tar'] > 1 or has['debian_diff'] > 1:
-        rejmsg.append("%s: lists multiple debian diff/tarballs." % (dsc_filename))
 
+    # Check for multiple files
+    for file_type in ('orig_tar', 'native_tar', 'debian_tar', 'debian_diff'):
+        if has[file_type] > 1:
+            rejmsg.append("%s: lists multiple %s" % (dsc_filename, file_type))
+
+    # Source format specific tests
     for format in srcformats:
         if format.re_format.match(dsc['format']):
             rejmsg.extend([