Use a collections.defaultdict to avoid boilerplate definitions.

[dak.git] / daklib / utils.py

diff --git a/daklib/utils.py b/daklib/utils.py
index 9f244963dc7cdf8e6ac29e24b350197e11ac240e..c4f93fe5f651cc2b8bc5c6b82861a548f554aebc 100755 (executable)
--- a/daklib/utils.py
+++ b/daklib/utils.py
@@ -48,6 +48,9 @@ from regexes import re_html_escaping, html_escaping, re_single_line_field, \
                     re_parse_maintainer, re_taint_free, re_gpg_uid, \
                     re_re_mark, re_whitespace_comment, re_issource
 
+from srcformats import srcformats
+from collections import defaultdict
+
 ################################################################################
 
 default_config = "/etc/dak/dak.conf"     #: default dak config, defines host properties
@@ -352,20 +355,16 @@ def check_dsc_files(dsc_filename, dsc=None, dsc_files=None):
     rejmsg = []
 
     # Parse the file if needed
-    if dsc == None:
+    if dsc is None:
         dsc = parse_changes(dsc_filename, signing_rules=1);
-    if dsc_files == None:
+
+    if dsc_files is None:
         dsc_files = build_file_list(dsc, is_a_dsc=1)
 
     # Ensure .dsc lists proper set of source files according to the format
     # announced
-    has_native_tar = 0
-    has_native_tar_gz = 0
-    has_orig_tar = 0
-    has_orig_tar_gz = 0
-    has_more_orig_tar = 0
-    has_debian_tar = 0
-    has_debian_diff = 0
+    has = defaultdict(lambda: 0)
+
     for f in dsc_files.keys():
         m = re_issource.match(f)
         if not m:
@@ -374,53 +373,36 @@ def check_dsc_files(dsc_filename, dsc=None, dsc_files=None):
             continue
         ftype = m.group(3)
         if ftype == "orig.tar.gz":
-            has_orig_tar_gz += 1
-            has_orig_tar += 1
+            has['orig_tar_gz'] += 1
+            has['orig_tar'] += 1
         elif ftype == "diff.gz":
-            has_debian_diff += 1
+            has['debian_diff'] += 1
         elif ftype == "tar.gz":
-            has_native_tar_gz += 1
-            has_native_tar += 1
+            has['native_tar_gz'] += 1
+            has['native_tar'] += 1
         elif re.match(r"debian\.tar\.(gz|bz2|lzma)", ftype):
-            has_debian_tar += 1
+            has['debian_tar'] += 1
         elif re.match(r"orig\.tar\.(gz|bz2|lzma)", ftype):
-            has_orig_tar += 1
+            has['orig_tar'] += 1
         elif re.match(r"tar\.(gz|bz2|lzma)", ftype):
-            has_native_tar += 1
+            has['native_tar'] += 1
         elif re.match(r"orig-.+\.tar\.(gz|bz2|lzma)", ftype):
-            has_more_orig_tar += 1
+            has['more_orig_tar'] += 1
         else:
             reject("%s: unexpected source file '%s'" % (dsc_filename, f))
-    if has_orig_tar > 1:
+    if has['orig_tar'] > 1:
         rejmsg.append("%s: lists multiple .orig tarballs." % (dsc_filename))
-    if has_native_tar > 1:
+    if has['native_tar'] > 1:
         rejmsg.append("%s: lists multiple native tarballs." % (dsc_filename))
-    if has_debian_tar > 1 or has_debian_diff > 1:
+    if has['debian_tar'] > 1 or has['debian_diff'] > 1:
         rejmsg.append("%s: lists multiple debian diff/tarballs." % (dsc_filename))
-    if dsc["format"] == "1.0":
-        if not (has_native_tar_gz or (has_orig_tar_gz and has_debian_diff)):
-            rejmsg.append("%s: no .tar.gz or .orig.tar.gz+.diff.gz in "
-                          "'Files' field." % (dsc_filename))
-        if (has_orig_tar_gz != has_orig_tar) or \
-           (has_native_tar_gz != has_native_tar) or \
-           has_debian_tar or has_more_orig_tar:
-            rejmsg.append("%s: contains source files not allowed in format 1.0"
-                          % (dsc_filename))
-    elif re.match(r"3\.\d+ \(native\)", dsc["format"]):
-        if not has_native_tar:
-            rejmsg.append("%s: lack required files for format 3.x (native)."
-                          % (dsc_filename))
-        if has_orig_tar or has_debian_diff or has_debian_tar or \
-           has_more_orig_tar:
-            rejmsg.append("%s: contains source files not allowed in "
-                          "format '3.x (native)'" % (dsc_filename))
-    elif re.match(r"3\.\d+ \(quilt\)", dsc["format"]):
-        if not(has_orig_tar and has_debian_tar):
-            rejmsg.append("%s: lack required files for format "
-                          "'3.x (quilt)'." % (dsc_filename))
-        if has_debian_diff or has_native_tar:
-            rejmsg.append("%s: contains source files not allowed in format "
-                          "3.x (quilt)" % (dsc_filename))
+
+    for format in srcformats:
+        if format.re_format.match(dsc['format']):
+            rejmsg.extend([
+                '%s: %s' % (dsc_filename, x) for x in format.reject_msgs(has)
+            ])
+            break
 
     return rejmsg