Use a collections.defaultdict to avoid boilerplate definitions.

[dak.git] / daklib / srcformats.py

diff --git a/daklib/srcformats.py b/daklib/srcformats.py
index 8364e6268ba757a0c4904fc5e4422a8b32646e0f..e454e2bd444e900a8b47ff8b786f65aeba2ad80d 100644 (file)
--- a/daklib/srcformats.py
+++ b/daklib/srcformats.py
@@ -7,6 +7,7 @@ class SourceFormat(type):
         klass = super(SourceFormat, cls).__new__(cls, name, bases, attrs)
         srcformats.append(klass)
 
+        assert str(klass.name)
         klass.re_format = re.compile(klass.format)
 
         return klass
@@ -14,37 +15,40 @@ class SourceFormat(type):
 class FormatOne(object):
     __metaclass__ = SourceFormat
 
+    name = '1.0'
     format = r'1.0'
 
     @classmethod
-    def reject_msgs(cls, dsc_filename, has_native_tar, has_native_tar_gz, has_debian_tar, has_debian_diff, has_orig_tar, has_orig_tar_gz, has_more_orig_tar):
-        if not (has_native_tar_gz or (has_orig_tar_gz and has_debian_diff)):
-            yield "%s: no .tar.gz or .orig.tar.gz+.diff.gz in 'Files' field." % dsc_filename
-        if (has_orig_tar_gz != has_orig_tar) or \
-           (has_native_tar_gz != has_native_tar) or \
-           has_debian_tar or has_more_orig_tar:
-            yield "%s: contains source files not allowed in format 1.0" % dsc_filename
+    def reject_msgs(cls, has):
+        if not (has['native_tar_gz'] or (has['orig_tar_gz'] and has['debian_diff'])):
+            yield "no .tar.gz or .orig.tar.gz+.diff.gz in 'Files' field."
+        if (has['orig_tar_gz'] != has['orig_tar']) or \
+           (has['native_tar_gz'] != has['native_tar']) or \
+           has['debian_tar'] or has['more_orig_tar']:
+            yield "contains source files not allowed in format %s" % cls.name
 
 class FormatThree(object):
     __metaclass__ = SourceFormat
 
+    name = '3.x (native)'
     format = r'3\.\d+ \(native\)'
 
     @classmethod
-    def reject_msgs(cls, dsc_filename, has_native_tar, has_native_tar_gz, has_debian_tar, has_debian_diff, has_orig_tar, has_orig_tar_gz, has_more_orig_tar):
-        if not has_native_tar:
-            yield "%s: lack required files for format 3.x (native)." % dsc_filename
-        if has_orig_tar or has_debian_diff or has_debian_tar or has_more_orig_tar:
-            yield "%s: contains source files not allowed in format '3.x (native)'" % dsc_filename
+    def reject_msgs(cls, has):
+        if not has['native_tar']:
+            yield "lack of required files for format %s" % cls.name
+        if has['orig_tar'] or has['debian_diff'] or has['debian_tar'] or has['more_orig_tar']:
+            yield "contains source files not allowed in format %s" % cls.name
 
 class FormatThreeQuilt(object):
     __metaclass__ = SourceFormat
 
+    name = '3.x (quilt)'
     format = r'3\.\d+ \(quilt\)'
 
     @classmethod
-    def reject_msgs(cls, dsc_filename, has_native_tar, has_native_tar_gz, has_debian_tar, has_debian_diff, has_orig_tar, has_orig_tar_gz, has_more_orig_tar):
-        if not(has_orig_tar and has_debian_tar):
-            yield "%s: lack required files for format '3.x (quilt)'." % dsc_filename
-        if has_debian_diff or has_native_tar:
-            yield "%s: contains source files not allowed in format 3.x (quilt)" % dsc_filename
+    def reject_msgs(cls, has):
+        if not (has['orig_tar'] and has['debian_tar']):
+            yield "lack of required files for format %s" % cls.name
+        if has['debian_diff'] or has['native_tar']:
+            yield "contains source files not allowed in format %s" % cls.name