"Format: 0.0" is now invalid

[dak.git] / daklib / srcformats.py

diff --git a/daklib/srcformats.py b/daklib/srcformats.py
index 5c9a9e0ecde9a33efeb6c79900584c2038b4f7c7..60da5bc0d7305e92a4e3b8c968caf2a247e0c99e 100644 (file)
--- a/daklib/srcformats.py
+++ b/daklib/srcformats.py
@@ -1,5 +1,8 @@
 import re
 
+from regexes import re_verwithext
+from dak_exceptions import UnknownFormatError
+
 srcformats = []
 
 class SourceFormat(type):
@@ -7,44 +10,85 @@ class SourceFormat(type):
         klass = super(SourceFormat, cls).__new__(cls, name, bases, attrs)
         srcformats.append(klass)
 
+        assert str(klass.name)
+        assert iter(klass.requires)
+        assert iter(klass.disallowed)
+
         klass.re_format = re.compile(klass.format)
 
         return klass
 
-class FormatOne(object):
+    @classmethod
+    def reject_msgs(cls, has):
+        if len(cls.requires) != len([x for x in cls.requires if has[x]]):
+            yield "lack of required files for format %s" % cls.name
+
+        for key in cls.disallowed:
+            if has[key]:
+                yield "contains source files not allowed in format %s" % cls.name
+
+    @classmethod
+    def parse_format(cls, txt, is_a_dsc=False, field='files'):
+        format = re_verwithext.search(txt)
+        if not format:
+            raise UnknownFormatError, txt
+
+        format = format.groups()
+        if format[1] == None:
+            format = int(float(format[0])), 0, format[2]
+        else:
+            format = int(format[0]), int(format[1]), format[2]
+        if format[2] == None:
+            format = format[:2]
+
+        if is_a_dsc:
+            if format != (1,0) and \
+               format != (3,0,"quilt") and format != (3,0,"native"):
+                raise UnknownFormatError, txt
+        else:
+            if (format < (1,5) or format > (1,8)):
+                raise UnknownFormatError, txt
+            if field != "files" and format < (1,8):
+                raise UnknownFormatError, txt
+
+        return format
+
+class FormatOne(SourceFormat):
     __metaclass__ = SourceFormat
 
+    name = '1.0'
     format = r'1.0'
 
+    requires = ()
+    disallowed = ('debian_tar', 'more_orig_tar')
+
     @classmethod
-    def reject_msgs(cls, has_native_tar, has_native_tar_gz, has_debian_tar, has_debian_diff, has_orig_tar, has_orig_tar_gz, has_more_orig_tar):
-        if not (has_native_tar_gz or (has_orig_tar_gz and has_debian_diff)):
+    def reject_msgs(cls, has):
+        if not (has['native_tar_gz'] or (has['orig_tar_gz'] and has['debian_diff'])):
             yield "no .tar.gz or .orig.tar.gz+.diff.gz in 'Files' field."
-        if (has_orig_tar_gz != has_orig_tar) or \
-           (has_native_tar_gz != has_native_tar) or \
-           has_debian_tar or has_more_orig_tar:
-            yield "contains source files not allowed in format 1.0"
+        if has['native_tar_gz'] and has['debian_diff']:
+            yield "native package with diff makes no sense"
+        if (has['orig_tar_gz'] != has['orig_tar']) or \
+           (has['native_tar_gz'] != has['native_tar']):
+            yield "contains source files not allowed in format %s" % cls.name
 
-class FormatThree(object):
+        for msg in super(FormatOne, cls).reject_msgs(has):
+            yield msg
+
+class FormatThree(SourceFormat):
     __metaclass__ = SourceFormat
 
+    name = '3.x (native)'
     format = r'3\.\d+ \(native\)'
 
-    @classmethod
-    def reject_msgs(cls, has_native_tar, has_native_tar_gz, has_debian_tar, has_debian_diff, has_orig_tar, has_orig_tar_gz, has_more_orig_tar):
-        if not has_native_tar:
-            yield "lack required files for format 3.x (native)."
-        if has_orig_tar or has_debian_diff or has_debian_tar or has_more_orig_tar:
-            yield "contains source files not allowed in format '3.x (native)'"
+    requires = ('native_tar',)
+    disallowed = ('orig_tar', 'debian_diff', 'debian_tar', 'more_orig_tar')
 
-class FormatThreeQuilt(object):
+class FormatThreeQuilt(SourceFormat):
     __metaclass__ = SourceFormat
 
+    name = '3.x (quilt)'
     format = r'3\.\d+ \(quilt\)'
 
-    @classmethod
-    def reject_msgs(cls, has_native_tar, has_native_tar_gz, has_debian_tar, has_debian_diff, has_orig_tar, has_orig_tar_gz, has_more_orig_tar):
-        if not(has_orig_tar and has_debian_tar):
-            yield "lack required files for format '3.x (quilt)'."
-        if has_debian_diff or has_native_tar:
-            yield "contains source files not allowed in format 3.x (quilt)"
+    requires = ('orig_tar', 'debian_tar')
+    disallowed = ('debian_diff', 'native_tar')