################################################################################
+#####################################
+#### This may run within sudo !! ####
+#####################################
def init():
global Cnf, Options, projectB
def usage (exit_code=0):
print """Usage: transitions [OPTION]...
Update and check the release managers transition file.
-transitions.
Options:
-i, --import <file> check and import transitions from file
-c, --check check the transitions file, remove outdated entries
-S, --sudo use sudo to update transitions file
- -n, --no-action don't do anything"""
+ -n, --no-action don't do anything (only affects check)"""
sys.exit(exit_code)
################################################################################
+#####################################
+#### This may run within sudo !! ####
+#####################################
def load_transitions(trans_file):
# Parse the yaml file
sourcefile = file(trans_file, 'r')
sourcecontent = sourcefile.read()
+ failure = False
try:
trans = syck.load(sourcecontent)
except syck.error, msg:
# Someone fucked it up
print "ERROR: %s" % (msg)
return None
- # could do further validation here
+
+ # lets do further validation here
+ checkkeys = ["source", "reason", "packages", "new", "rm"]
+ for test in trans:
+ t = trans[test]
+
+ # First check if we know all the keys for the transition and if they have
+ # the right type (and for the packages also if the list has the right types
+ # included, ie. not a list in list, but only str in the list)
+ for key in t:
+ if key not in checkkeys:
+ print "ERROR: Unknown key %s in transition %s" % (key, test)
+ failure = True
+
+ if key == "packages":
+ if type(t[key]) != list:
+ print "ERROR: Unknown type %s for packages in transition %s." % (type(t[key]), test)
+ failure = True
+
+ try:
+ for package in t["packages"]:
+ if type(package) != str:
+ print "ERROR: Packages list contains invalid type %s (as %s) in transition %s" % (type(package), package, test)
+ failure = True
+ except TypeError:
+ # In case someone has an empty packages list
+ print "ERROR: No packages defined in transition %s" % (test)
+ failure = True
+ continue
+
+ elif type(t[key]) != str:
+ print "ERROR: Unknown type %s for key %s in transition %s" % (type(t[key]), key, test)
+ failure = True
+
+ # And now the other way round - are all our keys defined?
+ for key in checkkeys:
+ if key not in t:
+ print "ERROR: Missing key %s in transition %s" % (key, test)
+ failure = True
+
+ if failure:
+ return None
+
return trans
################################################################################
+#####################################
+#### This may run within sudo !! ####
+#####################################
def lock_file(file):
for retry in range(10):
lock_fd = os.open(file, os.O_RDWR | os.O_CREAT)
################################################################################
+#####################################
+#### This may run within sudo !! ####
+#####################################
def write_transitions(from_trans):
"""Update the active transitions file safely.
This function takes a parsed input file (which avoids invalid
class ParseException(Exception):
pass
+##########################################
+#### This usually runs within sudo !! ####
+##########################################
def write_transitions_from_file(from_file):
"""We have a file we think is valid; if we're using sudo, we invoke it
here, otherwise we just parse the file and call write_transitions"""
+ # Lets check if from_file is in the directory we expect it to be in
+ if not os.path.abspath(from_file).startswith(Cnf["Transitions::TempPath"]):
+ print "Will not accept transitions file outside of %s" % (Cnf["Transitions::TempPath"])
+ sys.exit(3)
+
if Options["sudo"]:
os.spawnl(os.P_WAIT, "/usr/bin/sudo", "/usr/bin/sudo", "-u", "dak", "-H",
"/usr/local/bin/dak", "transitions", "--import", from_file)
def temp_transitions_file(transitions):
# NB: file is unlinked by caller, but fd is never actually closed.
-
- (fd, path) = tempfile.mkstemp("","transitions")
+ # We need the chmod, as the file is (most possibly) copied from a
+ # sudo-ed script and would be unreadable if it has default mkstemp mode
+
+ (fd, path) = tempfile.mkstemp("","transitions",Cnf["Transitions::TempPath"])
+ os.chmod(path, 0644)
f = open(path, "w")
syck.dump(transitions, f)
return path
default = "E"
else:
print "Edit looks okay.\n"
+ print "The following transitions are defined:"
print "------------------------------------------------------------------------"
transition_info(test)
def main():
global Cnf
+ #####################################
+ #### This can run within sudo !! ####
+ #####################################
init()
# Check if there is a file defined (and existant)
print m
sys.exit(2)
sys.exit(0)
+ ##############################################
+ #### Up to here it can run within sudo !! ####
+ ##############################################
# Parse the yaml file
transitions = load_transitions(transpath)
projects / dak.git / blobdiff