show-new: limit to five threads to avoid using too many resources

[dak.git] / dak / show_new.py

diff --git a/dak/show_new.py b/dak/show_new.py
index 48abf7318858d486a1a9d1f531998a34595586f9..d2b133b74fab208397eaa5d962d18066dae3a33a 100755 (executable)
--- a/dak/show_new.py
+++ b/dak/show_new.py
@@ -38,13 +38,14 @@ from daklib.config import Config
 from daklib import daklog
 from daklib.changesutils import *
 from daklib.dakmultiprocessing import DakProcessPool, PROC_STATUS_SUCCESS, PROC_STATUS_SIGNALRAISED
-from multiprocessing import Manager
+from multiprocessing import Manager, TimeoutError
 
 # Globals
 Cnf = None
 Options = None
 manager = Manager()
 sources = manager.list()
+htmlfiles_to_process = manager.list()
 
 
 ################################################################################
@@ -158,7 +159,6 @@ def do_pkg(changes_file):
         return
     print "\n" + changes_file
 
-    session = DBConn().session()
     u = Upload()
     u.pkg.changes_file = changes_file
     # We can afoord not to check the signature before loading the changes file
@@ -172,20 +172,20 @@ def do_pkg(changes_file):
     if u.pkg.changes.has_key('source') and u.pkg.changes.has_key('version'):
         htmlname = u.pkg.changes["source"] + "_" + u.pkg.changes["version"] + ".html"
         htmlfile = os.path.join(cnf["Show-New::HTMLPath"], htmlname)
+        htmlfiles_to_process.append(htmlfile)
     else:
         # Changes file was bad
         print "Changes file %s missing source or version field" % changes_file
-        session.close()
         return
 
     # Have we already processed this?
     if os.path.exists(htmlfile) and \
         os.stat(htmlfile).st_mtime > os.stat(origchanges).st_mtime:
             sources.append(htmlname)
-            session.close()
             return (PROC_STATUS_SUCCESS, '%s already up-to-date' % htmlfile)
 
     # Now we'll load the fingerprint
+    session = DBConn().session()
     (u.pkg.changes["fingerprint"], rejects) = utils.check_signature(changes_file, session=session)
     new_queue = get_policy_queue('new', session );
     u.pkg.directory = new_queue.path
@@ -228,6 +228,7 @@ def do_pkg(changes_file):
     outfile.close()
     session.close()
 
+    htmlfiles_to_process.remove(htmlfile)
     return (PROC_STATUS_SUCCESS, '%s already updated' % htmlfile)
 
 ################################################################################
@@ -275,11 +276,13 @@ def main():
 
     examine_package.use_html=1
 
-    pool = DakProcessPool()
-    for changes_file in changes_files:
-        pool.apply_async(do_pkg, (changes_file,))
+    pool = DakProcessPool(processes=5)
+    p = pool.map_async(do_pkg, changes_files)
     pool.close()
-    pool.join()
+    p.wait(timeout=600)
+    for htmlfile in htmlfiles_to_process:
+        with open(htmlfile, "w") as fd:
+            fd.write("Timed out while processing")
 
     files = set(os.listdir(cnf["Show-New::HTMLPath"]))
     to_delete = filter(lambda x: x.endswith(".html"), files.difference(set(sources)))