various

[dak.git] / dak / generate_index_diffs.py

diff --git a/dak/generate_index_diffs.py b/dak/generate_index_diffs.py
index acf6b5f36f153e69372e1fcca9bdc4b75e608df9..2b4ad69295c128a5cadb5aeaf68881dd9bb1769e 100755 (executable)
--- a/dak/generate_index_diffs.py
+++ b/dak/generate_index_diffs.py
@@ -32,7 +32,6 @@
 
 import sys, os, tempfile
 import apt_pkg
-import bz2, gzip, time
 from daklib import utils
 
 ################################################################################
@@ -79,29 +78,16 @@ def smartlink(f, t):
         print "missing: %s" % (f)
         raise IOError, f
 
-def smartread(filename):
-    """
-    If filename exists, slurp the contents into a string.
-    if filename.gz or filename.bz2 exists instead, decompress and slurp
-    It returns a tuple of (filename, filecontents)
-    """
-    actual_filename = None
-    contents = None
-    if os.path.isfile(filename):
-        f = open(filename, "r")
-    elif os.path.isfile("%s.gz" % filename):
-        actual_filename = "%s.gz" % filename
-        f = decompressors['zcat'](actual_filename)
-    elif os.path.isfile("%s.bz2" % filename):
-        actual_filename = "%s.bz2" % filename
-        f = decompressors['bzcat'](actual_filename)
+def smartopen(file):
+    if os.path.isfile(file):
+        f = open(file, "r")
+    elif os.path.isfile("%s.gz" % file):
+        f = create_temp_file(os.popen("zcat %s.gz" % file, "r"))
+    elif os.path.isfile("%s.bz2" % file):
+        f = create_temp_file(os.popen("bzcat %s.bz2" % file, "r"))
     else:
         f = None
-
-    if f:
-        contents = f.read()
-
-    return (actual_filename, contents)
+    return f
 
 def pipe_file(f, t):
     f.seek(0)
@@ -187,14 +173,17 @@ class Updates:
         for h in l:
             out.write(" %s %7d %s\n" % (hs[h][1][0], hs[h][1][1], h))
 
-decompressors = { 'zcat' : gzip.GzipFile,
-                  'bzip2' : bz2.BZ2File }
-
-def sizesha1_str(s):
-    """
-    given a string, return a tuple containing its (sha1sum, length)
-    """
-    return (apt_pkg.sha1sum(s), len( s ) )
+def create_temp_file(r):
+    f = tempfile.TemporaryFile()
+    while 1:
+        x = r.readline()
+        if not x: break
+        f.write(x)
+    r.close()
+    del x,r
+    f.flush()
+    f.seek(0)
+    return f
 
 def sizesha1(f):
     size = os.fstat(f.fileno())[6]
@@ -234,18 +223,17 @@ def genchanges(Options, outdir, oldfile, origfile, maxdiffs = 14):
         print "%s: hardlink unbroken, assuming unchanged" % (origfile)
         return
 
-    (oldf,contents) = smartread(oldfile)
-    oldsizesha1 = sizesha1_str(contents)
+    oldf = smartopen(oldfile)
+    oldsizesha1 = sizesha1(oldf)
 
     # should probably early exit if either of these checks fail
     # alternatively (optionally?) could just trim the patch history
 
     if upd.filesizesha1:
         if upd.filesizesha1 != oldsizesha1:
-            print "warning: old file seems to have changed! %s %s => %s %s" % (upd.filesizesha1 + oldsizesha1)
+            print "info: old file " + oldfile + " changed! %s %s => %s %s" % (upd.filesizesha1 + oldsizesha1)
 
     # XXX this should be usable now
-    # stew: whatever this is, it won't be usable now that i removed smartopen
     #
     #for d in upd.history.keys():
     #    df = smartopen("%s/%s" % (outdir,d))
@@ -266,17 +254,18 @@ def genchanges(Options, outdir, oldfile, origfile, maxdiffs = 14):
 
     if newsizesha1 == oldsizesha1:
         os.unlink(newfile)
-#        oldf.close()
+        oldf.close()
         print "%s: unchanged" % (origfile)
     else:
         if not os.path.isdir(outdir): os.mkdir(outdir)
-        os.popen("diff --ed %s %s | gzip -c -9 > %s.gz" %
-                 (oldf, newfile, difffile))
-#        pipe_file(oldf, w)
-#        oldf.close()
+        w = os.popen("diff --ed - %s | gzip -c -9 > %s.gz" %
+                         (newfile, difffile), "w")
+        pipe_file(oldf, w)
+        oldf.close()
 
-        (oldf,contents) = smartread(difffile)
-        difsizesha1 = sizesha1_str(contents)
+        difff = smartopen(difffile)
+        difsizesha1 = sizesha1(difff)
+        difff.close()
 
         upd.history[patchname] = (oldsizesha1, difsizesha1)
         upd.history_order.append(patchname)
@@ -317,7 +306,10 @@ def main():
 
     if not Options.has_key("PatchName"):
         format = "%Y-%m-%d-%H%M.%S"
-        Options["PatchName"] = time.strftime( format )
+        i,o = os.popen2("date +%s" % (format))
+        i.close()
+        Options["PatchName"] = o.readline()[:-1]
+        o.close()
 
     AptCnf = apt_pkg.newConfiguration()
     apt_pkg.ReadConfigFileISC(AptCnf,utils.which_apt_conf_file())