3 # Checks Debian packages from Incoming
4 # Copyright (C) 2000, 2001, 2002, 2003, 2004 James Troup <james@nocrew.org>
5 # $Id: jennifer,v 1.53 2004-11-27 17:59:47 troup Exp $
7 # This program is free software; you can redistribute it and/or modify
8 # it under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 2 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with this program; if not, write to the Free Software
19 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
21 # Originally based on dinstall by Guy Maor <maor@debian.org>
23 ################################################################################
25 # Computer games don't affect kids. I mean if Pacman affected our generation as
26 # kids, we'd all run around in a darkened room munching pills and listening to
30 ################################################################################
32 import commands, errno, fcntl, os, re, shutil, stat, sys, time, tempfile, traceback;
33 import apt_inst, apt_pkg;
34 import db_access, katie, logging, utils;
38 ################################################################################
40 re_valid_version = re.compile(r"^([0-9]+:)?[0-9A-Za-z\.\-\+:]+$");
41 re_valid_pkg_name = re.compile(r"^[\dA-Za-z][\dA-Za-z\+\-\.]+$");
42 re_changelog_versions = re.compile(r"^\w[-+0-9a-z.]+ \([^\(\) \t]+\)");
43 re_strip_revision = re.compile(r"-([^-]+)$");
45 ################################################################################
48 jennifer_version = "$Revision: 1.53 $";
58 # Aliases to the real vars in the Katie class; hysterical raisins.
66 ###############################################################################
69 global Cnf, Options, Katie, changes, dsc, dsc_files, files, pkg;
73 Cnf = apt_pkg.newConfiguration();
74 apt_pkg.ReadConfigFileISC(Cnf,utils.which_conf_file());
76 Arguments = [('a',"automatic","Dinstall::Options::Automatic"),
77 ('h',"help","Dinstall::Options::Help"),
78 ('n',"no-action","Dinstall::Options::No-Action"),
79 ('p',"no-lock", "Dinstall::Options::No-Lock"),
80 ('s',"no-mail", "Dinstall::Options::No-Mail"),
81 ('V',"version","Dinstall::Options::Version")];
83 for i in ["automatic", "help", "no-action", "no-lock", "no-mail",
84 "override-distribution", "version"]:
85 Cnf["Dinstall::Options::%s" % (i)] = "";
87 changes_files = apt_pkg.ParseCommandLine(Cnf,Arguments,sys.argv);
88 Options = Cnf.SubTree("Dinstall::Options")
92 elif Options["Version"]:
93 print "jennifer %s" % (jennifer_version);
96 Katie = katie.Katie(Cnf);
98 changes = Katie.pkg.changes;
100 dsc_files = Katie.pkg.dsc_files;
101 files = Katie.pkg.files;
104 return changes_files;
106 ################################################################################
108 def usage (exit_code=0):
109 print """Usage: dinstall [OPTION]... [CHANGES]...
110 -a, --automatic automatic run
111 -h, --help show this help and exit.
112 -n, --no-action don't do anything
113 -p, --no-lock don't check lockfile !! for cron.daily only !!
114 -s, --no-mail don't send any mail
115 -V, --version display the version number and exit"""
118 ################################################################################
120 def reject (str, prefix="Rejected: "):
121 global reject_message;
123 reject_message += prefix + str + "\n";
125 ################################################################################
127 def copy_to_holding(filename):
130 base_filename = os.path.basename(filename);
132 dest = Cnf["Dir::Queue::Holding"] + '/' + base_filename;
134 fd = os.open(dest, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0640);
137 # Shouldn't happen, but will if, for example, someone lists a
138 # file twice in the .changes.
139 if errno.errorcode[e.errno] == 'EEXIST':
140 reject("%s: already exists in holding area; can not overwrite." % (base_filename));
145 shutil.copy(filename, dest);
147 # In either case (ENOENT or EACCES) we want to remove the
148 # O_CREAT | O_EXCLed ghost file, so add the file to the list
149 # of 'in holding' even if it's not the real file.
150 if errno.errorcode[e.errno] == 'ENOENT':
151 reject("%s: can not copy to holding area: file not found." % (base_filename));
154 elif errno.errorcode[e.errno] == 'EACCES':
155 reject("%s: can not copy to holding area: read permission denied." % (base_filename));
160 in_holding[base_filename] = "";
162 ################################################################################
168 os.chdir(Cnf["Dir::Queue::Holding"]);
169 for file in in_holding.keys():
170 if os.path.exists(file):
171 if file.find('/') != -1:
172 utils.fubar("WTF? clean_holding() got a file ('%s') with / in it!" % (file));
178 ################################################################################
181 filename = pkg.changes_file;
183 # Parse the .changes field into a dictionary
185 changes.update(utils.parse_changes(filename));
186 except utils.cant_open_exc:
187 reject("%s: can't read file." % (filename));
189 except utils.changes_parse_error_exc, line:
190 reject("%s: parse error, can't grok: %s." % (filename, line));
193 # Parse the Files field from the .changes into another dictionary
195 files.update(utils.build_file_list(changes));
196 except utils.changes_parse_error_exc, line:
197 reject("%s: parse error, can't grok: %s." % (filename, line));
198 except utils.nk_format_exc, format:
199 reject("%s: unknown format '%s'." % (filename, format));
202 # Check for mandatory fields
203 for i in ("source", "binary", "architecture", "version", "distribution",
204 "maintainer", "files", "changes"):
205 if not changes.has_key(i):
206 reject("%s: Missing mandatory field `%s'." % (filename, i));
207 return 0 # Avoid <undef> errors during later tests
209 # Split multi-value fields into a lower-level dictionary
210 for i in ("architecture", "distribution", "binary", "closes"):
211 o = changes.get(i, "")
218 # Fix the Maintainer: field to be RFC822/2047 compatible
220 (changes["maintainer822"], changes["maintainer2047"],
221 changes["maintainername"], changes["maintaineremail"]) = \
222 utils.fix_maintainer (changes["maintainer"]);
223 except utils.ParseMaintError, msg:
224 reject("%s: Maintainer field ('%s') failed to parse: %s" \
225 % (filename, changes["maintainer"], msg));
227 # ...likewise for the Changed-By: field if it exists.
229 (changes["changedby822"], changes["changedby2047"],
230 changes["changedbyname"], changes["changedbyemail"]) = \
231 utils.fix_maintainer (changes.get("changed-by", ""));
232 except utils.ParseMaintError, msg:
233 reject("%s: Changed-By field ('%s') failed to parse: %s" \
234 % (filename, changes["changed-by"], msg));
236 # Ensure all the values in Closes: are numbers
237 if changes.has_key("closes"):
238 for i in changes["closes"].keys():
239 if katie.re_isanum.match (i) == None:
240 reject("%s: `%s' from Closes field isn't a number." % (filename, i));
243 # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
244 changes["chopversion"] = utils.re_no_epoch.sub('', changes["version"])
245 changes["chopversion2"] = utils.re_no_revision.sub('', changes["chopversion"])
247 # Check there isn't already a changes file of the same name in one
248 # of the queue directories.
249 base_filename = os.path.basename(filename);
250 for dir in [ "Accepted", "Byhand", "Done", "New" ]:
251 if os.path.exists(Cnf["Dir::Queue::%s" % (dir) ]+'/'+base_filename):
252 reject("%s: a file with this name already exists in the %s directory." % (base_filename, dir));
254 # Check the .changes is non-empty
256 reject("%s: nothing to do (Files field is empty)." % (base_filename))
261 ################################################################################
263 def check_distributions():
264 "Check and map the Distribution field of a .changes file."
266 # Handle suite mappings
267 for map in Cnf.ValueList("SuiteMappings"):
270 if type == "map" or type == "silent-map":
271 (source, dest) = args[1:3];
272 if changes["distribution"].has_key(source):
273 del changes["distribution"][source]
274 changes["distribution"][dest] = 1;
275 if type != "silent-map":
276 reject("Mapping %s to %s." % (source, dest),"");
277 elif type == "map-unreleased":
278 (source, dest) = args[1:3];
279 if changes["distribution"].has_key(source):
280 for arch in changes["architecture"].keys():
281 if arch not in Cnf.ValueList("Suite::%s::Architectures" % (source)):
282 reject("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch),"");
283 del changes["distribution"][source];
284 changes["distribution"][dest] = 1;
286 elif type == "ignore":
288 if changes["distribution"].has_key(suite):
289 del changes["distribution"][suite];
290 reject("Ignoring %s as a target suite." % (suite), "Warning: ");
292 # Ensure there is (still) a target distribution
293 if changes["distribution"].keys() == []:
294 reject("no valid distribution.");
296 # Ensure target distributions exist
297 for suite in changes["distribution"].keys():
298 if not Cnf.has_key("Suite::%s" % (suite)):
299 reject("Unknown distribution `%s'." % (suite));
301 ################################################################################
306 archive = utils.where_am_i();
307 file_keys = files.keys();
309 # if reprocess is 2 we've already done this and we're checking
310 # things again for the new .orig.tar.gz.
311 # [Yes, I'm fully aware of how disgusting this is]
312 if not Options["No-Action"] and reprocess < 2:
314 os.chdir(pkg.directory);
315 for file in file_keys:
316 copy_to_holding(file);
319 # Check there isn't already a .changes or .katie file of the same name in
320 # the proposed-updates "CopyChanges" or "CopyKatie" storage directories.
321 # [NB: this check must be done post-suite mapping]
322 base_filename = os.path.basename(pkg.changes_file);
323 katie_filename = base_filename[:-8]+".katie"
324 for suite in changes["distribution"].keys():
325 copychanges = "Suite::%s::CopyChanges" % (suite);
326 if Cnf.has_key(copychanges) and \
327 os.path.exists(Cnf[copychanges]+"/"+base_filename):
328 reject("%s: a file with this name already exists in %s" \
329 % (base_filename, Cnf[copychanges]));
331 copykatie = "Suite::%s::CopyKatie" % (suite);
332 if Cnf.has_key(copykatie) and \
333 os.path.exists(Cnf[copykatie]+"/"+katie_filename):
334 reject("%s: a file with this name already exists in %s" \
335 % (katie_filename, Cnf[copykatie]));
341 for file in file_keys:
342 # Ensure the file does not already exist in one of the accepted directories
343 for dir in [ "Accepted", "Byhand", "New" ]:
344 if os.path.exists(Cnf["Dir::Queue::%s" % (dir) ]+'/'+file):
345 reject("%s file already exists in the %s directory." % (file, dir));
346 if not utils.re_taint_free.match(file):
347 reject("!!WARNING!! tainted filename: '%s'." % (file));
348 # Check the file is readable
349 if os.access(file,os.R_OK) == 0:
350 # When running in -n, copy_to_holding() won't have
351 # generated the reject_message, so we need to.
352 if Options["No-Action"]:
353 if os.path.exists(file):
354 reject("Can't read `%s'. [permission denied]" % (file));
356 reject("Can't read `%s'. [file not found]" % (file));
357 files[file]["type"] = "unreadable";
359 # If it's byhand skip remaining checks
360 if files[file]["section"] == "byhand":
361 files[file]["byhand"] = 1;
362 files[file]["type"] = "byhand";
363 # Checks for a binary package...
364 elif utils.re_isadeb.match(file):
366 files[file]["type"] = "deb";
368 # Extract package control information
369 deb_file = utils.open_file(file);
371 control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file));
373 reject("%s: debExtractControl() raised %s." % (file, sys.exc_type));
375 # Can't continue, none of the checks on control would work.
379 # Check for mandatory fields
380 for field in [ "Package", "Architecture", "Version" ]:
381 if control.Find(field) == None:
382 reject("%s: No %s field in control." % (file, field));
386 # Ensure the package name matches the one give in the .changes
387 if not changes["binary"].has_key(control.Find("Package", "")):
388 reject("%s: control file lists name as `%s', which isn't in changes file." % (file, control.Find("Package", "")));
390 # Validate the package field
391 package = control.Find("Package");
392 if not re_valid_pkg_name.match(package):
393 reject("%s: invalid package name '%s'." % (file, package));
395 # Validate the version field
396 version = control.Find("Version");
397 if not re_valid_version.match(version):
398 reject("%s: invalid version number '%s'." % (file, version));
400 # Ensure the architecture of the .deb is one we know about.
401 default_suite = Cnf.get("Dinstall::DefaultSuite", "Unstable")
402 architecture = control.Find("Architecture");
403 if architecture not in Cnf.ValueList("Suite::%s::Architectures" % (default_suite)):
404 reject("Unknown architecture '%s'." % (architecture));
406 # Ensure the architecture of the .deb is one of the ones
407 # listed in the .changes.
408 if not changes["architecture"].has_key(architecture):
409 reject("%s: control file lists arch as `%s', which isn't in changes file." % (file, architecture));
411 # Sanity-check the Depends field
412 depends = control.Find("Depends");
414 reject("%s: Depends field is empty." % (file));
416 # Check the section & priority match those given in the .changes (non-fatal)
417 if control.Find("Section") and files[file]["section"] != "" and files[file]["section"] != control.Find("Section"):
418 reject("%s control file lists section as `%s', but changes file has `%s'." % (file, control.Find("Section", ""), files[file]["section"]), "Warning: ");
419 if control.Find("Priority") and files[file]["priority"] != "" and files[file]["priority"] != control.Find("Priority"):
420 reject("%s control file lists priority as `%s', but changes file has `%s'." % (file, control.Find("Priority", ""), files[file]["priority"]),"Warning: ");
422 files[file]["package"] = package;
423 files[file]["architecture"] = architecture;
424 files[file]["version"] = version;
425 files[file]["maintainer"] = control.Find("Maintainer", "");
426 if file.endswith(".udeb"):
427 files[file]["dbtype"] = "udeb";
428 elif file.endswith(".deb"):
429 files[file]["dbtype"] = "deb";
431 reject("%s is neither a .deb or a .udeb." % (file));
432 files[file]["source"] = control.Find("Source", files[file]["package"]);
433 # Get the source version
434 source = files[file]["source"];
436 if source.find("(") != -1:
437 m = utils.re_extract_src_version.match(source);
439 source_version = m.group(2);
440 if not source_version:
441 source_version = files[file]["version"];
442 files[file]["source package"] = source;
443 files[file]["source version"] = source_version;
445 # Ensure the filename matches the contents of the .deb
446 m = utils.re_isadeb.match(file);
448 file_package = m.group(1);
449 if files[file]["package"] != file_package:
450 reject("%s: package part of filename (%s) does not match package name in the %s (%s)." % (file, file_package, files[file]["dbtype"], files[file]["package"]));
451 epochless_version = utils.re_no_epoch.sub('', control.Find("Version"));
453 file_version = m.group(2);
454 if epochless_version != file_version:
455 reject("%s: version part of filename (%s) does not match package version in the %s (%s)." % (file, file_version, files[file]["dbtype"], epochless_version));
457 file_architecture = m.group(3);
458 if files[file]["architecture"] != file_architecture:
459 reject("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % (file, file_architecture, files[file]["dbtype"], files[file]["architecture"]));
461 # Check for existent source
462 source_version = files[file]["source version"];
463 source_package = files[file]["source package"];
464 if changes["architecture"].has_key("source"):
465 if source_version != changes["version"]:
466 reject("source version (%s) for %s doesn't match changes version %s." % (source_version, file, changes["version"]));
468 # Check in the SQL database
469 if not Katie.source_exists(source_package, source_version, changes["distribution"].keys()):
470 # Check in one of the other directories
471 source_epochless_version = utils.re_no_epoch.sub('', source_version);
472 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version);
473 if os.path.exists(Cnf["Dir::Queue::Byhand"] + '/' + dsc_filename):
474 files[file]["byhand"] = 1;
475 elif os.path.exists(Cnf["Dir::Queue::New"] + '/' + dsc_filename):
476 files[file]["new"] = 1;
477 elif not os.path.exists(Cnf["Dir::Queue::Accepted"] + '/' + dsc_filename):
478 reject("no source found for %s %s (%s)." % (source_package, source_version, file));
479 # Check the version and for file overwrites
480 reject(Katie.check_binary_against_db(file),"");
482 # Checks for a source package...
484 m = utils.re_issource.match(file);
487 files[file]["package"] = m.group(1);
488 files[file]["version"] = m.group(2);
489 files[file]["type"] = m.group(3);
491 # Ensure the source package name matches the Source filed in the .changes
492 if changes["source"] != files[file]["package"]:
493 reject("%s: changes file doesn't say %s for Source" % (file, files[file]["package"]));
495 # Ensure the source version matches the version in the .changes file
496 if files[file]["type"] == "orig.tar.gz":
497 changes_version = changes["chopversion2"];
499 changes_version = changes["chopversion"];
500 if changes_version != files[file]["version"]:
501 reject("%s: should be %s according to changes file." % (file, changes_version));
503 # Ensure the .changes lists source in the Architecture field
504 if not changes["architecture"].has_key("source"):
505 reject("%s: changes file doesn't list `source' in Architecture field." % (file));
507 # Check the signature of a .dsc file
508 if files[file]["type"] == "dsc":
509 dsc["fingerprint"] = utils.check_signature(file, reject);
511 files[file]["architecture"] = "source";
513 # Not a binary or source package? Assume byhand...
515 files[file]["byhand"] = 1;
516 files[file]["type"] = "byhand";
518 # Per-suite file checks
519 files[file]["oldfiles"] = {};
520 for suite in changes["distribution"].keys():
522 if files[file].has_key("byhand"):
525 # Handle component mappings
526 for map in Cnf.ValueList("ComponentMappings"):
527 (source, dest) = map.split();
528 if files[file]["component"] == source:
529 files[file]["original component"] = source;
530 files[file]["component"] = dest;
532 # Ensure the component is valid for the target suite
533 if Cnf.has_key("Suite:%s::Components" % (suite)) and \
534 files[file]["component"] not in Cnf.ValueList("Suite::%s::Components" % (suite)):
535 reject("unknown component `%s' for suite `%s'." % (files[file]["component"], suite));
538 # Validate the component
539 component = files[file]["component"];
540 component_id = db_access.get_component_id(component);
541 if component_id == -1:
542 reject("file '%s' has unknown component '%s'." % (file, component));
545 # See if the package is NEW
546 if not Katie.in_override_p(files[file]["package"], files[file]["component"], suite, files[file].get("dbtype",""), file):
547 files[file]["new"] = 1;
549 # Validate the priority
550 if files[file]["priority"].find('/') != -1:
551 reject("file '%s' has invalid priority '%s' [contains '/']." % (file, files[file]["priority"]));
553 # Determine the location
554 location = Cnf["Dir::Pool"];
555 location_id = db_access.get_location_id (location, component, archive);
556 if location_id == -1:
557 reject("[INTERNAL ERROR] couldn't determine location (Component: %s, Archive: %s)" % (component, archive));
558 files[file]["location id"] = location_id;
560 # Check the md5sum & size against existing files (if any)
561 files[file]["pool name"] = utils.poolify (changes["source"], files[file]["component"]);
562 files_id = db_access.get_files_id(files[file]["pool name"] + file, files[file]["size"], files[file]["md5sum"], files[file]["location id"]);
564 reject("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (file));
566 reject("md5sum and/or size mismatch on existing copy of %s." % (file));
567 files[file]["files id"] = files_id
569 # Check for packages that have moved from one component to another
570 q = Katie.projectB.query("""
571 SELECT c.name FROM binaries b, bin_associations ba, suite s, location l,
572 component c, architecture a, files f
573 WHERE b.package = '%s' AND s.suite_name = '%s'
574 AND (a.arch_string = '%s' OR a.arch_string = 'all')
575 AND ba.bin = b.id AND ba.suite = s.id AND b.architecture = a.id
576 AND f.location = l.id AND l.component = c.id AND b.file = f.id"""
577 % (files[file]["package"], suite,
578 files[file]["architecture"]));
581 files[file]["othercomponents"] = ql[0][0];
583 # If the .changes file says it has source, it must have source.
584 if changes["architecture"].has_key("source"):
586 reject("no source found and Architecture line in changes mention source.");
588 if not has_binaries and Cnf.FindB("Dinstall::Reject::NoSourceOnly"):
589 reject("source only uploads are not supported.");
591 ###############################################################################
596 # Ensure there is source to check
597 if not changes["architecture"].has_key("source"):
602 for file in files.keys():
603 if files[file]["type"] == "dsc":
605 reject("can not process a .changes file with multiple .dsc's.");
610 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
614 # Parse the .dsc file
616 dsc.update(utils.parse_changes(dsc_filename, signing_rules=1));
617 except utils.cant_open_exc:
618 # if not -n copy_to_holding() will have done this for us...
619 if Options["No-Action"]:
620 reject("%s: can't read file." % (dsc_filename));
621 except utils.changes_parse_error_exc, line:
622 reject("%s: parse error, can't grok: %s." % (dsc_filename, line));
623 except utils.invalid_dsc_format_exc, line:
624 reject("%s: syntax error on line %s." % (dsc_filename, line));
625 # Build up the file list of files mentioned by the .dsc
627 dsc_files.update(utils.build_file_list(dsc, is_a_dsc=1));
628 except utils.no_files_exc:
629 reject("%s: no Files: field." % (dsc_filename));
631 except utils.changes_parse_error_exc, line:
632 reject("%s: parse error, can't grok: %s." % (dsc_filename, line));
635 # Enforce mandatory fields
636 for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
637 if not dsc.has_key(i):
638 reject("%s: missing mandatory field `%s'." % (dsc_filename, i));
641 # Validate the source and version fields
642 if not re_valid_pkg_name.match(dsc["source"]):
643 reject("%s: invalid source name '%s'." % (dsc_filename, dsc["source"]));
644 if not re_valid_version.match(dsc["version"]):
645 reject("%s: invalid version number '%s'." % (dsc_filename, dsc["version"]));
647 # Bumping the version number of the .dsc breaks extraction by stable's
648 # dpkg-source. So let's not do that...
649 if dsc["format"] != "1.0":
650 reject("%s: incompatible 'Format' version produced by a broken version of dpkg-dev 1.9.1{3,4}." % (dsc_filename));
652 # Validate the Maintainer field
654 utils.fix_maintainer (dsc["maintainer"]);
655 except utils.ParseMaintError, msg:
656 reject("%s: Maintainer field ('%s') failed to parse: %s" \
657 % (dsc_filename, dsc["maintainer"], msg));
659 # Validate the build-depends field(s)
660 for field_name in [ "build-depends", "build-depends-indep" ]:
661 field = dsc.get(field_name);
663 # Check for broken dpkg-dev lossage...
664 if field.startswith("ARRAY"):
665 reject("%s: invalid %s field produced by a broken version of dpkg-dev (1.10.11)" % (dsc_filename, field_name.title()));
667 # Have apt try to parse them...
669 apt_pkg.ParseSrcDepends(field);
671 reject("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()));
674 # Ensure the version number in the .dsc matches the version number in the .changes
675 epochless_dsc_version = utils.re_no_epoch.sub('', dsc["version"]);
676 changes_version = files[dsc_filename]["version"];
677 if epochless_dsc_version != files[dsc_filename]["version"]:
678 reject("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version));
680 # Ensure there is a .tar.gz in the .dsc file
682 for f in dsc_files.keys():
683 m = utils.re_issource.match(f);
685 reject("%s: %s in Files field not recognised as source." % (dsc_filename, f));
687 if type == "orig.tar.gz" or type == "tar.gz":
690 reject("%s: no .tar.gz or .orig.tar.gz in 'Files' field." % (dsc_filename));
692 # Ensure source is newer than existing source in target suites
693 reject(Katie.check_source_against_db(dsc_filename),"");
695 (reject_msg, is_in_incoming) = Katie.check_dsc_against_db(dsc_filename);
696 reject(reject_msg, "");
698 if not Options["No-Action"]:
699 copy_to_holding(is_in_incoming);
700 orig_tar_gz = os.path.basename(is_in_incoming);
701 files[orig_tar_gz] = {};
702 files[orig_tar_gz]["size"] = os.stat(orig_tar_gz)[stat.ST_SIZE];
703 files[orig_tar_gz]["md5sum"] = dsc_files[orig_tar_gz]["md5sum"];
704 files[orig_tar_gz]["section"] = files[dsc_filename]["section"];
705 files[orig_tar_gz]["priority"] = files[dsc_filename]["priority"];
706 files[orig_tar_gz]["component"] = files[dsc_filename]["component"];
707 files[orig_tar_gz]["type"] = "orig.tar.gz";
712 ################################################################################
714 def get_changelog_versions(source_dir):
715 """Extracts a the source package and (optionally) grabs the
716 version history out of debian/changelog for the BTS."""
718 # Find the .dsc (again)
720 for file in files.keys():
721 if files[file]["type"] == "dsc":
724 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
728 # Create a symlink mirror of the source files in our temporary directory
729 for f in files.keys():
730 m = utils.re_issource.match(f);
732 src = os.path.join(source_dir, f);
733 # If a file is missing for whatever reason, give up.
734 if not os.path.exists(src):
737 if type == "orig.tar.gz" and pkg.orig_tar_gz:
739 dest = os.path.join(os.getcwd(), f);
740 os.symlink(src, dest);
742 # If the orig.tar.gz is not a part of the upload, create a symlink to the
745 dest = os.path.join(os.getcwd(), os.path.basename(pkg.orig_tar_gz));
746 os.symlink(pkg.orig_tar_gz, dest);
749 cmd = "dpkg-source -sn -x %s" % (dsc_filename);
750 (result, output) = commands.getstatusoutput(cmd);
752 reject("'dpkg-source -x' failed for %s [return code: %s]." % (dsc_filename, result));
753 reject(utils.prefix_multi_line_string(output, " [dpkg-source output:] "), "");
756 if not Cnf.Find("Dir::Queue::BTSVersionTrack"):
759 # Get the upstream version
760 upstr_version = utils.re_no_epoch.sub('', dsc["version"]);
761 if re_strip_revision.search(upstr_version):
762 upstr_version = re_strip_revision.sub('', upstr_version);
764 # Ensure the changelog file exists
765 changelog_filename = "%s-%s/debian/changelog" % (dsc["source"], upstr_version);
766 if not os.path.exists(changelog_filename):
767 reject("%s: debian/changelog not found in extracted source." % (dsc_filename));
770 # Parse the changelog
771 dsc["bts changelog"] = "";
772 changelog_file = utils.open_file(changelog_filename);
773 for line in changelog_file.readlines():
774 m = re_changelog_versions.match(line);
776 dsc["bts changelog"] += line;
777 changelog_file.close();
779 # Check we found at least one revision in the changelog
780 if not dsc["bts changelog"]:
781 reject("%s: changelog format not recognised (empty version tree)." % (dsc_filename));
783 ########################################
787 # a) there's no source
788 # or b) reprocess is 2 - we will do this check next time when orig.tar.gz is in 'files'
789 # or c) the orig.tar.gz is MIA
790 if not changes["architecture"].has_key("source") or reprocess == 2 \
791 or pkg.orig_tar_gz == -1:
794 # Create a temporary directory to extract the source into
795 if Options["No-Action"]:
796 tmpdir = tempfile.mktemp();
798 # We're in queue/holding and can create a random directory.
799 tmpdir = "%s" % (os.getpid());
802 # Move into the temporary directory
806 # Get the changelog version history
807 get_changelog_versions(cwd);
809 # Move back and cleanup the temporary tree
812 shutil.rmtree(tmpdir);
814 if errno.errorcode[e.errno] != 'EACCES':
815 utils.fubar("%s: couldn't remove tmp dir for source tree." % (dsc["source"]));
817 reject("%s: source tree could not be cleanly removed." % (dsc["source"]));
818 # We probably have u-r or u-w directories so chmod everything
820 cmd = "chmod -R u+rwx %s" % (tmpdir)
821 result = os.system(cmd)
823 utils.fubar("'%s' failed with result %s." % (cmd, result));
824 shutil.rmtree(tmpdir);
826 utils.fubar("%s: couldn't remove tmp dir for source tree." % (dsc["source"]));
828 ################################################################################
830 # FIXME: should be a debian specific check called from a hook
832 def check_urgency ():
833 if changes["architecture"].has_key("source"):
834 if not changes.has_key("urgency"):
835 changes["urgency"] = Cnf["Urgency::Default"];
836 if changes["urgency"] not in Cnf.ValueList("Urgency::Valid"):
837 reject("%s is not a valid urgency; it will be treated as %s by testing." % (changes["urgency"], Cnf["Urgency::Default"]), "Warning: ");
838 changes["urgency"] = Cnf["Urgency::Default"];
839 changes["urgency"] = changes["urgency"].lower();
841 ################################################################################
843 def check_md5sums ():
844 for file in files.keys():
846 file_handle = utils.open_file(file);
847 except utils.cant_open_exc:
851 if apt_pkg.md5sum(file_handle) != files[file]["md5sum"]:
852 reject("%s: md5sum check failed." % (file));
855 actual_size = os.stat(file)[stat.ST_SIZE];
856 size = int(files[file]["size"]);
857 if size != actual_size:
858 reject("%s: actual file size (%s) does not match size (%s) in .changes"
859 % (file, actual_size, size));
861 for file in dsc_files.keys():
863 file_handle = utils.open_file(file);
864 except utils.cant_open_exc:
868 if apt_pkg.md5sum(file_handle) != dsc_files[file]["md5sum"]:
869 reject("%s: md5sum check failed." % (file));
872 actual_size = os.stat(file)[stat.ST_SIZE];
873 size = int(dsc_files[file]["size"]);
874 if size != actual_size:
875 reject("%s: actual file size (%s) does not match size (%s) in .dsc"
876 % (file, actual_size, size));
878 ################################################################################
880 # Sanity check the time stamps of files inside debs.
881 # [Files in the near future cause ugly warnings and extreme time
882 # travel can cause errors on extraction]
884 def check_timestamps():
886 def __init__(self, future_cutoff, past_cutoff):
888 self.future_cutoff = future_cutoff;
889 self.past_cutoff = past_cutoff;
892 self.future_files = {};
893 self.ancient_files = {};
895 def callback(self, Kind,Name,Link,Mode,UID,GID,Size,MTime,Major,Minor):
896 if MTime > self.future_cutoff:
897 self.future_files[Name] = MTime;
898 if MTime < self.past_cutoff:
899 self.ancient_files[Name] = MTime;
902 future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"]);
903 past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"));
904 tar = Tar(future_cutoff, past_cutoff);
905 for filename in files.keys():
906 if files[filename]["type"] == "deb":
909 deb_file = utils.open_file(filename);
910 apt_inst.debExtract(deb_file,tar.callback,"control.tar.gz");
912 apt_inst.debExtract(deb_file,tar.callback,"data.tar.gz");
915 future_files = tar.future_files.keys();
917 num_future_files = len(future_files);
918 future_file = future_files[0];
919 future_date = tar.future_files[future_file];
920 reject("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
921 % (filename, num_future_files, future_file,
922 time.ctime(future_date)));
924 ancient_files = tar.ancient_files.keys();
926 num_ancient_files = len(ancient_files);
927 ancient_file = ancient_files[0];
928 ancient_date = tar.ancient_files[ancient_file];
929 reject("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
930 % (filename, num_ancient_files, ancient_file,
931 time.ctime(ancient_date)));
933 reject("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value));
935 ################################################################################
936 ################################################################################
938 # If any file of an upload has a recent mtime then chances are good
939 # the file is still being uploaded.
941 def upload_too_new():
943 # Move back to the original directory to get accurate time stamps
945 os.chdir(pkg.directory);
946 file_list = pkg.files.keys();
947 file_list.extend(pkg.dsc_files.keys());
948 file_list.append(pkg.changes_file);
949 for file in file_list:
951 last_modified = time.time()-os.path.getmtime(file);
952 if last_modified < int(Cnf["Dinstall::SkipTime"]):
960 ################################################################################
963 # changes["distribution"] may not exist in corner cases
964 # (e.g. unreadable changes files)
965 if not changes.has_key("distribution") or not isinstance(changes["distribution"], DictType):
966 changes["distribution"] = {};
968 (summary, short_summary) = Katie.build_summaries();
971 for file in files.keys():
972 if files[file].has_key("byhand"):
974 elif files[file].has_key("new"):
977 (prompt, answer) = ("", "XXX")
978 if Options["No-Action"] or Options["Automatic"]:
981 if reject_message.find("Rejected") != -1:
983 print "SKIP (too new)\n" + reject_message,;
984 prompt = "[S]kip, Quit ?";
986 print "REJECT\n" + reject_message,;
987 prompt = "[R]eject, Skip, Quit ?";
988 if Options["Automatic"]:
991 print "NEW to %s\n%s%s" % (", ".join(changes["distribution"].keys()), reject_message, summary),;
992 prompt = "[N]ew, Skip, Quit ?";
993 if Options["Automatic"]:
996 print "BYHAND\n" + reject_message + summary,;
997 prompt = "[B]yhand, Skip, Quit ?";
998 if Options["Automatic"]:
1001 print "ACCEPT\n" + reject_message + summary,;
1002 prompt = "[A]ccept, Skip, Quit ?";
1003 if Options["Automatic"]:
1006 while prompt.find(answer) == -1:
1007 answer = utils.our_raw_input(prompt);
1008 m = katie.re_default_answer.match(prompt);
1010 answer = m.group(1);
1011 answer = answer[:1].upper();
1014 os.chdir (pkg.directory);
1015 Katie.do_reject(0, reject_message);
1017 accept(summary, short_summary);
1021 acknowledge_new (summary);
1025 ################################################################################
1027 def accept (summary, short_summary):
1028 Katie.accept(summary, short_summary);
1029 Katie.check_override();
1031 # Finally, remove the originals from the unchecked directory
1032 os.chdir (pkg.directory);
1033 for file in files.keys():
1035 os.unlink(pkg.changes_file);
1037 ################################################################################
1039 def do_byhand (summary):
1040 print "Moving to BYHAND holding area."
1041 Logger.log(["Moving to byhand", pkg.changes_file]);
1043 Katie.dump_vars(Cnf["Dir::Queue::Byhand"]);
1045 file_keys = files.keys();
1047 # Move all the files into the byhand directory
1048 utils.move (pkg.changes_file, Cnf["Dir::Queue::Byhand"]);
1049 for file in file_keys:
1050 utils.move (file, Cnf["Dir::Queue::Byhand"], perms=0660);
1052 # Check for override disparities
1053 Katie.Subst["__SUMMARY__"] = summary;
1054 Katie.check_override();
1056 # Finally remove the originals.
1057 os.chdir (pkg.directory);
1058 for file in file_keys:
1060 os.unlink(pkg.changes_file);
1062 ################################################################################
1064 def acknowledge_new (summary):
1065 Subst = Katie.Subst;
1067 print "Moving to NEW holding area."
1068 Logger.log(["Moving to new", pkg.changes_file]);
1070 Katie.dump_vars(Cnf["Dir::Queue::New"]);
1072 file_keys = files.keys();
1074 # Move all the files into the 'new' directory
1075 utils.move (pkg.changes_file, Cnf["Dir::Queue::New"]);
1076 for file in file_keys:
1077 utils.move (file, Cnf["Dir::Queue::New"], perms=0660);
1079 if not Options["No-Mail"]:
1080 print "Sending new ack.";
1081 Subst["__SUMMARY__"] = summary;
1082 new_ack_message = utils.TemplateSubst(Subst,Cnf["Dir::Templates"]+"/jennifer.new");
1083 utils.send_mail(new_ack_message);
1085 # Finally remove the originals.
1086 os.chdir (pkg.directory);
1087 for file in file_keys:
1089 os.unlink(pkg.changes_file);
1091 ################################################################################
1093 # reprocess is necessary for the case of foo_1.2-1 and foo_1.2-2 in
1094 # Incoming. -1 will reference the .orig.tar.gz, but -2 will not.
1095 # Katie.check_dsc_against_db() can find the .orig.tar.gz but it will
1096 # not have processed it during it's checks of -2. If -1 has been
1097 # deleted or otherwise not checked by jennifer, the .orig.tar.gz will
1098 # not have been checked at all. To get round this, we force the
1099 # .orig.tar.gz into the .changes structure and reprocess the .changes
1102 def process_it (changes_file):
1103 global reprocess, reject_message;
1105 # Reset some globals
1108 # Some defaults in case we can't fully process the .changes file
1109 changes["maintainer2047"] = Cnf["Dinstall::MyEmailAddress"];
1110 changes["changedby2047"] = Cnf["Dinstall::MyEmailAddress"];
1111 reject_message = "";
1113 # Absolutize the filename to avoid the requirement of being in the
1114 # same directory as the .changes file.
1115 pkg.changes_file = os.path.abspath(changes_file);
1117 # Remember where we are so we can come back after cd-ing into the
1118 # holding directory.
1119 pkg.directory = os.getcwd();
1122 # If this is the Real Thing(tm), copy things into a private
1123 # holding directory first to avoid replacable file races.
1124 if not Options["No-Action"]:
1125 os.chdir(Cnf["Dir::Queue::Holding"]);
1126 copy_to_holding(pkg.changes_file);
1127 # Relativize the filename so we use the copy in holding
1128 # rather than the original...
1129 pkg.changes_file = os.path.basename(pkg.changes_file);
1130 changes["fingerprint"] = utils.check_signature(pkg.changes_file, reject);
1131 if changes["fingerprint"]:
1132 valid_changes_p = check_changes();
1134 valid_changes_p = 0;
1137 check_distributions();
1139 valid_dsc_p = check_dsc();
1145 Katie.update_subst(reject_message);
1151 traceback.print_exc(file=sys.stderr);
1154 # Restore previous WD
1155 os.chdir(pkg.directory);
1157 ###############################################################################
1160 global Cnf, Options, Logger;
1162 changes_files = init();
1164 # -n/--dry-run invalidates some other options which would involve things happening
1165 if Options["No-Action"]:
1166 Options["Automatic"] = "";
1168 # Ensure all the arguments we were given are .changes files
1169 for file in changes_files:
1170 if not file.endswith(".changes"):
1171 utils.warn("Ignoring '%s' because it's not a .changes file." % (file));
1172 changes_files.remove(file);
1174 if changes_files == []:
1175 utils.fubar("Need at least one .changes file as an argument.");
1177 # Check that we aren't going to clash with the daily cron job
1179 if not Options["No-Action"] and os.path.exists("%s/Archive_Maintenance_In_Progress" % (Cnf["Dir::Root"])) and not Options["No-Lock"]:
1180 utils.fubar("Archive maintenance in progress. Try again later.");
1182 # Obtain lock if not in no-action mode and initialize the log
1184 if not Options["No-Action"]:
1185 lock_fd = os.open(Cnf["Dinstall::LockFile"], os.O_RDWR | os.O_CREAT);
1187 fcntl.lockf(lock_fd, fcntl.LOCK_EX | fcntl.LOCK_NB);
1189 if errno.errorcode[e.errno] == 'EACCES' or errno.errorcode[e.errno] == 'EAGAIN':
1190 utils.fubar("Couldn't obtain lock; assuming another jennifer is already running.");
1193 Logger = Katie.Logger = logging.Logger(Cnf, "jennifer");
1195 # debian-{devel-,}-changes@lists.debian.org toggles writes access based on this header
1196 bcc = "X-Katie: %s" % (jennifer_version);
1197 if Cnf.has_key("Dinstall::Bcc"):
1198 Katie.Subst["__BCC__"] = bcc + "\nBcc: %s" % (Cnf["Dinstall::Bcc"]);
1200 Katie.Subst["__BCC__"] = bcc;
1203 # Sort the .changes files so that we process sourceful ones first
1204 changes_files.sort(utils.changes_compare);
1206 # Process the changes files
1207 for changes_file in changes_files:
1208 print "\n" + changes_file;
1210 process_it (changes_file);
1212 if not Options["No-Action"]:
1215 accept_count = Katie.accept_count;
1216 accept_bytes = Katie.accept_bytes;
1219 if accept_count > 1:
1221 print "Accepted %d package %s, %s." % (accept_count, sets, utils.size_type(int(accept_bytes)));
1222 Logger.log(["total",accept_count,accept_bytes]);
1224 if not Options["No-Action"]:
1227 ################################################################################
1229 if __name__ == '__main__':