3 # Checks Debian packages from Incoming
4 # Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005 James Troup <james@nocrew.org>
5 # $Id: jennifer,v 1.56 2005-01-18 22:18:31 troup Exp $
7 # This program is free software; you can redistribute it and/or modify
8 # it under the terms of the GNU General Public License as published by
9 # the Free Software Foundation; either version 2 of the License, or
10 # (at your option) any later version.
12 # This program is distributed in the hope that it will be useful,
13 # but WITHOUT ANY WARRANTY; without even the implied warranty of
14 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 # GNU General Public License for more details.
17 # You should have received a copy of the GNU General Public License
18 # along with this program; if not, write to the Free Software
19 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
21 # Originally based on dinstall by Guy Maor <maor@debian.org>
23 ################################################################################
25 # Computer games don't affect kids. I mean if Pacman affected our generation as
26 # kids, we'd all run around in a darkened room munching pills and listening to
30 ################################################################################
32 import commands, errno, fcntl, os, re, shutil, stat, sys, time, tempfile, traceback;
33 import apt_inst, apt_pkg;
34 import db_access, katie, logging, utils;
38 ################################################################################
40 re_valid_version = re.compile(r"^([0-9]+:)?[0-9A-Za-z\.\-\+:]+$");
41 re_valid_pkg_name = re.compile(r"^[\dA-Za-z][\dA-Za-z\+\-\.]+$");
42 re_changelog_versions = re.compile(r"^\w[-+0-9a-z.]+ \([^\(\) \t]+\)");
43 re_strip_revision = re.compile(r"-([^-]+)$");
45 ################################################################################
48 jennifer_version = "$Revision: 1.56 $";
58 # Aliases to the real vars in the Katie class; hysterical raisins.
66 ###############################################################################
69 global Cnf, Options, Katie, changes, dsc, dsc_files, files, pkg;
73 Cnf = apt_pkg.newConfiguration();
74 apt_pkg.ReadConfigFileISC(Cnf,utils.which_conf_file());
76 Arguments = [('a',"automatic","Dinstall::Options::Automatic"),
77 ('h',"help","Dinstall::Options::Help"),
78 ('n',"no-action","Dinstall::Options::No-Action"),
79 ('p',"no-lock", "Dinstall::Options::No-Lock"),
80 ('s',"no-mail", "Dinstall::Options::No-Mail"),
81 ('V',"version","Dinstall::Options::Version")];
83 for i in ["automatic", "help", "no-action", "no-lock", "no-mail",
84 "override-distribution", "version"]:
85 Cnf["Dinstall::Options::%s" % (i)] = "";
87 changes_files = apt_pkg.ParseCommandLine(Cnf,Arguments,sys.argv);
88 Options = Cnf.SubTree("Dinstall::Options")
92 elif Options["Version"]:
93 print "jennifer %s" % (jennifer_version);
96 Katie = katie.Katie(Cnf);
98 changes = Katie.pkg.changes;
100 dsc_files = Katie.pkg.dsc_files;
101 files = Katie.pkg.files;
104 return changes_files;
106 ################################################################################
108 def usage (exit_code=0):
109 print """Usage: dinstall [OPTION]... [CHANGES]...
110 -a, --automatic automatic run
111 -h, --help show this help and exit.
112 -n, --no-action don't do anything
113 -p, --no-lock don't check lockfile !! for cron.daily only !!
114 -s, --no-mail don't send any mail
115 -V, --version display the version number and exit"""
118 ################################################################################
120 def reject (str, prefix="Rejected: "):
121 global reject_message;
123 reject_message += prefix + str + "\n";
125 ################################################################################
127 def copy_to_holding(filename):
130 base_filename = os.path.basename(filename);
132 dest = Cnf["Dir::Queue::Holding"] + '/' + base_filename;
134 fd = os.open(dest, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0640);
137 # Shouldn't happen, but will if, for example, someone lists a
138 # file twice in the .changes.
139 if errno.errorcode[e.errno] == 'EEXIST':
140 reject("%s: already exists in holding area; can not overwrite." % (base_filename));
145 shutil.copy(filename, dest);
147 # In either case (ENOENT or EACCES) we want to remove the
148 # O_CREAT | O_EXCLed ghost file, so add the file to the list
149 # of 'in holding' even if it's not the real file.
150 if errno.errorcode[e.errno] == 'ENOENT':
151 reject("%s: can not copy to holding area: file not found." % (base_filename));
154 elif errno.errorcode[e.errno] == 'EACCES':
155 reject("%s: can not copy to holding area: read permission denied." % (base_filename));
160 in_holding[base_filename] = "";
162 ################################################################################
168 os.chdir(Cnf["Dir::Queue::Holding"]);
169 for file in in_holding.keys():
170 if os.path.exists(file):
171 if file.find('/') != -1:
172 utils.fubar("WTF? clean_holding() got a file ('%s') with / in it!" % (file));
178 ################################################################################
181 filename = pkg.changes_file;
183 # Parse the .changes field into a dictionary
185 changes.update(utils.parse_changes(filename));
186 except utils.cant_open_exc:
187 reject("%s: can't read file." % (filename));
189 except utils.changes_parse_error_exc, line:
190 reject("%s: parse error, can't grok: %s." % (filename, line));
193 # Parse the Files field from the .changes into another dictionary
195 files.update(utils.build_file_list(changes));
196 except utils.changes_parse_error_exc, line:
197 reject("%s: parse error, can't grok: %s." % (filename, line));
198 except utils.nk_format_exc, format:
199 reject("%s: unknown format '%s'." % (filename, format));
202 # Check for mandatory fields
203 for i in ("source", "binary", "architecture", "version", "distribution",
204 "maintainer", "files", "changes"):
205 if not changes.has_key(i):
206 reject("%s: Missing mandatory field `%s'." % (filename, i));
207 return 0 # Avoid <undef> errors during later tests
209 # Split multi-value fields into a lower-level dictionary
210 for i in ("architecture", "distribution", "binary", "closes"):
211 o = changes.get(i, "")
218 # Fix the Maintainer: field to be RFC822/2047 compatible
220 (changes["maintainer822"], changes["maintainer2047"],
221 changes["maintainername"], changes["maintaineremail"]) = \
222 utils.fix_maintainer (changes["maintainer"]);
223 except utils.ParseMaintError, msg:
224 reject("%s: Maintainer field ('%s') failed to parse: %s" \
225 % (filename, changes["maintainer"], msg));
227 # ...likewise for the Changed-By: field if it exists.
229 (changes["changedby822"], changes["changedby2047"],
230 changes["changedbyname"], changes["changedbyemail"]) = \
231 utils.fix_maintainer (changes.get("changed-by", ""));
232 except utils.ParseMaintError, msg:
233 reject("%s: Changed-By field ('%s') failed to parse: %s" \
234 % (filename, changes["changed-by"], msg));
236 # Ensure all the values in Closes: are numbers
237 if changes.has_key("closes"):
238 for i in changes["closes"].keys():
239 if katie.re_isanum.match (i) == None:
240 reject("%s: `%s' from Closes field isn't a number." % (filename, i));
243 # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
244 changes["chopversion"] = utils.re_no_epoch.sub('', changes["version"])
245 changes["chopversion2"] = utils.re_no_revision.sub('', changes["chopversion"])
247 # Check there isn't already a changes file of the same name in one
248 # of the queue directories.
249 base_filename = os.path.basename(filename);
250 for dir in [ "Accepted", "Byhand", "Done", "New" ]:
251 if os.path.exists(Cnf["Dir::Queue::%s" % (dir) ]+'/'+base_filename):
252 reject("%s: a file with this name already exists in the %s directory." % (base_filename, dir));
254 # Check the .changes is non-empty
256 reject("%s: nothing to do (Files field is empty)." % (base_filename))
261 ################################################################################
263 def check_distributions():
264 "Check and map the Distribution field of a .changes file."
266 # Handle suite mappings
267 for map in Cnf.ValueList("SuiteMappings"):
270 if type == "map" or type == "silent-map":
271 (source, dest) = args[1:3];
272 if changes["distribution"].has_key(source):
273 del changes["distribution"][source]
274 changes["distribution"][dest] = 1;
275 if type != "silent-map":
276 reject("Mapping %s to %s." % (source, dest),"");
277 if changes.has_key("distribution-version"):
278 if changes["distribution-version"].has_key(source):
279 changes["distribution-version"][source]=dest
280 elif type == "map-unreleased":
281 (source, dest) = args[1:3];
282 if changes["distribution"].has_key(source):
283 for arch in changes["architecture"].keys():
284 if arch not in Cnf.ValueList("Suite::%s::Architectures" % (source)):
285 reject("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch),"");
286 del changes["distribution"][source];
287 changes["distribution"][dest] = 1;
289 elif type == "ignore":
291 if changes["distribution"].has_key(suite):
292 del changes["distribution"][suite];
293 reject("Ignoring %s as a target suite." % (suite), "Warning: ");
294 elif type == "reject":
296 if changes["distribution"].has_key(suite):
297 reject("Uploads to %s are not accepted." % (suite));
298 elif type == "propup-version":
299 # give these as "uploaded-to(non-mapped) suites-to-add-when-upload-obsoletes"
301 # changes["distribution-version"] looks like: {'testing': 'testing-proposed-updates'}
302 if args[1] in changes["distribution"]:
303 changes.setdefault("distribution-version", {})
304 for suite in args[2:]: changes["distribution-version"][suite]=suite
306 # Ensure there is (still) a target distribution
307 if changes["distribution"].keys() == []:
308 reject("no valid distribution.");
310 # Ensure target distributions exist
311 for suite in changes["distribution"].keys():
312 if not Cnf.has_key("Suite::%s" % (suite)):
313 reject("Unknown distribution `%s'." % (suite));
315 ################################################################################
317 def check_deb_ar(filename, control):
318 """Sanity check the ar of a .deb, i.e. that there is:
322 o data.tar.gz or data.tar.bz2
324 in that order, and nothing else. If the third member is a
325 data.tar.bz2, an additional check is performed for the required
326 Pre-Depends on dpkg (>= 1.10.24)."""
327 cmd = "ar t %s" % (filename)
328 (result, output) = commands.getstatusoutput(cmd)
330 reject("%s: 'ar t' invocation failed." % (filename))
331 reject(utils.prefix_multi_line_string(output, " [ar output:] "), "")
332 chunks = output.split('\n')
334 reject("%s: found %d chunks, expected 3." % (filename, len(chunks)))
335 if chunks[0] != "debian-binary":
336 reject("%s: first chunk is '%s', expected 'debian-binary'." % (filename, chunks[0]))
337 if chunks[1] != "control.tar.gz":
338 reject("%s: second chunk is '%s', expected 'control.tar.gz'." % (filename, chunks[1]))
339 if chunks[2] == "data.tar.bz2":
340 # Packages using bzip2 compression must have a Pre-Depends on dpkg >= 1.10.24.
341 found_needed_predep = 0
342 for parsed_dep in apt_pkg.ParseDepends(control.Find("Pre-Depends", "")):
343 for atom in parsed_dep:
344 (dep, version, constraint) = atom
345 if dep != "dpkg" or (constraint != ">=" and constraint != ">>") or \
346 len(parsed_dep) > 1: # or'ed deps don't count
348 if (constraint == ">=" and apt_pkg.VersionCompare(version, "1.10.24") < 0) or \
349 (constraint == ">>" and apt_pkg.VersionCompare(version, "1.10.23") < 0):
351 found_needed_predep = 1
352 if not found_needed_predep:
353 reject("%s: uses bzip2 compression, but doesn't Pre-Depend on dpkg (>= 1.10.24)" % (filename))
354 elif chunks[2] != "data.tar.gz":
355 reject("%s: third chunk is '%s', expected 'data.tar.gz' or 'data.tar.bz2'." % (filename, chunks[2]))
357 ################################################################################
362 archive = utils.where_am_i();
363 file_keys = files.keys();
365 # if reprocess is 2 we've already done this and we're checking
366 # things again for the new .orig.tar.gz.
367 # [Yes, I'm fully aware of how disgusting this is]
368 if not Options["No-Action"] and reprocess < 2:
370 os.chdir(pkg.directory);
371 for file in file_keys:
372 copy_to_holding(file);
375 # Check there isn't already a .changes or .katie file of the same name in
376 # the proposed-updates "CopyChanges" or "CopyKatie" storage directories.
377 # [NB: this check must be done post-suite mapping]
378 base_filename = os.path.basename(pkg.changes_file);
379 katie_filename = base_filename[:-8]+".katie"
380 for suite in changes["distribution"].keys():
381 copychanges = "Suite::%s::CopyChanges" % (suite);
382 if Cnf.has_key(copychanges) and \
383 os.path.exists(Cnf[copychanges]+"/"+base_filename):
384 reject("%s: a file with this name already exists in %s" \
385 % (base_filename, Cnf[copychanges]));
387 copykatie = "Suite::%s::CopyKatie" % (suite);
388 if Cnf.has_key(copykatie) and \
389 os.path.exists(Cnf[copykatie]+"/"+katie_filename):
390 reject("%s: a file with this name already exists in %s" \
391 % (katie_filename, Cnf[copykatie]));
397 for file in file_keys:
398 # Ensure the file does not already exist in one of the accepted directories
399 for dir in [ "Accepted", "Byhand", "New" ]:
400 if os.path.exists(Cnf["Dir::Queue::%s" % (dir) ]+'/'+file):
401 reject("%s file already exists in the %s directory." % (file, dir));
402 if not utils.re_taint_free.match(file):
403 reject("!!WARNING!! tainted filename: '%s'." % (file));
404 # Check the file is readable
405 if os.access(file,os.R_OK) == 0:
406 # When running in -n, copy_to_holding() won't have
407 # generated the reject_message, so we need to.
408 if Options["No-Action"]:
409 if os.path.exists(file):
410 reject("Can't read `%s'. [permission denied]" % (file));
412 reject("Can't read `%s'. [file not found]" % (file));
413 files[file]["type"] = "unreadable";
415 # If it's byhand skip remaining checks
416 if files[file]["section"] == "byhand" or files[file]["section"] == "raw-installer":
417 files[file]["byhand"] = 1;
418 files[file]["type"] = "byhand";
419 # Checks for a binary package...
420 elif utils.re_isadeb.match(file):
422 files[file]["type"] = "deb";
424 # Extract package control information
425 deb_file = utils.open_file(file);
427 control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file));
429 reject("%s: debExtractControl() raised %s." % (file, sys.exc_type));
431 # Can't continue, none of the checks on control would work.
435 # Check for mandatory fields
436 for field in [ "Package", "Architecture", "Version" ]:
437 if control.Find(field) == None:
438 reject("%s: No %s field in control." % (file, field));
442 # Ensure the package name matches the one give in the .changes
443 if not changes["binary"].has_key(control.Find("Package", "")):
444 reject("%s: control file lists name as `%s', which isn't in changes file." % (file, control.Find("Package", "")));
446 # Validate the package field
447 package = control.Find("Package");
448 if not re_valid_pkg_name.match(package):
449 reject("%s: invalid package name '%s'." % (file, package));
451 # Validate the version field
452 version = control.Find("Version");
453 if not re_valid_version.match(version):
454 reject("%s: invalid version number '%s'." % (file, version));
456 # Ensure the architecture of the .deb is one we know about.
457 default_suite = Cnf.get("Dinstall::DefaultSuite", "Unstable")
458 architecture = control.Find("Architecture");
459 if architecture not in Cnf.ValueList("Suite::%s::Architectures" % (default_suite)):
460 reject("Unknown architecture '%s'." % (architecture));
462 # Ensure the architecture of the .deb is one of the ones
463 # listed in the .changes.
464 if not changes["architecture"].has_key(architecture):
465 reject("%s: control file lists arch as `%s', which isn't in changes file." % (file, architecture));
467 # Sanity-check the Depends field
468 depends = control.Find("Depends");
470 reject("%s: Depends field is empty." % (file));
472 # Check the section & priority match those given in the .changes (non-fatal)
473 if control.Find("Section") and files[file]["section"] != "" and files[file]["section"] != control.Find("Section"):
474 reject("%s control file lists section as `%s', but changes file has `%s'." % (file, control.Find("Section", ""), files[file]["section"]), "Warning: ");
475 if control.Find("Priority") and files[file]["priority"] != "" and files[file]["priority"] != control.Find("Priority"):
476 reject("%s control file lists priority as `%s', but changes file has `%s'." % (file, control.Find("Priority", ""), files[file]["priority"]),"Warning: ");
478 files[file]["package"] = package;
479 files[file]["architecture"] = architecture;
480 files[file]["version"] = version;
481 files[file]["maintainer"] = control.Find("Maintainer", "");
482 if file.endswith(".udeb"):
483 files[file]["dbtype"] = "udeb";
484 elif file.endswith(".deb"):
485 files[file]["dbtype"] = "deb";
487 reject("%s is neither a .deb or a .udeb." % (file));
488 files[file]["source"] = control.Find("Source", files[file]["package"]);
489 # Get the source version
490 source = files[file]["source"];
492 if source.find("(") != -1:
493 m = utils.re_extract_src_version.match(source);
495 source_version = m.group(2);
496 if not source_version:
497 source_version = files[file]["version"];
498 files[file]["source package"] = source;
499 files[file]["source version"] = source_version;
501 # Ensure the filename matches the contents of the .deb
502 m = utils.re_isadeb.match(file);
504 file_package = m.group(1);
505 if files[file]["package"] != file_package:
506 reject("%s: package part of filename (%s) does not match package name in the %s (%s)." % (file, file_package, files[file]["dbtype"], files[file]["package"]));
507 epochless_version = utils.re_no_epoch.sub('', control.Find("Version"));
509 file_version = m.group(2);
510 if epochless_version != file_version:
511 reject("%s: version part of filename (%s) does not match package version in the %s (%s)." % (file, file_version, files[file]["dbtype"], epochless_version));
513 file_architecture = m.group(3);
514 if files[file]["architecture"] != file_architecture:
515 reject("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % (file, file_architecture, files[file]["dbtype"], files[file]["architecture"]));
517 # Check for existent source
518 source_version = files[file]["source version"];
519 source_package = files[file]["source package"];
520 if changes["architecture"].has_key("source"):
521 if source_version != changes["version"]:
522 reject("source version (%s) for %s doesn't match changes version %s." % (source_version, file, changes["version"]));
524 # Check in the SQL database
525 if not Katie.source_exists(source_package, source_version, changes["distribution"].keys()):
526 # Check in one of the other directories
527 source_epochless_version = utils.re_no_epoch.sub('', source_version);
528 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version);
529 if os.path.exists(Cnf["Dir::Queue::Byhand"] + '/' + dsc_filename):
530 files[file]["byhand"] = 1;
531 elif os.path.exists(Cnf["Dir::Queue::New"] + '/' + dsc_filename):
532 files[file]["new"] = 1;
533 elif not os.path.exists(Cnf["Dir::Queue::Accepted"] + '/' + dsc_filename):
534 reject("no source found for %s %s (%s)." % (source_package, source_version, file));
535 # Check the version and for file overwrites
536 reject(Katie.check_binary_against_db(file),"");
538 check_deb_ar(file, control)
540 # Checks for a source package...
542 m = utils.re_issource.match(file);
545 files[file]["package"] = m.group(1);
546 files[file]["version"] = m.group(2);
547 files[file]["type"] = m.group(3);
549 # Ensure the source package name matches the Source filed in the .changes
550 if changes["source"] != files[file]["package"]:
551 reject("%s: changes file doesn't say %s for Source" % (file, files[file]["package"]));
553 # Ensure the source version matches the version in the .changes file
554 if files[file]["type"] == "orig.tar.gz":
555 changes_version = changes["chopversion2"];
557 changes_version = changes["chopversion"];
558 if changes_version != files[file]["version"]:
559 reject("%s: should be %s according to changes file." % (file, changes_version));
561 # Ensure the .changes lists source in the Architecture field
562 if not changes["architecture"].has_key("source"):
563 reject("%s: changes file doesn't list `source' in Architecture field." % (file));
565 # Check the signature of a .dsc file
566 if files[file]["type"] == "dsc":
567 dsc["fingerprint"] = utils.check_signature(file, reject);
569 files[file]["architecture"] = "source";
571 # Not a binary or source package? Assume byhand...
573 files[file]["byhand"] = 1;
574 files[file]["type"] = "byhand";
576 # Per-suite file checks
577 files[file]["oldfiles"] = {};
578 for suite in changes["distribution"].keys():
580 if files[file].has_key("byhand"):
583 # Handle component mappings
584 for map in Cnf.ValueList("ComponentMappings"):
585 (source, dest) = map.split();
586 if files[file]["component"] == source:
587 files[file]["original component"] = source;
588 files[file]["component"] = dest;
590 # Ensure the component is valid for the target suite
591 if Cnf.has_key("Suite:%s::Components" % (suite)) and \
592 files[file]["component"] not in Cnf.ValueList("Suite::%s::Components" % (suite)):
593 reject("unknown component `%s' for suite `%s'." % (files[file]["component"], suite));
596 # Validate the component
597 component = files[file]["component"];
598 component_id = db_access.get_component_id(component);
599 if component_id == -1:
600 reject("file '%s' has unknown component '%s'." % (file, component));
603 # See if the package is NEW
604 if not Katie.in_override_p(files[file]["package"], files[file]["component"], suite, files[file].get("dbtype",""), file):
605 files[file]["new"] = 1;
607 # Validate the priority
608 if files[file]["priority"].find('/') != -1:
609 reject("file '%s' has invalid priority '%s' [contains '/']." % (file, files[file]["priority"]));
611 # Determine the location
612 location = Cnf["Dir::Pool"];
613 location_id = db_access.get_location_id (location, component, archive);
614 if location_id == -1:
615 reject("[INTERNAL ERROR] couldn't determine location (Component: %s, Archive: %s)" % (component, archive));
616 files[file]["location id"] = location_id;
618 # Check the md5sum & size against existing files (if any)
619 files[file]["pool name"] = utils.poolify (changes["source"], files[file]["component"]);
620 files_id = db_access.get_files_id(files[file]["pool name"] + file, files[file]["size"], files[file]["md5sum"], files[file]["location id"]);
622 reject("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (file));
624 reject("md5sum and/or size mismatch on existing copy of %s." % (file));
625 files[file]["files id"] = files_id
627 # Check for packages that have moved from one component to another
628 q = Katie.projectB.query("""
629 SELECT c.name FROM binaries b, bin_associations ba, suite s, location l,
630 component c, architecture a, files f
631 WHERE b.package = '%s' AND s.suite_name = '%s'
632 AND (a.arch_string = '%s' OR a.arch_string = 'all')
633 AND ba.bin = b.id AND ba.suite = s.id AND b.architecture = a.id
634 AND f.location = l.id AND l.component = c.id AND b.file = f.id"""
635 % (files[file]["package"], suite,
636 files[file]["architecture"]));
639 files[file]["othercomponents"] = ql[0][0];
641 # If the .changes file says it has source, it must have source.
642 if changes["architecture"].has_key("source"):
644 reject("no source found and Architecture line in changes mention source.");
646 if not has_binaries and Cnf.FindB("Dinstall::Reject::NoSourceOnly"):
647 reject("source only uploads are not supported.");
649 ###############################################################################
654 # Ensure there is source to check
655 if not changes["architecture"].has_key("source"):
660 for file in files.keys():
661 if files[file]["type"] == "dsc":
663 reject("can not process a .changes file with multiple .dsc's.");
668 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
672 # Parse the .dsc file
674 dsc.update(utils.parse_changes(dsc_filename, signing_rules=1));
675 except utils.cant_open_exc:
676 # if not -n copy_to_holding() will have done this for us...
677 if Options["No-Action"]:
678 reject("%s: can't read file." % (dsc_filename));
679 except utils.changes_parse_error_exc, line:
680 reject("%s: parse error, can't grok: %s." % (dsc_filename, line));
681 except utils.invalid_dsc_format_exc, line:
682 reject("%s: syntax error on line %s." % (dsc_filename, line));
683 # Build up the file list of files mentioned by the .dsc
685 dsc_files.update(utils.build_file_list(dsc, is_a_dsc=1));
686 except utils.no_files_exc:
687 reject("%s: no Files: field." % (dsc_filename));
689 except utils.changes_parse_error_exc, line:
690 reject("%s: parse error, can't grok: %s." % (dsc_filename, line));
693 # Enforce mandatory fields
694 for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
695 if not dsc.has_key(i):
696 reject("%s: missing mandatory field `%s'." % (dsc_filename, i));
699 # Validate the source and version fields
700 if not re_valid_pkg_name.match(dsc["source"]):
701 reject("%s: invalid source name '%s'." % (dsc_filename, dsc["source"]));
702 if not re_valid_version.match(dsc["version"]):
703 reject("%s: invalid version number '%s'." % (dsc_filename, dsc["version"]));
705 # Bumping the version number of the .dsc breaks extraction by stable's
706 # dpkg-source. So let's not do that...
707 if dsc["format"] != "1.0":
708 reject("%s: incompatible 'Format' version produced by a broken version of dpkg-dev 1.9.1{3,4}." % (dsc_filename));
710 # Validate the Maintainer field
712 utils.fix_maintainer (dsc["maintainer"]);
713 except utils.ParseMaintError, msg:
714 reject("%s: Maintainer field ('%s') failed to parse: %s" \
715 % (dsc_filename, dsc["maintainer"], msg));
717 # Validate the build-depends field(s)
718 for field_name in [ "build-depends", "build-depends-indep" ]:
719 field = dsc.get(field_name);
721 # Check for broken dpkg-dev lossage...
722 if field.startswith("ARRAY"):
723 reject("%s: invalid %s field produced by a broken version of dpkg-dev (1.10.11)" % (dsc_filename, field_name.title()));
725 # Have apt try to parse them...
727 apt_pkg.ParseSrcDepends(field);
729 reject("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()));
732 # Ensure the version number in the .dsc matches the version number in the .changes
733 epochless_dsc_version = utils.re_no_epoch.sub('', dsc["version"]);
734 changes_version = files[dsc_filename]["version"];
735 if epochless_dsc_version != files[dsc_filename]["version"]:
736 reject("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version));
738 # Ensure there is a .tar.gz in the .dsc file
740 for f in dsc_files.keys():
741 m = utils.re_issource.match(f);
743 reject("%s: %s in Files field not recognised as source." % (dsc_filename, f));
745 if type == "orig.tar.gz" or type == "tar.gz":
748 reject("%s: no .tar.gz or .orig.tar.gz in 'Files' field." % (dsc_filename));
750 # Ensure source is newer than existing source in target suites
751 reject(Katie.check_source_against_db(dsc_filename),"");
753 (reject_msg, is_in_incoming) = Katie.check_dsc_against_db(dsc_filename);
754 reject(reject_msg, "");
756 if not Options["No-Action"]:
757 copy_to_holding(is_in_incoming);
758 orig_tar_gz = os.path.basename(is_in_incoming);
759 files[orig_tar_gz] = {};
760 files[orig_tar_gz]["size"] = os.stat(orig_tar_gz)[stat.ST_SIZE];
761 files[orig_tar_gz]["md5sum"] = dsc_files[orig_tar_gz]["md5sum"];
762 files[orig_tar_gz]["section"] = files[dsc_filename]["section"];
763 files[orig_tar_gz]["priority"] = files[dsc_filename]["priority"];
764 files[orig_tar_gz]["component"] = files[dsc_filename]["component"];
765 files[orig_tar_gz]["type"] = "orig.tar.gz";
770 ################################################################################
772 def get_changelog_versions(source_dir):
773 """Extracts a the source package and (optionally) grabs the
774 version history out of debian/changelog for the BTS."""
776 # Find the .dsc (again)
778 for file in files.keys():
779 if files[file]["type"] == "dsc":
782 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
786 # Create a symlink mirror of the source files in our temporary directory
787 for f in files.keys():
788 m = utils.re_issource.match(f);
790 src = os.path.join(source_dir, f);
791 # If a file is missing for whatever reason, give up.
792 if not os.path.exists(src):
795 if type == "orig.tar.gz" and pkg.orig_tar_gz:
797 dest = os.path.join(os.getcwd(), f);
798 os.symlink(src, dest);
800 # If the orig.tar.gz is not a part of the upload, create a symlink to the
803 dest = os.path.join(os.getcwd(), os.path.basename(pkg.orig_tar_gz));
804 os.symlink(pkg.orig_tar_gz, dest);
807 cmd = "dpkg-source -sn -x %s" % (dsc_filename);
808 (result, output) = commands.getstatusoutput(cmd);
810 reject("'dpkg-source -x' failed for %s [return code: %s]." % (dsc_filename, result));
811 reject(utils.prefix_multi_line_string(output, " [dpkg-source output:] "), "");
814 if not Cnf.Find("Dir::Queue::BTSVersionTrack"):
817 # Get the upstream version
818 upstr_version = utils.re_no_epoch.sub('', dsc["version"]);
819 if re_strip_revision.search(upstr_version):
820 upstr_version = re_strip_revision.sub('', upstr_version);
822 # Ensure the changelog file exists
823 changelog_filename = "%s-%s/debian/changelog" % (dsc["source"], upstr_version);
824 if not os.path.exists(changelog_filename):
825 reject("%s: debian/changelog not found in extracted source." % (dsc_filename));
828 # Parse the changelog
829 dsc["bts changelog"] = "";
830 changelog_file = utils.open_file(changelog_filename);
831 for line in changelog_file.readlines():
832 m = re_changelog_versions.match(line);
834 dsc["bts changelog"] += line;
835 changelog_file.close();
837 # Check we found at least one revision in the changelog
838 if not dsc["bts changelog"]:
839 reject("%s: changelog format not recognised (empty version tree)." % (dsc_filename));
841 ########################################
845 # a) there's no source
846 # or b) reprocess is 2 - we will do this check next time when orig.tar.gz is in 'files'
847 # or c) the orig.tar.gz is MIA
848 if not changes["architecture"].has_key("source") or reprocess == 2 \
849 or pkg.orig_tar_gz == -1:
852 # Create a temporary directory to extract the source into
853 if Options["No-Action"]:
854 tmpdir = tempfile.mktemp();
856 # We're in queue/holding and can create a random directory.
857 tmpdir = "%s" % (os.getpid());
860 # Move into the temporary directory
864 # Get the changelog version history
865 get_changelog_versions(cwd);
867 # Move back and cleanup the temporary tree
870 shutil.rmtree(tmpdir);
872 if errno.errorcode[e.errno] != 'EACCES':
873 utils.fubar("%s: couldn't remove tmp dir for source tree." % (dsc["source"]));
875 reject("%s: source tree could not be cleanly removed." % (dsc["source"]));
876 # We probably have u-r or u-w directories so chmod everything
878 cmd = "chmod -R u+rwx %s" % (tmpdir)
879 result = os.system(cmd)
881 utils.fubar("'%s' failed with result %s." % (cmd, result));
882 shutil.rmtree(tmpdir);
884 utils.fubar("%s: couldn't remove tmp dir for source tree." % (dsc["source"]));
886 ################################################################################
888 # FIXME: should be a debian specific check called from a hook
890 def check_urgency ():
891 if changes["architecture"].has_key("source"):
892 if not changes.has_key("urgency"):
893 changes["urgency"] = Cnf["Urgency::Default"];
894 if changes["urgency"] not in Cnf.ValueList("Urgency::Valid"):
895 reject("%s is not a valid urgency; it will be treated as %s by testing." % (changes["urgency"], Cnf["Urgency::Default"]), "Warning: ");
896 changes["urgency"] = Cnf["Urgency::Default"];
897 changes["urgency"] = changes["urgency"].lower();
899 ################################################################################
901 def check_md5sums ():
902 for file in files.keys():
904 file_handle = utils.open_file(file);
905 except utils.cant_open_exc:
909 if apt_pkg.md5sum(file_handle) != files[file]["md5sum"]:
910 reject("%s: md5sum check failed." % (file));
913 actual_size = os.stat(file)[stat.ST_SIZE];
914 size = int(files[file]["size"]);
915 if size != actual_size:
916 reject("%s: actual file size (%s) does not match size (%s) in .changes"
917 % (file, actual_size, size));
919 for file in dsc_files.keys():
921 file_handle = utils.open_file(file);
922 except utils.cant_open_exc:
926 if apt_pkg.md5sum(file_handle) != dsc_files[file]["md5sum"]:
927 reject("%s: md5sum check failed." % (file));
930 actual_size = os.stat(file)[stat.ST_SIZE];
931 size = int(dsc_files[file]["size"]);
932 if size != actual_size:
933 reject("%s: actual file size (%s) does not match size (%s) in .dsc"
934 % (file, actual_size, size));
936 ################################################################################
938 # Sanity check the time stamps of files inside debs.
939 # [Files in the near future cause ugly warnings and extreme time
940 # travel can cause errors on extraction]
942 def check_timestamps():
944 def __init__(self, future_cutoff, past_cutoff):
946 self.future_cutoff = future_cutoff;
947 self.past_cutoff = past_cutoff;
950 self.future_files = {};
951 self.ancient_files = {};
953 def callback(self, Kind,Name,Link,Mode,UID,GID,Size,MTime,Major,Minor):
954 if MTime > self.future_cutoff:
955 self.future_files[Name] = MTime;
956 if MTime < self.past_cutoff:
957 self.ancient_files[Name] = MTime;
960 future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"]);
961 past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"));
962 tar = Tar(future_cutoff, past_cutoff);
963 for filename in files.keys():
964 if files[filename]["type"] == "deb":
967 deb_file = utils.open_file(filename);
968 apt_inst.debExtract(deb_file,tar.callback,"control.tar.gz");
971 apt_inst.debExtract(deb_file,tar.callback,"data.tar.gz")
972 except SystemError, e:
973 # If we can't find a data.tar.gz, look for data.tar.bz2 instead.
974 if not re.match(r"Cannot f[ui]nd chunk data.tar.gz$", str(e)):
977 apt_inst.debExtract(deb_file,tar.callback,"data.tar.bz2")
980 future_files = tar.future_files.keys();
982 num_future_files = len(future_files);
983 future_file = future_files[0];
984 future_date = tar.future_files[future_file];
985 reject("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
986 % (filename, num_future_files, future_file,
987 time.ctime(future_date)));
989 ancient_files = tar.ancient_files.keys();
991 num_ancient_files = len(ancient_files);
992 ancient_file = ancient_files[0];
993 ancient_date = tar.ancient_files[ancient_file];
994 reject("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
995 % (filename, num_ancient_files, ancient_file,
996 time.ctime(ancient_date)));
998 reject("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value));
1000 ################################################################################
1001 ################################################################################
1003 # If any file of an upload has a recent mtime then chances are good
1004 # the file is still being uploaded.
1006 def upload_too_new():
1008 # Move back to the original directory to get accurate time stamps
1010 os.chdir(pkg.directory);
1011 file_list = pkg.files.keys();
1012 file_list.extend(pkg.dsc_files.keys());
1013 file_list.append(pkg.changes_file);
1014 for file in file_list:
1016 last_modified = time.time()-os.path.getmtime(file);
1017 if last_modified < int(Cnf["Dinstall::SkipTime"]):
1025 ################################################################################
1028 # changes["distribution"] may not exist in corner cases
1029 # (e.g. unreadable changes files)
1030 if not changes.has_key("distribution") or not isinstance(changes["distribution"], DictType):
1031 changes["distribution"] = {};
1033 (summary, short_summary) = Katie.build_summaries();
1036 for file in files.keys():
1037 if files[file].has_key("byhand"):
1039 elif files[file].has_key("new"):
1042 (prompt, answer) = ("", "XXX")
1043 if Options["No-Action"] or Options["Automatic"]:
1046 if reject_message.find("Rejected") != -1:
1047 if upload_too_new():
1048 print "SKIP (too new)\n" + reject_message,;
1049 prompt = "[S]kip, Quit ?";
1051 print "REJECT\n" + reject_message,;
1052 prompt = "[R]eject, Skip, Quit ?";
1053 if Options["Automatic"]:
1056 print "NEW to %s\n%s%s" % (", ".join(changes["distribution"].keys()), reject_message, summary),;
1057 prompt = "[N]ew, Skip, Quit ?";
1058 if Options["Automatic"]:
1061 print "BYHAND\n" + reject_message + summary,;
1062 prompt = "[B]yhand, Skip, Quit ?";
1063 if Options["Automatic"]:
1066 print "ACCEPT\n" + reject_message + summary,;
1067 prompt = "[A]ccept, Skip, Quit ?";
1068 if Options["Automatic"]:
1071 while prompt.find(answer) == -1:
1072 answer = utils.our_raw_input(prompt);
1073 m = katie.re_default_answer.match(prompt);
1075 answer = m.group(1);
1076 answer = answer[:1].upper();
1079 os.chdir (pkg.directory);
1080 Katie.do_reject(0, reject_message);
1082 accept(summary, short_summary);
1086 acknowledge_new (summary);
1090 ################################################################################
1092 def accept (summary, short_summary):
1093 Katie.accept(summary, short_summary);
1094 Katie.check_override();
1096 # Finally, remove the originals from the unchecked directory
1097 os.chdir (pkg.directory);
1098 for file in files.keys():
1100 os.unlink(pkg.changes_file);
1102 ################################################################################
1104 def do_byhand (summary):
1105 print "Moving to BYHAND holding area."
1106 Logger.log(["Moving to byhand", pkg.changes_file]);
1108 Katie.dump_vars(Cnf["Dir::Queue::Byhand"]);
1110 file_keys = files.keys();
1112 # Move all the files into the byhand directory
1113 utils.move (pkg.changes_file, Cnf["Dir::Queue::Byhand"]);
1114 for file in file_keys:
1115 utils.move (file, Cnf["Dir::Queue::Byhand"], perms=0660);
1117 # Check for override disparities
1118 Katie.Subst["__SUMMARY__"] = summary;
1119 Katie.check_override();
1121 # Finally remove the originals.
1122 os.chdir (pkg.directory);
1123 for file in file_keys:
1125 os.unlink(pkg.changes_file);
1127 ################################################################################
1129 def acknowledge_new (summary):
1130 Subst = Katie.Subst;
1132 print "Moving to NEW holding area."
1133 Logger.log(["Moving to new", pkg.changes_file]);
1135 Katie.dump_vars(Cnf["Dir::Queue::New"]);
1137 file_keys = files.keys();
1139 # Move all the files into the 'new' directory
1140 utils.move (pkg.changes_file, Cnf["Dir::Queue::New"]);
1141 for file in file_keys:
1142 utils.move (file, Cnf["Dir::Queue::New"], perms=0660);
1144 if not Options["No-Mail"]:
1145 print "Sending new ack.";
1146 Subst["__SUMMARY__"] = summary;
1147 new_ack_message = utils.TemplateSubst(Subst,Cnf["Dir::Templates"]+"/jennifer.new");
1148 utils.send_mail(new_ack_message);
1150 # Finally remove the originals.
1151 os.chdir (pkg.directory);
1152 for file in file_keys:
1154 os.unlink(pkg.changes_file);
1156 ################################################################################
1158 # reprocess is necessary for the case of foo_1.2-1 and foo_1.2-2 in
1159 # Incoming. -1 will reference the .orig.tar.gz, but -2 will not.
1160 # Katie.check_dsc_against_db() can find the .orig.tar.gz but it will
1161 # not have processed it during it's checks of -2. If -1 has been
1162 # deleted or otherwise not checked by jennifer, the .orig.tar.gz will
1163 # not have been checked at all. To get round this, we force the
1164 # .orig.tar.gz into the .changes structure and reprocess the .changes
1167 def process_it (changes_file):
1168 global reprocess, reject_message;
1170 # Reset some globals
1173 # Some defaults in case we can't fully process the .changes file
1174 changes["maintainer2047"] = Cnf["Dinstall::MyEmailAddress"];
1175 changes["changedby2047"] = Cnf["Dinstall::MyEmailAddress"];
1176 reject_message = "";
1178 # Absolutize the filename to avoid the requirement of being in the
1179 # same directory as the .changes file.
1180 pkg.changes_file = os.path.abspath(changes_file);
1182 # Remember where we are so we can come back after cd-ing into the
1183 # holding directory.
1184 pkg.directory = os.getcwd();
1187 # If this is the Real Thing(tm), copy things into a private
1188 # holding directory first to avoid replacable file races.
1189 if not Options["No-Action"]:
1190 os.chdir(Cnf["Dir::Queue::Holding"]);
1191 copy_to_holding(pkg.changes_file);
1192 # Relativize the filename so we use the copy in holding
1193 # rather than the original...
1194 pkg.changes_file = os.path.basename(pkg.changes_file);
1195 changes["fingerprint"] = utils.check_signature(pkg.changes_file, reject);
1196 if changes["fingerprint"]:
1197 valid_changes_p = check_changes();
1199 valid_changes_p = 0;
1202 check_distributions();
1204 valid_dsc_p = check_dsc();
1210 Katie.update_subst(reject_message);
1216 traceback.print_exc(file=sys.stderr);
1219 # Restore previous WD
1220 os.chdir(pkg.directory);
1222 ###############################################################################
1225 global Cnf, Options, Logger;
1227 changes_files = init();
1229 # -n/--dry-run invalidates some other options which would involve things happening
1230 if Options["No-Action"]:
1231 Options["Automatic"] = "";
1233 # Ensure all the arguments we were given are .changes files
1234 for file in changes_files:
1235 if not file.endswith(".changes"):
1236 utils.warn("Ignoring '%s' because it's not a .changes file." % (file));
1237 changes_files.remove(file);
1239 if changes_files == []:
1240 utils.fubar("Need at least one .changes file as an argument.");
1242 # Check that we aren't going to clash with the daily cron job
1244 if not Options["No-Action"] and os.path.exists("%s/Archive_Maintenance_In_Progress" % (Cnf["Dir::Root"])) and not Options["No-Lock"]:
1245 utils.fubar("Archive maintenance in progress. Try again later.");
1247 # Obtain lock if not in no-action mode and initialize the log
1249 if not Options["No-Action"]:
1250 lock_fd = os.open(Cnf["Dinstall::LockFile"], os.O_RDWR | os.O_CREAT);
1252 fcntl.lockf(lock_fd, fcntl.LOCK_EX | fcntl.LOCK_NB);
1254 if errno.errorcode[e.errno] == 'EACCES' or errno.errorcode[e.errno] == 'EAGAIN':
1255 utils.fubar("Couldn't obtain lock; assuming another jennifer is already running.");
1258 Logger = Katie.Logger = logging.Logger(Cnf, "jennifer");
1260 # debian-{devel-,}-changes@lists.debian.org toggles writes access based on this header
1261 bcc = "X-Katie: %s" % (jennifer_version);
1262 if Cnf.has_key("Dinstall::Bcc"):
1263 Katie.Subst["__BCC__"] = bcc + "\nBcc: %s" % (Cnf["Dinstall::Bcc"]);
1265 Katie.Subst["__BCC__"] = bcc;
1268 # Sort the .changes files so that we process sourceful ones first
1269 changes_files.sort(utils.changes_compare);
1271 # Process the changes files
1272 for changes_file in changes_files:
1273 print "\n" + changes_file;
1275 process_it (changes_file);
1277 if not Options["No-Action"]:
1280 accept_count = Katie.accept_count;
1281 accept_bytes = Katie.accept_bytes;
1284 if accept_count > 1:
1286 print "Accepted %d package %s, %s." % (accept_count, sets, utils.size_type(int(accept_bytes)));
1287 Logger.log(["total",accept_count,accept_bytes]);
1289 if not Options["No-Action"]:
1292 ################################################################################
1294 if __name__ == '__main__':