5 Queue utility functions for dak
7 @contact: Debian FTP Master <ftpmaster@debian.org>
8 @copyright: 2001 - 2006 James Troup <james@nocrew.org>
9 @copyright: 2009 Joerg Jaspert <joerg@debian.org>
10 @license: GNU General Public License version 2 or later
13 # This program is free software; you can redistribute it and/or modify
14 # it under the terms of the GNU General Public License as published by
15 # the Free Software Foundation; either version 2 of the License, or
16 # (at your option) any later version.
18 # This program is distributed in the hope that it will be useful,
19 # but WITHOUT ANY WARRANTY; without even the implied warranty of
20 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 # GNU General Public License for more details.
23 # You should have received a copy of the GNU General Public License
24 # along with this program; if not, write to the Free Software
25 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
27 ###############################################################################
41 from sqlalchemy.sql.expression import desc
42 from sqlalchemy.orm.exc import NoResultFound
46 from dak_exceptions import *
49 from config import Config
50 from holding import Holding
51 from urgencylog import UrgencyLog
53 from summarystats import SummaryStats
54 from utils import parse_changes, check_dsc_files
55 from textutils import fix_maintainer
56 from binary import Binary
57 from lintian import parse_lintian_output, generate_reject_messages
59 ###############################################################################
61 def get_type(f, session):
63 Get the file type of C{f}
66 @param f: file entry from Changes object
68 @type session: SQLA Session
69 @param session: SQL Alchemy session object
76 if f.has_key("dbtype"):
77 file_type = f["dbtype"]
78 elif re_source_ext.match(f["type"]):
81 utils.fubar("invalid type (%s) for new. Dazed, confused and sure as heck not continuing." % (file_type))
83 # Validate the override type
84 type_id = get_override_type(file_type, session)
86 utils.fubar("invalid type (%s) for new. Say wha?" % (file_type))
90 ################################################################################
92 # Determine what parts in a .changes are NEW
94 def determine_new(changes, files, warn=1):
96 Determine what parts in a C{changes} file are NEW.
98 @type changes: Upload.Pkg.changes dict
99 @param changes: Changes dictionary
101 @type files: Upload.Pkg.files dict
102 @param files: Files dictionary
105 @param warn: Warn if overrides are added for (old)stable
108 @return: dictionary of NEW components.
113 session = DBConn().session()
115 # Build up a list of potentially new things
116 for name, f in files.items():
117 # Skip byhand elements
118 if f["type"] == "byhand":
121 priority = f["priority"]
122 section = f["section"]
123 file_type = get_type(f, session)
124 component = f["component"]
126 if file_type == "dsc":
129 if not new.has_key(pkg):
131 new[pkg]["priority"] = priority
132 new[pkg]["section"] = section
133 new[pkg]["type"] = file_type
134 new[pkg]["component"] = component
135 new[pkg]["files"] = []
137 old_type = new[pkg]["type"]
138 if old_type != file_type:
139 # source gets trumped by deb or udeb
140 if old_type == "dsc":
141 new[pkg]["priority"] = priority
142 new[pkg]["section"] = section
143 new[pkg]["type"] = file_type
144 new[pkg]["component"] = component
146 new[pkg]["files"].append(name)
148 if f.has_key("othercomponents"):
149 new[pkg]["othercomponents"] = f["othercomponents"]
151 for suite in changes["suite"].keys():
152 for pkg in new.keys():
153 ql = get_override(pkg, suite, new[pkg]["component"], new[pkg]["type"], session)
155 for file_entry in new[pkg]["files"]:
156 if files[file_entry].has_key("new"):
157 del files[file_entry]["new"]
161 for s in ['stable', 'oldstable']:
162 if changes["suite"].has_key(s):
163 print "WARNING: overrides will be added for %s!" % s
164 for pkg in new.keys():
165 if new[pkg].has_key("othercomponents"):
166 print "WARNING: %s already present in %s distribution." % (pkg, new[pkg]["othercomponents"])
172 ################################################################################
174 def check_valid(new):
176 Check if section and priority for NEW packages exist in database.
177 Additionally does sanity checks:
178 - debian-installer packages have to be udeb (or source)
179 - non debian-installer packages can not be udeb
180 - source priority can only be assigned to dsc file types
183 @param new: Dict of new packages with their section, priority and type.
186 for pkg in new.keys():
187 section_name = new[pkg]["section"]
188 priority_name = new[pkg]["priority"]
189 file_type = new[pkg]["type"]
191 section = get_section(section_name)
193 new[pkg]["section id"] = -1
195 new[pkg]["section id"] = section.section_id
197 priority = get_priority(priority_name)
199 new[pkg]["priority id"] = -1
201 new[pkg]["priority id"] = priority.priority_id
204 di = section_name.find("debian-installer") != -1
206 # If d-i, we must be udeb and vice-versa
207 if (di and file_type not in ("udeb", "dsc")) or \
208 (not di and file_type == "udeb"):
209 new[pkg]["section id"] = -1
211 # If dsc we need to be source and vice-versa
212 if (priority == "source" and file_type != "dsc") or \
213 (priority != "source" and file_type == "dsc"):
214 new[pkg]["priority id"] = -1
216 ###############################################################################
218 def check_status(files):
220 for f in files.keys():
221 if files[f]["type"] == "byhand":
223 elif files[f].has_key("new"):
227 ###############################################################################
229 # Used by Upload.check_timestamps
230 class TarTime(object):
231 def __init__(self, future_cutoff, past_cutoff):
233 self.future_cutoff = future_cutoff
234 self.past_cutoff = past_cutoff
237 self.future_files = {}
238 self.ancient_files = {}
240 def callback(self, Kind, Name, Link, Mode, UID, GID, Size, MTime, Major, Minor):
241 if MTime > self.future_cutoff:
242 self.future_files[Name] = MTime
243 if MTime < self.past_cutoff:
244 self.ancient_files[Name] = MTime
246 ###############################################################################
248 class Upload(object):
250 Everything that has to do with an upload processed.
258 ###########################################################################
261 """ Reset a number of internal variables."""
263 # Initialize the substitution template map
266 self.Subst["__ADMIN_ADDRESS__"] = cnf["Dinstall::MyAdminAddress"]
267 self.Subst["__BUG_SERVER__"] = cnf["Dinstall::BugServer"]
268 self.Subst["__DISTRO__"] = cnf["Dinstall::MyDistribution"]
269 self.Subst["__DAK_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
277 def package_info(self):
279 Format various messages from this Upload to send to the maintainer.
283 ('Reject Reasons', self.rejects),
284 ('Warnings', self.warnings),
285 ('Notes', self.notes),
289 for title, messages in msgs:
291 msg += '\n\n%s:\n%s' % (title, '\n'.join(messages))
296 ###########################################################################
297 def update_subst(self):
298 """ Set up the per-package template substitution mappings """
302 # If 'dak process-unchecked' crashed out in the right place, architecture may still be a string.
303 if not self.pkg.changes.has_key("architecture") or not \
304 isinstance(self.pkg.changes["architecture"], dict):
305 self.pkg.changes["architecture"] = { "Unknown" : "" }
307 # and maintainer2047 may not exist.
308 if not self.pkg.changes.has_key("maintainer2047"):
309 self.pkg.changes["maintainer2047"] = cnf["Dinstall::MyEmailAddress"]
311 self.Subst["__ARCHITECTURE__"] = " ".join(self.pkg.changes["architecture"].keys())
312 self.Subst["__CHANGES_FILENAME__"] = os.path.basename(self.pkg.changes_file)
313 self.Subst["__FILE_CONTENTS__"] = self.pkg.changes.get("filecontents", "")
315 # For source uploads the Changed-By field wins; otherwise Maintainer wins.
316 if self.pkg.changes["architecture"].has_key("source") and \
317 self.pkg.changes["changedby822"] != "" and \
318 (self.pkg.changes["changedby822"] != self.pkg.changes["maintainer822"]):
320 self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["changedby2047"]
321 self.Subst["__MAINTAINER_TO__"] = "%s, %s" % (self.pkg.changes["changedby2047"], self.pkg.changes["maintainer2047"])
322 self.Subst["__MAINTAINER__"] = self.pkg.changes.get("changed-by", "Unknown")
324 self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["maintainer2047"]
325 self.Subst["__MAINTAINER_TO__"] = self.pkg.changes["maintainer2047"]
326 self.Subst["__MAINTAINER__"] = self.pkg.changes.get("maintainer", "Unknown")
328 if "sponsoremail" in self.pkg.changes:
329 self.Subst["__MAINTAINER_TO__"] += ", %s" % self.pkg.changes["sponsoremail"]
331 if cnf.has_key("Dinstall::TrackingServer") and self.pkg.changes.has_key("source"):
332 self.Subst["__MAINTAINER_TO__"] += "\nBcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
334 # Apply any global override of the Maintainer field
335 if cnf.get("Dinstall::OverrideMaintainer"):
336 self.Subst["__MAINTAINER_TO__"] = cnf["Dinstall::OverrideMaintainer"]
337 self.Subst["__MAINTAINER_FROM__"] = cnf["Dinstall::OverrideMaintainer"]
339 self.Subst["__REJECT_MESSAGE__"] = self.package_info()
340 self.Subst["__SOURCE__"] = self.pkg.changes.get("source", "Unknown")
341 self.Subst["__VERSION__"] = self.pkg.changes.get("version", "Unknown")
343 ###########################################################################
344 def load_changes(self, filename):
347 @rvalue: whether the changes file was valid or not. We may want to
348 reject even if this is True (see what gets put in self.rejects).
349 This is simply to prevent us even trying things later which will
350 fail because we couldn't properly parse the file.
353 self.pkg.changes_file = filename
355 # Parse the .changes field into a dictionary
357 self.pkg.changes.update(parse_changes(filename))
358 except CantOpenError:
359 self.rejects.append("%s: can't read file." % (filename))
361 except ParseChangesError, line:
362 self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
364 except ChangesUnicodeError:
365 self.rejects.append("%s: changes file not proper utf-8" % (filename))
368 # Parse the Files field from the .changes into another dictionary
370 self.pkg.files.update(utils.build_file_list(self.pkg.changes))
371 except ParseChangesError, line:
372 self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
374 except UnknownFormatError, format:
375 self.rejects.append("%s: unknown format '%s'." % (filename, format))
378 # Check for mandatory fields
379 for i in ("distribution", "source", "binary", "architecture",
380 "version", "maintainer", "files", "changes", "description"):
381 if not self.pkg.changes.has_key(i):
382 # Avoid undefined errors later
383 self.rejects.append("%s: Missing mandatory field `%s'." % (filename, i))
386 # Strip a source version in brackets from the source field
387 if re_strip_srcver.search(self.pkg.changes["source"]):
388 self.pkg.changes["source"] = re_strip_srcver.sub('', self.pkg.changes["source"])
390 # Ensure the source field is a valid package name.
391 if not re_valid_pkg_name.match(self.pkg.changes["source"]):
392 self.rejects.append("%s: invalid source name '%s'." % (filename, self.pkg.changes["source"]))
394 # Split multi-value fields into a lower-level dictionary
395 for i in ("architecture", "distribution", "binary", "closes"):
396 o = self.pkg.changes.get(i, "")
398 del self.pkg.changes[i]
400 self.pkg.changes[i] = {}
403 self.pkg.changes[i][j] = 1
405 # Fix the Maintainer: field to be RFC822/2047 compatible
407 (self.pkg.changes["maintainer822"],
408 self.pkg.changes["maintainer2047"],
409 self.pkg.changes["maintainername"],
410 self.pkg.changes["maintaineremail"]) = \
411 fix_maintainer (self.pkg.changes["maintainer"])
412 except ParseMaintError, msg:
413 self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
414 % (filename, self.pkg.changes["maintainer"], msg))
416 # ...likewise for the Changed-By: field if it exists.
418 (self.pkg.changes["changedby822"],
419 self.pkg.changes["changedby2047"],
420 self.pkg.changes["changedbyname"],
421 self.pkg.changes["changedbyemail"]) = \
422 fix_maintainer (self.pkg.changes.get("changed-by", ""))
423 except ParseMaintError, msg:
424 self.pkg.changes["changedby822"] = ""
425 self.pkg.changes["changedby2047"] = ""
426 self.pkg.changes["changedbyname"] = ""
427 self.pkg.changes["changedbyemail"] = ""
429 self.rejects.append("%s: Changed-By field ('%s') failed to parse: %s" \
430 % (filename, changes["changed-by"], msg))
432 # Ensure all the values in Closes: are numbers
433 if self.pkg.changes.has_key("closes"):
434 for i in self.pkg.changes["closes"].keys():
435 if re_isanum.match (i) == None:
436 self.rejects.append(("%s: `%s' from Closes field isn't a number." % (filename, i)))
438 # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
439 self.pkg.changes["chopversion"] = re_no_epoch.sub('', self.pkg.changes["version"])
440 self.pkg.changes["chopversion2"] = re_no_revision.sub('', self.pkg.changes["chopversion"])
442 # Check the .changes is non-empty
443 if not self.pkg.files:
444 self.rejects.append("%s: nothing to do (Files field is empty)." % (base_filename))
447 # Changes was syntactically valid even if we'll reject
450 ###########################################################################
452 def check_distributions(self):
453 "Check and map the Distribution field"
457 # Handle suite mappings
458 for m in Cnf.ValueList("SuiteMappings"):
461 if mtype == "map" or mtype == "silent-map":
462 (source, dest) = args[1:3]
463 if self.pkg.changes["distribution"].has_key(source):
464 del self.pkg.changes["distribution"][source]
465 self.pkg.changes["distribution"][dest] = 1
466 if mtype != "silent-map":
467 self.notes.append("Mapping %s to %s." % (source, dest))
468 if self.pkg.changes.has_key("distribution-version"):
469 if self.pkg.changes["distribution-version"].has_key(source):
470 self.pkg.changes["distribution-version"][source]=dest
471 elif mtype == "map-unreleased":
472 (source, dest) = args[1:3]
473 if self.pkg.changes["distribution"].has_key(source):
474 for arch in self.pkg.changes["architecture"].keys():
475 if arch not in [ a.arch_string for a in get_suite_architectures(source) ]:
476 self.notes.append("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch))
477 del self.pkg.changes["distribution"][source]
478 self.pkg.changes["distribution"][dest] = 1
480 elif mtype == "ignore":
482 if self.pkg.changes["distribution"].has_key(suite):
483 del self.pkg.changes["distribution"][suite]
484 self.warnings.append("Ignoring %s as a target suite." % (suite))
485 elif mtype == "reject":
487 if self.pkg.changes["distribution"].has_key(suite):
488 self.rejects.append("Uploads to %s are not accepted." % (suite))
489 elif mtype == "propup-version":
490 # give these as "uploaded-to(non-mapped) suites-to-add-when-upload-obsoletes"
492 # changes["distribution-version"] looks like: {'testing': 'testing-proposed-updates'}
493 if self.pkg.changes["distribution"].has_key(args[1]):
494 self.pkg.changes.setdefault("distribution-version", {})
495 for suite in args[2:]:
496 self.pkg.changes["distribution-version"][suite] = suite
498 # Ensure there is (still) a target distribution
499 if len(self.pkg.changes["distribution"].keys()) < 1:
500 self.rejects.append("No valid distribution remaining.")
502 # Ensure target distributions exist
503 for suite in self.pkg.changes["distribution"].keys():
504 if not Cnf.has_key("Suite::%s" % (suite)):
505 self.rejects.append("Unknown distribution `%s'." % (suite))
507 ###########################################################################
509 def binary_file_checks(self, f, session):
511 entry = self.pkg.files[f]
513 # Extract package control information
514 deb_file = utils.open_file(f)
516 control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))
518 self.rejects.append("%s: debExtractControl() raised %s." % (f, sys.exc_type))
520 # Can't continue, none of the checks on control would work.
523 # Check for mandantory "Description:"
526 apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))["Description"] + '\n'
528 self.rejects.append("%s: Missing Description in binary package" % (f))
533 # Check for mandatory fields
534 for field in [ "Package", "Architecture", "Version" ]:
535 if control.Find(field) == None:
537 self.rejects.append("%s: No %s field in control." % (f, field))
540 # Ensure the package name matches the one give in the .changes
541 if not self.pkg.changes["binary"].has_key(control.Find("Package", "")):
542 self.rejects.append("%s: control file lists name as `%s', which isn't in changes file." % (f, control.Find("Package", "")))
544 # Validate the package field
545 package = control.Find("Package")
546 if not re_valid_pkg_name.match(package):
547 self.rejects.append("%s: invalid package name '%s'." % (f, package))
549 # Validate the version field
550 version = control.Find("Version")
551 if not re_valid_version.match(version):
552 self.rejects.append("%s: invalid version number '%s'." % (f, version))
554 # Ensure the architecture of the .deb is one we know about.
555 default_suite = cnf.get("Dinstall::DefaultSuite", "Unstable")
556 architecture = control.Find("Architecture")
557 upload_suite = self.pkg.changes["distribution"].keys()[0]
559 if architecture not in [a.arch_string for a in get_suite_architectures(default_suite, session)] \
560 and architecture not in [a.arch_string for a in get_suite_architectures(upload_suite, session)]:
561 self.rejects.append("Unknown architecture '%s'." % (architecture))
563 # Ensure the architecture of the .deb is one of the ones
564 # listed in the .changes.
565 if not self.pkg.changes["architecture"].has_key(architecture):
566 self.rejects.append("%s: control file lists arch as `%s', which isn't in changes file." % (f, architecture))
568 # Sanity-check the Depends field
569 depends = control.Find("Depends")
571 self.rejects.append("%s: Depends field is empty." % (f))
573 # Sanity-check the Provides field
574 provides = control.Find("Provides")
576 provide = re_spacestrip.sub('', provides)
578 self.rejects.append("%s: Provides field is empty." % (f))
579 prov_list = provide.split(",")
580 for prov in prov_list:
581 if not re_valid_pkg_name.match(prov):
582 self.rejects.append("%s: Invalid Provides field content %s." % (f, prov))
584 # Check the section & priority match those given in the .changes (non-fatal)
585 if control.Find("Section") and entry["section"] != "" \
586 and entry["section"] != control.Find("Section"):
587 self.warnings.append("%s control file lists section as `%s', but changes file has `%s'." % \
588 (f, control.Find("Section", ""), entry["section"]))
589 if control.Find("Priority") and entry["priority"] != "" \
590 and entry["priority"] != control.Find("Priority"):
591 self.warnings.append("%s control file lists priority as `%s', but changes file has `%s'." % \
592 (f, control.Find("Priority", ""), entry["priority"]))
594 entry["package"] = package
595 entry["architecture"] = architecture
596 entry["version"] = version
597 entry["maintainer"] = control.Find("Maintainer", "")
599 if f.endswith(".udeb"):
600 self.pkg.files[f]["dbtype"] = "udeb"
601 elif f.endswith(".deb"):
602 self.pkg.files[f]["dbtype"] = "deb"
604 self.rejects.append("%s is neither a .deb or a .udeb." % (f))
606 entry["source"] = control.Find("Source", entry["package"])
608 # Get the source version
609 source = entry["source"]
612 if source.find("(") != -1:
613 m = re_extract_src_version.match(source)
615 source_version = m.group(2)
617 if not source_version:
618 source_version = self.pkg.files[f]["version"]
620 entry["source package"] = source
621 entry["source version"] = source_version
623 # Ensure the filename matches the contents of the .deb
624 m = re_isadeb.match(f)
627 file_package = m.group(1)
628 if entry["package"] != file_package:
629 self.rejects.append("%s: package part of filename (%s) does not match package name in the %s (%s)." % \
630 (f, file_package, entry["dbtype"], entry["package"]))
631 epochless_version = re_no_epoch.sub('', control.Find("Version"))
634 file_version = m.group(2)
635 if epochless_version != file_version:
636 self.rejects.append("%s: version part of filename (%s) does not match package version in the %s (%s)." % \
637 (f, file_version, entry["dbtype"], epochless_version))
640 file_architecture = m.group(3)
641 if entry["architecture"] != file_architecture:
642 self.rejects.append("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % \
643 (f, file_architecture, entry["dbtype"], entry["architecture"]))
645 # Check for existent source
646 source_version = entry["source version"]
647 source_package = entry["source package"]
648 if self.pkg.changes["architecture"].has_key("source"):
649 if source_version != self.pkg.changes["version"]:
650 self.rejects.append("source version (%s) for %s doesn't match changes version %s." % \
651 (source_version, f, self.pkg.changes["version"]))
653 # Check in the SQL database
654 if not source_exists(source_package, source_version, self.pkg.changes["distribution"].keys(), session):
655 # Check in one of the other directories
656 source_epochless_version = re_no_epoch.sub('', source_version)
657 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
658 if os.path.exists(os.path.join(cnf["Dir::Queue::Byhand"], dsc_filename)):
660 elif os.path.exists(os.path.join(cnf["Dir::Queue::New"], dsc_filename)):
663 dsc_file_exists = False
664 for myq in ["Accepted", "Embargoed", "Unembargoed", "ProposedUpdates", "OldProposedUpdates"]:
665 if cnf.has_key("Dir::Queue::%s" % (myq)):
666 if os.path.exists(os.path.join(cnf["Dir::Queue::" + myq], dsc_filename)):
667 dsc_file_exists = True
670 if not dsc_file_exists:
671 self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))
673 # Check the version and for file overwrites
674 self.check_binary_against_db(f, session)
676 # Temporarily disable contents generation until we change the table storage layout
679 #if len(b.rejects) > 0:
680 # for j in b.rejects:
681 # self.rejects.append(j)
683 def source_file_checks(self, f, session):
684 entry = self.pkg.files[f]
686 m = re_issource.match(f)
690 entry["package"] = m.group(1)
691 entry["version"] = m.group(2)
692 entry["type"] = m.group(3)
694 # Ensure the source package name matches the Source filed in the .changes
695 if self.pkg.changes["source"] != entry["package"]:
696 self.rejects.append("%s: changes file doesn't say %s for Source" % (f, entry["package"]))
698 # Ensure the source version matches the version in the .changes file
699 if re_is_orig_source.match(f):
700 changes_version = self.pkg.changes["chopversion2"]
702 changes_version = self.pkg.changes["chopversion"]
704 if changes_version != entry["version"]:
705 self.rejects.append("%s: should be %s according to changes file." % (f, changes_version))
707 # Ensure the .changes lists source in the Architecture field
708 if not self.pkg.changes["architecture"].has_key("source"):
709 self.rejects.append("%s: changes file doesn't list `source' in Architecture field." % (f))
711 # Check the signature of a .dsc file
712 if entry["type"] == "dsc":
713 # check_signature returns either:
714 # (None, [list, of, rejects]) or (signature, [])
715 (self.pkg.dsc["fingerprint"], rejects) = utils.check_signature(f)
717 self.rejects.append(j)
719 entry["architecture"] = "source"
721 def per_suite_file_checks(self, f, suite, session):
723 entry = self.pkg.files[f]
726 if entry.has_key("byhand"):
729 # Check we have fields we need to do these checks
731 for m in ['component', 'package', 'priority', 'size', 'md5sum']:
732 if not entry.has_key(m):
733 self.rejects.append("file '%s' does not have field %s set" % (f, m))
739 # Handle component mappings
740 for m in cnf.ValueList("ComponentMappings"):
741 (source, dest) = m.split()
742 if entry["component"] == source:
743 entry["original component"] = source
744 entry["component"] = dest
746 # Ensure the component is valid for the target suite
747 if cnf.has_key("Suite:%s::Components" % (suite)) and \
748 entry["component"] not in cnf.ValueList("Suite::%s::Components" % (suite)):
749 self.rejects.append("unknown component `%s' for suite `%s'." % (entry["component"], suite))
752 # Validate the component
753 if not get_component(entry["component"], session):
754 self.rejects.append("file '%s' has unknown component '%s'." % (f, entry["component"]))
757 # See if the package is NEW
758 if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), f, session):
761 # Validate the priority
762 if entry["priority"].find('/') != -1:
763 self.rejects.append("file '%s' has invalid priority '%s' [contains '/']." % (f, entry["priority"]))
765 # Determine the location
766 location = cnf["Dir::Pool"]
767 l = get_location(location, entry["component"], session=session)
769 self.rejects.append("[INTERNAL ERROR] couldn't determine location (Component: %)" % entry["component"])
770 entry["location id"] = -1
772 entry["location id"] = l.location_id
774 # Check the md5sum & size against existing files (if any)
775 entry["pool name"] = utils.poolify(self.pkg.changes["source"], entry["component"])
777 found, poolfile = check_poolfile(os.path.join(entry["pool name"], f),
778 entry["size"], entry["md5sum"], entry["location id"])
781 self.rejects.append("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (f))
782 elif found is False and poolfile is not None:
783 self.rejects.append("md5sum and/or size mismatch on existing copy of %s." % (f))
786 entry["files id"] = None
788 entry["files id"] = poolfile.file_id
790 # Check for packages that have moved from one component to another
791 entry['suite'] = suite
792 res = get_binary_components(self.pkg.files[f]['package'], suite, entry["architecture"], session)
794 entry["othercomponents"] = res.fetchone()[0]
796 def check_files(self, action=True):
797 file_keys = self.pkg.files.keys()
803 os.chdir(self.pkg.directory)
805 ret = holding.copy_to_holding(f)
807 # XXX: Should we bail out here or try and continue?
808 self.rejects.append(ret)
812 # check we already know the changes file
813 # [NB: this check must be done post-suite mapping]
814 base_filename = os.path.basename(self.pkg.changes_file)
816 session = DBConn().session()
819 dbc = session.query(DBChange).filter_by(changesname=base_filename).one()
820 # if in the pool or in a queue other than unchecked, reject
821 if (dbc.in_queue is None) \
822 or (dbc.in_queue is not None
823 and dbc.in_queue.queue_name != 'unchecked'):
824 self.rejects.append("%s file already known to dak" % base_filename)
825 except NoResultFound, e:
832 for f, entry in self.pkg.files.items():
833 # Ensure the file does not already exist in one of the accepted directories
834 for d in [ "Byhand", "New", "ProposedUpdates", "OldProposedUpdates", "Embargoed", "Unembargoed" ]:
835 if not cnf.has_key("Dir::Queue::%s" % (d)): continue
836 if os.path.exists(os.path.join(cnf["Dir::Queue::%s" % (d) ], f)):
837 self.rejects.append("%s file already exists in the %s directory." % (f, d))
839 if not re_taint_free.match(f):
840 self.rejects.append("!!WARNING!! tainted filename: '%s'." % (f))
842 # Check the file is readable
843 if os.access(f, os.R_OK) == 0:
844 # When running in -n, copy_to_holding() won't have
845 # generated the reject_message, so we need to.
847 if os.path.exists(f):
848 self.rejects.append("Can't read `%s'. [permission denied]" % (f))
850 self.rejects.append("Can't read `%s'. [file not found]" % (f))
851 entry["type"] = "unreadable"
854 # If it's byhand skip remaining checks
855 if entry["section"] == "byhand" or entry["section"][:4] == "raw-":
857 entry["type"] = "byhand"
859 # Checks for a binary package...
860 elif re_isadeb.match(f):
862 entry["type"] = "deb"
864 # This routine appends to self.rejects/warnings as appropriate
865 self.binary_file_checks(f, session)
867 # Checks for a source package...
868 elif re_issource.match(f):
871 # This routine appends to self.rejects/warnings as appropriate
872 self.source_file_checks(f, session)
874 # Not a binary or source package? Assume byhand...
877 entry["type"] = "byhand"
879 # Per-suite file checks
880 entry["oldfiles"] = {}
881 for suite in self.pkg.changes["distribution"].keys():
882 self.per_suite_file_checks(f, suite, session)
886 # If the .changes file says it has source, it must have source.
887 if self.pkg.changes["architecture"].has_key("source"):
889 self.rejects.append("no source found and Architecture line in changes mention source.")
891 if not has_binaries and cnf.FindB("Dinstall::Reject::NoSourceOnly"):
892 self.rejects.append("source only uploads are not supported.")
894 ###########################################################################
895 def check_dsc(self, action=True, session=None):
896 """Returns bool indicating whether or not the source changes are valid"""
897 # Ensure there is source to check
898 if not self.pkg.changes["architecture"].has_key("source"):
903 for f, entry in self.pkg.files.items():
904 if entry["type"] == "dsc":
906 self.rejects.append("can not process a .changes file with multiple .dsc's.")
911 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
913 self.rejects.append("source uploads must contain a dsc file")
916 # Parse the .dsc file
918 self.pkg.dsc.update(utils.parse_changes(dsc_filename, signing_rules=1))
919 except CantOpenError:
920 # if not -n copy_to_holding() will have done this for us...
922 self.rejects.append("%s: can't read file." % (dsc_filename))
923 except ParseChangesError, line:
924 self.rejects.append("%s: parse error, can't grok: %s." % (dsc_filename, line))
925 except InvalidDscError, line:
926 self.rejects.append("%s: syntax error on line %s." % (dsc_filename, line))
927 except ChangesUnicodeError:
928 self.rejects.append("%s: dsc file not proper utf-8." % (dsc_filename))
930 # Build up the file list of files mentioned by the .dsc
932 self.pkg.dsc_files.update(utils.build_file_list(self.pkg.dsc, is_a_dsc=1))
933 except NoFilesFieldError:
934 self.rejects.append("%s: no Files: field." % (dsc_filename))
936 except UnknownFormatError, format:
937 self.rejects.append("%s: unknown format '%s'." % (dsc_filename, format))
939 except ParseChangesError, line:
940 self.rejects.append("%s: parse error, can't grok: %s." % (dsc_filename, line))
943 # Enforce mandatory fields
944 for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
945 if not self.pkg.dsc.has_key(i):
946 self.rejects.append("%s: missing mandatory field `%s'." % (dsc_filename, i))
949 # Validate the source and version fields
950 if not re_valid_pkg_name.match(self.pkg.dsc["source"]):
951 self.rejects.append("%s: invalid source name '%s'." % (dsc_filename, self.pkg.dsc["source"]))
952 if not re_valid_version.match(self.pkg.dsc["version"]):
953 self.rejects.append("%s: invalid version number '%s'." % (dsc_filename, self.pkg.dsc["version"]))
955 # Only a limited list of source formats are allowed in each suite
956 for dist in self.pkg.changes["distribution"].keys():
957 allowed = [ x.format_name for x in get_suite_src_formats(dist, session) ]
958 if self.pkg.dsc["format"] not in allowed:
959 self.rejects.append("%s: source format '%s' not allowed in %s (accepted: %s) " % (dsc_filename, self.pkg.dsc["format"], dist, ", ".join(allowed)))
961 # Validate the Maintainer field
963 # We ignore the return value
964 fix_maintainer(self.pkg.dsc["maintainer"])
965 except ParseMaintError, msg:
966 self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
967 % (dsc_filename, self.pkg.dsc["maintainer"], msg))
969 # Validate the build-depends field(s)
970 for field_name in [ "build-depends", "build-depends-indep" ]:
971 field = self.pkg.dsc.get(field_name)
973 # Have apt try to parse them...
975 apt_pkg.ParseSrcDepends(field)
977 self.rejects.append("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()))
979 # Ensure the version number in the .dsc matches the version number in the .changes
980 epochless_dsc_version = re_no_epoch.sub('', self.pkg.dsc["version"])
981 changes_version = self.pkg.files[dsc_filename]["version"]
983 if epochless_dsc_version != self.pkg.files[dsc_filename]["version"]:
984 self.rejects.append("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version))
986 # Ensure the Files field contain only what's expected
987 self.rejects.extend(check_dsc_files(dsc_filename, self.pkg.dsc, self.pkg.dsc_files))
989 # Ensure source is newer than existing source in target suites
990 session = DBConn().session()
991 self.check_source_against_db(dsc_filename, session)
992 self.check_dsc_against_db(dsc_filename, session)
997 ###########################################################################
999 def get_changelog_versions(self, source_dir):
1000 """Extracts a the source package and (optionally) grabs the
1001 version history out of debian/changelog for the BTS."""
1005 # Find the .dsc (again)
1007 for f in self.pkg.files.keys():
1008 if self.pkg.files[f]["type"] == "dsc":
1011 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
1012 if not dsc_filename:
1015 # Create a symlink mirror of the source files in our temporary directory
1016 for f in self.pkg.files.keys():
1017 m = re_issource.match(f)
1019 src = os.path.join(source_dir, f)
1020 # If a file is missing for whatever reason, give up.
1021 if not os.path.exists(src):
1024 if re_is_orig_source.match(f) and self.pkg.orig_files.has_key(f) and \
1025 self.pkg.orig_files[f].has_key("path"):
1027 dest = os.path.join(os.getcwd(), f)
1028 os.symlink(src, dest)
1030 # If the orig files are not a part of the upload, create symlinks to the
1032 for orig_file in self.pkg.orig_files.keys():
1033 if not self.pkg.orig_files[orig_file].has_key("path"):
1035 dest = os.path.join(os.getcwd(), os.path.basename(orig_file))
1036 os.symlink(self.pkg.orig_files[orig_file]["path"], dest)
1038 # Extract the source
1039 cmd = "dpkg-source -sn -x %s" % (dsc_filename)
1040 (result, output) = commands.getstatusoutput(cmd)
1042 self.rejects.append("'dpkg-source -x' failed for %s [return code: %s]." % (dsc_filename, result))
1043 self.rejects.append(utils.prefix_multi_line_string(output, " [dpkg-source output:] "))
1046 if not cnf.Find("Dir::Queue::BTSVersionTrack"):
1049 # Get the upstream version
1050 upstr_version = re_no_epoch.sub('', self.pkg.dsc["version"])
1051 if re_strip_revision.search(upstr_version):
1052 upstr_version = re_strip_revision.sub('', upstr_version)
1054 # Ensure the changelog file exists
1055 changelog_filename = "%s-%s/debian/changelog" % (self.pkg.dsc["source"], upstr_version)
1056 if not os.path.exists(changelog_filename):
1057 self.rejects.append("%s: debian/changelog not found in extracted source." % (dsc_filename))
1060 # Parse the changelog
1061 self.pkg.dsc["bts changelog"] = ""
1062 changelog_file = utils.open_file(changelog_filename)
1063 for line in changelog_file.readlines():
1064 m = re_changelog_versions.match(line)
1066 self.pkg.dsc["bts changelog"] += line
1067 changelog_file.close()
1069 # Check we found at least one revision in the changelog
1070 if not self.pkg.dsc["bts changelog"]:
1071 self.rejects.append("%s: changelog format not recognised (empty version tree)." % (dsc_filename))
1073 def check_source(self):
1075 # a) there's no source
1076 # or c) the orig files are MIA
1077 if not self.pkg.changes["architecture"].has_key("source") \
1078 or len(self.pkg.orig_files) == 0:
1081 tmpdir = utils.temp_dirname()
1083 # Move into the temporary directory
1087 # Get the changelog version history
1088 self.get_changelog_versions(cwd)
1090 # Move back and cleanup the temporary tree
1094 shutil.rmtree(tmpdir)
1096 if e.errno != errno.EACCES:
1098 utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))
1100 self.rejects.append("%s: source tree could not be cleanly removed." % (self.pkg.dsc["source"]))
1101 # We probably have u-r or u-w directories so chmod everything
1103 cmd = "chmod -R u+rwx %s" % (tmpdir)
1104 result = os.system(cmd)
1106 utils.fubar("'%s' failed with result %s." % (cmd, result))
1107 shutil.rmtree(tmpdir)
1108 except Exception, e:
1109 print "foobar2 (%s)" % e
1110 utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))
1112 ###########################################################################
1113 def ensure_hashes(self):
1114 # Make sure we recognise the format of the Files: field in the .changes
1115 format = self.pkg.changes.get("format", "0.0").split(".", 1)
1116 if len(format) == 2:
1117 format = int(format[0]), int(format[1])
1119 format = int(float(format[0])), 0
1121 # We need to deal with the original changes blob, as the fields we need
1122 # might not be in the changes dict serialised into the .dak anymore.
1123 orig_changes = utils.parse_deb822(self.pkg.changes['filecontents'])
1125 # Copy the checksums over to the current changes dict. This will keep
1126 # the existing modifications to it intact.
1127 for field in orig_changes:
1128 if field.startswith('checksums-'):
1129 self.pkg.changes[field] = orig_changes[field]
1131 # Check for unsupported hashes
1132 for j in utils.check_hash_fields(".changes", self.pkg.changes):
1133 self.rejects.append(j)
1135 for j in utils.check_hash_fields(".dsc", self.pkg.dsc):
1136 self.rejects.append(j)
1138 # We have to calculate the hash if we have an earlier changes version than
1139 # the hash appears in rather than require it exist in the changes file
1140 for hashname, hashfunc, version in utils.known_hashes:
1141 # TODO: Move _ensure_changes_hash into this class
1142 for j in utils._ensure_changes_hash(self.pkg.changes, format, version, self.pkg.files, hashname, hashfunc):
1143 self.rejects.append(j)
1144 if "source" in self.pkg.changes["architecture"]:
1145 # TODO: Move _ensure_dsc_hash into this class
1146 for j in utils._ensure_dsc_hash(self.pkg.dsc, self.pkg.dsc_files, hashname, hashfunc):
1147 self.rejects.append(j)
1149 def check_hashes(self):
1150 for m in utils.check_hash(".changes", self.pkg.files, "md5", apt_pkg.md5sum):
1151 self.rejects.append(m)
1153 for m in utils.check_size(".changes", self.pkg.files):
1154 self.rejects.append(m)
1156 for m in utils.check_hash(".dsc", self.pkg.dsc_files, "md5", apt_pkg.md5sum):
1157 self.rejects.append(m)
1159 for m in utils.check_size(".dsc", self.pkg.dsc_files):
1160 self.rejects.append(m)
1162 self.ensure_hashes()
1164 ###########################################################################
1166 def ensure_orig(self, target_dir='.', session=None):
1168 Ensures that all orig files mentioned in the changes file are present
1169 in target_dir. If they do not exist, they are symlinked into place.
1171 An list containing the symlinks that were created are returned (so they
1178 for filename, entry in self.pkg.dsc_files.iteritems():
1179 if not re_is_orig_source.match(filename):
1180 # File is not an orig; ignore
1183 if os.path.exists(filename):
1184 # File exists, no need to continue
1187 def symlink_if_valid(path):
1188 f = utils.open_file(path)
1189 md5sum = apt_pkg.md5sum(f)
1192 fingerprint = (os.stat(path)[stat.ST_SIZE], md5sum)
1193 expected = (int(entry['size']), entry['md5sum'])
1195 if fingerprint != expected:
1198 dest = os.path.join(target_dir, filename)
1200 os.symlink(path, dest)
1201 symlinked.append(dest)
1207 session_ = DBConn().session()
1212 for poolfile in get_poolfile_like_name('/%s' % filename, session_):
1213 poolfile_path = os.path.join(
1214 poolfile.location.path, poolfile.filename
1217 if symlink_if_valid(poolfile_path):
1227 # Look in some other queues for the file
1228 queues = ('Accepted', 'New', 'Byhand', 'ProposedUpdates',
1229 'OldProposedUpdates', 'Embargoed', 'Unembargoed')
1231 for queue in queues:
1232 if not cnf.get('Dir::Queue::%s' % queue):
1235 queuefile_path = os.path.join(
1236 cnf['Dir::Queue::%s' % queue], filename
1239 if not os.path.exists(queuefile_path):
1240 # Does not exist in this queue
1243 if symlink_if_valid(queuefile_path):
1248 ###########################################################################
1250 def check_lintian(self):
1253 # Don't reject binary uploads
1254 if not self.pkg.changes['architecture'].has_key('source'):
1257 # Only check some distributions
1259 for dist in ('unstable', 'experimental'):
1260 if dist in self.pkg.changes['distribution']:
1267 tagfile = cnf.get("Dinstall::LintianTags")
1269 # We don't have a tagfile, so just don't do anything.
1272 # Parse the yaml file
1273 sourcefile = file(tagfile, 'r')
1274 sourcecontent = sourcefile.read()
1277 lintiantags = yaml.load(sourcecontent)['lintian']
1278 except yaml.YAMLError, msg:
1279 utils.fubar("Can not read the lintian tags file %s, YAML error: %s." % (tagfile, msg))
1282 # Try and find all orig mentioned in the .dsc
1283 symlinked = self.ensure_orig()
1285 # Now setup the input file for lintian. lintian wants "one tag per line" only,
1286 # so put it together like it. We put all types of tags in one file and then sort
1287 # through lintians output later to see if its a fatal tag we detected, or not.
1288 # So we only run lintian once on all tags, even if we might reject on some, but not
1290 (fd, temp_filename) = utils.temp_filename()
1291 temptagfile = os.fdopen(fd, 'w')
1292 for tags in lintiantags.values():
1294 temptagfile.write("%s\n" % tag)
1297 # So now we should look at running lintian at the .changes file, capturing output
1299 command = "lintian --show-overrides --tags-from-file %s %s" % (temp_filename, self.pkg.changes_file)
1300 (result, output) = commands.getstatusoutput(command)
1302 # We are done with lintian, remove our tempfile and any symlinks we created
1303 os.unlink(temp_filename)
1304 for symlink in symlinked:
1308 utils.warn("lintian failed for %s [return code: %s]." % (self.pkg.changes_file, result))
1309 utils.warn(utils.prefix_multi_line_string(output, " [possible output:] "))
1311 parsed_tags = parse_lintian_output(output)
1315 self.logger.log([self.pkg.changes_file, "check_lintian"] + list(txt))
1317 self.rejects.extend(
1318 generate_reject_messages(parsed_tags, lintiantags, log=log)
1321 ###########################################################################
1322 def check_urgency(self):
1324 if self.pkg.changes["architecture"].has_key("source"):
1325 if not self.pkg.changes.has_key("urgency"):
1326 self.pkg.changes["urgency"] = cnf["Urgency::Default"]
1327 self.pkg.changes["urgency"] = self.pkg.changes["urgency"].lower()
1328 if self.pkg.changes["urgency"] not in cnf.ValueList("Urgency::Valid"):
1329 self.warnings.append("%s is not a valid urgency; it will be treated as %s by testing." % \
1330 (self.pkg.changes["urgency"], cnf["Urgency::Default"]))
1331 self.pkg.changes["urgency"] = cnf["Urgency::Default"]
1333 ###########################################################################
1335 # Sanity check the time stamps of files inside debs.
1336 # [Files in the near future cause ugly warnings and extreme time
1337 # travel can cause errors on extraction]
1339 def check_timestamps(self):
1342 future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"])
1343 past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"))
1344 tar = TarTime(future_cutoff, past_cutoff)
1346 for filename, entry in self.pkg.files.items():
1347 if entry["type"] == "deb":
1350 deb_file = utils.open_file(filename)
1351 apt_inst.debExtract(deb_file, tar.callback, "control.tar.gz")
1354 apt_inst.debExtract(deb_file, tar.callback, "data.tar.gz")
1355 except SystemError, e:
1356 # If we can't find a data.tar.gz, look for data.tar.bz2 instead.
1357 if not re.search(r"Cannot f[ui]nd chunk data.tar.gz$", str(e)):
1360 apt_inst.debExtract(deb_file,tar.callback,"data.tar.bz2")
1364 future_files = tar.future_files.keys()
1366 num_future_files = len(future_files)
1367 future_file = future_files[0]
1368 future_date = tar.future_files[future_file]
1369 self.rejects.append("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
1370 % (filename, num_future_files, future_file, time.ctime(future_date)))
1372 ancient_files = tar.ancient_files.keys()
1374 num_ancient_files = len(ancient_files)
1375 ancient_file = ancient_files[0]
1376 ancient_date = tar.ancient_files[ancient_file]
1377 self.rejects.append("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
1378 % (filename, num_ancient_files, ancient_file, time.ctime(ancient_date)))
1380 self.rejects.append("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value))
1382 def check_if_upload_is_sponsored(self, uid_email, uid_name):
1383 if uid_email in [self.pkg.changes["maintaineremail"], self.pkg.changes["changedbyemail"]]:
1385 elif uid_name in [self.pkg.changes["maintainername"], self.pkg.changes["changedbyname"]]:
1391 if ("source" in self.pkg.changes["architecture"] and uid_email and utils.is_email_alias(uid_email)):
1392 sponsor_addresses = utils.gpg_get_key_addresses(self.pkg.changes["fingerprint"])
1393 if (self.pkg.changes["maintaineremail"] not in sponsor_addresses and
1394 self.pkg.changes["changedbyemail"] not in sponsor_addresses):
1395 self.pkg.changes["sponsoremail"] = uid_email
1400 ###########################################################################
1401 # check_signed_by_key checks
1402 ###########################################################################
1404 def check_signed_by_key(self):
1405 """Ensure the .changes is signed by an authorized uploader."""
1406 session = DBConn().session()
1408 # First of all we check that the person has proper upload permissions
1409 # and that this upload isn't blocked
1410 fpr = get_fingerprint(self.pkg.changes['fingerprint'], session=session)
1413 self.rejects.append("Cannot find fingerprint %s" % self.pkg.changes["fingerprint"])
1416 # TODO: Check that import-keyring adds UIDs properly
1418 self.rejects.append("Cannot find uid for fingerprint %s. Please contact ftpmaster@debian.org" % fpr.fingerprint)
1421 # Check that the fingerprint which uploaded has permission to do so
1422 self.check_upload_permissions(fpr, session)
1424 # Check that this package is not in a transition
1425 self.check_transition(session)
1430 def check_upload_permissions(self, fpr, session):
1431 # Check any one-off upload blocks
1432 self.check_upload_blocks(fpr, session)
1434 # Start with DM as a special case
1435 # DM is a special case unfortunately, so we check it first
1436 # (keys with no source access get more access than DMs in one
1437 # way; DMs can only upload for their packages whether source
1438 # or binary, whereas keys with no access might be able to
1439 # upload some binaries)
1440 if fpr.source_acl.access_level == 'dm':
1441 self.check_dm_upload(fpr, session)
1443 # Check source-based permissions for other types
1444 if self.pkg.changes["architecture"].has_key("source"):
1445 if fpr.source_acl.access_level is None:
1446 rej = 'Fingerprint %s may not upload source' % fpr.fingerprint
1447 rej += '\nPlease contact ftpmaster if you think this is incorrect'
1448 self.rejects.append(rej)
1451 # If not a DM, we allow full upload rights
1452 uid_email = "%s@debian.org" % (fpr.uid.uid)
1453 self.check_if_upload_is_sponsored(uid_email, fpr.uid.name)
1456 # Check binary upload permissions
1457 # By this point we know that DMs can't have got here unless they
1458 # are allowed to deal with the package concerned so just apply
1460 if fpr.binary_acl.access_level == 'full':
1463 # Otherwise we're in the map case
1464 tmparches = self.pkg.changes["architecture"].copy()
1465 tmparches.pop('source', None)
1467 for bam in fpr.binary_acl_map:
1468 tmparches.pop(bam.architecture.arch_string, None)
1470 if len(tmparches.keys()) > 0:
1471 if fpr.binary_reject:
1472 rej = ".changes file contains files of architectures not permitted for fingerprint %s" % fpr.fingerprint
1473 rej += "\narchitectures involved are: ", ",".join(tmparches.keys())
1474 self.rejects.append(rej)
1476 # TODO: This is where we'll implement reject vs throw away binaries later
1477 rej = "Uhm. I'm meant to throw away the binaries now but that's not implemented yet"
1478 rej += "\nPlease complain to ftpmaster@debian.org as this shouldn't have been turned on"
1479 rej += "\nFingerprint: %s", (fpr.fingerprint)
1480 self.rejects.append(rej)
1483 def check_upload_blocks(self, fpr, session):
1484 """Check whether any upload blocks apply to this source, source
1485 version, uid / fpr combination"""
1487 def block_rej_template(fb):
1488 rej = 'Manual upload block in place for package %s' % fb.source
1489 if fb.version is not None:
1490 rej += ', version %s' % fb.version
1493 for fb in session.query(UploadBlock).filter_by(source = self.pkg.changes['source']).all():
1494 # version is None if the block applies to all versions
1495 if fb.version is None or fb.version == self.pkg.changes['version']:
1496 # Check both fpr and uid - either is enough to cause a reject
1497 if fb.fpr is not None:
1498 if fb.fpr.fingerprint == fpr.fingerprint:
1499 self.rejects.append(block_rej_template(fb) + ' for fingerprint %s\nReason: %s' % (fpr.fingerprint, fb.reason))
1500 if fb.uid is not None:
1501 if fb.uid == fpr.uid:
1502 self.rejects.append(block_rej_template(fb) + ' for uid %s\nReason: %s' % (fb.uid.uid, fb.reason))
1505 def check_dm_upload(self, fpr, session):
1506 # Quoth the GR (http://www.debian.org/vote/2007/vote_003):
1507 ## none of the uploaded packages are NEW
1509 for f in self.pkg.files.keys():
1510 if self.pkg.files[f].has_key("byhand"):
1511 self.rejects.append("%s may not upload BYHAND file %s" % (fpr.uid.uid, f))
1513 if self.pkg.files[f].has_key("new"):
1514 self.rejects.append("%s may not upload NEW file %s" % (fpr.uid.uid, f))
1520 ## the most recent version of the package uploaded to unstable or
1521 ## experimental includes the field "DM-Upload-Allowed: yes" in the source
1522 ## section of its control file
1523 q = session.query(DBSource).filter_by(source=self.pkg.changes["source"])
1524 q = q.join(SrcAssociation)
1525 q = q.join(Suite).filter(Suite.suite_name.in_(['unstable', 'experimental']))
1526 q = q.order_by(desc('source.version')).limit(1)
1531 rej = "Could not find existing source package %s in unstable or experimental and this is a DM upload" % self.pkg.changes["source"]
1532 self.rejects.append(rej)
1536 if not r.dm_upload_allowed:
1537 rej = "Source package %s does not have 'DM-Upload-Allowed: yes' in its most recent version (%s)" % (self.pkg.changes["source"], r.version)
1538 self.rejects.append(rej)
1541 ## the Maintainer: field of the uploaded .changes file corresponds with
1542 ## the owner of the key used (ie, non-developer maintainers may not sponsor
1544 if self.check_if_upload_is_sponsored(fpr.uid.uid, fpr.uid.name):
1545 self.rejects.append("%s (%s) is not authorised to sponsor uploads" % (fpr.uid.uid, fpr.fingerprint))
1547 ## the most recent version of the package uploaded to unstable or
1548 ## experimental lists the uploader in the Maintainer: or Uploaders: fields (ie,
1549 ## non-developer maintainers cannot NMU or hijack packages)
1551 # srcuploaders includes the maintainer
1553 for sup in r.srcuploaders:
1554 (rfc822, rfc2047, name, email) = sup.maintainer.get_split_maintainer()
1555 # Eww - I hope we never have two people with the same name in Debian
1556 if email == fpr.uid.uid or name == fpr.uid.name:
1561 self.rejects.append("%s is not in Maintainer or Uploaders of source package %s" % (fpr.uid.uid, self.pkg.changes["source"]))
1564 ## none of the packages are being taken over from other source packages
1565 for b in self.pkg.changes["binary"].keys():
1566 for suite in self.pkg.changes["distribution"].keys():
1567 q = session.query(DBSource)
1568 q = q.join(DBBinary).filter_by(package=b)
1569 q = q.join(BinAssociation).join(Suite).filter_by(suite_name=suite)
1572 if s.source != self.pkg.changes["source"]:
1573 self.rejects.append("%s may not hijack %s from source package %s in suite %s" % (fpr.uid.uid, b, s, suite))
1577 def check_transition(self, session):
1580 sourcepkg = self.pkg.changes["source"]
1582 # No sourceful upload -> no need to do anything else, direct return
1583 # We also work with unstable uploads, not experimental or those going to some
1584 # proposed-updates queue
1585 if "source" not in self.pkg.changes["architecture"] or \
1586 "unstable" not in self.pkg.changes["distribution"]:
1589 # Also only check if there is a file defined (and existant) with
1591 transpath = cnf.get("Dinstall::Reject::ReleaseTransitions", "")
1592 if transpath == "" or not os.path.exists(transpath):
1595 # Parse the yaml file
1596 sourcefile = file(transpath, 'r')
1597 sourcecontent = sourcefile.read()
1599 transitions = yaml.load(sourcecontent)
1600 except yaml.YAMLError, msg:
1601 # This shouldn't happen, there is a wrapper to edit the file which
1602 # checks it, but we prefer to be safe than ending up rejecting
1604 utils.warn("Not checking transitions, the transitions file is broken: %s." % (msg))
1607 # Now look through all defined transitions
1608 for trans in transitions:
1609 t = transitions[trans]
1610 source = t["source"]
1613 # Will be None if nothing is in testing.
1614 current = get_source_in_suite(source, "testing", session)
1615 if current is not None:
1616 compare = apt_pkg.VersionCompare(current.version, expected)
1618 if current is None or compare < 0:
1619 # This is still valid, the current version in testing is older than
1620 # the new version we wait for, or there is none in testing yet
1622 # Check if the source we look at is affected by this.
1623 if sourcepkg in t['packages']:
1624 # The source is affected, lets reject it.
1626 rejectmsg = "%s: part of the %s transition.\n\n" % (
1629 if current is not None:
1630 currentlymsg = "at version %s" % (current.version)
1632 currentlymsg = "not present in testing"
1634 rejectmsg += "Transition description: %s\n\n" % (t["reason"])
1636 rejectmsg += "\n".join(textwrap.wrap("""Your package
1637 is part of a testing transition designed to get %s migrated (it is
1638 currently %s, we need version %s). This transition is managed by the
1639 Release Team, and %s is the Release-Team member responsible for it.
1640 Please mail debian-release@lists.debian.org or contact %s directly if you
1641 need further assistance. You might want to upload to experimental until this
1642 transition is done."""
1643 % (source, currentlymsg, expected,t["rm"], t["rm"])))
1645 self.rejects.append(rejectmsg)
1648 ###########################################################################
1649 # End check_signed_by_key checks
1650 ###########################################################################
1652 def build_summaries(self):
1653 """ Build a summary of changes the upload introduces. """
1655 (byhand, new, summary, override_summary) = self.pkg.file_summary()
1657 short_summary = summary
1659 # This is for direport's benefit...
1660 f = re_fdnic.sub("\n .\n", self.pkg.changes.get("changes", ""))
1663 summary += "Changes: " + f
1665 summary += "\n\nOverride entries for your package:\n" + override_summary + "\n"
1667 summary += self.announce(short_summary, 0)
1669 return (summary, short_summary)
1671 ###########################################################################
1673 def close_bugs(self, summary, action):
1675 Send mail to close bugs as instructed by the closes field in the changes file.
1676 Also add a line to summary if any work was done.
1678 @type summary: string
1679 @param summary: summary text, as given by L{build_summaries}
1682 @param action: Set to false no real action will be done.
1685 @return: summary. If action was taken, extended by the list of closed bugs.
1689 template = os.path.join(Config()["Dir::Templates"], 'process-unchecked.bug-close')
1691 bugs = self.pkg.changes["closes"].keys()
1697 summary += "Closing bugs: "
1699 summary += "%s " % (bug)
1702 self.Subst["__BUG_NUMBER__"] = bug
1703 if self.pkg.changes["distribution"].has_key("stable"):
1704 self.Subst["__STABLE_WARNING__"] = """
1705 Note that this package is not part of the released stable Debian
1706 distribution. It may have dependencies on other unreleased software,
1707 or other instabilities. Please take care if you wish to install it.
1708 The update will eventually make its way into the next released Debian
1711 self.Subst["__STABLE_WARNING__"] = ""
1712 mail_message = utils.TemplateSubst(self.Subst, template)
1713 utils.send_mail(mail_message)
1715 # Clear up after ourselves
1716 del self.Subst["__BUG_NUMBER__"]
1717 del self.Subst["__STABLE_WARNING__"]
1719 if action and self.logger:
1720 self.logger.log(["closing bugs"] + bugs)
1726 ###########################################################################
1728 def announce(self, short_summary, action):
1730 Send an announce mail about a new upload.
1732 @type short_summary: string
1733 @param short_summary: Short summary text to include in the mail
1736 @param action: Set to false no real action will be done.
1739 @return: Textstring about action taken.
1744 announcetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.announce')
1746 # Only do announcements for source uploads with a recent dpkg-dev installed
1747 if float(self.pkg.changes.get("format", 0)) < 1.6 or not \
1748 self.pkg.changes["architecture"].has_key("source"):
1754 self.Subst["__SHORT_SUMMARY__"] = short_summary
1756 for dist in self.pkg.changes["distribution"].keys():
1757 announce_list = cnf.Find("Suite::%s::Announce" % (dist))
1758 if announce_list == "" or lists_done.has_key(announce_list):
1761 lists_done[announce_list] = 1
1762 summary += "Announcing to %s\n" % (announce_list)
1766 self.Subst["__ANNOUNCE_LIST_ADDRESS__"] = announce_list
1767 if cnf.get("Dinstall::TrackingServer") and \
1768 self.pkg.changes["architecture"].has_key("source"):
1769 trackingsendto = "Bcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
1770 self.Subst["__ANNOUNCE_LIST_ADDRESS__"] += "\n" + trackingsendto
1772 mail_message = utils.TemplateSubst(self.Subst, announcetemplate)
1773 utils.send_mail(mail_message)
1775 del self.Subst["__ANNOUNCE_LIST_ADDRESS__"]
1777 if cnf.FindB("Dinstall::CloseBugs"):
1778 summary = self.close_bugs(summary, action)
1780 del self.Subst["__SHORT_SUMMARY__"]
1784 ###########################################################################
1786 def accept (self, summary, short_summary, session=None):
1790 This moves all files referenced from the .changes into the pool,
1791 sends the accepted mail, announces to lists, closes bugs and
1792 also checks for override disparities. If enabled it will write out
1793 the version history for the BTS Version Tracking and will finally call
1796 @type summary: string
1797 @param summary: Summary text
1799 @type short_summary: string
1800 @param short_summary: Short summary
1804 stats = SummaryStats()
1807 self.logger.log(["installing changes", self.pkg.changes_file])
1811 # Add the .dsc file to the DB first
1812 for newfile, entry in self.pkg.files.items():
1813 if entry["type"] == "dsc":
1814 dsc_component, dsc_location_id, pfs = add_dsc_to_db(self, newfile, session)
1818 # Add .deb / .udeb files to the DB (type is always deb, dbtype is udeb/deb)
1819 for newfile, entry in self.pkg.files.items():
1820 if entry["type"] == "deb":
1821 poolfiles.append(add_deb_to_db(self, newfile, session))
1823 # If this is a sourceful diff only upload that is moving
1824 # cross-component we need to copy the .orig files into the new
1825 # component too for the same reasons as above.
1826 if self.pkg.changes["architecture"].has_key("source"):
1827 for orig_file in self.pkg.orig_files.keys():
1828 if not self.pkg.orig_files[orig_file].has_key("id"):
1829 continue # Skip if it's not in the pool
1830 orig_file_id = self.pkg.orig_files[orig_file]["id"]
1831 if self.pkg.orig_files[orig_file]["location"] == dsc_location_id:
1832 continue # Skip if the location didn't change
1835 oldf = get_poolfile_by_id(orig_file_id, session)
1836 old_filename = os.path.join(oldf.location.path, oldf.filename)
1837 old_dat = {'size': oldf.filesize, 'md5sum': oldf.md5sum,
1838 'sha1sum': oldf.sha1sum, 'sha256sum': oldf.sha256sum}
1840 new_filename = os.path.join(utils.poolify(self.pkg.changes["source"], dsc_component), os.path.basename(old_filename))
1842 # TODO: Care about size/md5sum collisions etc
1843 (found, newf) = check_poolfile(new_filename, file_size, file_md5sum, dsc_location_id, session)
1846 utils.copy(old_filename, os.path.join(cnf["Dir::Pool"], new_filename))
1847 newf = add_poolfile(new_filename, old_dat, dsc_location_id, session)
1849 # TODO: Check that there's only 1 here
1850 source = get_sources_from_name(self.pkg.changes["source"], self.pkg.changes["version"])[0]
1851 dscf = get_dscfiles(source_id=source.source_id, poolfile_id=orig_file_id, session=session)[0]
1852 dscf.poolfile_id = newf.file_id
1856 poolfiles.append(newf)
1858 # Install the files into the pool
1859 for newfile, entry in self.pkg.files.items():
1860 destination = os.path.join(cnf["Dir::Pool"], entry["pool name"], newfile)
1861 utils.move(newfile, destination)
1862 self.logger.log(["installed", newfile, entry["type"], entry["size"], entry["architecture"]])
1863 stats.accept_bytes += float(entry["size"])
1865 # Copy the .changes file across for suite which need it.
1867 for suite_name in self.pkg.changes["distribution"].keys():
1868 if cnf.has_key("Suite::%s::CopyChanges" % (suite_name)):
1869 copy_changes[cnf["Suite::%s::CopyChanges" % (suite_name)]] = ""
1871 for dest in copy_changes.keys():
1872 utils.copy(self.pkg.changes_file, os.path.join(cnf["Dir::Root"], dest))
1874 # We're done - commit the database changes
1876 # Our SQL session will automatically start a new transaction after
1879 # Move the .changes into the 'done' directory
1880 utils.move(self.pkg.changes_file,
1881 os.path.join(cnf["Dir::Queue::Done"], os.path.basename(self.pkg.changes_file)))
1883 if self.pkg.changes["architecture"].has_key("source") and cnf.get("Dir::UrgencyLog"):
1884 UrgencyLog().log(self.pkg.dsc["source"], self.pkg.dsc["version"], self.pkg.changes["urgency"])
1886 # Send accept mail, announce to lists, close bugs and check for
1887 # override disparities
1888 if not cnf["Dinstall::Options::No-Mail"]:
1890 self.Subst["__SUITE__"] = ""
1891 self.Subst["__SUMMARY__"] = summary
1892 mail_message = utils.TemplateSubst(self.Subst,
1893 os.path.join(cnf["Dir::Templates"], 'process-unchecked.accepted'))
1894 utils.send_mail(mail_message)
1895 self.announce(short_summary, 1)
1897 ## Helper stuff for DebBugs Version Tracking
1898 if cnf.Find("Dir::Queue::BTSVersionTrack"):
1899 # ??? once queue/* is cleared on *.d.o and/or reprocessed
1900 # the conditionalization on dsc["bts changelog"] should be
1903 # Write out the version history from the changelog
1904 if self.pkg.changes["architecture"].has_key("source") and \
1905 self.pkg.dsc.has_key("bts changelog"):
1907 (fd, temp_filename) = utils.temp_filename(cnf["Dir::Queue::BTSVersionTrack"], prefix=".")
1908 version_history = os.fdopen(fd, 'w')
1909 version_history.write(self.pkg.dsc["bts changelog"])
1910 version_history.close()
1911 filename = "%s/%s" % (cnf["Dir::Queue::BTSVersionTrack"],
1912 self.pkg.changes_file[:-8]+".versions")
1913 os.rename(temp_filename, filename)
1914 os.chmod(filename, 0644)
1916 # Write out the binary -> source mapping.
1917 (fd, temp_filename) = utils.temp_filename(cnf["Dir::Queue::BTSVersionTrack"], prefix=".")
1918 debinfo = os.fdopen(fd, 'w')
1919 for name, entry in sorted(self.pkg.files.items()):
1920 if entry["type"] == "deb":
1921 line = " ".join([entry["package"], entry["version"],
1922 entry["architecture"], entry["source package"],
1923 entry["source version"]])
1924 debinfo.write(line+"\n")
1926 filename = "%s/%s" % (cnf["Dir::Queue::BTSVersionTrack"],
1927 self.pkg.changes_file[:-8]+".debinfo")
1928 os.rename(temp_filename, filename)
1929 os.chmod(filename, 0644)
1933 # Set up our copy queues (e.g. buildd queues)
1934 for suite_name in self.pkg.changes["distribution"].keys():
1935 suite = get_suite(suite_name, session)
1936 for q in suite.copy_queues:
1938 q.add_file_from_pool(f)
1943 stats.accept_count += 1
1945 def check_override(self):
1947 Checks override entries for validity. Mails "Override disparity" warnings,
1948 if that feature is enabled.
1950 Abandons the check if
1951 - override disparity checks are disabled
1952 - mail sending is disabled
1957 # Abandon the check if:
1958 # a) override disparity checks have been disabled
1959 # b) we're not sending mail
1960 if not cnf.FindB("Dinstall::OverrideDisparityCheck") or \
1961 cnf["Dinstall::Options::No-Mail"]:
1964 summary = self.pkg.check_override()
1969 overridetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.override-disparity')
1972 self.Subst["__SUMMARY__"] = summary
1973 mail_message = utils.TemplateSubst(self.Subst, overridetemplate)
1974 utils.send_mail(mail_message)
1975 del self.Subst["__SUMMARY__"]
1977 ###########################################################################
1979 def remove(self, from_dir=None):
1981 Used (for instance) in p-u to remove the package from unchecked
1983 Also removes the package from holding area.
1985 if from_dir is None:
1986 from_dir = self.pkg.directory
1989 for f in self.pkg.files.keys():
1990 os.unlink(os.path.join(from_dir, f))
1991 if os.path.exists(os.path.join(h.holding_dir, f)):
1992 os.unlink(os.path.join(h.holding_dir, f))
1994 os.unlink(os.path.join(from_dir, self.pkg.changes_file))
1995 if os.path.exists(os.path.join(h.holding_dir, self.pkg.changes_file)):
1996 os.unlink(os.path.join(h.holding_dir, self.pkg.changes_file))
1998 ###########################################################################
2000 def move_to_queue (self, queue):
2002 Move files to a destination queue using the permissions in the table
2005 utils.move(os.path.join(h.holding_dir, self.pkg.changes_file),
2006 queue.path, perms=int(queue.change_perms, 8))
2007 for f in self.pkg.files.keys():
2008 utils.move(os.path.join(h.holding_dir, f), queue.path, perms=int(queue.perms, 8))
2010 ###########################################################################
2012 def force_reject(self, reject_files):
2014 Forcefully move files from the current directory to the
2015 reject directory. If any file already exists in the reject
2016 directory it will be moved to the morgue to make way for
2020 @param files: file dictionary
2026 for file_entry in reject_files:
2027 # Skip any files which don't exist or which we don't have permission to copy.
2028 if os.access(file_entry, os.R_OK) == 0:
2031 dest_file = os.path.join(cnf["Dir::Queue::Reject"], file_entry)
2034 dest_fd = os.open(dest_file, os.O_RDWR | os.O_CREAT | os.O_EXCL, 0644)
2036 # File exists? Let's try and move it to the morgue
2037 if e.errno == errno.EEXIST:
2038 morgue_file = os.path.join(cnf["Dir::Morgue"], cnf["Dir::MorgueReject"], file_entry)
2040 morgue_file = utils.find_next_free(morgue_file)
2041 except NoFreeFilenameError:
2042 # Something's either gone badly Pete Tong, or
2043 # someone is trying to exploit us.
2044 utils.warn("**WARNING** failed to move %s from the reject directory to the morgue." % (file_entry))
2046 utils.move(dest_file, morgue_file, perms=0660)
2048 dest_fd = os.open(dest_file, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
2051 utils.warn("**WARNING** failed to claim %s in the reject directory." % (file_entry))
2055 # If we got here, we own the destination file, so we can
2056 # safely overwrite it.
2057 utils.move(file_entry, dest_file, 1, perms=0660)
2060 ###########################################################################
2061 def do_reject (self, manual=0, reject_message="", note=""):
2063 Reject an upload. If called without a reject message or C{manual} is
2064 true, spawn an editor so the user can write one.
2067 @param manual: manual or automated rejection
2069 @type reject_message: string
2070 @param reject_message: A reject message
2075 # If we weren't given a manual rejection message, spawn an
2076 # editor so the user can add one in...
2077 if manual and not reject_message:
2078 (fd, temp_filename) = utils.temp_filename()
2079 temp_file = os.fdopen(fd, 'w')
2082 temp_file.write(line)
2084 editor = os.environ.get("EDITOR","vi")
2086 while answer == 'E':
2087 os.system("%s %s" % (editor, temp_filename))
2088 temp_fh = utils.open_file(temp_filename)
2089 reject_message = "".join(temp_fh.readlines())
2091 print "Reject message:"
2092 print utils.prefix_multi_line_string(reject_message," ",include_blank_lines=1)
2093 prompt = "[R]eject, Edit, Abandon, Quit ?"
2095 while prompt.find(answer) == -1:
2096 answer = utils.our_raw_input(prompt)
2097 m = re_default_answer.search(prompt)
2100 answer = answer[:1].upper()
2101 os.unlink(temp_filename)
2107 print "Rejecting.\n"
2111 reason_filename = self.pkg.changes_file[:-8] + ".reason"
2112 reason_filename = os.path.join(cnf["Dir::Queue::Reject"], reason_filename)
2114 # Move all the files into the reject directory
2115 reject_files = self.pkg.files.keys() + [self.pkg.changes_file]
2116 self.force_reject(reject_files)
2118 # If we fail here someone is probably trying to exploit the race
2119 # so let's just raise an exception ...
2120 if os.path.exists(reason_filename):
2121 os.unlink(reason_filename)
2122 reason_fd = os.open(reason_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
2124 rej_template = os.path.join(cnf["Dir::Templates"], "queue.rejected")
2128 self.Subst["__REJECTOR_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
2129 self.Subst["__MANUAL_REJECT_MESSAGE__"] = ""
2130 self.Subst["__CC__"] = "X-DAK-Rejection: automatic (moo)"
2131 os.write(reason_fd, reject_message)
2132 reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
2134 # Build up the rejection email
2135 user_email_address = utils.whoami() + " <%s>" % (cnf["Dinstall::MyAdminAddress"])
2136 self.Subst["__REJECTOR_ADDRESS__"] = user_email_address
2137 self.Subst["__MANUAL_REJECT_MESSAGE__"] = reject_message
2138 self.Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
2139 reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
2140 # Write the rejection email out as the <foo>.reason file
2141 os.write(reason_fd, reject_mail_message)
2143 del self.Subst["__REJECTOR_ADDRESS__"]
2144 del self.Subst["__MANUAL_REJECT_MESSAGE__"]
2145 del self.Subst["__CC__"]
2149 # Send the rejection mail if appropriate
2150 if not cnf["Dinstall::Options::No-Mail"]:
2151 utils.send_mail(reject_mail_message)
2154 self.logger.log(["rejected", self.pkg.changes_file])
2158 ################################################################################
2159 def in_override_p(self, package, component, suite, binary_type, filename, session):
2161 Check if a package already has override entries in the DB
2163 @type package: string
2164 @param package: package name
2166 @type component: string
2167 @param component: database id of the component
2170 @param suite: database id of the suite
2172 @type binary_type: string
2173 @param binary_type: type of the package
2175 @type filename: string
2176 @param filename: filename we check
2178 @return: the database result. But noone cares anyway.
2184 if binary_type == "": # must be source
2187 file_type = binary_type
2189 # Override suite name; used for example with proposed-updates
2190 if cnf.Find("Suite::%s::OverrideSuite" % (suite)) != "":
2191 suite = cnf["Suite::%s::OverrideSuite" % (suite)]
2193 result = get_override(package, suite, component, file_type, session)
2195 # If checking for a source package fall back on the binary override type
2196 if file_type == "dsc" and len(result) < 1:
2197 result = get_override(package, suite, component, ['deb', 'udeb'], session)
2199 # Remember the section and priority so we can check them later if appropriate
2202 self.pkg.files[filename]["override section"] = result.section.section
2203 self.pkg.files[filename]["override priority"] = result.priority.priority
2208 ################################################################################
2209 def get_anyversion(self, sv_list, suite):
2212 @param sv_list: list of (suite, version) tuples to check
2215 @param suite: suite name
2221 anysuite = [suite] + Cnf.ValueList("Suite::%s::VersionChecks::Enhances" % (suite))
2222 for (s, v) in sv_list:
2223 if s in [ x.lower() for x in anysuite ]:
2224 if not anyversion or apt_pkg.VersionCompare(anyversion, v) <= 0:
2229 ################################################################################
2231 def cross_suite_version_check(self, sv_list, filename, new_version, sourceful=False):
2234 @param sv_list: list of (suite, version) tuples to check
2236 @type filename: string
2237 @param filename: XXX
2239 @type new_version: string
2240 @param new_version: XXX
2242 Ensure versions are newer than existing packages in target
2243 suites and that cross-suite version checking rules as
2244 set out in the conf file are satisfied.
2249 # Check versions for each target suite
2250 for target_suite in self.pkg.changes["distribution"].keys():
2251 must_be_newer_than = [ i.lower() for i in cnf.ValueList("Suite::%s::VersionChecks::MustBeNewerThan" % (target_suite)) ]
2252 must_be_older_than = [ i.lower() for i in cnf.ValueList("Suite::%s::VersionChecks::MustBeOlderThan" % (target_suite)) ]
2254 # Enforce "must be newer than target suite" even if conffile omits it
2255 if target_suite not in must_be_newer_than:
2256 must_be_newer_than.append(target_suite)
2258 for (suite, existent_version) in sv_list:
2259 vercmp = apt_pkg.VersionCompare(new_version, existent_version)
2261 if suite in must_be_newer_than and sourceful and vercmp < 1:
2262 self.rejects.append("%s: old version (%s) in %s >= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2264 if suite in must_be_older_than and vercmp > -1:
2267 if self.pkg.changes.get('distribution-version', {}).has_key(suite):
2268 # we really use the other suite, ignoring the conflicting one ...
2269 addsuite = self.pkg.changes["distribution-version"][suite]
2271 add_version = self.get_anyversion(sv_list, addsuite)
2272 target_version = self.get_anyversion(sv_list, target_suite)
2275 # not add_version can only happen if we map to a suite
2276 # that doesn't enhance the suite we're propup'ing from.
2277 # so "propup-ver x a b c; map a d" is a problem only if
2278 # d doesn't enhance a.
2280 # i think we could always propagate in this case, rather
2281 # than complaining. either way, this isn't a REJECT issue
2283 # And - we really should complain to the dorks who configured dak
2284 self.warnings.append("%s is mapped to, but not enhanced by %s - adding anyways" % (suite, addsuite))
2285 self.pkg.changes.setdefault("propdistribution", {})
2286 self.pkg.changes["propdistribution"][addsuite] = 1
2288 elif not target_version:
2289 # not targets_version is true when the package is NEW
2290 # we could just stick with the "...old version..." REJECT
2291 # for this, I think.
2292 self.rejects.append("Won't propogate NEW packages.")
2293 elif apt_pkg.VersionCompare(new_version, add_version) < 0:
2294 # propogation would be redundant. no need to reject though.
2295 self.warnings.append("ignoring versionconflict: %s: old version (%s) in %s <= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2297 elif apt_pkg.VersionCompare(new_version, add_version) > 0 and \
2298 apt_pkg.VersionCompare(add_version, target_version) >= 0:
2300 self.warnings.append("Propogating upload to %s" % (addsuite))
2301 self.pkg.changes.setdefault("propdistribution", {})
2302 self.pkg.changes["propdistribution"][addsuite] = 1
2306 self.reject.append("%s: old version (%s) in %s <= new version (%s) targeted at %s." % (filename, existent_version, suite, new_version, target_suite))
2308 ################################################################################
2309 def check_binary_against_db(self, filename, session):
2310 # Ensure version is sane
2311 q = session.query(BinAssociation)
2312 q = q.join(DBBinary).filter(DBBinary.package==self.pkg.files[filename]["package"])
2313 q = q.join(Architecture).filter(Architecture.arch_string.in_([self.pkg.files[filename]["architecture"], 'all']))
2315 self.cross_suite_version_check([ (x.suite.suite_name, x.binary.version) for x in q.all() ],
2316 filename, self.pkg.files[filename]["version"], sourceful=False)
2318 # Check for any existing copies of the file
2319 q = session.query(DBBinary).filter_by(package=self.pkg.files[filename]["package"])
2320 q = q.filter_by(version=self.pkg.files[filename]["version"])
2321 q = q.join(Architecture).filter_by(arch_string=self.pkg.files[filename]["architecture"])
2324 self.rejects.append("%s: can not overwrite existing copy already in the archive." % filename)
2326 ################################################################################
2328 def check_source_against_db(self, filename, session):
2331 source = self.pkg.dsc.get("source")
2332 version = self.pkg.dsc.get("version")
2334 # Ensure version is sane
2335 q = session.query(SrcAssociation)
2336 q = q.join(DBSource).filter(DBSource.source==source)
2338 self.cross_suite_version_check([ (x.suite.suite_name, x.source.version) for x in q.all() ],
2339 filename, version, sourceful=True)
2341 ################################################################################
2342 def check_dsc_against_db(self, filename, session):
2345 @warning: NB: this function can remove entries from the 'files' index [if
2346 the orig tarball is a duplicate of the one in the archive]; if
2347 you're iterating over 'files' and call this function as part of
2348 the loop, be sure to add a check to the top of the loop to
2349 ensure you haven't just tried to dereference the deleted entry.
2354 self.pkg.orig_files = {} # XXX: do we need to clear it?
2355 orig_files = self.pkg.orig_files
2357 # Try and find all files mentioned in the .dsc. This has
2358 # to work harder to cope with the multiple possible
2359 # locations of an .orig.tar.gz.
2360 # The ordering on the select is needed to pick the newest orig
2361 # when it exists in multiple places.
2362 for dsc_name, dsc_entry in self.pkg.dsc_files.items():
2364 if self.pkg.files.has_key(dsc_name):
2365 actual_md5 = self.pkg.files[dsc_name]["md5sum"]
2366 actual_size = int(self.pkg.files[dsc_name]["size"])
2367 found = "%s in incoming" % (dsc_name)
2369 # Check the file does not already exist in the archive
2370 ql = get_poolfile_like_name(dsc_name, session)
2372 # Strip out anything that isn't '%s' or '/%s$'
2374 if not i.filename.endswith(dsc_name):
2377 # "[dak] has not broken them. [dak] has fixed a
2378 # brokenness. Your crappy hack exploited a bug in
2381 # "(Come on! I thought it was always obvious that
2382 # one just doesn't release different files with
2383 # the same name and version.)"
2384 # -- ajk@ on d-devel@l.d.o
2387 # Ignore exact matches for .orig.tar.gz
2389 if re_is_orig_source.match(dsc_name):
2391 if self.pkg.files.has_key(dsc_name) and \
2392 int(self.pkg.files[dsc_name]["size"]) == int(i.filesize) and \
2393 self.pkg.files[dsc_name]["md5sum"] == i.md5sum:
2394 self.warnings.append("ignoring %s, since it's already in the archive." % (dsc_name))
2395 # TODO: Don't delete the entry, just mark it as not needed
2396 # This would fix the stupidity of changing something we often iterate over
2397 # whilst we're doing it
2398 del self.pkg.files[dsc_name]
2399 dsc_entry["files id"] = i.file_id
2400 if not orig_files.has_key(dsc_name):
2401 orig_files[dsc_name] = {}
2402 orig_files[dsc_name]["path"] = os.path.join(i.location.path, i.filename)
2406 self.rejects.append("can not overwrite existing copy of '%s' already in the archive." % (dsc_name))
2408 elif re_is_orig_source.match(dsc_name):
2410 ql = get_poolfile_like_name(dsc_name, session)
2412 # Strip out anything that isn't '%s' or '/%s$'
2413 # TODO: Shouldn't we just search for things which end with our string explicitly in the SQL?
2415 if not i.filename.endswith(dsc_name):
2419 # Unfortunately, we may get more than one match here if,
2420 # for example, the package was in potato but had an -sa
2421 # upload in woody. So we need to choose the right one.
2423 # default to something sane in case we don't match any or have only one
2428 old_file = os.path.join(i.location.path, i.filename)
2429 old_file_fh = utils.open_file(old_file)
2430 actual_md5 = apt_pkg.md5sum(old_file_fh)
2432 actual_size = os.stat(old_file)[stat.ST_SIZE]
2433 if actual_md5 == dsc_entry["md5sum"] and actual_size == int(dsc_entry["size"]):
2436 old_file = os.path.join(i.location.path, i.filename)
2437 old_file_fh = utils.open_file(old_file)
2438 actual_md5 = apt_pkg.md5sum(old_file_fh)
2440 actual_size = os.stat(old_file)[stat.ST_SIZE]
2442 suite_type = x.location.archive_type
2443 # need this for updating dsc_files in install()
2444 dsc_entry["files id"] = x.file_id
2445 # See install() in process-accepted...
2446 if not orig_files.has_key(dsc_name):
2447 orig_files[dsc_name] = {}
2448 orig_files[dsc_name]["id"] = x.file_id
2449 orig_files[dsc_name]["path"] = old_file
2450 orig_files[dsc_name]["location"] = x.location.location_id
2452 # TODO: Record the queues and info in the DB so we don't hardcode all this crap
2453 # Not there? Check the queue directories...
2454 for directory in [ "Accepted", "New", "Byhand", "ProposedUpdates", "OldProposedUpdates", "Embargoed", "Unembargoed" ]:
2455 if not Cnf.has_key("Dir::Queue::%s" % (directory)):
2457 in_otherdir = os.path.join(Cnf["Dir::Queue::%s" % (directory)], dsc_name)
2458 if os.path.exists(in_otherdir):
2459 in_otherdir_fh = utils.open_file(in_otherdir)
2460 actual_md5 = apt_pkg.md5sum(in_otherdir_fh)
2461 in_otherdir_fh.close()
2462 actual_size = os.stat(in_otherdir)[stat.ST_SIZE]
2464 if not orig_files.has_key(dsc_name):
2465 orig_files[dsc_name] = {}
2466 orig_files[dsc_name]["path"] = in_otherdir
2469 self.rejects.append("%s refers to %s, but I can't find it in the queue or in the pool." % (filename, dsc_name))
2472 self.rejects.append("%s refers to %s, but I can't find it in the queue." % (filename, dsc_name))
2474 if actual_md5 != dsc_entry["md5sum"]:
2475 self.rejects.append("md5sum for %s doesn't match %s." % (found, filename))
2476 if actual_size != int(dsc_entry["size"]):
2477 self.rejects.append("size for %s doesn't match %s." % (found, filename))
2479 ################################################################################
2480 # This is used by process-new and process-holding to recheck a changes file
2481 # at the time we're running. It mainly wraps various other internal functions
2482 # and is similar to accepted_checks - these should probably be tidied up
2484 def recheck(self, session):
2486 for f in self.pkg.files.keys():
2487 # The .orig.tar.gz can disappear out from under us is it's a
2488 # duplicate of one in the archive.
2489 if not self.pkg.files.has_key(f):
2492 entry = self.pkg.files[f]
2494 # Check that the source still exists
2495 if entry["type"] == "deb":
2496 source_version = entry["source version"]
2497 source_package = entry["source package"]
2498 if not self.pkg.changes["architecture"].has_key("source") \
2499 and not source_exists(source_package, source_version, self.pkg.changes["distribution"].keys(), session):
2500 source_epochless_version = re_no_epoch.sub('', source_version)
2501 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
2503 for q in ["Accepted", "Embargoed", "Unembargoed", "Newstage"]:
2504 if cnf.has_key("Dir::Queue::%s" % (q)):
2505 if os.path.exists(cnf["Dir::Queue::%s" % (q)] + '/' + dsc_filename):
2508 self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))
2510 # Version and file overwrite checks
2511 if entry["type"] == "deb":
2512 self.check_binary_against_db(f, session)
2513 elif entry["type"] == "dsc":
2514 self.check_source_against_db(f, session)
2515 self.check_dsc_against_db(f, session)
2517 ################################################################################
2518 def accepted_checks(self, overwrite_checks, session):
2519 # Recheck anything that relies on the database; since that's not
2520 # frozen between accept and our run time when called from p-a.
2522 # overwrite_checks is set to False when installing to stable/oldstable
2527 # Find the .dsc (again)
2529 for f in self.pkg.files.keys():
2530 if self.pkg.files[f]["type"] == "dsc":
2533 for checkfile in self.pkg.files.keys():
2534 # The .orig.tar.gz can disappear out from under us is it's a
2535 # duplicate of one in the archive.
2536 if not self.pkg.files.has_key(checkfile):
2539 entry = self.pkg.files[checkfile]
2541 # Check that the source still exists
2542 if entry["type"] == "deb":
2543 source_version = entry["source version"]
2544 source_package = entry["source package"]
2545 if not self.pkg.changes["architecture"].has_key("source") \
2546 and not source_exists(source_package, source_version, self.pkg.changes["distribution"].keys()):
2547 self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, checkfile))
2549 # Version and file overwrite checks
2550 if overwrite_checks:
2551 if entry["type"] == "deb":
2552 self.check_binary_against_db(checkfile, session)
2553 elif entry["type"] == "dsc":
2554 self.check_source_against_db(checkfile, session)
2555 self.check_dsc_against_db(dsc_filename, session)
2557 # propogate in the case it is in the override tables:
2558 for suite in self.pkg.changes.get("propdistribution", {}).keys():
2559 if self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
2560 propogate[suite] = 1
2562 nopropogate[suite] = 1
2564 for suite in propogate.keys():
2565 if suite in nopropogate:
2567 self.pkg.changes["distribution"][suite] = 1
2569 for checkfile in self.pkg.files.keys():
2570 # Check the package is still in the override tables
2571 for suite in self.pkg.changes["distribution"].keys():
2572 if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
2573 self.rejects.append("%s is NEW for %s." % (checkfile, suite))
2575 ################################################################################
2576 # This is not really a reject, but an unaccept, but since a) the code for
2577 # that is non-trivial (reopen bugs, unannounce etc.), b) this should be
2578 # extremely rare, for now we'll go with whining at our admin folks...
2580 def do_unaccept(self):
2584 self.Subst["__REJECTOR_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
2585 self.Subst["__REJECT_MESSAGE__"] = self.package_info()
2586 self.Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
2587 self.Subst["__BCC__"] = "X-DAK: dak process-accepted"
2588 if cnf.has_key("Dinstall::Bcc"):
2589 self.Subst["__BCC__"] += "\nBcc: %s" % (cnf["Dinstall::Bcc"])
2591 template = os.path.join(cnf["Dir::Templates"], "process-accepted.unaccept")
2593 reject_mail_message = utils.TemplateSubst(self.Subst, template)
2595 # Write the rejection email out as the <foo>.reason file
2596 reason_filename = os.path.basename(self.pkg.changes_file[:-8]) + ".reason"
2597 reject_filename = os.path.join(cnf["Dir::Queue::Reject"], reason_filename)
2599 # If we fail here someone is probably trying to exploit the race
2600 # so let's just raise an exception ...
2601 if os.path.exists(reject_filename):
2602 os.unlink(reject_filename)
2604 fd = os.open(reject_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
2605 os.write(fd, reject_mail_message)
2608 utils.send_mail(reject_mail_message)
2610 del self.Subst["__REJECTOR_ADDRESS__"]
2611 del self.Subst["__REJECT_MESSAGE__"]
2612 del self.Subst["__CC__"]
2614 ################################################################################
2615 # If any file of an upload has a recent mtime then chances are good
2616 # the file is still being uploaded.
2618 def upload_too_new(self):
2621 # Move back to the original directory to get accurate time stamps
2623 os.chdir(self.pkg.directory)
2624 file_list = self.pkg.files.keys()
2625 file_list.extend(self.pkg.dsc_files.keys())
2626 file_list.append(self.pkg.changes_file)
2629 last_modified = time.time()-os.path.getmtime(f)
2630 if last_modified < int(cnf["Dinstall::SkipTime"]):