5 Queue utility functions for dak
7 @contact: Debian FTP Master <ftpmaster@debian.org>
8 @copyright: 2001 - 2006 James Troup <james@nocrew.org>
9 @copyright: 2009 Joerg Jaspert <joerg@debian.org>
10 @license: GNU General Public License version 2 or later
13 # This program is free software; you can redistribute it and/or modify
14 # it under the terms of the GNU General Public License as published by
15 # the Free Software Foundation; either version 2 of the License, or
16 # (at your option) any later version.
18 # This program is distributed in the hope that it will be useful,
19 # but WITHOUT ANY WARRANTY; without even the implied warranty of
20 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21 # GNU General Public License for more details.
23 # You should have received a copy of the GNU General Public License
24 # along with this program; if not, write to the Free Software
25 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
27 ###############################################################################
46 from dak_exceptions import *
49 from config import Config
50 from holding import Holding
52 from summarystats import SummaryStats
53 from utils import parse_changes, check_dsc_files
54 from textutils import fix_maintainer
55 from binary import Binary
57 ###############################################################################
59 def get_type(f, session):
61 Get the file type of C{f}
64 @param f: file entry from Changes object
66 @type session: SQLA Session
67 @param session: SQL Alchemy session object
74 if f.has_key("dbtype"):
75 file_type = f["dbtype"]
76 elif re_source_ext.match(f["type"]):
79 utils.fubar("invalid type (%s) for new. Dazed, confused and sure as heck not continuing." % (file_type))
81 # Validate the override type
82 type_id = get_override_type(file_type, session)
84 utils.fubar("invalid type (%s) for new. Say wha?" % (file_type))
88 ################################################################################
90 # Determine what parts in a .changes are NEW
92 def determine_new(changes, files, warn=1):
94 Determine what parts in a C{changes} file are NEW.
96 @type changes: Upload.Pkg.changes dict
97 @param changes: Changes dictionary
99 @type files: Upload.Pkg.files dict
100 @param files: Files dictionary
103 @param warn: Warn if overrides are added for (old)stable
106 @return: dictionary of NEW components.
111 session = DBConn().session()
113 # Build up a list of potentially new things
114 for name, f in files.items():
115 # Skip byhand elements
116 if f["type"] == "byhand":
119 priority = f["priority"]
120 section = f["section"]
121 file_type = get_type(f, session)
122 component = f["component"]
124 if file_type == "dsc":
127 if not new.has_key(pkg):
129 new[pkg]["priority"] = priority
130 new[pkg]["section"] = section
131 new[pkg]["type"] = file_type
132 new[pkg]["component"] = component
133 new[pkg]["files"] = []
135 old_type = new[pkg]["type"]
136 if old_type != file_type:
137 # source gets trumped by deb or udeb
138 if old_type == "dsc":
139 new[pkg]["priority"] = priority
140 new[pkg]["section"] = section
141 new[pkg]["type"] = file_type
142 new[pkg]["component"] = component
144 new[pkg]["files"].append(name)
146 if f.has_key("othercomponents"):
147 new[pkg]["othercomponents"] = f["othercomponents"]
149 for suite in changes["suite"].keys():
150 for pkg in new.keys():
151 ql = get_override(pkg, suite, new[pkg]["component"], new[pkg]["type"], session)
153 for file_entry in new[pkg]["files"]:
154 if files[file_entry].has_key("new"):
155 del files[file_entry]["new"]
159 for s in ['stable', 'oldstable']:
160 if changes["suite"].has_key(s):
161 print "WARNING: overrides will be added for %s!" % s
162 for pkg in new.keys():
163 if new[pkg].has_key("othercomponents"):
164 print "WARNING: %s already present in %s distribution." % (pkg, new[pkg]["othercomponents"])
170 ################################################################################
172 def check_valid(new):
174 Check if section and priority for NEW packages exist in database.
175 Additionally does sanity checks:
176 - debian-installer packages have to be udeb (or source)
177 - non debian-installer packages can not be udeb
178 - source priority can only be assigned to dsc file types
181 @param new: Dict of new packages with their section, priority and type.
184 for pkg in new.keys():
185 section_name = new[pkg]["section"]
186 priority_name = new[pkg]["priority"]
187 file_type = new[pkg]["type"]
189 section = get_section(section_name)
191 new[pkg]["section id"] = -1
193 new[pkg]["section id"] = section.section_id
195 priority = get_priority(priority_name)
197 new[pkg]["priority id"] = -1
199 new[pkg]["priority id"] = priority.priority_id
202 di = section_name.find("debian-installer") != -1
204 # If d-i, we must be udeb and vice-versa
205 if (di and file_type not in ("udeb", "dsc")) or \
206 (not di and file_type == "udeb"):
207 new[pkg]["section id"] = -1
209 # If dsc we need to be source and vice-versa
210 if (priority == "source" and file_type != "dsc") or \
211 (priority != "source" and file_type == "dsc"):
212 new[pkg]["priority id"] = -1
214 ###############################################################################
216 def lookup_uid_from_fingerprint(fpr, session):
219 # This is a stupid default, but see the comments below
222 user = get_uid_from_fingerprint(fpr, session)
226 if user.name is None:
231 # Check the relevant fingerprint (which we have to have)
232 for f in user.fingerprint:
233 if f.fingerprint == fpr:
234 is_dm = f.keyring.debian_maintainer
237 return (uid, uid_name, is_dm)
239 ###############################################################################
241 # Used by Upload.check_timestamps
242 class TarTime(object):
243 def __init__(self, future_cutoff, past_cutoff):
245 self.future_cutoff = future_cutoff
246 self.past_cutoff = past_cutoff
249 self.future_files = {}
250 self.ancient_files = {}
252 def callback(self, Kind, Name, Link, Mode, UID, GID, Size, MTime, Major, Minor):
253 if MTime > self.future_cutoff:
254 self.future_files[Name] = MTime
255 if MTime < self.past_cutoff:
256 self.ancient_files[Name] = MTime
258 ###############################################################################
260 class Upload(object):
262 Everything that has to do with an upload processed.
270 ###########################################################################
273 """ Reset a number of internal variables."""
275 # Initialize the substitution template map
278 self.Subst["__ADMIN_ADDRESS__"] = cnf["Dinstall::MyAdminAddress"]
279 self.Subst["__BUG_SERVER__"] = cnf["Dinstall::BugServer"]
280 self.Subst["__DISTRO__"] = cnf["Dinstall::MyDistribution"]
281 self.Subst["__DAK_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
289 def package_info(self):
292 if len(self.rejects) > 0:
293 msg += "Reject Reasons:\n"
294 msg += "\n".join(self.rejects)
296 if len(self.warnings) > 0:
298 msg += "\n".join(self.warnings)
300 if len(self.notes) > 0:
302 msg += "\n".join(self.notes)
306 ###########################################################################
307 def update_subst(self):
308 """ Set up the per-package template substitution mappings """
312 # If 'dak process-unchecked' crashed out in the right place, architecture may still be a string.
313 if not self.pkg.changes.has_key("architecture") or not \
314 isinstance(self.pkg.changes["architecture"], DictType):
315 self.pkg.changes["architecture"] = { "Unknown" : "" }
317 # and maintainer2047 may not exist.
318 if not self.pkg.changes.has_key("maintainer2047"):
319 self.pkg.changes["maintainer2047"] = cnf["Dinstall::MyEmailAddress"]
321 self.Subst["__ARCHITECTURE__"] = " ".join(self.pkg.changes["architecture"].keys())
322 self.Subst["__CHANGES_FILENAME__"] = os.path.basename(self.pkg.changes_file)
323 self.Subst["__FILE_CONTENTS__"] = self.pkg.changes.get("filecontents", "")
325 # For source uploads the Changed-By field wins; otherwise Maintainer wins.
326 if self.pkg.changes["architecture"].has_key("source") and \
327 self.pkg.changes["changedby822"] != "" and \
328 (self.pkg.changes["changedby822"] != self.pkg.changes["maintainer822"]):
330 self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["changedby2047"]
331 self.Subst["__MAINTAINER_TO__"] = "%s, %s" % (self.pkg.changes["changedby2047"], self.pkg.changes["maintainer2047"])
332 self.Subst["__MAINTAINER__"] = self.pkg.changes.get("changed-by", "Unknown")
334 self.Subst["__MAINTAINER_FROM__"] = self.pkg.changes["maintainer2047"]
335 self.Subst["__MAINTAINER_TO__"] = self.pkg.changes["maintainer2047"]
336 self.Subst["__MAINTAINER__"] = self.pkg.changes.get("maintainer", "Unknown")
338 if "sponsoremail" in self.pkg.changes:
339 self.Subst["__MAINTAINER_TO__"] += ", %s" % self.pkg.changes["sponsoremail"]
341 if cnf.has_key("Dinstall::TrackingServer") and self.pkg.changes.has_key("source"):
342 self.Subst["__MAINTAINER_TO__"] += "\nBcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
344 # Apply any global override of the Maintainer field
345 if cnf.get("Dinstall::OverrideMaintainer"):
346 self.Subst["__MAINTAINER_TO__"] = cnf["Dinstall::OverrideMaintainer"]
347 self.Subst["__MAINTAINER_FROM__"] = cnf["Dinstall::OverrideMaintainer"]
349 self.Subst["__REJECT_MESSAGE__"] = self.package_info()
350 self.Subst["__SOURCE__"] = self.pkg.changes.get("source", "Unknown")
351 self.Subst["__VERSION__"] = self.pkg.changes.get("version", "Unknown")
353 ###########################################################################
354 def load_changes(self, filename):
357 @rvalue: whether the changes file was valid or not. We may want to
358 reject even if this is True (see what gets put in self.rejects).
359 This is simply to prevent us even trying things later which will
360 fail because we couldn't properly parse the file.
363 self.pkg.changes_file = filename
365 # Parse the .changes field into a dictionary
367 self.pkg.changes.update(parse_changes(filename))
368 except CantOpenError:
369 self.rejects.append("%s: can't read file." % (filename))
371 except ParseChangesError, line:
372 self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
374 except ChangesUnicodeError:
375 self.rejects.append("%s: changes file not proper utf-8" % (filename))
378 # Parse the Files field from the .changes into another dictionary
380 self.pkg.files.update(utils.build_file_list(self.pkg.changes))
381 except ParseChangesError, line:
382 self.rejects.append("%s: parse error, can't grok: %s." % (filename, line))
384 except UnknownFormatError, format:
385 self.rejects.append("%s: unknown format '%s'." % (filename, format))
388 # Check for mandatory fields
389 for i in ("distribution", "source", "binary", "architecture",
390 "version", "maintainer", "files", "changes", "description"):
391 if not self.pkg.changes.has_key(i):
392 # Avoid undefined errors later
393 self.rejects.append("%s: Missing mandatory field `%s'." % (filename, i))
396 # Strip a source version in brackets from the source field
397 if re_strip_srcver.search(self.pkg.changes["source"]):
398 self.pkg.changes["source"] = re_strip_srcver.sub('', self.pkg.changes["source"])
400 # Ensure the source field is a valid package name.
401 if not re_valid_pkg_name.match(self.pkg.changes["source"]):
402 self.rejects.append("%s: invalid source name '%s'." % (filename, self.pkg.changes["source"]))
404 # Split multi-value fields into a lower-level dictionary
405 for i in ("architecture", "distribution", "binary", "closes"):
406 o = self.pkg.changes.get(i, "")
408 del self.pkg.changes[i]
410 self.pkg.changes[i] = {}
413 self.pkg.changes[i][j] = 1
415 # Fix the Maintainer: field to be RFC822/2047 compatible
417 (self.pkg.changes["maintainer822"],
418 self.pkg.changes["maintainer2047"],
419 self.pkg.changes["maintainername"],
420 self.pkg.changes["maintaineremail"]) = \
421 fix_maintainer (self.pkg.changes["maintainer"])
422 except ParseMaintError, msg:
423 self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
424 % (filename, changes["maintainer"], msg))
426 # ...likewise for the Changed-By: field if it exists.
428 (self.pkg.changes["changedby822"],
429 self.pkg.changes["changedby2047"],
430 self.pkg.changes["changedbyname"],
431 self.pkg.changes["changedbyemail"]) = \
432 fix_maintainer (self.pkg.changes.get("changed-by", ""))
433 except ParseMaintError, msg:
434 self.pkg.changes["changedby822"] = ""
435 self.pkg.changes["changedby2047"] = ""
436 self.pkg.changes["changedbyname"] = ""
437 self.pkg.changes["changedbyemail"] = ""
439 self.rejects.append("%s: Changed-By field ('%s') failed to parse: %s" \
440 % (filename, changes["changed-by"], msg))
442 # Ensure all the values in Closes: are numbers
443 if self.pkg.changes.has_key("closes"):
444 for i in self.pkg.changes["closes"].keys():
445 if re_isanum.match (i) == None:
446 self.rejects.append(("%s: `%s' from Closes field isn't a number." % (filename, i)))
448 # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
449 self.pkg.changes["chopversion"] = re_no_epoch.sub('', self.pkg.changes["version"])
450 self.pkg.changes["chopversion2"] = re_no_revision.sub('', self.pkg.changes["chopversion"])
452 # Check there isn't already a changes file of the same name in one
453 # of the queue directories.
454 base_filename = os.path.basename(filename)
455 for d in [ "Accepted", "Byhand", "Done", "New", "ProposedUpdates", "OldProposedUpdates" ]:
456 if os.path.exists(os.path.join(Cnf["Dir::Queue::%s" % (d) ], base_filename)):
457 self.rejects.append("%s: a file with this name already exists in the %s directory." % (base_filename, d))
459 # Check the .changes is non-empty
460 if not self.pkg.files:
461 self.rejects.append("%s: nothing to do (Files field is empty)." % (base_filename))
464 # Changes was syntactically valid even if we'll reject
467 ###########################################################################
469 def check_distributions(self):
470 "Check and map the Distribution field"
474 # Handle suite mappings
475 for m in Cnf.ValueList("SuiteMappings"):
478 if mtype == "map" or mtype == "silent-map":
479 (source, dest) = args[1:3]
480 if self.pkg.changes["distribution"].has_key(source):
481 del self.pkg.changes["distribution"][source]
482 self.pkg.changes["distribution"][dest] = 1
483 if mtype != "silent-map":
484 self.notes.append("Mapping %s to %s." % (source, dest))
485 if self.pkg.changes.has_key("distribution-version"):
486 if self.pkg.changes["distribution-version"].has_key(source):
487 self.pkg.changes["distribution-version"][source]=dest
488 elif mtype == "map-unreleased":
489 (source, dest) = args[1:3]
490 if self.pkg.changes["distribution"].has_key(source):
491 for arch in self.pkg.changes["architecture"].keys():
492 if arch not in [ a.arch_string for a in get_suite_architectures(source) ]:
493 self.notes.append("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch))
494 del self.pkg.changes["distribution"][source]
495 self.pkg.changes["distribution"][dest] = 1
497 elif mtype == "ignore":
499 if self.pkg.changes["distribution"].has_key(suite):
500 del self.pkg.changes["distribution"][suite]
501 self.warnings.append("Ignoring %s as a target suite." % (suite))
502 elif mtype == "reject":
504 if self.pkg.changes["distribution"].has_key(suite):
505 self.rejects.append("Uploads to %s are not accepted." % (suite))
506 elif mtype == "propup-version":
507 # give these as "uploaded-to(non-mapped) suites-to-add-when-upload-obsoletes"
509 # changes["distribution-version"] looks like: {'testing': 'testing-proposed-updates'}
510 if self.pkg.changes["distribution"].has_key(args[1]):
511 self.pkg.changes.setdefault("distribution-version", {})
512 for suite in args[2:]:
513 self.pkg.changes["distribution-version"][suite] = suite
515 # Ensure there is (still) a target distribution
516 if len(self.pkg.changes["distribution"].keys()) < 1:
517 self.rejects.append("No valid distribution remaining.")
519 # Ensure target distributions exist
520 for suite in self.pkg.changes["distribution"].keys():
521 if not Cnf.has_key("Suite::%s" % (suite)):
522 self.rejects.append("Unknown distribution `%s'." % (suite))
524 ###########################################################################
526 def binary_file_checks(self, f, session):
528 entry = self.pkg.files[f]
530 # Extract package control information
531 deb_file = utils.open_file(f)
533 control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))
535 self.rejects.append("%s: debExtractControl() raised %s." % (f, sys.exc_type))
537 # Can't continue, none of the checks on control would work.
540 # Check for mandantory "Description:"
543 apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))["Description"] + '\n'
545 self.rejects.append("%s: Missing Description in binary package" % (f))
550 # Check for mandatory fields
551 for field in [ "Package", "Architecture", "Version" ]:
552 if control.Find(field) == None:
554 self.rejects.append("%s: No %s field in control." % (f, field))
557 # Ensure the package name matches the one give in the .changes
558 if not self.pkg.changes["binary"].has_key(control.Find("Package", "")):
559 self.rejects.append("%s: control file lists name as `%s', which isn't in changes file." % (f, control.Find("Package", "")))
561 # Validate the package field
562 package = control.Find("Package")
563 if not re_valid_pkg_name.match(package):
564 self.rejects.append("%s: invalid package name '%s'." % (f, package))
566 # Validate the version field
567 version = control.Find("Version")
568 if not re_valid_version.match(version):
569 self.rejects.append("%s: invalid version number '%s'." % (f, version))
571 # Ensure the architecture of the .deb is one we know about.
572 default_suite = cnf.get("Dinstall::DefaultSuite", "Unstable")
573 architecture = control.Find("Architecture")
574 upload_suite = self.pkg.changes["distribution"].keys()[0]
576 if architecture not in [a.arch_string for a in get_suite_architectures(default_suite, session)] \
577 and architecture not in [a.arch_string for a in get_suite_architectures(upload_suite, session)]:
578 self.rejects.append("Unknown architecture '%s'." % (architecture))
580 # Ensure the architecture of the .deb is one of the ones
581 # listed in the .changes.
582 if not self.pkg.changes["architecture"].has_key(architecture):
583 self.rejects.append("%s: control file lists arch as `%s', which isn't in changes file." % (f, architecture))
585 # Sanity-check the Depends field
586 depends = control.Find("Depends")
588 self.rejects.append("%s: Depends field is empty." % (f))
590 # Sanity-check the Provides field
591 provides = control.Find("Provides")
593 provide = re_spacestrip.sub('', provides)
595 self.rejects.append("%s: Provides field is empty." % (f))
596 prov_list = provide.split(",")
597 for prov in prov_list:
598 if not re_valid_pkg_name.match(prov):
599 self.rejects.append("%s: Invalid Provides field content %s." % (f, prov))
601 # Check the section & priority match those given in the .changes (non-fatal)
602 if control.Find("Section") and entry["section"] != "" \
603 and entry["section"] != control.Find("Section"):
604 self.warnings.append("%s control file lists section as `%s', but changes file has `%s'." % \
605 (f, control.Find("Section", ""), entry["section"]))
606 if control.Find("Priority") and entry["priority"] != "" \
607 and entry["priority"] != control.Find("Priority"):
608 self.warnings.append("%s control file lists priority as `%s', but changes file has `%s'." % \
609 (f, control.Find("Priority", ""), entry["priority"]))
611 entry["package"] = package
612 entry["architecture"] = architecture
613 entry["version"] = version
614 entry["maintainer"] = control.Find("Maintainer", "")
616 if f.endswith(".udeb"):
617 self.pkg.files[f]["dbtype"] = "udeb"
618 elif f.endswith(".deb"):
619 self.pkg.files[f]["dbtype"] = "deb"
621 self.rejects.append("%s is neither a .deb or a .udeb." % (f))
623 entry["source"] = control.Find("Source", entry["package"])
625 # Get the source version
626 source = entry["source"]
629 if source.find("(") != -1:
630 m = re_extract_src_version.match(source)
632 source_version = m.group(2)
634 if not source_version:
635 source_version = self.pkg.files[f]["version"]
637 entry["source package"] = source
638 entry["source version"] = source_version
640 # Ensure the filename matches the contents of the .deb
641 m = re_isadeb.match(f)
644 file_package = m.group(1)
645 if entry["package"] != file_package:
646 self.rejects.append("%s: package part of filename (%s) does not match package name in the %s (%s)." % \
647 (f, file_package, entry["dbtype"], entry["package"]))
648 epochless_version = re_no_epoch.sub('', control.Find("Version"))
651 file_version = m.group(2)
652 if epochless_version != file_version:
653 self.rejects.append("%s: version part of filename (%s) does not match package version in the %s (%s)." % \
654 (f, file_version, entry["dbtype"], epochless_version))
657 file_architecture = m.group(3)
658 if entry["architecture"] != file_architecture:
659 self.rejects.append("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % \
660 (f, file_architecture, entry["dbtype"], entry["architecture"]))
662 # Check for existent source
663 source_version = entry["source version"]
664 source_package = entry["source package"]
665 if self.pkg.changes["architecture"].has_key("source"):
666 if source_version != self.pkg.changes["version"]:
667 self.rejects.append("source version (%s) for %s doesn't match changes version %s." % \
668 (source_version, f, self.pkg.changes["version"]))
670 # Check in the SQL database
671 if not source_exists(source_package, source_version, self.pkg.changes["distribution"].keys(), session):
672 # Check in one of the other directories
673 source_epochless_version = re_no_epoch.sub('', source_version)
674 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
675 if os.path.exists(os.path.join(cnf["Dir::Queue::Byhand"], dsc_filename)):
677 elif os.path.exists(os.path.join(cnf["Dir::Queue::New"], dsc_filename)):
680 dsc_file_exists = False
681 for myq in ["Accepted", "Embargoed", "Unembargoed", "ProposedUpdates", "OldProposedUpdates"]:
682 if cnf.has_key("Dir::Queue::%s" % (myq)):
683 if os.path.exists(os.path.join(cnf["Dir::Queue::" + myq], dsc_filename)):
684 dsc_file_exists = True
687 if not dsc_file_exists:
688 self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, f))
690 # Check the version and for file overwrites
691 self.check_binary_against_db(f, session)
693 # Temporarily disable contents generation until we change the table storage layout
696 #if len(b.rejects) > 0:
697 # for j in b.rejects:
698 # self.rejects.append(j)
700 def source_file_checks(self, f, session):
701 entry = self.pkg.files[f]
703 m = re_issource.match(f)
707 entry["package"] = m.group(1)
708 entry["version"] = m.group(2)
709 entry["type"] = m.group(3)
711 # Ensure the source package name matches the Source filed in the .changes
712 if self.pkg.changes["source"] != entry["package"]:
713 self.rejects.append("%s: changes file doesn't say %s for Source" % (f, entry["package"]))
715 # Ensure the source version matches the version in the .changes file
716 if re_is_orig_source.match(f):
717 changes_version = self.pkg.changes["chopversion2"]
719 changes_version = self.pkg.changes["chopversion"]
721 if changes_version != entry["version"]:
722 self.rejects.append("%s: should be %s according to changes file." % (f, changes_version))
724 # Ensure the .changes lists source in the Architecture field
725 if not self.pkg.changes["architecture"].has_key("source"):
726 self.rejects.append("%s: changes file doesn't list `source' in Architecture field." % (f))
728 # Check the signature of a .dsc file
729 if entry["type"] == "dsc":
730 # check_signature returns either:
731 # (None, [list, of, rejects]) or (signature, [])
732 (self.pkg.dsc["fingerprint"], rejects) = utils.check_signature(f)
734 self.rejects.append(j)
736 entry["architecture"] = "source"
738 def per_suite_file_checks(self, f, suite, session):
740 entry = self.pkg.files[f]
741 archive = utils.where_am_i()
744 if entry.has_key("byhand"):
747 # Check we have fields we need to do these checks
749 for m in ['component', 'package', 'priority', 'size', 'md5sum']:
750 if not entry.has_key(m):
751 self.rejects.append("file '%s' does not have field %s set" % (f, m))
757 # Handle component mappings
758 for m in cnf.ValueList("ComponentMappings"):
759 (source, dest) = m.split()
760 if entry["component"] == source:
761 entry["original component"] = source
762 entry["component"] = dest
764 # Ensure the component is valid for the target suite
765 if cnf.has_key("Suite:%s::Components" % (suite)) and \
766 entry["component"] not in cnf.ValueList("Suite::%s::Components" % (suite)):
767 self.rejects.append("unknown component `%s' for suite `%s'." % (entry["component"], suite))
770 # Validate the component
771 if not get_component(entry["component"], session):
772 self.rejects.append("file '%s' has unknown component '%s'." % (f, component))
775 # See if the package is NEW
776 if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), f, session):
779 # Validate the priority
780 if entry["priority"].find('/') != -1:
781 self.rejects.append("file '%s' has invalid priority '%s' [contains '/']." % (f, entry["priority"]))
783 # Determine the location
784 location = cnf["Dir::Pool"]
785 l = get_location(location, entry["component"], archive, session)
787 self.rejects.append("[INTERNAL ERROR] couldn't determine location (Component: %s, Archive: %s)" % (component, archive))
788 entry["location id"] = -1
790 entry["location id"] = l.location_id
792 # Check the md5sum & size against existing files (if any)
793 entry["pool name"] = utils.poolify(self.pkg.changes["source"], entry["component"])
795 found, poolfile = check_poolfile(os.path.join(entry["pool name"], f),
796 entry["size"], entry["md5sum"], entry["location id"])
799 self.rejects.append("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (f))
800 elif found is False and poolfile is not None:
801 self.rejects.append("md5sum and/or size mismatch on existing copy of %s." % (f))
804 entry["files id"] = None
806 entry["files id"] = poolfile.file_id
808 # Check for packages that have moved from one component to another
809 entry['suite'] = suite
810 res = get_binary_components(self.pkg.files[f]['package'], suite, entry["architecture"], session)
812 entry["othercomponents"] = res.fetchone()[0]
814 def check_files(self, action=True):
815 archive = utils.where_am_i()
816 file_keys = self.pkg.files.keys()
820 # XXX: As far as I can tell, this can no longer happen - see
821 # comments by AJ in old revisions - mhy
822 # if reprocess is 2 we've already done this and we're checking
823 # things again for the new .orig.tar.gz.
824 # [Yes, I'm fully aware of how disgusting this is]
825 if action and self.reprocess < 2:
827 os.chdir(self.pkg.directory)
829 ret = holding.copy_to_holding(f)
831 # XXX: Should we bail out here or try and continue?
832 self.rejects.append(ret)
836 # Check there isn't already a .changes or .dak file of the same name in
837 # the proposed-updates "CopyChanges" or "CopyDotDak" storage directories.
838 # [NB: this check must be done post-suite mapping]
839 base_filename = os.path.basename(self.pkg.changes_file)
840 dot_dak_filename = base_filename[:-8] + ".dak"
842 for suite in self.pkg.changes["distribution"].keys():
843 copychanges = "Suite::%s::CopyChanges" % (suite)
844 if cnf.has_key(copychanges) and \
845 os.path.exists(os.path.join(cnf[copychanges], base_filename)):
846 self.rejects.append("%s: a file with this name already exists in %s" \
847 % (base_filename, cnf[copychanges]))
849 copy_dot_dak = "Suite::%s::CopyDotDak" % (suite)
850 if cnf.has_key(copy_dot_dak) and \
851 os.path.exists(os.path.join(cnf[copy_dot_dak], dot_dak_filename)):
852 self.rejects.append("%s: a file with this name already exists in %s" \
853 % (dot_dak_filename, Cnf[copy_dot_dak]))
859 session = DBConn().session()
861 for f, entry in self.pkg.files.items():
862 # Ensure the file does not already exist in one of the accepted directories
863 for d in [ "Accepted", "Byhand", "New", "ProposedUpdates", "OldProposedUpdates", "Embargoed", "Unembargoed" ]:
864 if not cnf.has_key("Dir::Queue::%s" % (d)): continue
865 if os.path.exists(cnf["Dir::Queue::%s" % (d) ] + '/' + f):
866 self.rejects.append("%s file already exists in the %s directory." % (f, d))
868 if not re_taint_free.match(f):
869 self.rejects.append("!!WARNING!! tainted filename: '%s'." % (f))
871 # Check the file is readable
872 if os.access(f, os.R_OK) == 0:
873 # When running in -n, copy_to_holding() won't have
874 # generated the reject_message, so we need to.
876 if os.path.exists(f):
877 self.rejects.append("Can't read `%s'. [permission denied]" % (f))
879 self.rejects.append("Can't read `%s'. [file not found]" % (f))
880 entry["type"] = "unreadable"
883 # If it's byhand skip remaining checks
884 if entry["section"] == "byhand" or entry["section"][:4] == "raw-":
886 entry["type"] = "byhand"
888 # Checks for a binary package...
889 elif re_isadeb.match(f):
891 entry["type"] = "deb"
893 # This routine appends to self.rejects/warnings as appropriate
894 self.binary_file_checks(f, session)
896 # Checks for a source package...
897 elif re_issource.match(f):
900 # This routine appends to self.rejects/warnings as appropriate
901 self.source_file_checks(f, session)
903 # Not a binary or source package? Assume byhand...
906 entry["type"] = "byhand"
908 # Per-suite file checks
909 entry["oldfiles"] = {}
910 for suite in self.pkg.changes["distribution"].keys():
911 self.per_suite_file_checks(f, suite, session)
915 # If the .changes file says it has source, it must have source.
916 if self.pkg.changes["architecture"].has_key("source"):
918 self.rejects.append("no source found and Architecture line in changes mention source.")
920 if not has_binaries and cnf.FindB("Dinstall::Reject::NoSourceOnly"):
921 self.rejects.append("source only uploads are not supported.")
923 ###########################################################################
924 def check_dsc(self, action=True, session=None):
925 """Returns bool indicating whether or not the source changes are valid"""
926 # Ensure there is source to check
927 if not self.pkg.changes["architecture"].has_key("source"):
932 for f, entry in self.pkg.files.items():
933 if entry["type"] == "dsc":
935 self.rejects.append("can not process a .changes file with multiple .dsc's.")
940 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
942 self.rejects.append("source uploads must contain a dsc file")
945 # Parse the .dsc file
947 self.pkg.dsc.update(utils.parse_changes(dsc_filename, signing_rules=1))
948 except CantOpenError:
949 # if not -n copy_to_holding() will have done this for us...
951 self.rejects.append("%s: can't read file." % (dsc_filename))
952 except ParseChangesError, line:
953 self.rejects.append("%s: parse error, can't grok: %s." % (dsc_filename, line))
954 except InvalidDscError, line:
955 self.rejects.append("%s: syntax error on line %s." % (dsc_filename, line))
956 except ChangesUnicodeError:
957 self.rejects.append("%s: dsc file not proper utf-8." % (dsc_filename))
959 # Build up the file list of files mentioned by the .dsc
961 self.pkg.dsc_files.update(utils.build_file_list(self.pkg.dsc, is_a_dsc=1))
962 except NoFilesFieldError:
963 self.rejects.append("%s: no Files: field." % (dsc_filename))
965 except UnknownFormatError, format:
966 self.rejects.append("%s: unknown format '%s'." % (dsc_filename, format))
968 except ParseChangesError, line:
969 self.rejects.append("%s: parse error, can't grok: %s." % (dsc_filename, line))
972 # Enforce mandatory fields
973 for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
974 if not self.pkg.dsc.has_key(i):
975 self.rejects.append("%s: missing mandatory field `%s'." % (dsc_filename, i))
978 # Validate the source and version fields
979 if not re_valid_pkg_name.match(self.pkg.dsc["source"]):
980 self.rejects.append("%s: invalid source name '%s'." % (dsc_filename, self.pkg.dsc["source"]))
981 if not re_valid_version.match(self.pkg.dsc["version"]):
982 self.rejects.append("%s: invalid version number '%s'." % (dsc_filename, self.pkg.dsc["version"]))
984 # Only a limited list of source formats are allowed in each suite
985 for dist in self.pkg.changes["distribution"].keys():
986 allowed = [ x.format_name for x in get_suite_src_formats(dist, session) ]
987 if self.pkg.dsc["format"] not in allowed:
988 self.rejects.append("%s: source format '%s' not allowed in %s (accepted: %s) " % (dsc_filename, self.pkg.dsc["format"], dist, ", ".join(allowed)))
990 # Validate the Maintainer field
992 # We ignore the return value
993 fix_maintainer(self.pkg.dsc["maintainer"])
994 except ParseMaintError, msg:
995 self.rejects.append("%s: Maintainer field ('%s') failed to parse: %s" \
996 % (dsc_filename, self.pkg.dsc["maintainer"], msg))
998 # Validate the build-depends field(s)
999 for field_name in [ "build-depends", "build-depends-indep" ]:
1000 field = self.pkg.dsc.get(field_name)
1002 # Have apt try to parse them...
1004 apt_pkg.ParseSrcDepends(field)
1006 self.rejects.append("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()))
1008 # Ensure the version number in the .dsc matches the version number in the .changes
1009 epochless_dsc_version = re_no_epoch.sub('', self.pkg.dsc["version"])
1010 changes_version = self.pkg.files[dsc_filename]["version"]
1012 if epochless_dsc_version != self.pkg.files[dsc_filename]["version"]:
1013 self.rejects.append("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version))
1015 # Ensure the Files field contain only what's expected
1016 self.rejects.extend(check_dsc_files(dsc_filename, self.pkg.dsc, self.pkg.dsc_files))
1018 # Ensure source is newer than existing source in target suites
1019 session = DBConn().session()
1020 self.check_source_against_db(dsc_filename, session)
1021 self.check_dsc_against_db(dsc_filename, session)
1026 ###########################################################################
1028 def ensure_all_source_exists(self, dest_dir=None):
1030 Ensure that dest_dir contains all the orig tarballs for the specified
1031 changes. If it does not, symlink them into place.
1033 If dest_dir is None, populate the current directory.
1036 if dest_dir is None:
1037 dest_dir = os.getcwd()
1039 # Create a symlink mirror of the source files in our temporary directory
1040 for f in self.pkg.files.keys():
1041 m = re_issource.match(f)
1043 src = os.path.join(source_dir, f)
1044 # If a file is missing for whatever reason, give up.
1045 if not os.path.exists(src):
1048 if re_is_orig_source.match(f) and pkg.orig_files.has_key(f) and \
1049 pkg.orig_files[f].has_key("path"):
1051 dest = os.path.join(os.getcwd(), f)
1052 os.symlink(src, dest)
1054 # If the orig files are not a part of the upload, create symlinks to the
1056 for orig_file in self.pkg.orig_files.keys():
1057 if not self.pkg.orig_files[orig_file].has_key("path"):
1059 dest = os.path.join(os.getcwd(), os.path.basename(orig_file))
1060 os.symlink(self.pkg.orig_files[orig_file]["path"], dest)
1062 ###########################################################################
1064 def get_changelog_versions(self, source_dir):
1065 """Extracts a the source package and (optionally) grabs the
1066 version history out of debian/changelog for the BTS."""
1070 # Find the .dsc (again)
1072 for f in self.pkg.files.keys():
1073 if self.pkg.files[f]["type"] == "dsc":
1076 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
1077 if not dsc_filename:
1080 self.ensure_all_source_exists()
1082 # Extract the source
1083 cmd = "dpkg-source -sn -x %s" % (dsc_filename)
1084 (result, output) = commands.getstatusoutput(cmd)
1086 self.rejects.append("'dpkg-source -x' failed for %s [return code: %s]." % (dsc_filename, result))
1087 self.rejects.append(utils.prefix_multi_line_string(output, " [dpkg-source output:] "))
1090 if not cnf.Find("Dir::Queue::BTSVersionTrack"):
1093 # Get the upstream version
1094 upstr_version = re_no_epoch.sub('', self.pkg.dsc["version"])
1095 if re_strip_revision.search(upstr_version):
1096 upstr_version = re_strip_revision.sub('', upstr_version)
1098 # Ensure the changelog file exists
1099 changelog_filename = "%s-%s/debian/changelog" % (self.pkg.dsc["source"], upstr_version)
1100 if not os.path.exists(changelog_filename):
1101 self.rejects.append("%s: debian/changelog not found in extracted source." % (dsc_filename))
1104 # Parse the changelog
1105 self.pkg.dsc["bts changelog"] = ""
1106 changelog_file = utils.open_file(changelog_filename)
1107 for line in changelog_file.readlines():
1108 m = re_changelog_versions.match(line)
1110 self.pkg.dsc["bts changelog"] += line
1111 changelog_file.close()
1113 # Check we found at least one revision in the changelog
1114 if not self.pkg.dsc["bts changelog"]:
1115 self.rejects.append("%s: changelog format not recognised (empty version tree)." % (dsc_filename))
1117 def check_source(self):
1118 # XXX: I'm fairly sure reprocess == 2 can never happen
1119 # AJT disabled the is_incoming check years ago - mhy
1120 # We should probably scrap or rethink the whole reprocess thing
1122 # a) there's no source
1123 # or b) reprocess is 2 - we will do this check next time when orig
1124 # tarball is in 'files'
1125 # or c) the orig files are MIA
1126 if not self.pkg.changes["architecture"].has_key("source") or self.reprocess == 2 \
1127 or len(self.pkg.orig_files) == 0:
1130 tmpdir = utils.temp_dirname()
1132 # Move into the temporary directory
1136 # Get the changelog version history
1137 self.get_changelog_versions(cwd)
1139 # Move back and cleanup the temporary tree
1143 shutil.rmtree(tmpdir)
1145 if e.errno != errno.EACCES:
1147 utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))
1149 self.rejects.append("%s: source tree could not be cleanly removed." % (self.pkg.dsc["source"]))
1150 # We probably have u-r or u-w directories so chmod everything
1152 cmd = "chmod -R u+rwx %s" % (tmpdir)
1153 result = os.system(cmd)
1155 utils.fubar("'%s' failed with result %s." % (cmd, result))
1156 shutil.rmtree(tmpdir)
1157 except Exception, e:
1158 print "foobar2 (%s)" % e
1159 utils.fubar("%s: couldn't remove tmp dir for source tree." % (self.pkg.dsc["source"]))
1161 ###########################################################################
1162 def ensure_hashes(self):
1163 # Make sure we recognise the format of the Files: field in the .changes
1164 format = self.pkg.changes.get("format", "0.0").split(".", 1)
1165 if len(format) == 2:
1166 format = int(format[0]), int(format[1])
1168 format = int(float(format[0])), 0
1170 # We need to deal with the original changes blob, as the fields we need
1171 # might not be in the changes dict serialised into the .dak anymore.
1172 orig_changes = utils.parse_deb822(self.pkg.changes['filecontents'])
1174 # Copy the checksums over to the current changes dict. This will keep
1175 # the existing modifications to it intact.
1176 for field in orig_changes:
1177 if field.startswith('checksums-'):
1178 self.pkg.changes[field] = orig_changes[field]
1180 # Check for unsupported hashes
1181 for j in utils.check_hash_fields(".changes", self.pkg.changes):
1182 self.rejects.append(j)
1184 for j in utils.check_hash_fields(".dsc", self.pkg.dsc):
1185 self.rejects.append(j)
1187 # We have to calculate the hash if we have an earlier changes version than
1188 # the hash appears in rather than require it exist in the changes file
1189 for hashname, hashfunc, version in utils.known_hashes:
1190 # TODO: Move _ensure_changes_hash into this class
1191 for j in utils._ensure_changes_hash(self.pkg.changes, format, version, self.pkg.files, hashname, hashfunc):
1192 self.rejects.append(j)
1193 if "source" in self.pkg.changes["architecture"]:
1194 # TODO: Move _ensure_dsc_hash into this class
1195 for j in utils._ensure_dsc_hash(self.pkg.dsc, self.pkg.dsc_files, hashname, hashfunc):
1196 self.rejects.append(j)
1198 def check_hashes(self):
1199 for m in utils.check_hash(".changes", self.pkg.files, "md5", apt_pkg.md5sum):
1200 self.rejects.append(m)
1202 for m in utils.check_size(".changes", self.pkg.files):
1203 self.rejects.append(m)
1205 for m in utils.check_hash(".dsc", self.pkg.dsc_files, "md5", apt_pkg.md5sum):
1206 self.rejects.append(m)
1208 for m in utils.check_size(".dsc", self.pkg.dsc_files):
1209 self.rejects.append(m)
1211 self.ensure_hashes()
1213 ###########################################################################
1214 def check_lintian(self):
1215 # Only check some distributions
1217 for dist in ('unstable', 'experimental'):
1218 if dist in self.pkg.changes['distribution']:
1225 self.ensure_all_source_exists()
1228 tagfile = cnf["Dinstall::LintianTags"]
1229 # Parse the yaml file
1230 sourcefile = file(tagfile, 'r')
1231 sourcecontent = sourcefile.read()
1234 lintiantags = yaml.load(sourcecontent)['lintian']
1235 except yaml.YAMLError, msg:
1236 utils.fubar("Can not read the lintian tags file %s, YAML error: %s." % (tagfile, msg))
1239 # Now setup the input file for lintian. lintian wants "one tag per line" only,
1240 # so put it together like it. We put all types of tags in one file and then sort
1241 # through lintians output later to see if its a fatal tag we detected, or not.
1242 # So we only run lintian once on all tags, even if we might reject on some, but not
1244 # Additionally build up a set of tags
1246 (fd, temp_filename) = utils.temp_filename()
1247 temptagfile = os.fdopen(fd, 'w')
1248 for tagtype in lintiantags:
1249 for tag in lintiantags[tagtype]:
1250 temptagfile.write("%s\n" % tag)
1254 # So now we should look at running lintian at the .changes file, capturing output
1256 command = "lintian --show-overrides --tags-from-file %s %s" % (temp_filename, self.pkg.changes_file)
1257 (result, output) = commands.getstatusoutput(command)
1258 # We are done with lintian, remove our tempfile
1259 os.unlink(temp_filename)
1261 utils.warn("lintian failed for %s [return code: %s]." % (self.pkg.changes_file, result))
1262 utils.warn(utils.prefix_multi_line_string(output, " [possible output:] "))
1264 if len(output) == 0:
1267 # We have output of lintian, this package isn't clean. Lets parse it and see if we
1268 # are having a victim for a reject.
1269 # W: tzdata: binary-without-manpage usr/sbin/tzconfig
1270 for line in output.split('\n'):
1271 m = re_parse_lintian.match(line)
1276 epackage = m.group(2)
1280 # So lets check if we know the tag at all.
1281 if etag not in tags:
1285 # We know it and it is overriden. Check that override is allowed.
1286 if etag in lintiantags['warning']:
1287 # The tag is overriden, and it is allowed to be overriden.
1288 # Don't add a reject message.
1290 elif etag in lintiantags['error']:
1291 # The tag is overriden - but is not allowed to be
1292 self.rejects.append("%s: Overriden tag %s found, but this tag may not be overwritten." % (epackage, etag))
1294 # Tag is known, it is not overriden, direct reject.
1295 self.rejects.append("%s: Found lintian output: '%s %s', automatically rejected package." % (epackage, etag, etext))
1296 # Now tell if they *might* override it.
1297 if etag in lintiantags['warning']:
1298 self.rejects.append("%s: If you have a good reason, you may override this lintian tag." % (epackage))
1300 ###########################################################################
1301 def check_urgency(self):
1303 if self.pkg.changes["architecture"].has_key("source"):
1304 if not self.pkg.changes.has_key("urgency"):
1305 self.pkg.changes["urgency"] = cnf["Urgency::Default"]
1306 self.pkg.changes["urgency"] = self.pkg.changes["urgency"].lower()
1307 if self.pkg.changes["urgency"] not in cnf.ValueList("Urgency::Valid"):
1308 self.warnings.append("%s is not a valid urgency; it will be treated as %s by testing." % \
1309 (self.pkg.changes["urgency"], cnf["Urgency::Default"]))
1310 self.pkg.changes["urgency"] = cnf["Urgency::Default"]
1312 ###########################################################################
1314 # Sanity check the time stamps of files inside debs.
1315 # [Files in the near future cause ugly warnings and extreme time
1316 # travel can cause errors on extraction]
1318 def check_timestamps(self):
1321 future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"])
1322 past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"))
1323 tar = TarTime(future_cutoff, past_cutoff)
1325 for filename, entry in self.pkg.files.items():
1326 if entry["type"] == "deb":
1329 deb_file = utils.open_file(filename)
1330 apt_inst.debExtract(deb_file, tar.callback, "control.tar.gz")
1333 apt_inst.debExtract(deb_file, tar.callback, "data.tar.gz")
1334 except SystemError, e:
1335 # If we can't find a data.tar.gz, look for data.tar.bz2 instead.
1336 if not re.search(r"Cannot f[ui]nd chunk data.tar.gz$", str(e)):
1339 apt_inst.debExtract(deb_file,tar.callback,"data.tar.bz2")
1343 future_files = tar.future_files.keys()
1345 num_future_files = len(future_files)
1346 future_file = future_files[0]
1347 future_date = tar.future_files[future_file]
1348 self.rejects.append("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
1349 % (filename, num_future_files, future_file, time.ctime(future_date)))
1351 ancient_files = tar.ancient_files.keys()
1353 num_ancient_files = len(ancient_files)
1354 ancient_file = ancient_files[0]
1355 ancient_date = tar.ancient_files[ancient_file]
1356 self.rejects.append("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
1357 % (filename, num_ancient_files, ancient_file, time.ctime(ancient_date)))
1359 self.rejects.append("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value))
1361 ###########################################################################
1362 def check_transition(self, session):
1365 sourcepkg = self.pkg.changes["source"]
1367 # No sourceful upload -> no need to do anything else, direct return
1368 # We also work with unstable uploads, not experimental or those going to some
1369 # proposed-updates queue
1370 if "source" not in self.pkg.changes["architecture"] or \
1371 "unstable" not in self.pkg.changes["distribution"]:
1374 # Also only check if there is a file defined (and existant) with
1376 transpath = cnf.get("Dinstall::Reject::ReleaseTransitions", "")
1377 if transpath == "" or not os.path.exists(transpath):
1380 # Parse the yaml file
1381 sourcefile = file(transpath, 'r')
1382 sourcecontent = sourcefile.read()
1384 transitions = yaml.load(sourcecontent)
1385 except yaml.YAMLError, msg:
1386 # This shouldn't happen, there is a wrapper to edit the file which
1387 # checks it, but we prefer to be safe than ending up rejecting
1389 utils.warn("Not checking transitions, the transitions file is broken: %s." % (msg))
1392 # Now look through all defined transitions
1393 for trans in transitions:
1394 t = transitions[trans]
1395 source = t["source"]
1398 # Will be None if nothing is in testing.
1399 current = get_source_in_suite(source, "testing", session)
1400 if current is not None:
1401 compare = apt_pkg.VersionCompare(current.version, expected)
1403 if current is None or compare < 0:
1404 # This is still valid, the current version in testing is older than
1405 # the new version we wait for, or there is none in testing yet
1407 # Check if the source we look at is affected by this.
1408 if sourcepkg in t['packages']:
1409 # The source is affected, lets reject it.
1411 rejectmsg = "%s: part of the %s transition.\n\n" % (
1414 if current is not None:
1415 currentlymsg = "at version %s" % (current.version)
1417 currentlymsg = "not present in testing"
1419 rejectmsg += "Transition description: %s\n\n" % (t["reason"])
1421 rejectmsg += "\n".join(textwrap.wrap("""Your package
1422 is part of a testing transition designed to get %s migrated (it is
1423 currently %s, we need version %s). This transition is managed by the
1424 Release Team, and %s is the Release-Team member responsible for it.
1425 Please mail debian-release@lists.debian.org or contact %s directly if you
1426 need further assistance. You might want to upload to experimental until this
1427 transition is done."""
1428 % (source, currentlymsg, expected,t["rm"], t["rm"])))
1430 self.rejects.append(rejectmsg)
1433 ###########################################################################
1434 def check_signed_by_key(self):
1435 """Ensure the .changes is signed by an authorized uploader."""
1436 session = DBConn().session()
1438 self.check_transition(session)
1440 (uid, uid_name, is_dm) = lookup_uid_from_fingerprint(self.pkg.changes["fingerprint"], session=session)
1442 # match claimed name with actual name:
1444 # This is fundamentally broken but need us to refactor how we get
1445 # the UIDs/Fingerprints in order for us to fix it properly
1446 uid, uid_email = self.pkg.changes["fingerprint"], uid
1447 may_nmu, may_sponsor = 1, 1
1448 # XXX by default new dds don't have a fingerprint/uid in the db atm,
1449 # and can't get one in there if we don't allow nmu/sponsorship
1450 elif is_dm is False:
1451 # If is_dm is False, we allow full upload rights
1452 uid_email = "%s@debian.org" % (uid)
1453 may_nmu, may_sponsor = 1, 1
1455 # Assume limited upload rights unless we've discovered otherwise
1457 may_nmu, may_sponsor = 0, 0
1459 if uid_email in [self.pkg.changes["maintaineremail"], self.pkg.changes["changedbyemail"]]:
1461 elif uid_name in [self.pkg.changes["maintainername"], self.pkg.changes["changedbyname"]]:
1463 if uid_name == "": sponsored = 1
1466 if ("source" in self.pkg.changes["architecture"] and
1467 uid_email and utils.is_email_alias(uid_email)):
1468 sponsor_addresses = utils.gpg_get_key_addresses(self.pkg.changes["fingerprint"])
1469 if (self.pkg.changes["maintaineremail"] not in sponsor_addresses and
1470 self.pkg.changes["changedbyemail"] not in sponsor_addresses):
1471 self.pkg.changes["sponsoremail"] = uid_email
1473 if sponsored and not may_sponsor:
1474 self.rejects.append("%s is not authorised to sponsor uploads" % (uid))
1476 if not sponsored and not may_nmu:
1477 should_reject = True
1478 highest_sid, highest_version = None, None
1480 # XXX: This reimplements in SQLA what existed before but it's fundamentally fucked
1481 # It ignores higher versions with the dm_upload_allowed flag set to false
1482 # I'm keeping the existing behaviour for now until I've gone back and
1483 # checked exactly what the GR says - mhy
1484 for si in get_sources_from_name(source=self.pkg.changes['source'], dm_upload_allowed=True, session=session):
1485 if highest_version is None or apt_pkg.VersionCompare(si.version, highest_version) == 1:
1486 highest_sid = si.source_id
1487 highest_version = si.version
1489 if highest_sid is None:
1490 self.rejects.append("Source package %s does not have 'DM-Upload-Allowed: yes' in its most recent version" % self.pkg.changes["source"])
1492 for sup in session.query(SrcUploader).join(DBSource).filter_by(source_id=highest_sid):
1493 (rfc822, rfc2047, name, email) = sup.maintainer.get_split_maintainer()
1494 if email == uid_email or name == uid_name:
1495 should_reject = False
1498 if should_reject is True:
1499 self.rejects.append("%s is not in Maintainer or Uploaders of source package %s" % (uid, self.pkg.changes["source"]))
1501 for b in self.pkg.changes["binary"].keys():
1502 for suite in self.pkg.changes["distribution"].keys():
1503 q = session.query(DBSource)
1504 q = q.join(DBBinary).filter_by(package=b)
1505 q = q.join(BinAssociation).join(Suite).filter_by(suite_name=suite)
1508 if s.source != self.pkg.changes["source"]:
1509 self.rejects.append("%s may not hijack %s from source package %s in suite %s" % (uid, b, s, suite))
1511 for f in self.pkg.files.keys():
1512 if self.pkg.files[f].has_key("byhand"):
1513 self.rejects.append("%s may not upload BYHAND file %s" % (uid, f))
1514 if self.pkg.files[f].has_key("new"):
1515 self.rejects.append("%s may not upload NEW file %s" % (uid, f))
1519 ###########################################################################
1520 def build_summaries(self):
1521 """ Build a summary of changes the upload introduces. """
1523 (byhand, new, summary, override_summary) = self.pkg.file_summary()
1525 short_summary = summary
1527 # This is for direport's benefit...
1528 f = re_fdnic.sub("\n .\n", self.pkg.changes.get("changes", ""))
1531 summary += "Changes: " + f
1533 summary += "\n\nOverride entries for your package:\n" + override_summary + "\n"
1535 summary += self.announce(short_summary, 0)
1537 return (summary, short_summary)
1539 ###########################################################################
1541 def close_bugs(self, summary, action):
1543 Send mail to close bugs as instructed by the closes field in the changes file.
1544 Also add a line to summary if any work was done.
1546 @type summary: string
1547 @param summary: summary text, as given by L{build_summaries}
1550 @param action: Set to false no real action will be done.
1553 @return: summary. If action was taken, extended by the list of closed bugs.
1557 template = os.path.join(Config()["Dir::Templates"], 'process-unchecked.bug-close')
1559 bugs = self.pkg.changes["closes"].keys()
1565 summary += "Closing bugs: "
1567 summary += "%s " % (bug)
1570 self.Subst["__BUG_NUMBER__"] = bug
1571 if self.pkg.changes["distribution"].has_key("stable"):
1572 self.Subst["__STABLE_WARNING__"] = """
1573 Note that this package is not part of the released stable Debian
1574 distribution. It may have dependencies on other unreleased software,
1575 or other instabilities. Please take care if you wish to install it.
1576 The update will eventually make its way into the next released Debian
1579 self.Subst["__STABLE_WARNING__"] = ""
1580 mail_message = utils.TemplateSubst(self.Subst, template)
1581 utils.send_mail(mail_message)
1583 # Clear up after ourselves
1584 del self.Subst["__BUG_NUMBER__"]
1585 del self.Subst["__STABLE_WARNING__"]
1587 if action and self.logger:
1588 self.logger.log(["closing bugs"] + bugs)
1594 ###########################################################################
1596 def announce(self, short_summary, action):
1598 Send an announce mail about a new upload.
1600 @type short_summary: string
1601 @param short_summary: Short summary text to include in the mail
1604 @param action: Set to false no real action will be done.
1607 @return: Textstring about action taken.
1612 announcetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.announce')
1614 # Only do announcements for source uploads with a recent dpkg-dev installed
1615 if float(self.pkg.changes.get("format", 0)) < 1.6 or not \
1616 self.pkg.changes["architecture"].has_key("source"):
1622 self.Subst["__SHORT_SUMMARY__"] = short_summary
1624 for dist in self.pkg.changes["distribution"].keys():
1625 announce_list = cnf.Find("Suite::%s::Announce" % (dist))
1626 if announce_list == "" or lists_done.has_key(announce_list):
1629 lists_done[announce_list] = 1
1630 summary += "Announcing to %s\n" % (announce_list)
1634 self.Subst["__ANNOUNCE_LIST_ADDRESS__"] = announce_list
1635 if cnf.get("Dinstall::TrackingServer") and \
1636 self.pkg.changes["architecture"].has_key("source"):
1637 trackingsendto = "Bcc: %s@%s" % (self.pkg.changes["source"], cnf["Dinstall::TrackingServer"])
1638 self.Subst["__ANNOUNCE_LIST_ADDRESS__"] += "\n" + trackingsendto
1640 mail_message = utils.TemplateSubst(self.Subst, announcetemplate)
1641 utils.send_mail(mail_message)
1643 del self.Subst["__ANNOUNCE_LIST_ADDRESS__"]
1645 if cnf.FindB("Dinstall::CloseBugs"):
1646 summary = self.close_bugs(summary, action)
1648 del self.Subst["__SHORT_SUMMARY__"]
1652 ###########################################################################
1654 def accept (self, summary, short_summary, targetdir=None):
1658 This moves all files referenced from the .changes into the I{accepted}
1659 queue, sends the accepted mail, announces to lists, closes bugs and
1660 also checks for override disparities. If enabled it will write out
1661 the version history for the BTS Version Tracking and will finally call
1664 @type summary: string
1665 @param summary: Summary text
1667 @type short_summary: string
1668 @param short_summary: Short summary
1673 stats = SummaryStats()
1675 accepttemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.accepted')
1677 if targetdir is None:
1678 targetdir = cnf["Dir::Queue::Accepted"]
1682 self.logger.log(["Accepting changes", self.pkg.changes_file])
1684 self.pkg.write_dot_dak(targetdir)
1686 # Move all the files into the accepted directory
1687 utils.move(self.pkg.changes_file, targetdir)
1689 for name, entry in sorted(self.pkg.files.items()):
1690 utils.move(name, targetdir)
1691 stats.accept_bytes += float(entry["size"])
1693 stats.accept_count += 1
1695 # Send accept mail, announce to lists, close bugs and check for
1696 # override disparities
1697 if not cnf["Dinstall::Options::No-Mail"]:
1699 self.Subst["__SUITE__"] = ""
1700 self.Subst["__SUMMARY__"] = summary
1701 mail_message = utils.TemplateSubst(self.Subst, accepttemplate)
1702 utils.send_mail(mail_message)
1703 self.announce(short_summary, 1)
1705 ## Helper stuff for DebBugs Version Tracking
1706 if cnf.Find("Dir::Queue::BTSVersionTrack"):
1707 # ??? once queue/* is cleared on *.d.o and/or reprocessed
1708 # the conditionalization on dsc["bts changelog"] should be
1711 # Write out the version history from the changelog
1712 if self.pkg.changes["architecture"].has_key("source") and \
1713 self.pkg.dsc.has_key("bts changelog"):
1715 (fd, temp_filename) = utils.temp_filename(cnf["Dir::Queue::BTSVersionTrack"], prefix=".")
1716 version_history = os.fdopen(fd, 'w')
1717 version_history.write(self.pkg.dsc["bts changelog"])
1718 version_history.close()
1719 filename = "%s/%s" % (cnf["Dir::Queue::BTSVersionTrack"],
1720 self.pkg.changes_file[:-8]+".versions")
1721 os.rename(temp_filename, filename)
1722 os.chmod(filename, 0644)
1724 # Write out the binary -> source mapping.
1725 (fd, temp_filename) = utils.temp_filename(cnf["Dir::Queue::BTSVersionTrack"], prefix=".")
1726 debinfo = os.fdopen(fd, 'w')
1727 for name, entry in sorted(self.pkg.files.items()):
1728 if entry["type"] == "deb":
1729 line = " ".join([entry["package"], entry["version"],
1730 entry["architecture"], entry["source package"],
1731 entry["source version"]])
1732 debinfo.write(line+"\n")
1734 filename = "%s/%s" % (cnf["Dir::Queue::BTSVersionTrack"],
1735 self.pkg.changes_file[:-8]+".debinfo")
1736 os.rename(temp_filename, filename)
1737 os.chmod(filename, 0644)
1739 # Its is Cnf["Dir::Queue::Accepted"] here, not targetdir!
1740 # <Ganneff> we do call queue_build too
1741 # <mhy> well yes, we'd have had to if we were inserting into accepted
1742 # <Ganneff> now. thats database only.
1743 # <mhy> urgh, that's going to get messy
1744 # <Ganneff> so i make the p-n call to it *also* using accepted/
1745 # <mhy> but then the packages will be in the queue_build table without the files being there
1746 # <Ganneff> as the buildd queue is only regenerated whenever unchecked runs
1747 # <mhy> ah, good point
1748 # <Ganneff> so it will work out, as unchecked move it over
1749 # <mhy> that's all completely sick
1752 # This routine returns None on success or an error on failure
1753 res = get_or_set_queue('accepted').autobuild_upload(self.pkg, cnf["Dir::Queue::Accepted"])
1758 def check_override(self):
1760 Checks override entries for validity. Mails "Override disparity" warnings,
1761 if that feature is enabled.
1763 Abandons the check if
1764 - override disparity checks are disabled
1765 - mail sending is disabled
1770 # Abandon the check if:
1771 # a) override disparity checks have been disabled
1772 # b) we're not sending mail
1773 if not cnf.FindB("Dinstall::OverrideDisparityCheck") or \
1774 cnf["Dinstall::Options::No-Mail"]:
1777 summary = self.pkg.check_override()
1782 overridetemplate = os.path.join(cnf["Dir::Templates"], 'process-unchecked.override-disparity')
1785 self.Subst["__SUMMARY__"] = summary
1786 mail_message = utils.TemplateSubst(self.Subst, overridetemplate)
1787 utils.send_mail(mail_message)
1788 del self.Subst["__SUMMARY__"]
1790 ###########################################################################
1792 def remove(self, dir=None):
1794 Used (for instance) in p-u to remove the package from unchecked
1797 os.chdir(self.pkg.directory)
1801 for f in self.pkg.files.keys():
1803 os.unlink(self.pkg.changes_file)
1805 ###########################################################################
1807 def move_to_dir (self, dest, perms=0660, changesperms=0664):
1809 Move files to dest with certain perms/changesperms
1811 utils.move(self.pkg.changes_file, dest, perms=changesperms)
1812 for f in self.pkg.files.keys():
1813 utils.move(f, dest, perms=perms)
1815 ###########################################################################
1817 def force_reject(self, reject_files):
1819 Forcefully move files from the current directory to the
1820 reject directory. If any file already exists in the reject
1821 directory it will be moved to the morgue to make way for
1825 @param files: file dictionary
1831 for file_entry in reject_files:
1832 # Skip any files which don't exist or which we don't have permission to copy.
1833 if os.access(file_entry, os.R_OK) == 0:
1836 dest_file = os.path.join(cnf["Dir::Queue::Reject"], file_entry)
1839 dest_fd = os.open(dest_file, os.O_RDWR | os.O_CREAT | os.O_EXCL, 0644)
1841 # File exists? Let's try and move it to the morgue
1842 if e.errno == errno.EEXIST:
1843 morgue_file = os.path.join(cnf["Dir::Morgue"], cnf["Dir::MorgueReject"], file_entry)
1845 morgue_file = utils.find_next_free(morgue_file)
1846 except NoFreeFilenameError:
1847 # Something's either gone badly Pete Tong, or
1848 # someone is trying to exploit us.
1849 utils.warn("**WARNING** failed to move %s from the reject directory to the morgue." % (file_entry))
1851 utils.move(dest_file, morgue_file, perms=0660)
1853 dest_fd = os.open(dest_file, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
1856 utils.warn("**WARNING** failed to claim %s in the reject directory." % (file_entry))
1860 # If we got here, we own the destination file, so we can
1861 # safely overwrite it.
1862 utils.move(file_entry, dest_file, 1, perms=0660)
1865 ###########################################################################
1866 def do_reject (self, manual=0, reject_message="", note=""):
1868 Reject an upload. If called without a reject message or C{manual} is
1869 true, spawn an editor so the user can write one.
1872 @param manual: manual or automated rejection
1874 @type reject_message: string
1875 @param reject_message: A reject message
1880 # If we weren't given a manual rejection message, spawn an
1881 # editor so the user can add one in...
1882 if manual and not reject_message:
1883 (fd, temp_filename) = utils.temp_filename()
1884 temp_file = os.fdopen(fd, 'w')
1887 temp_file.write(line)
1889 editor = os.environ.get("EDITOR","vi")
1891 while answer == 'E':
1892 os.system("%s %s" % (editor, temp_filename))
1893 temp_fh = utils.open_file(temp_filename)
1894 reject_message = "".join(temp_fh.readlines())
1896 print "Reject message:"
1897 print utils.prefix_multi_line_string(reject_message," ",include_blank_lines=1)
1898 prompt = "[R]eject, Edit, Abandon, Quit ?"
1900 while prompt.find(answer) == -1:
1901 answer = utils.our_raw_input(prompt)
1902 m = re_default_answer.search(prompt)
1905 answer = answer[:1].upper()
1906 os.unlink(temp_filename)
1912 print "Rejecting.\n"
1916 reason_filename = self.pkg.changes_file[:-8] + ".reason"
1917 reason_filename = os.path.join(cnf["Dir::Queue::Reject"], reason_filename)
1919 # Move all the files into the reject directory
1920 reject_files = self.pkg.files.keys() + [self.pkg.changes_file]
1921 self.force_reject(reject_files)
1923 # If we fail here someone is probably trying to exploit the race
1924 # so let's just raise an exception ...
1925 if os.path.exists(reason_filename):
1926 os.unlink(reason_filename)
1927 reason_fd = os.open(reason_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
1929 rej_template = os.path.join(cnf["Dir::Templates"], "queue.rejected")
1933 self.Subst["__REJECTOR_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
1934 self.Subst["__MANUAL_REJECT_MESSAGE__"] = ""
1935 self.Subst["__CC__"] = "X-DAK-Rejection: automatic (moo)\nX-Katie-Rejection: automatic (moo)"
1936 os.write(reason_fd, reject_message)
1937 reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
1939 # Build up the rejection email
1940 user_email_address = utils.whoami() + " <%s>" % (cnf["Dinstall::MyAdminAddress"])
1941 self.Subst["__REJECTOR_ADDRESS__"] = user_email_address
1942 self.Subst["__MANUAL_REJECT_MESSAGE__"] = reject_message
1943 self.Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
1944 reject_mail_message = utils.TemplateSubst(self.Subst, rej_template)
1945 # Write the rejection email out as the <foo>.reason file
1946 os.write(reason_fd, reject_mail_message)
1948 del self.Subst["__REJECTOR_ADDRESS__"]
1949 del self.Subst["__MANUAL_REJECT_MESSAGE__"]
1950 del self.Subst["__CC__"]
1954 # Send the rejection mail if appropriate
1955 if not cnf["Dinstall::Options::No-Mail"]:
1956 utils.send_mail(reject_mail_message)
1959 self.logger.log(["rejected", self.pkg.changes_file])
1963 ################################################################################
1964 def in_override_p(self, package, component, suite, binary_type, file, session):
1966 Check if a package already has override entries in the DB
1968 @type package: string
1969 @param package: package name
1971 @type component: string
1972 @param component: database id of the component
1975 @param suite: database id of the suite
1977 @type binary_type: string
1978 @param binary_type: type of the package
1981 @param file: filename we check
1983 @return: the database result. But noone cares anyway.
1989 if binary_type == "": # must be source
1992 file_type = binary_type
1994 # Override suite name; used for example with proposed-updates
1995 if cnf.Find("Suite::%s::OverrideSuite" % (suite)) != "":
1996 suite = cnf["Suite::%s::OverrideSuite" % (suite)]
1998 result = get_override(package, suite, component, file_type, session)
2000 # If checking for a source package fall back on the binary override type
2001 if file_type == "dsc" and len(result) < 1:
2002 result = get_override(package, suite, component, ['deb', 'udeb'], session)
2004 # Remember the section and priority so we can check them later if appropriate
2007 self.pkg.files[file]["override section"] = result.section.section
2008 self.pkg.files[file]["override priority"] = result.priority.priority
2013 ################################################################################
2014 def get_anyversion(self, sv_list, suite):
2017 @param sv_list: list of (suite, version) tuples to check
2020 @param suite: suite name
2026 anysuite = [suite] + Cnf.ValueList("Suite::%s::VersionChecks::Enhances" % (suite))
2027 for (s, v) in sv_list:
2028 if s in [ x.lower() for x in anysuite ]:
2029 if not anyversion or apt_pkg.VersionCompare(anyversion, v) <= 0:
2034 ################################################################################
2036 def cross_suite_version_check(self, sv_list, file, new_version, sourceful=False):
2039 @param sv_list: list of (suite, version) tuples to check
2044 @type new_version: string
2045 @param new_version: XXX
2047 Ensure versions are newer than existing packages in target
2048 suites and that cross-suite version checking rules as
2049 set out in the conf file are satisfied.
2054 # Check versions for each target suite
2055 for target_suite in self.pkg.changes["distribution"].keys():
2056 must_be_newer_than = [ i.lower() for i in cnf.ValueList("Suite::%s::VersionChecks::MustBeNewerThan" % (target_suite)) ]
2057 must_be_older_than = [ i.lower() for i in cnf.ValueList("Suite::%s::VersionChecks::MustBeOlderThan" % (target_suite)) ]
2059 # Enforce "must be newer than target suite" even if conffile omits it
2060 if target_suite not in must_be_newer_than:
2061 must_be_newer_than.append(target_suite)
2063 for (suite, existent_version) in sv_list:
2064 vercmp = apt_pkg.VersionCompare(new_version, existent_version)
2066 if suite in must_be_newer_than and sourceful and vercmp < 1:
2067 self.rejects.append("%s: old version (%s) in %s >= new version (%s) targeted at %s." % (file, existent_version, suite, new_version, target_suite))
2069 if suite in must_be_older_than and vercmp > -1:
2072 if self.pkg.changes.get('distribution-version', {}).has_key(suite):
2073 # we really use the other suite, ignoring the conflicting one ...
2074 addsuite = self.pkg.changes["distribution-version"][suite]
2076 add_version = self.get_anyversion(sv_list, addsuite)
2077 target_version = self.get_anyversion(sv_list, target_suite)
2080 # not add_version can only happen if we map to a suite
2081 # that doesn't enhance the suite we're propup'ing from.
2082 # so "propup-ver x a b c; map a d" is a problem only if
2083 # d doesn't enhance a.
2085 # i think we could always propagate in this case, rather
2086 # than complaining. either way, this isn't a REJECT issue
2088 # And - we really should complain to the dorks who configured dak
2089 self.warnings.append("%s is mapped to, but not enhanced by %s - adding anyways" % (suite, addsuite))
2090 self.pkg.changes.setdefault("propdistribution", {})
2091 self.pkg.changes["propdistribution"][addsuite] = 1
2093 elif not target_version:
2094 # not targets_version is true when the package is NEW
2095 # we could just stick with the "...old version..." REJECT
2096 # for this, I think.
2097 self.rejects.append("Won't propogate NEW packages.")
2098 elif apt_pkg.VersionCompare(new_version, add_version) < 0:
2099 # propogation would be redundant. no need to reject though.
2100 self.warnings.append("ignoring versionconflict: %s: old version (%s) in %s <= new version (%s) targeted at %s." % (file, existent_version, suite, new_version, target_suite))
2102 elif apt_pkg.VersionCompare(new_version, add_version) > 0 and \
2103 apt_pkg.VersionCompare(add_version, target_version) >= 0:
2105 self.warnings.append("Propogating upload to %s" % (addsuite))
2106 self.pkg.changes.setdefault("propdistribution", {})
2107 self.pkg.changes["propdistribution"][addsuite] = 1
2111 self.reject.append("%s: old version (%s) in %s <= new version (%s) targeted at %s." % (file, existent_version, suite, new_version, target_suite))
2113 ################################################################################
2114 def check_binary_against_db(self, file, session):
2115 # Ensure version is sane
2116 q = session.query(BinAssociation)
2117 q = q.join(DBBinary).filter(DBBinary.package==self.pkg.files[file]["package"])
2118 q = q.join(Architecture).filter(Architecture.arch_string.in_([self.pkg.files[file]["architecture"], 'all']))
2120 self.cross_suite_version_check([ (x.suite.suite_name, x.binary.version) for x in q.all() ],
2121 file, self.pkg.files[file]["version"], sourceful=False)
2123 # Check for any existing copies of the file
2124 q = session.query(DBBinary).filter_by(package=self.pkg.files[file]["package"])
2125 q = q.filter_by(version=self.pkg.files[file]["version"])
2126 q = q.join(Architecture).filter_by(arch_string=self.pkg.files[file]["architecture"])
2129 self.rejects.append("%s: can not overwrite existing copy already in the archive." % (file))
2131 ################################################################################
2133 def check_source_against_db(self, file, session):
2136 source = self.pkg.dsc.get("source")
2137 version = self.pkg.dsc.get("version")
2139 # Ensure version is sane
2140 q = session.query(SrcAssociation)
2141 q = q.join(DBSource).filter(DBSource.source==source)
2143 self.cross_suite_version_check([ (x.suite.suite_name, x.source.version) for x in q.all() ],
2144 file, version, sourceful=True)
2146 ################################################################################
2147 def check_dsc_against_db(self, file, session):
2150 @warning: NB: this function can remove entries from the 'files' index [if
2151 the orig tarball is a duplicate of the one in the archive]; if
2152 you're iterating over 'files' and call this function as part of
2153 the loop, be sure to add a check to the top of the loop to
2154 ensure you haven't just tried to dereference the deleted entry.
2159 self.pkg.orig_files = {} # XXX: do we need to clear it?
2160 orig_files = self.pkg.orig_files
2162 # Try and find all files mentioned in the .dsc. This has
2163 # to work harder to cope with the multiple possible
2164 # locations of an .orig.tar.gz.
2165 # The ordering on the select is needed to pick the newest orig
2166 # when it exists in multiple places.
2167 for dsc_name, dsc_entry in self.pkg.dsc_files.items():
2169 if self.pkg.files.has_key(dsc_name):
2170 actual_md5 = self.pkg.files[dsc_name]["md5sum"]
2171 actual_size = int(self.pkg.files[dsc_name]["size"])
2172 found = "%s in incoming" % (dsc_name)
2174 # Check the file does not already exist in the archive
2175 ql = get_poolfile_like_name(dsc_name, session)
2177 # Strip out anything that isn't '%s' or '/%s$'
2179 if not i.filename.endswith(dsc_name):
2182 # "[dak] has not broken them. [dak] has fixed a
2183 # brokenness. Your crappy hack exploited a bug in
2186 # "(Come on! I thought it was always obvious that
2187 # one just doesn't release different files with
2188 # the same name and version.)"
2189 # -- ajk@ on d-devel@l.d.o
2192 # Ignore exact matches for .orig.tar.gz
2194 if re_is_orig_source.match(dsc_name):
2196 if self.pkg.files.has_key(dsc_name) and \
2197 int(self.pkg.files[dsc_name]["size"]) == int(i.filesize) and \
2198 self.pkg.files[dsc_name]["md5sum"] == i.md5sum:
2199 self.warnings.append("ignoring %s, since it's already in the archive." % (dsc_name))
2200 # TODO: Don't delete the entry, just mark it as not needed
2201 # This would fix the stupidity of changing something we often iterate over
2202 # whilst we're doing it
2203 del self.pkg.files[dsc_name]
2204 if not orig_files.has_key(dsc_name):
2205 orig_files[dsc_name] = {}
2206 orig_files[dsc_name]["path"] = os.path.join(i.location.path, i.filename)
2210 self.rejects.append("can not overwrite existing copy of '%s' already in the archive." % (dsc_name))
2212 elif re_is_orig_source.match(dsc_name):
2214 ql = get_poolfile_like_name(dsc_name, session)
2216 # Strip out anything that isn't '%s' or '/%s$'
2217 # TODO: Shouldn't we just search for things which end with our string explicitly in the SQL?
2219 if not i.filename.endswith(dsc_name):
2223 # Unfortunately, we may get more than one match here if,
2224 # for example, the package was in potato but had an -sa
2225 # upload in woody. So we need to choose the right one.
2227 # default to something sane in case we don't match any or have only one
2232 old_file = os.path.join(i.location.path, i.filename)
2233 old_file_fh = utils.open_file(old_file)
2234 actual_md5 = apt_pkg.md5sum(old_file_fh)
2236 actual_size = os.stat(old_file)[stat.ST_SIZE]
2237 if actual_md5 == dsc_entry["md5sum"] and actual_size == int(dsc_entry["size"]):
2240 old_file = os.path.join(i.location.path, i.filename)
2241 old_file_fh = utils.open_file(old_file)
2242 actual_md5 = apt_pkg.md5sum(old_file_fh)
2244 actual_size = os.stat(old_file)[stat.ST_SIZE]
2246 suite_type = x.location.archive_type
2247 # need this for updating dsc_files in install()
2248 dsc_entry["files id"] = x.file_id
2249 # See install() in process-accepted...
2250 if not orig_files.has_key(dsc_name):
2251 orig_files[dsc_name] = {}
2252 orig_files[dsc_name]["id"] = x.file_id
2253 orig_files[dsc_name]["path"] = old_file
2254 orig_files[dsc_name]["location"] = x.location.location_id
2256 # TODO: Record the queues and info in the DB so we don't hardcode all this crap
2257 # Not there? Check the queue directories...
2258 for directory in [ "Accepted", "New", "Byhand", "ProposedUpdates", "OldProposedUpdates", "Embargoed", "Unembargoed" ]:
2259 if not Cnf.has_key("Dir::Queue::%s" % (directory)):
2261 in_otherdir = os.path.join(Cnf["Dir::Queue::%s" % (directory)], dsc_name)
2262 if os.path.exists(in_otherdir):
2263 in_otherdir_fh = utils.open_file(in_otherdir)
2264 actual_md5 = apt_pkg.md5sum(in_otherdir_fh)
2265 in_otherdir_fh.close()
2266 actual_size = os.stat(in_otherdir)[stat.ST_SIZE]
2268 if not orig_files.has_key(dsc_name):
2269 orig_files[dsc_name] = {}
2270 orig_files[dsc_name]["path"] = in_otherdir
2273 self.rejects.append("%s refers to %s, but I can't find it in the queue or in the pool." % (file, dsc_name))
2276 self.rejects.append("%s refers to %s, but I can't find it in the queue." % (file, dsc_name))
2278 if actual_md5 != dsc_entry["md5sum"]:
2279 self.rejects.append("md5sum for %s doesn't match %s." % (found, file))
2280 if actual_size != int(dsc_entry["size"]):
2281 self.rejects.append("size for %s doesn't match %s." % (found, file))
2283 ################################################################################
2284 def accepted_checks(self, overwrite_checks, session):
2285 # Recheck anything that relies on the database; since that's not
2286 # frozen between accept and our run time when called from p-a.
2288 # overwrite_checks is set to False when installing to stable/oldstable
2293 # Find the .dsc (again)
2295 for f in self.pkg.files.keys():
2296 if self.pkg.files[f]["type"] == "dsc":
2299 for checkfile in self.pkg.files.keys():
2300 # The .orig.tar.gz can disappear out from under us is it's a
2301 # duplicate of one in the archive.
2302 if not self.pkg.files.has_key(checkfile):
2305 entry = self.pkg.files[checkfile]
2307 # Check that the source still exists
2308 if entry["type"] == "deb":
2309 source_version = entry["source version"]
2310 source_package = entry["source package"]
2311 if not self.pkg.changes["architecture"].has_key("source") \
2312 and not source_exists(source_package, source_version, self.pkg.changes["distribution"].keys()):
2313 self.rejects.append("no source found for %s %s (%s)." % (source_package, source_version, checkfile))
2315 # Version and file overwrite checks
2316 if overwrite_checks:
2317 if entry["type"] == "deb":
2318 self.check_binary_against_db(checkfile, session)
2319 elif entry["type"] == "dsc":
2320 self.check_source_against_db(checkfile, session)
2321 self.check_dsc_against_db(dsc_filename, session)
2323 # propogate in the case it is in the override tables:
2324 for suite in self.pkg.changes.get("propdistribution", {}).keys():
2325 if self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
2326 propogate[suite] = 1
2328 nopropogate[suite] = 1
2330 for suite in propogate.keys():
2331 if suite in nopropogate:
2333 self.pkg.changes["distribution"][suite] = 1
2335 for checkfile in self.pkg.files.keys():
2336 # Check the package is still in the override tables
2337 for suite in self.pkg.changes["distribution"].keys():
2338 if not self.in_override_p(entry["package"], entry["component"], suite, entry.get("dbtype",""), checkfile, session):
2339 self.rejects.append("%s is NEW for %s." % (checkfile, suite))
2341 ################################################################################
2342 # This is not really a reject, but an unaccept, but since a) the code for
2343 # that is non-trivial (reopen bugs, unannounce etc.), b) this should be
2344 # extremely rare, for now we'll go with whining at our admin folks...
2346 def do_unaccept(self):
2350 self.Subst["__REJECTOR_ADDRESS__"] = cnf["Dinstall::MyEmailAddress"]
2351 self.Subst["__REJECT_MESSAGE__"] = self.package_info()
2352 self.Subst["__CC__"] = "Cc: " + cnf["Dinstall::MyEmailAddress"]
2353 self.Subst["__BCC__"] = "X-DAK: dak process-accepted\nX-Katie: $Revision: 1.18 $"
2354 if cnf.has_key("Dinstall::Bcc"):
2355 self.Subst["__BCC__"] += "\nBcc: %s" % (cnf["Dinstall::Bcc"])
2357 template = os.path.join(cnf["Dir::Templates"], "process-accepted.unaccept")
2359 reject_mail_message = utils.TemplateSubst(self.Subst, template)
2361 # Write the rejection email out as the <foo>.reason file
2362 reason_filename = os.path.basename(self.pkg.changes_file[:-8]) + ".reason"
2363 reject_filename = os.path.join(cnf["Dir::Queue::Reject"], reason_filename)
2365 # If we fail here someone is probably trying to exploit the race
2366 # so let's just raise an exception ...
2367 if os.path.exists(reject_filename):
2368 os.unlink(reject_filename)
2370 fd = os.open(reject_filename, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0644)
2371 os.write(fd, reject_mail_message)
2374 utils.send_mail(reject_mail_message)
2376 del self.Subst["__REJECTOR_ADDRESS__"]
2377 del self.Subst["__REJECT_MESSAGE__"]
2378 del self.Subst["__CC__"]
2380 ################################################################################
2381 # If any file of an upload has a recent mtime then chances are good
2382 # the file is still being uploaded.
2384 def upload_too_new(self):
2387 # Move back to the original directory to get accurate time stamps
2389 os.chdir(self.pkg.directory)
2390 file_list = self.pkg.files.keys()
2391 file_list.extend(self.pkg.dsc_files.keys())
2392 file_list.append(self.pkg.changes_file)
2395 last_modified = time.time()-os.path.getmtime(f)
2396 if last_modified < int(cnf["Dinstall::SkipTime"]):