3 # Checks Debian packages from Incoming
4 # Copyright (C) 2000, 2001, 2002, 2003, 2004, 2005, 2006 James Troup <james@nocrew.org>
6 # This program is free software; you can redistribute it and/or modify
7 # it under the terms of the GNU General Public License as published by
8 # the Free Software Foundation; either version 2 of the License, or
9 # (at your option) any later version.
11 # This program is distributed in the hope that it will be useful,
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 # GNU General Public License for more details.
16 # You should have received a copy of the GNU General Public License
17 # along with this program; if not, write to the Free Software
18 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
20 # Originally based on dinstall by Guy Maor <maor@debian.org>
22 ################################################################################
24 # Computer games don't affect kids. I mean if Pacman affected our generation as
25 # kids, we'd all run around in a darkened room munching pills and listening to
29 ################################################################################
31 import commands, errno, fcntl, os, re, shutil, stat, sys, time, tempfile, traceback
32 import apt_inst, apt_pkg
33 import daklib.database
40 ################################################################################
42 re_valid_version = re.compile(r"^([0-9]+:)?[0-9A-Za-z\.\-\+:]+$")
43 re_valid_pkg_name = re.compile(r"^[\dA-Za-z][\dA-Za-z\+\-\.]+$")
44 re_changelog_versions = re.compile(r"^\w[-+0-9a-z.]+ \([^\(\) \t]+\)")
45 re_strip_revision = re.compile(r"-([^-]+)$")
47 ################################################################################
58 # Aliases to the real vars in the Upload class; hysterical raisins.
66 ###############################################################################
69 global Cnf, Options, Upload, changes, dsc, dsc_files, files, pkg
73 Cnf = apt_pkg.newConfiguration()
74 apt_pkg.ReadConfigFileISC(Cnf,daklib.utils.which_conf_file())
76 Arguments = [('a',"automatic","Dinstall::Options::Automatic"),
77 ('h',"help","Dinstall::Options::Help"),
78 ('n',"no-action","Dinstall::Options::No-Action"),
79 ('p',"no-lock", "Dinstall::Options::No-Lock"),
80 ('s',"no-mail", "Dinstall::Options::No-Mail")]
82 for i in ["automatic", "help", "no-action", "no-lock", "no-mail",
83 "override-distribution", "version"]:
84 Cnf["Dinstall::Options::%s" % (i)] = ""
86 changes_files = apt_pkg.ParseCommandLine(Cnf,Arguments,sys.argv)
87 Options = Cnf.SubTree("Dinstall::Options")
92 Upload = daklib.queue.Upload(Cnf)
94 changes = Upload.pkg.changes
96 dsc_files = Upload.pkg.dsc_files
97 files = Upload.pkg.files
102 ################################################################################
104 def usage (exit_code=0):
105 print """Usage: dinstall [OPTION]... [CHANGES]...
106 -a, --automatic automatic run
107 -h, --help show this help and exit.
108 -n, --no-action don't do anything
109 -p, --no-lock don't check lockfile !! for cron.daily only !!
110 -s, --no-mail don't send any mail
111 -V, --version display the version number and exit"""
114 ################################################################################
116 def reject (str, prefix="Rejected: "):
117 global reject_message
119 reject_message += prefix + str + "\n"
121 ################################################################################
123 def copy_to_holding(filename):
126 base_filename = os.path.basename(filename)
128 dest = Cnf["Dir::Queue::Holding"] + '/' + base_filename
130 fd = os.open(dest, os.O_RDWR|os.O_CREAT|os.O_EXCL, 0640)
133 # Shouldn't happen, but will if, for example, someone lists a
134 # file twice in the .changes.
135 if errno.errorcode[e.errno] == 'EEXIST':
136 reject("%s: already exists in holding area; can not overwrite." % (base_filename))
141 shutil.copy(filename, dest)
143 # In either case (ENOENT or EACCES) we want to remove the
144 # O_CREAT | O_EXCLed ghost file, so add the file to the list
145 # of 'in holding' even if it's not the real file.
146 if errno.errorcode[e.errno] == 'ENOENT':
147 reject("%s: can not copy to holding area: file not found." % (base_filename))
150 elif errno.errorcode[e.errno] == 'EACCES':
151 reject("%s: can not copy to holding area: read permission denied." % (base_filename))
156 in_holding[base_filename] = ""
158 ################################################################################
164 os.chdir(Cnf["Dir::Queue::Holding"])
165 for file in in_holding.keys():
166 if os.path.exists(file):
167 if file.find('/') != -1:
168 daklib.utils.fubar("WTF? clean_holding() got a file ('%s') with / in it!" % (file))
174 ################################################################################
177 filename = pkg.changes_file
179 # Parse the .changes field into a dictionary
181 changes.update(daklib.utils.parse_changes(filename))
182 except daklib.utils.cant_open_exc:
183 reject("%s: can't read file." % (filename))
185 except daklib.utils.changes_parse_error_exc, line:
186 reject("%s: parse error, can't grok: %s." % (filename, line))
189 # Parse the Files field from the .changes into another dictionary
191 files.update(daklib.utils.build_file_list(changes))
192 except daklib.utils.changes_parse_error_exc, line:
193 reject("%s: parse error, can't grok: %s." % (filename, line))
194 except daklib.utils.nk_format_exc, format:
195 reject("%s: unknown format '%s'." % (filename, format))
198 # Check for mandatory fields
199 for i in ("source", "binary", "architecture", "version", "distribution",
200 "maintainer", "files", "changes", "description"):
201 if not changes.has_key(i):
202 reject("%s: Missing mandatory field `%s'." % (filename, i))
203 return 0 # Avoid <undef> errors during later tests
205 # Split multi-value fields into a lower-level dictionary
206 for i in ("architecture", "distribution", "binary", "closes"):
207 o = changes.get(i, "")
214 # Fix the Maintainer: field to be RFC822/2047 compatible
216 (changes["maintainer822"], changes["maintainer2047"],
217 changes["maintainername"], changes["maintaineremail"]) = \
218 daklib.utils.fix_maintainer (changes["maintainer"])
219 except daklib.utils.ParseMaintError, msg:
220 reject("%s: Maintainer field ('%s') failed to parse: %s" \
221 % (filename, changes["maintainer"], msg))
223 # ...likewise for the Changed-By: field if it exists.
225 (changes["changedby822"], changes["changedby2047"],
226 changes["changedbyname"], changes["changedbyemail"]) = \
227 daklib.utils.fix_maintainer (changes.get("changed-by", ""))
228 except daklib.utils.ParseMaintError, msg:
229 (changes["changedby822"], changes["changedby2047"],
230 changes["changedbyname"], changes["changedbyemail"]) = \
232 reject("%s: Changed-By field ('%s') failed to parse: %s" \
233 % (filename, changes["changed-by"], msg))
235 # Ensure all the values in Closes: are numbers
236 if changes.has_key("closes"):
237 for i in changes["closes"].keys():
238 if daklib.queue.re_isanum.match (i) == None:
239 reject("%s: `%s' from Closes field isn't a number." % (filename, i))
242 # chopversion = no epoch; chopversion2 = no epoch and no revision (e.g. for .orig.tar.gz comparison)
243 changes["chopversion"] = daklib.utils.re_no_epoch.sub('', changes["version"])
244 changes["chopversion2"] = daklib.utils.re_no_revision.sub('', changes["chopversion"])
246 # Check there isn't already a changes file of the same name in one
247 # of the queue directories.
248 base_filename = os.path.basename(filename)
249 for dir in [ "Accepted", "Byhand", "Done", "New" ]:
250 if os.path.exists(Cnf["Dir::Queue::%s" % (dir) ]+'/'+base_filename):
251 reject("%s: a file with this name already exists in the %s directory." % (base_filename, dir))
253 # Check the .changes is non-empty
255 reject("%s: nothing to do (Files field is empty)." % (base_filename))
260 ################################################################################
262 def check_distributions():
263 "Check and map the Distribution field of a .changes file."
265 # Handle suite mappings
266 for map in Cnf.ValueList("SuiteMappings"):
269 if type == "map" or type == "silent-map":
270 (source, dest) = args[1:3]
271 if changes["distribution"].has_key(source):
272 del changes["distribution"][source]
273 changes["distribution"][dest] = 1
274 if type != "silent-map":
275 reject("Mapping %s to %s." % (source, dest),"")
276 if changes.has_key("distribution-version"):
277 if changes["distribution-version"].has_key(source):
278 changes["distribution-version"][source]=dest
279 elif type == "map-unreleased":
280 (source, dest) = args[1:3]
281 if changes["distribution"].has_key(source):
282 for arch in changes["architecture"].keys():
283 if arch not in Cnf.ValueList("Suite::%s::Architectures" % (source)):
284 reject("Mapping %s to %s for unreleased architecture %s." % (source, dest, arch),"")
285 del changes["distribution"][source]
286 changes["distribution"][dest] = 1
288 elif type == "ignore":
290 if changes["distribution"].has_key(suite):
291 del changes["distribution"][suite]
292 reject("Ignoring %s as a target suite." % (suite), "Warning: ")
293 elif type == "reject":
295 if changes["distribution"].has_key(suite):
296 reject("Uploads to %s are not accepted." % (suite))
297 elif type == "propup-version":
298 # give these as "uploaded-to(non-mapped) suites-to-add-when-upload-obsoletes"
300 # changes["distribution-version"] looks like: {'testing': 'testing-proposed-updates'}
301 if changes["distribution"].has_key(args[1]):
302 changes.setdefault("distribution-version", {})
303 for suite in args[2:]: changes["distribution-version"][suite]=suite
305 # Ensure there is (still) a target distribution
306 if changes["distribution"].keys() == []:
307 reject("no valid distribution.")
309 # Ensure target distributions exist
310 for suite in changes["distribution"].keys():
311 if not Cnf.has_key("Suite::%s" % (suite)):
312 reject("Unknown distribution `%s'." % (suite))
314 ################################################################################
316 def check_deb_ar(filename, control):
317 """Sanity check the ar of a .deb, i.e. that there is:
321 o data.tar.gz or data.tar.bz2
323 in that order, and nothing else. If the third member is a
324 data.tar.bz2, an additional check is performed for the required
325 Pre-Depends on dpkg (>= 1.10.24)."""
326 cmd = "ar t %s" % (filename)
327 (result, output) = commands.getstatusoutput(cmd)
329 reject("%s: 'ar t' invocation failed." % (filename))
330 reject(daklib.utils.prefix_multi_line_string(output, " [ar output:] "), "")
331 chunks = output.split('\n')
333 reject("%s: found %d chunks, expected 3." % (filename, len(chunks)))
334 if chunks[0] != "debian-binary":
335 reject("%s: first chunk is '%s', expected 'debian-binary'." % (filename, chunks[0]))
336 if chunks[1] != "control.tar.gz":
337 reject("%s: second chunk is '%s', expected 'control.tar.gz'." % (filename, chunks[1]))
338 if chunks[2] == "data.tar.bz2":
339 # Packages using bzip2 compression must have a Pre-Depends on dpkg >= 1.10.24.
340 found_needed_predep = 0
341 for parsed_dep in apt_pkg.ParseDepends(control.Find("Pre-Depends", "")):
342 for atom in parsed_dep:
343 (dep, version, constraint) = atom
344 if dep != "dpkg" or (constraint != ">=" and constraint != ">>") or \
345 len(parsed_dep) > 1: # or'ed deps don't count
347 if (constraint == ">=" and apt_pkg.VersionCompare(version, "1.10.24") < 0) or \
348 (constraint == ">>" and apt_pkg.VersionCompare(version, "1.10.23") < 0):
350 found_needed_predep = 1
351 if not found_needed_predep:
352 reject("%s: uses bzip2 compression, but doesn't Pre-Depend on dpkg (>= 1.10.24)" % (filename))
353 elif chunks[2] != "data.tar.gz":
354 reject("%s: third chunk is '%s', expected 'data.tar.gz' or 'data.tar.bz2'." % (filename, chunks[2]))
356 ################################################################################
361 archive = daklib.utils.where_am_i()
362 file_keys = files.keys()
364 # if reprocess is 2 we've already done this and we're checking
365 # things again for the new .orig.tar.gz.
366 # [Yes, I'm fully aware of how disgusting this is]
367 if not Options["No-Action"] and reprocess < 2:
369 os.chdir(pkg.directory)
370 for file in file_keys:
371 copy_to_holding(file)
374 # Check there isn't already a .changes or .dak file of the same name in
375 # the proposed-updates "CopyChanges" or "CopyDotDak" storage directories.
376 # [NB: this check must be done post-suite mapping]
377 base_filename = os.path.basename(pkg.changes_file)
378 dot_dak_filename = base_filename[:-8]+".dak"
379 for suite in changes["distribution"].keys():
380 copychanges = "Suite::%s::CopyChanges" % (suite)
381 if Cnf.has_key(copychanges) and \
382 os.path.exists(Cnf[copychanges]+"/"+base_filename):
383 reject("%s: a file with this name already exists in %s" \
384 % (base_filename, Cnf[copychanges]))
386 copy_dot_dak = "Suite::%s::CopyDotDak" % (suite)
387 if Cnf.has_key(copy_dot_dak) and \
388 os.path.exists(Cnf[copy_dot_dak]+"/"+dot_dak_filename):
389 reject("%s: a file with this name already exists in %s" \
390 % (dot_dak_filename, Cnf[copy_dot_dak]))
396 for file in file_keys:
397 # Ensure the file does not already exist in one of the accepted directories
398 for dir in [ "Accepted", "Byhand", "New" ]:
399 if os.path.exists(Cnf["Dir::Queue::%s" % (dir) ]+'/'+file):
400 reject("%s file already exists in the %s directory." % (file, dir))
401 if not daklib.utils.re_taint_free.match(file):
402 reject("!!WARNING!! tainted filename: '%s'." % (file))
403 # Check the file is readable
404 if os.access(file,os.R_OK) == 0:
405 # When running in -n, copy_to_holding() won't have
406 # generated the reject_message, so we need to.
407 if Options["No-Action"]:
408 if os.path.exists(file):
409 reject("Can't read `%s'. [permission denied]" % (file))
411 reject("Can't read `%s'. [file not found]" % (file))
412 files[file]["type"] = "unreadable"
414 # If it's byhand skip remaining checks
415 if files[file]["section"] == "byhand" or files[file]["section"] == "raw-installer":
416 files[file]["byhand"] = 1
417 files[file]["type"] = "byhand"
418 # Checks for a binary package...
419 elif daklib.utils.re_isadeb.match(file):
421 files[file]["type"] = "deb"
423 # Extract package control information
424 deb_file = daklib.utils.open_file(file)
426 control = apt_pkg.ParseSection(apt_inst.debExtractControl(deb_file))
428 reject("%s: debExtractControl() raised %s." % (file, sys.exc_type))
430 # Can't continue, none of the checks on control would work.
434 # Check for mandatory fields
435 for field in [ "Package", "Architecture", "Version" ]:
436 if control.Find(field) == None:
437 reject("%s: No %s field in control." % (file, field))
441 # Ensure the package name matches the one give in the .changes
442 if not changes["binary"].has_key(control.Find("Package", "")):
443 reject("%s: control file lists name as `%s', which isn't in changes file." % (file, control.Find("Package", "")))
445 # Validate the package field
446 package = control.Find("Package")
447 if not re_valid_pkg_name.match(package):
448 reject("%s: invalid package name '%s'." % (file, package))
450 # Validate the version field
451 version = control.Find("Version")
452 if not re_valid_version.match(version):
453 reject("%s: invalid version number '%s'." % (file, version))
455 # Ensure the architecture of the .deb is one we know about.
456 default_suite = Cnf.get("Dinstall::DefaultSuite", "Unstable")
457 architecture = control.Find("Architecture")
458 if architecture not in Cnf.ValueList("Suite::%s::Architectures" % (default_suite)):
459 reject("Unknown architecture '%s'." % (architecture))
461 # Ensure the architecture of the .deb is one of the ones
462 # listed in the .changes.
463 if not changes["architecture"].has_key(architecture):
464 reject("%s: control file lists arch as `%s', which isn't in changes file." % (file, architecture))
466 # Sanity-check the Depends field
467 depends = control.Find("Depends")
469 reject("%s: Depends field is empty." % (file))
471 # Check the section & priority match those given in the .changes (non-fatal)
472 if control.Find("Section") and files[file]["section"] != "" and files[file]["section"] != control.Find("Section"):
473 reject("%s control file lists section as `%s', but changes file has `%s'." % (file, control.Find("Section", ""), files[file]["section"]), "Warning: ")
474 if control.Find("Priority") and files[file]["priority"] != "" and files[file]["priority"] != control.Find("Priority"):
475 reject("%s control file lists priority as `%s', but changes file has `%s'." % (file, control.Find("Priority", ""), files[file]["priority"]),"Warning: ")
477 files[file]["package"] = package
478 files[file]["architecture"] = architecture
479 files[file]["version"] = version
480 files[file]["maintainer"] = control.Find("Maintainer", "")
481 if file.endswith(".udeb"):
482 files[file]["dbtype"] = "udeb"
483 elif file.endswith(".deb"):
484 files[file]["dbtype"] = "deb"
486 reject("%s is neither a .deb or a .udeb." % (file))
487 files[file]["source"] = control.Find("Source", files[file]["package"])
488 # Get the source version
489 source = files[file]["source"]
491 if source.find("(") != -1:
492 m = daklib.utils.re_extract_src_version.match(source)
494 source_version = m.group(2)
495 if not source_version:
496 source_version = files[file]["version"]
497 files[file]["source package"] = source
498 files[file]["source version"] = source_version
500 # Ensure the filename matches the contents of the .deb
501 m = daklib.utils.re_isadeb.match(file)
503 file_package = m.group(1)
504 if files[file]["package"] != file_package:
505 reject("%s: package part of filename (%s) does not match package name in the %s (%s)." % (file, file_package, files[file]["dbtype"], files[file]["package"]))
506 epochless_version = daklib.utils.re_no_epoch.sub('', control.Find("Version"))
508 file_version = m.group(2)
509 if epochless_version != file_version:
510 reject("%s: version part of filename (%s) does not match package version in the %s (%s)." % (file, file_version, files[file]["dbtype"], epochless_version))
512 file_architecture = m.group(3)
513 if files[file]["architecture"] != file_architecture:
514 reject("%s: architecture part of filename (%s) does not match package architecture in the %s (%s)." % (file, file_architecture, files[file]["dbtype"], files[file]["architecture"]))
516 # Check for existent source
517 source_version = files[file]["source version"]
518 source_package = files[file]["source package"]
519 if changes["architecture"].has_key("source"):
520 if source_version != changes["version"]:
521 reject("source version (%s) for %s doesn't match changes version %s." % (source_version, file, changes["version"]))
523 # Check in the SQL database
524 if not Upload.source_exists(source_package, source_version, changes["distribution"].keys()):
525 # Check in one of the other directories
526 source_epochless_version = daklib.utils.re_no_epoch.sub('', source_version)
527 dsc_filename = "%s_%s.dsc" % (source_package, source_epochless_version)
528 if os.path.exists(Cnf["Dir::Queue::Byhand"] + '/' + dsc_filename):
529 files[file]["byhand"] = 1
530 elif os.path.exists(Cnf["Dir::Queue::New"] + '/' + dsc_filename):
531 files[file]["new"] = 1
532 elif not os.path.exists(Cnf["Dir::Queue::Accepted"] + '/' + dsc_filename):
533 reject("no source found for %s %s (%s)." % (source_package, source_version, file))
534 # Check the version and for file overwrites
535 reject(Upload.check_binary_against_db(file),"")
537 check_deb_ar(file, control)
539 # Checks for a source package...
541 m = daklib.utils.re_issource.match(file)
544 files[file]["package"] = m.group(1)
545 files[file]["version"] = m.group(2)
546 files[file]["type"] = m.group(3)
548 # Ensure the source package name matches the Source filed in the .changes
549 if changes["source"] != files[file]["package"]:
550 reject("%s: changes file doesn't say %s for Source" % (file, files[file]["package"]))
552 # Ensure the source version matches the version in the .changes file
553 if files[file]["type"] == "orig.tar.gz":
554 changes_version = changes["chopversion2"]
556 changes_version = changes["chopversion"]
557 if changes_version != files[file]["version"]:
558 reject("%s: should be %s according to changes file." % (file, changes_version))
560 # Ensure the .changes lists source in the Architecture field
561 if not changes["architecture"].has_key("source"):
562 reject("%s: changes file doesn't list `source' in Architecture field." % (file))
564 # Check the signature of a .dsc file
565 if files[file]["type"] == "dsc":
566 dsc["fingerprint"] = daklib.utils.check_signature(file, reject)
568 files[file]["architecture"] = "source"
570 # Not a binary or source package? Assume byhand...
572 files[file]["byhand"] = 1
573 files[file]["type"] = "byhand"
575 # Per-suite file checks
576 files[file]["oldfiles"] = {}
577 for suite in changes["distribution"].keys():
579 if files[file].has_key("byhand"):
582 # Handle component mappings
583 for map in Cnf.ValueList("ComponentMappings"):
584 (source, dest) = map.split()
585 if files[file]["component"] == source:
586 files[file]["original component"] = source
587 files[file]["component"] = dest
589 # Ensure the component is valid for the target suite
590 if Cnf.has_key("Suite:%s::Components" % (suite)) and \
591 files[file]["component"] not in Cnf.ValueList("Suite::%s::Components" % (suite)):
592 reject("unknown component `%s' for suite `%s'." % (files[file]["component"], suite))
595 # Validate the component
596 component = files[file]["component"]
597 component_id = daklib.database.get_component_id(component)
598 if component_id == -1:
599 reject("file '%s' has unknown component '%s'." % (file, component))
602 # See if the package is NEW
603 if not Upload.in_override_p(files[file]["package"], files[file]["component"], suite, files[file].get("dbtype",""), file):
604 files[file]["new"] = 1
606 # Validate the priority
607 if files[file]["priority"].find('/') != -1:
608 reject("file '%s' has invalid priority '%s' [contains '/']." % (file, files[file]["priority"]))
610 # Determine the location
611 location = Cnf["Dir::Pool"]
612 location_id = daklib.database.get_location_id (location, component, archive)
613 if location_id == -1:
614 reject("[INTERNAL ERROR] couldn't determine location (Component: %s, Archive: %s)" % (component, archive))
615 files[file]["location id"] = location_id
617 # Check the md5sum & size against existing files (if any)
618 files[file]["pool name"] = daklib.utils.poolify (changes["source"], files[file]["component"])
619 files_id = daklib.database.get_files_id(files[file]["pool name"] + file, files[file]["size"], files[file]["md5sum"], files[file]["location id"])
621 reject("INTERNAL ERROR, get_files_id() returned multiple matches for %s." % (file))
623 reject("md5sum and/or size mismatch on existing copy of %s." % (file))
624 files[file]["files id"] = files_id
626 # Check for packages that have moved from one component to another
627 q = Upload.projectB.query("""
628 SELECT c.name FROM binaries b, bin_associations ba, suite s, location l,
629 component c, architecture a, files f
630 WHERE b.package = '%s' AND s.suite_name = '%s'
631 AND (a.arch_string = '%s' OR a.arch_string = 'all')
632 AND ba.bin = b.id AND ba.suite = s.id AND b.architecture = a.id
633 AND f.location = l.id AND l.component = c.id AND b.file = f.id"""
634 % (files[file]["package"], suite,
635 files[file]["architecture"]))
638 files[file]["othercomponents"] = ql[0][0]
640 # If the .changes file says it has source, it must have source.
641 if changes["architecture"].has_key("source"):
643 reject("no source found and Architecture line in changes mention source.")
645 if not has_binaries and Cnf.FindB("Dinstall::Reject::NoSourceOnly"):
646 reject("source only uploads are not supported.")
648 ###############################################################################
653 # Ensure there is source to check
654 if not changes["architecture"].has_key("source"):
659 for file in files.keys():
660 if files[file]["type"] == "dsc":
662 reject("can not process a .changes file with multiple .dsc's.")
667 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
669 reject("source uploads must contain a dsc file")
672 # Parse the .dsc file
674 dsc.update(daklib.utils.parse_changes(dsc_filename, signing_rules=1))
675 except daklib.utils.cant_open_exc:
676 # if not -n copy_to_holding() will have done this for us...
677 if Options["No-Action"]:
678 reject("%s: can't read file." % (dsc_filename))
679 except daklib.utils.changes_parse_error_exc, line:
680 reject("%s: parse error, can't grok: %s." % (dsc_filename, line))
681 except daklib.utils.invalid_dsc_format_exc, line:
682 reject("%s: syntax error on line %s." % (dsc_filename, line))
683 # Build up the file list of files mentioned by the .dsc
685 dsc_files.update(daklib.utils.build_file_list(dsc, is_a_dsc=1))
686 except daklib.utils.no_files_exc:
687 reject("%s: no Files: field." % (dsc_filename))
689 except daklib.utils.changes_parse_error_exc, line:
690 reject("%s: parse error, can't grok: %s." % (dsc_filename, line))
693 # Enforce mandatory fields
694 for i in ("format", "source", "version", "binary", "maintainer", "architecture", "files"):
695 if not dsc.has_key(i):
696 reject("%s: missing mandatory field `%s'." % (dsc_filename, i))
699 # Validate the source and version fields
700 if not re_valid_pkg_name.match(dsc["source"]):
701 reject("%s: invalid source name '%s'." % (dsc_filename, dsc["source"]))
702 if not re_valid_version.match(dsc["version"]):
703 reject("%s: invalid version number '%s'." % (dsc_filename, dsc["version"]))
705 # Bumping the version number of the .dsc breaks extraction by stable's
706 # dpkg-source. So let's not do that...
707 if dsc["format"] != "1.0":
708 reject("%s: incompatible 'Format' version produced by a broken version of dpkg-dev 1.9.1{3,4}." % (dsc_filename))
710 # Validate the Maintainer field
712 daklib.utils.fix_maintainer (dsc["maintainer"])
713 except daklib.utils.ParseMaintError, msg:
714 reject("%s: Maintainer field ('%s') failed to parse: %s" \
715 % (dsc_filename, dsc["maintainer"], msg))
717 # Validate the build-depends field(s)
718 for field_name in [ "build-depends", "build-depends-indep" ]:
719 field = dsc.get(field_name)
721 # Check for broken dpkg-dev lossage...
722 if field.startswith("ARRAY"):
723 reject("%s: invalid %s field produced by a broken version of dpkg-dev (1.10.11)" % (dsc_filename, field_name.title()))
725 # Have apt try to parse them...
727 apt_pkg.ParseSrcDepends(field)
729 reject("%s: invalid %s field (can not be parsed by apt)." % (dsc_filename, field_name.title()))
732 # Ensure the version number in the .dsc matches the version number in the .changes
733 epochless_dsc_version = daklib.utils.re_no_epoch.sub('', dsc["version"])
734 changes_version = files[dsc_filename]["version"]
735 if epochless_dsc_version != files[dsc_filename]["version"]:
736 reject("version ('%s') in .dsc does not match version ('%s') in .changes." % (epochless_dsc_version, changes_version))
738 # Ensure there is a .tar.gz in the .dsc file
740 for f in dsc_files.keys():
741 m = daklib.utils.re_issource.match(f)
743 reject("%s: %s in Files field not recognised as source." % (dsc_filename, f))
745 if type == "orig.tar.gz" or type == "tar.gz":
748 reject("%s: no .tar.gz or .orig.tar.gz in 'Files' field." % (dsc_filename))
750 # Ensure source is newer than existing source in target suites
751 reject(Upload.check_source_against_db(dsc_filename),"")
753 (reject_msg, is_in_incoming) = Upload.check_dsc_against_db(dsc_filename)
754 reject(reject_msg, "")
756 if not Options["No-Action"]:
757 copy_to_holding(is_in_incoming)
758 orig_tar_gz = os.path.basename(is_in_incoming)
759 files[orig_tar_gz] = {}
760 files[orig_tar_gz]["size"] = os.stat(orig_tar_gz)[stat.ST_SIZE]
761 files[orig_tar_gz]["md5sum"] = dsc_files[orig_tar_gz]["md5sum"]
762 files[orig_tar_gz]["section"] = files[dsc_filename]["section"]
763 files[orig_tar_gz]["priority"] = files[dsc_filename]["priority"]
764 files[orig_tar_gz]["component"] = files[dsc_filename]["component"]
765 files[orig_tar_gz]["type"] = "orig.tar.gz"
770 ################################################################################
772 def get_changelog_versions(source_dir):
773 """Extracts a the source package and (optionally) grabs the
774 version history out of debian/changelog for the BTS."""
776 # Find the .dsc (again)
778 for file in files.keys():
779 if files[file]["type"] == "dsc":
782 # If there isn't one, we have nothing to do. (We have reject()ed the upload already)
786 # Create a symlink mirror of the source files in our temporary directory
787 for f in files.keys():
788 m = daklib.utils.re_issource.match(f)
790 src = os.path.join(source_dir, f)
791 # If a file is missing for whatever reason, give up.
792 if not os.path.exists(src):
795 if type == "orig.tar.gz" and pkg.orig_tar_gz:
797 dest = os.path.join(os.getcwd(), f)
798 os.symlink(src, dest)
800 # If the orig.tar.gz is not a part of the upload, create a symlink to the
803 dest = os.path.join(os.getcwd(), os.path.basename(pkg.orig_tar_gz))
804 os.symlink(pkg.orig_tar_gz, dest)
807 cmd = "dpkg-source -sn -x %s" % (dsc_filename)
808 (result, output) = commands.getstatusoutput(cmd)
810 reject("'dpkg-source -x' failed for %s [return code: %s]." % (dsc_filename, result))
811 reject(daklib.utils.prefix_multi_line_string(output, " [dpkg-source output:] "), "")
814 if not Cnf.Find("Dir::Queue::BTSVersionTrack"):
817 # Get the upstream version
818 upstr_version = daklib.utils.re_no_epoch.sub('', dsc["version"])
819 if re_strip_revision.search(upstr_version):
820 upstr_version = re_strip_revision.sub('', upstr_version)
822 # Ensure the changelog file exists
823 changelog_filename = "%s-%s/debian/changelog" % (dsc["source"], upstr_version)
824 if not os.path.exists(changelog_filename):
825 reject("%s: debian/changelog not found in extracted source." % (dsc_filename))
828 # Parse the changelog
829 dsc["bts changelog"] = ""
830 changelog_file = daklib.utils.open_file(changelog_filename)
831 for line in changelog_file.readlines():
832 m = re_changelog_versions.match(line)
834 dsc["bts changelog"] += line
835 changelog_file.close()
837 # Check we found at least one revision in the changelog
838 if not dsc["bts changelog"]:
839 reject("%s: changelog format not recognised (empty version tree)." % (dsc_filename))
841 ########################################
845 # a) there's no source
846 # or b) reprocess is 2 - we will do this check next time when orig.tar.gz is in 'files'
847 # or c) the orig.tar.gz is MIA
848 if not changes["architecture"].has_key("source") or reprocess == 2 \
849 or pkg.orig_tar_gz == -1:
852 # Create a temporary directory to extract the source into
853 if Options["No-Action"]:
854 tmpdir = tempfile.mktemp()
856 # We're in queue/holding and can create a random directory.
857 tmpdir = "%s" % (os.getpid())
860 # Move into the temporary directory
864 # Get the changelog version history
865 get_changelog_versions(cwd)
867 # Move back and cleanup the temporary tree
870 shutil.rmtree(tmpdir)
872 if errno.errorcode[e.errno] != 'EACCES':
873 daklib.utils.fubar("%s: couldn't remove tmp dir for source tree." % (dsc["source"]))
875 reject("%s: source tree could not be cleanly removed." % (dsc["source"]))
876 # We probably have u-r or u-w directories so chmod everything
878 cmd = "chmod -R u+rwx %s" % (tmpdir)
879 result = os.system(cmd)
881 daklib.utils.fubar("'%s' failed with result %s." % (cmd, result))
882 shutil.rmtree(tmpdir)
884 daklib.utils.fubar("%s: couldn't remove tmp dir for source tree." % (dsc["source"]))
886 ################################################################################
888 # FIXME: should be a debian specific check called from a hook
890 def check_urgency ():
891 if changes["architecture"].has_key("source"):
892 if not changes.has_key("urgency"):
893 changes["urgency"] = Cnf["Urgency::Default"]
894 if changes["urgency"] not in Cnf.ValueList("Urgency::Valid"):
895 reject("%s is not a valid urgency; it will be treated as %s by testing." % (changes["urgency"], Cnf["Urgency::Default"]), "Warning: ")
896 changes["urgency"] = Cnf["Urgency::Default"]
897 changes["urgency"] = changes["urgency"].lower()
899 ################################################################################
901 def check_md5sums ():
902 for file in files.keys():
904 file_handle = daklib.utils.open_file(file)
905 except daklib.utils.cant_open_exc:
909 if apt_pkg.md5sum(file_handle) != files[file]["md5sum"]:
910 reject("%s: md5sum check failed." % (file))
913 actual_size = os.stat(file)[stat.ST_SIZE]
914 size = int(files[file]["size"])
915 if size != actual_size:
916 reject("%s: actual file size (%s) does not match size (%s) in .changes"
917 % (file, actual_size, size))
919 for file in dsc_files.keys():
921 file_handle = daklib.utils.open_file(file)
922 except daklib.utils.cant_open_exc:
926 if apt_pkg.md5sum(file_handle) != dsc_files[file]["md5sum"]:
927 reject("%s: md5sum check failed." % (file))
930 actual_size = os.stat(file)[stat.ST_SIZE]
931 size = int(dsc_files[file]["size"])
932 if size != actual_size:
933 reject("%s: actual file size (%s) does not match size (%s) in .dsc"
934 % (file, actual_size, size))
936 ################################################################################
938 # Sanity check the time stamps of files inside debs.
939 # [Files in the near future cause ugly warnings and extreme time
940 # travel can cause errors on extraction]
942 def check_timestamps():
944 def __init__(self, future_cutoff, past_cutoff):
946 self.future_cutoff = future_cutoff
947 self.past_cutoff = past_cutoff
950 self.future_files = {}
951 self.ancient_files = {}
953 def callback(self, Kind,Name,Link,Mode,UID,GID,Size,MTime,Major,Minor):
954 if MTime > self.future_cutoff:
955 self.future_files[Name] = MTime
956 if MTime < self.past_cutoff:
957 self.ancient_files[Name] = MTime
960 future_cutoff = time.time() + int(Cnf["Dinstall::FutureTimeTravelGrace"])
961 past_cutoff = time.mktime(time.strptime(Cnf["Dinstall::PastCutoffYear"],"%Y"))
962 tar = Tar(future_cutoff, past_cutoff)
963 for filename in files.keys():
964 if files[filename]["type"] == "deb":
967 deb_file = daklib.utils.open_file(filename)
968 apt_inst.debExtract(deb_file,tar.callback,"control.tar.gz")
971 apt_inst.debExtract(deb_file,tar.callback,"data.tar.gz")
972 except SystemError, e:
973 # If we can't find a data.tar.gz, look for data.tar.bz2 instead.
974 if not re.match(r"Cannot f[ui]nd chunk data.tar.gz$", str(e)):
977 apt_inst.debExtract(deb_file,tar.callback,"data.tar.bz2")
980 future_files = tar.future_files.keys()
982 num_future_files = len(future_files)
983 future_file = future_files[0]
984 future_date = tar.future_files[future_file]
985 reject("%s: has %s file(s) with a time stamp too far into the future (e.g. %s [%s])."
986 % (filename, num_future_files, future_file,
987 time.ctime(future_date)))
989 ancient_files = tar.ancient_files.keys()
991 num_ancient_files = len(ancient_files)
992 ancient_file = ancient_files[0]
993 ancient_date = tar.ancient_files[ancient_file]
994 reject("%s: has %s file(s) with a time stamp too ancient (e.g. %s [%s])."
995 % (filename, num_ancient_files, ancient_file,
996 time.ctime(ancient_date)))
998 reject("%s: deb contents timestamp check failed [%s: %s]" % (filename, sys.exc_type, sys.exc_value))
1000 ################################################################################
1001 ################################################################################
1003 # If any file of an upload has a recent mtime then chances are good
1004 # the file is still being uploaded.
1006 def upload_too_new():
1008 # Move back to the original directory to get accurate time stamps
1010 os.chdir(pkg.directory)
1011 file_list = pkg.files.keys()
1012 file_list.extend(pkg.dsc_files.keys())
1013 file_list.append(pkg.changes_file)
1014 for file in file_list:
1016 last_modified = time.time()-os.path.getmtime(file)
1017 if last_modified < int(Cnf["Dinstall::SkipTime"]):
1025 ################################################################################
1028 # changes["distribution"] may not exist in corner cases
1029 # (e.g. unreadable changes files)
1030 if not changes.has_key("distribution") or not isinstance(changes["distribution"], DictType):
1031 changes["distribution"] = {}
1033 (summary, short_summary) = Upload.build_summaries()
1035 # q-unapproved hax0ring
1037 "New": { "is": is_new, "process": acknowledge_new },
1038 "Byhand" : { "is": is_byhand, "process": do_byhand },
1039 "Unembargo" : { "is": is_unembargo, "process": queue_unembargo },
1040 "Embargo" : { "is": is_embargo, "process": queue_embargo },
1042 queues = [ "New", "Byhand" ]
1043 if Cnf.FindB("Dinstall::SecurityQueueHandling"):
1044 queues += [ "Unembargo", "Embargo" ]
1046 (prompt, answer) = ("", "XXX")
1047 if Options["No-Action"] or Options["Automatic"]:
1052 if reject_message.find("Rejected") != -1:
1053 if upload_too_new():
1054 print "SKIP (too new)\n" + reject_message,
1055 prompt = "[S]kip, Quit ?"
1057 print "REJECT\n" + reject_message,
1058 prompt = "[R]eject, Skip, Quit ?"
1059 if Options["Automatic"]:
1064 if queue_info[q]["is"]():
1068 print "%s for %s\n%s%s" % (
1069 queue.upper(), ", ".join(changes["distribution"].keys()),
1070 reject_message, summary),
1071 queuekey = queue[0].upper()
1072 if queuekey in "RQSA":
1074 prompt = "[D]ivert, Skip, Quit ?"
1076 prompt = "[%s]%s, Skip, Quit ?" % (queuekey, queue[1:].lower())
1077 if Options["Automatic"]:
1080 print "ACCEPT\n" + reject_message + summary,
1081 prompt = "[A]ccept, Skip, Quit ?"
1082 if Options["Automatic"]:
1085 while prompt.find(answer) == -1:
1086 answer = daklib.utils.our_raw_input(prompt)
1087 m = daklib.queue.re_default_answer.match(prompt)
1090 answer = answer[:1].upper()
1093 os.chdir (pkg.directory)
1094 Upload.do_reject(0, reject_message)
1096 accept(summary, short_summary)
1097 remove_from_unchecked()
1098 elif answer == queuekey:
1099 queue_info[queue]["process"](summary)
1100 remove_from_unchecked()
1104 def remove_from_unchecked():
1105 os.chdir (pkg.directory)
1106 for file in files.keys():
1108 os.unlink(pkg.changes_file)
1110 ################################################################################
1112 def accept (summary, short_summary):
1113 Upload.accept(summary, short_summary)
1114 Upload.check_override()
1116 ################################################################################
1118 def move_to_dir (dest, perms=0660, changesperms=0664):
1119 daklib.utils.move (pkg.changes_file, dest, perms=changesperms)
1120 file_keys = files.keys()
1121 for file in file_keys:
1122 daklib.utils.move (file, dest, perms=perms)
1124 ################################################################################
1126 def is_unembargo ():
1127 q = Upload.projectB.query(
1128 "SELECT package FROM disembargo WHERE package = '%s' AND version = '%s'" %
1129 (changes["source"], changes["version"]))
1134 if pkg.directory == Cnf["Dir::Queue::Disembargo"].rstrip("/"):
1135 if changes["architecture"].has_key("source"):
1136 if Options["No-Action"]: return 1
1138 Upload.projectB.query(
1139 "INSERT INTO disembargo (package, version) VALUES ('%s', '%s')" %
1140 (changes["source"], changes["version"]))
1145 def queue_unembargo (summary):
1146 print "Moving to UNEMBARGOED holding area."
1147 Logger.log(["Moving to unembargoed", pkg.changes_file])
1149 Upload.dump_vars(Cnf["Dir::Queue::Unembargoed"])
1150 move_to_dir(Cnf["Dir::Queue::Unembargoed"])
1151 Upload.queue_build("unembargoed", Cnf["Dir::Queue::Unembargoed"])
1153 # Check for override disparities
1154 Upload.Subst["__SUMMARY__"] = summary
1155 Upload.check_override()
1157 ################################################################################
1162 def queue_embargo (summary):
1163 print "Moving to EMBARGOED holding area."
1164 Logger.log(["Moving to embargoed", pkg.changes_file])
1166 Upload.dump_vars(Cnf["Dir::Queue::Embargoed"])
1167 move_to_dir(Cnf["Dir::Queue::Embargoed"])
1168 Upload.queue_build("embargoed", Cnf["Dir::Queue::Embargoed"])
1170 # Check for override disparities
1171 Upload.Subst["__SUMMARY__"] = summary
1172 Upload.check_override()
1174 ################################################################################
1177 for file in files.keys():
1178 if files[file].has_key("byhand"):
1182 def do_byhand (summary):
1183 print "Moving to BYHAND holding area."
1184 Logger.log(["Moving to byhand", pkg.changes_file])
1186 Upload.dump_vars(Cnf["Dir::Queue::Byhand"])
1187 move_to_dir(Cnf["Dir::Queue::Byhand"])
1189 # Check for override disparities
1190 Upload.Subst["__SUMMARY__"] = summary
1191 Upload.check_override()
1193 ################################################################################
1196 for file in files.keys():
1197 if files[file].has_key("new"):
1201 def acknowledge_new (summary):
1202 Subst = Upload.Subst
1204 print "Moving to NEW holding area."
1205 Logger.log(["Moving to new", pkg.changes_file])
1207 Upload.dump_vars(Cnf["Dir::Queue::New"])
1208 move_to_dir(Cnf["Dir::Queue::New"])
1210 if not Options["No-Mail"]:
1211 print "Sending new ack."
1212 Subst["__SUMMARY__"] = summary
1213 new_ack_message = daklib.utils.TemplateSubst(Subst,Cnf["Dir::Templates"]+"/process-unchecked.new")
1214 daklib.utils.send_mail(new_ack_message)
1216 ################################################################################
1218 # reprocess is necessary for the case of foo_1.2-1 and foo_1.2-2 in
1219 # Incoming. -1 will reference the .orig.tar.gz, but -2 will not.
1220 # Upload.check_dsc_against_db() can find the .orig.tar.gz but it will
1221 # not have processed it during it's checks of -2. If -1 has been
1222 # deleted or otherwise not checked by 'dak process-unchecked', the
1223 # .orig.tar.gz will not have been checked at all. To get round this,
1224 # we force the .orig.tar.gz into the .changes structure and reprocess
1225 # the .changes file.
1227 def process_it (changes_file):
1228 global reprocess, reject_message
1230 # Reset some globals
1233 # Some defaults in case we can't fully process the .changes file
1234 changes["maintainer2047"] = Cnf["Dinstall::MyEmailAddress"]
1235 changes["changedby2047"] = Cnf["Dinstall::MyEmailAddress"]
1238 # Absolutize the filename to avoid the requirement of being in the
1239 # same directory as the .changes file.
1240 pkg.changes_file = os.path.abspath(changes_file)
1242 # Remember where we are so we can come back after cd-ing into the
1243 # holding directory.
1244 pkg.directory = os.getcwd()
1247 # If this is the Real Thing(tm), copy things into a private
1248 # holding directory first to avoid replacable file races.
1249 if not Options["No-Action"]:
1250 os.chdir(Cnf["Dir::Queue::Holding"])
1251 copy_to_holding(pkg.changes_file)
1252 # Relativize the filename so we use the copy in holding
1253 # rather than the original...
1254 pkg.changes_file = os.path.basename(pkg.changes_file)
1255 changes["fingerprint"] = daklib.utils.check_signature(pkg.changes_file, reject)
1256 if changes["fingerprint"]:
1257 valid_changes_p = check_changes()
1262 check_distributions()
1264 valid_dsc_p = check_dsc()
1270 Upload.update_subst(reject_message)
1276 traceback.print_exc(file=sys.stderr)
1279 # Restore previous WD
1280 os.chdir(pkg.directory)
1282 ###############################################################################
1285 global Cnf, Options, Logger
1287 changes_files = init()
1289 # -n/--dry-run invalidates some other options which would involve things happening
1290 if Options["No-Action"]:
1291 Options["Automatic"] = ""
1293 # Ensure all the arguments we were given are .changes files
1294 for file in changes_files:
1295 if not file.endswith(".changes"):
1296 daklib.utils.warn("Ignoring '%s' because it's not a .changes file." % (file))
1297 changes_files.remove(file)
1299 if changes_files == []:
1300 daklib.utils.fubar("Need at least one .changes file as an argument.")
1302 # Check that we aren't going to clash with the daily cron job
1304 if not Options["No-Action"] and os.path.exists("%s/daily.lock" % (Cnf["Dir::Lock"])) and not Options["No-Lock"]:
1305 daklib.utils.fubar("Archive maintenance in progress. Try again later.")
1307 # Obtain lock if not in no-action mode and initialize the log
1309 if not Options["No-Action"]:
1310 lock_fd = os.open(Cnf["Dinstall::LockFile"], os.O_RDWR | os.O_CREAT)
1312 fcntl.lockf(lock_fd, fcntl.LOCK_EX | fcntl.LOCK_NB)
1314 if errno.errorcode[e.errno] == 'EACCES' or errno.errorcode[e.errno] == 'EAGAIN':
1315 daklib.utils.fubar("Couldn't obtain lock; assuming another 'dak process-unchecked' is already running.")
1318 Logger = Upload.Logger = daklib.logging.Logger(Cnf, "process-unchecked")
1320 # debian-{devel-,}-changes@lists.debian.org toggles writes access based on this header
1321 bcc = "X-DAK: dak process-unchecked\nX-Katie: this header is obsolete"
1322 if Cnf.has_key("Dinstall::Bcc"):
1323 Upload.Subst["__BCC__"] = bcc + "\nBcc: %s" % (Cnf["Dinstall::Bcc"])
1325 Upload.Subst["__BCC__"] = bcc
1328 # Sort the .changes files so that we process sourceful ones first
1329 changes_files.sort(daklib.utils.changes_compare)
1331 # Process the changes files
1332 for changes_file in changes_files:
1333 print "\n" + changes_file
1335 process_it (changes_file)
1337 if not Options["No-Action"]:
1340 accept_count = Upload.accept_count
1341 accept_bytes = Upload.accept_bytes
1344 if accept_count > 1:
1346 print "Accepted %d package %s, %s." % (accept_count, sets, daklib.utils.size_type(int(accept_bytes)))
1347 Logger.log(["total",accept_count,accept_bytes])
1349 if not Options["No-Action"]:
1352 ################################################################################
1354 if __name__ == '__main__':