odhcp6c.git
5 years agoFix building with clang 3.4
Steven Barth [Tue, 18 Mar 2014 13:39:22 +0000 (14:39 +0100)]
Fix building with clang 3.4

5 years agoFix HMAC-MD5 verify in reconfigure
Steven Barth [Tue, 11 Mar 2014 08:18:32 +0000 (09:18 +0100)]
Fix HMAC-MD5 verify in reconfigure

5 years agofix integer overflow after 50 days (thx Hauke Mehrtens)
Steven Barth [Fri, 7 Mar 2014 09:33:49 +0000 (10:33 +0100)]
fix integer overflow after 50 days (thx Hauke Mehrtens)

5 years agora: don't set nd_ra_{reachable,retransmit} to 0
Steven Barth [Wed, 5 Mar 2014 08:11:24 +0000 (09:11 +0100)]
ra: don't set nd_ra_{reachable,retransmit} to 0

5 years agoSet default for min-update-interval to 30
Steven Barth [Wed, 5 Mar 2014 08:06:29 +0000 (09:06 +0100)]
Set default for min-update-interval to 30

5 years agoMerge pull request #18 from kaspar030/rebase
sbyx [Tue, 4 Mar 2014 17:21:04 +0000 (18:21 +0100)]
Merge pull request #18 from kaspar030/rebase

add option to specify minimum interval for accepting RA or DHCP updates.

5 years agoadd option to specify minimum interval for accepting RA or DHCP updates.
Kaspar Schleiser [Tue, 4 Mar 2014 15:29:02 +0000 (16:29 +0100)]
add option to specify minimum interval for accepting RA or DHCP updates.

This was fixed to 60s. Add '-m <seconds>' option to change default time.

5 years agoFix invalid use of open()
Steven Barth [Sat, 1 Mar 2014 12:31:33 +0000 (13:31 +0100)]
Fix invalid use of open()

5 years agoMake hex-string say base-16 encoded in help
Steven Barth [Wed, 19 Feb 2014 08:14:09 +0000 (09:14 +0100)]
Make hex-string say base-16 encoded in help

5 years agoReintroduce Reconfigure-Accept in Request-Message
Steven Barth [Mon, 17 Feb 2014 20:18:49 +0000 (21:18 +0100)]
Reintroduce Reconfigure-Accept in Request-Message

5 years agoMerge pull request #16 from kaspar030/use_enum_for_iov
sbyx [Wed, 12 Feb 2014 13:51:54 +0000 (14:51 +0100)]
Merge pull request #16 from kaspar030/use_enum_for_iov

use enum to specify order and indexes of iov struct in dhcp_send().

5 years agouse enum to specify order and indexes of iov struct.
Kaspar Schleiser [Wed, 12 Feb 2014 12:48:25 +0000 (13:48 +0100)]
use enum to specify order and indexes of iov struct.

This helps to avoid brainfuck index calculation errors when adding
features.

On my build machine (arch linux x86_64), the stripped binary has exactly
the same size, so this patch should produce the same binary, but
increase code maintainability.

5 years agoFix fallout from userclass addition
Steven Barth [Thu, 6 Feb 2014 10:08:51 +0000 (11:08 +0100)]
Fix fallout from userclass addition

5 years agoMerge pull request #15 from dedeckeh/bugfixes
sbyx [Thu, 6 Feb 2014 07:05:45 +0000 (08:05 +0100)]
Merge pull request #15 from dedeckeh/bugfixes

Bugfixes

5 years agoFix default sol max rt value in help text
Hans Dedecker [Wed, 5 Feb 2014 21:32:40 +0000 (22:32 +0100)]
Fix default sol max rt value in help text

5 years agoFix T1, T2 and T3 timer values in case of infinite time values
Hans Dedecker [Wed, 5 Feb 2014 21:28:50 +0000 (22:28 +0100)]
Fix T1, T2 and T3 timer values in case of infinite time values

Honor T1, T2 and T3 timer values from DHCPv6 server in case of infinite values

5 years agoAdd user-class option
Steven Barth [Wed, 5 Feb 2014 13:47:47 +0000 (14:47 +0100)]
Add user-class option

5 years agoRevert "RA: fix on-link/off-link handling"
Steven Barth [Mon, 3 Feb 2014 09:10:10 +0000 (10:10 +0100)]
Revert "RA: fix on-link/off-link handling"

New behavior breaks source-restrictions of on-link routes.

This reverts commit 9817e4983c7d4e28f53b78d4fc6ea1eabed8affe.

5 years agoRA: fix on-link/off-link handling
Steven Barth [Sun, 2 Feb 2014 17:40:50 +0000 (18:40 +0100)]
RA: fix on-link/off-link handling

5 years agoAdd example status script
Steven Barth [Wed, 29 Jan 2014 11:59:32 +0000 (12:59 +0100)]
Add example status script

5 years agoDon't export IAID as class if IAID is 1 (default)
Steven Barth [Wed, 29 Jan 2014 10:55:40 +0000 (11:55 +0100)]
Don't export IAID as class if IAID is 1 (default)

5 years agoBump copyright headers
Steven Barth [Wed, 29 Jan 2014 10:33:53 +0000 (11:33 +0100)]
Bump copyright headers

5 years agoMerge pull request #12 from kaspar030/pid_usage_filename_fix
sbyx [Wed, 29 Jan 2014 09:45:11 +0000 (01:45 -0800)]
Merge pull request #12 from kaspar030/pid_usage_filename_fix

fix pidfile default in help text

5 years agofix pidfile default in help text
Kaspar Schleiser [Wed, 29 Jan 2014 09:40:30 +0000 (10:40 +0100)]
fix pidfile default in help text

5 years agoFix stateless mode
Steven Barth [Tue, 28 Jan 2014 16:40:46 +0000 (17:40 +0100)]
Fix stateless mode

5 years agooutput prefix IAID as prefix class in script
Kaspar Schleiser [Fri, 24 Jan 2014 13:15:12 +0000 (14:15 +0100)]
output prefix IAID as prefix class in script

Contributed by T-Labs, Deutsche Telekom Innovation Laboratories

5 years agoadd support Vendor Class option
Kaspar Schleiser [Mon, 27 Jan 2014 12:43:38 +0000 (13:43 +0100)]
add support Vendor Class option

This patch adds cli option "-V <hex-string>" which will enable sending
of DHCPv6 option 16 ("vendor class").

Based on Patch by Christian Carstensen

Contributed by T-Labs, Deutsche Telekom Innovation Laboratories

5 years agoallow disabling "client fqdn" and "accept reconfiguration" options
Kaspar Schleiser [Thu, 23 Jan 2014 16:05:18 +0000 (17:05 +0100)]
allow disabling "client fqdn" and "accept reconfiguration" options

Some DHCPv6 servers require these to be absent, so add
command line switches that allow disabling them.

(includes "Combination of command line switches -f and -a
 broke "-N none" and IA_PD." from Christian Carstensen)

Contributed by T-Labs, Deutsche Telekom Innovation Laboratories

5 years agoadd support for multiple prefixes with distinct IAIDs
Kaspar Schleiser [Thu, 23 Jan 2014 15:39:43 +0000 (16:39 +0100)]
add support for multiple prefixes with distinct IAIDs

Changes from v1:
- removed some unneeded changes
- use *_add_state instead of (semantically identical and so unnecessary)
  *_append_state

This is missing IAID validation for prefixes.

Contributed by T-Labs, Deutsche Telekom Innovation Laboratories

5 years agoadded command line switch for strict oro
Kaspar Schleiser [Thu, 9 Jan 2014 14:58:31 +0000 (15:58 +0100)]
added command line switch for strict oro

Now "-R" command line switch makes odhcpv6c only request those options
specified by "-r".

Contributed by T-Labs, Deutsche Telekom Innovation Laboratories

5 years agofix NTP server option handling
Kaspar Schleiser [Tue, 7 Jan 2014 12:58:38 +0000 (13:58 +0100)]
fix NTP server option handling

previously, only option 56 (NTP server) was supported, but named SNTP_*
throughout code and in the scripts environment. This patch fixes this and adds
optnion 31 (SNTP Servers) support. Uses NTP_IP and NTP_FQDN and SNTP_IP in
script environment.

Contributed by T-Labs, Deutsche Telekom Innovation Laboratories

5 years agoMerge pull request #11 from NeoRaider/fixes
sbyx [Sat, 11 Jan 2014 10:36:49 +0000 (02:36 -0800)]
Merge pull request #11 from NeoRaider/fixes

A few fixes for race conditions and similar problems

5 years agoFix race conditions in signal handling
Matthias Schiffer [Fri, 10 Jan 2014 18:58:14 +0000 (19:58 +0100)]
Fix race conditions in signal handling

Avoid several race conditions by using distinct variables for the different
signals. In particular different signals received in quick succession don't
overwrite each other any more, and odhcp6c_signal_process doesn't return true
anymore when a new SIGIO is received while another is still being processed.

5 years agoUse getifaddrs to get the interface-id when not specified
Matthias Schiffer [Fri, 10 Jan 2014 16:38:39 +0000 (17:38 +0100)]
Use getifaddrs to get the interface-id when not specified

Reimplementing this section also fixes two potential bugs:

1. Only link-local addresses should be used for automatic interface-id
   selection, as it should always be assigned by the kernel and is always based
   on the EUI-64 unless an administrator is doing strange things (while other
   addresses might be chosen according to the privacy extensions or by an
   administrator)
2. When no address is available (because of a race condition or because an
   administrator removed it), RA packets should just be ignored; otherwise
   an address with a zero interface-id might be assigned

5 years agoWhitespace fixes
Matthias Schiffer [Fri, 10 Jan 2014 12:10:37 +0000 (13:10 +0100)]
Whitespace fixes

Mostly trailing spaces or whitespace in empty lines.

5 years agoSwitch to a leaner MD5 library
Steven Barth [Sun, 5 Jan 2014 17:38:15 +0000 (18:38 +0100)]
Switch to a leaner MD5 library

5 years agoRevert to old behaviour regarding information requests
Steven Barth [Mon, 30 Dec 2013 18:10:18 +0000 (19:10 +0100)]
Revert to old behaviour regarding information requests

5 years agoRevert "Server unicast option support"
Steven Barth [Mon, 30 Dec 2013 17:45:45 +0000 (18:45 +0100)]
Revert "Server unicast option support"

This reverts commit 348cbc2efee1281c3b39e705114f44eca72a8247.

Avoid too much bloat for rarely useful functionality

5 years agoFix compilation and cleanup
Steven Barth [Mon, 30 Dec 2013 17:33:25 +0000 (18:33 +0100)]
Fix compilation and cleanup

5 years agoMerge pull request #9 from dedeckeh/master
sbyx [Mon, 30 Dec 2013 17:15:54 +0000 (09:15 -0800)]
Merge pull request #9 from dedeckeh/master

5 years agoSupport for SOL_MAX_RT and INF_MAX_RT options (RFC7083)
Hans Dedecker [Mon, 30 Dec 2013 13:58:10 +0000 (14:58 +0100)]
Support for SOL_MAX_RT and INF_MAX_RT options (RFC7083)

5 years agoDrop DHCPv6 messages containing invalid option length
Hans Dedecker [Fri, 27 Dec 2013 14:55:24 +0000 (15:55 +0100)]
Drop DHCPv6 messages containing invalid option length

5 years agoRevert "Fix handling of DHCPv6 messages containing option lengths exceeding the message"
Hans Dedecker [Fri, 27 Dec 2013 14:49:44 +0000 (15:49 +0100)]
Revert "Fix handling of DHCPv6 messages containing option lengths exceeding the message"

This reverts commit 26c5d8724355b29694af684ee29b47e52129a33c.

5 years agoAdd ICMPv6 validity check
Hans Dedecker [Tue, 24 Dec 2013 16:22:05 +0000 (17:22 +0100)]
Add ICMPv6 validity check

5 years agoRevert "Fix parsing of Router Advertisement messsages"
Hans Dedecker [Tue, 24 Dec 2013 15:37:04 +0000 (16:37 +0100)]
Revert "Fix parsing of Router Advertisement messsages"

This reverts commit de89d2888d38d1ca6676070584ea6ff9c7dd6f23.

5 years agoParse Router Advertisement Hop Limit parameter
Hans Dedecker [Thu, 19 Dec 2013 15:40:39 +0000 (16:40 +0100)]
Parse Router Advertisement Hop Limit parameter

5 years agoFix parsing of Router Advertisement messsages
Hans Dedecker [Thu, 12 Dec 2013 16:07:34 +0000 (17:07 +0100)]
Fix parsing of Router Advertisement messsages

Router Advertisement message checks according to RFC4861 paragraph 6.1.2
Fix and further improve router advertisement option parsing

5 years agoFix handling of DHCPv6 messages containing option lengths exceeding the message
Hans Dedecker [Thu, 12 Dec 2013 16:05:25 +0000 (17:05 +0100)]
Fix handling of DHCPv6 messages containing option lengths exceeding the message

5 years agoFix server candidate selection logic
Hans Dedecker [Thu, 12 Dec 2013 16:02:58 +0000 (17:02 +0100)]
Fix server candidate selection logic

Flush all server candidates for unbound client in stateless mode
Fix initial server candidate promotion condition

5 years agoFine tune server candidate selection logic
Hans Dedecker [Sun, 1 Dec 2013 17:57:06 +0000 (18:57 +0100)]
Fine tune server candidate selection logic

DHCPv6 server info from ADVERTISE messages is inserted in the server
candidate list sorted according to the preference value (highest values
first in the list).
Server candidate list can only contain one entry from a given server.
Server with highest preference value is selected; in case the server
does not respond the next server is selected from the list.
When the server candidate list is empty and no servers responded;
the client restarts the DHCPv6 server discovery process

5 years agoBasic error checking when initializing ra
Hans Dedecker [Sun, 1 Dec 2013 17:55:11 +0000 (18:55 +0100)]
Basic error checking when initializing ra

5 years agoFix receive rounds end condition
Hans Dedecker [Sun, 1 Dec 2013 17:49:36 +0000 (18:49 +0100)]
Fix receive rounds end condition

5 years agoRemove setsockopt error checking
Hans Dedecker [Sun, 1 Dec 2013 17:47:19 +0000 (18:47 +0100)]
Remove setsockopt error checking

5 years agoServer unicast option support
Hans Dedecker [Wed, 13 Nov 2013 15:04:42 +0000 (16:04 +0100)]
Server unicast option support

5 years agoImproved message validation checks and socket error hardening
Hans Dedecker [Wed, 13 Nov 2013 15:03:34 +0000 (16:03 +0100)]
Improved message validation checks and socket error hardening

5 years agoFinalizing bfd work
Steven Barth [Mon, 11 Nov 2013 14:34:05 +0000 (15:34 +0100)]
Finalizing bfd work

5 years agoFix bfd ping
Steven Barth [Wed, 6 Nov 2013 12:04:53 +0000 (13:04 +0100)]
Fix bfd ping

5 years agoAdd experimental and unfinished bfd ping work
Steven Barth [Tue, 5 Nov 2013 07:56:29 +0000 (08:56 +0100)]
Add experimental and unfinished bfd ping work

5 years agoReact to carrier down events as well
Steven Barth [Wed, 30 Oct 2013 13:13:50 +0000 (14:13 +0100)]
React to carrier down events as well

5 years agoFix compilation on 32-bit platforms
Steven Barth [Wed, 30 Oct 2013 12:43:15 +0000 (13:43 +0100)]
Fix compilation on 32-bit platforms

5 years agoDetect "carrier up"-events and restart transaction
Steven Barth [Wed, 30 Oct 2013 12:37:05 +0000 (13:37 +0100)]
Detect "carrier up"-events and restart transaction

5 years agoMake -F and -P arguments position independent
Steven Barth [Tue, 29 Oct 2013 14:19:42 +0000 (15:19 +0100)]
Make -F and -P arguments position independent

5 years agoBe less verbose when sending solicits
Steven Barth [Tue, 29 Oct 2013 14:00:08 +0000 (15:00 +0100)]
Be less verbose when sending solicits

5 years agoFix RA spam filter logic
Steven Barth [Tue, 29 Oct 2013 13:52:16 +0000 (14:52 +0100)]
Fix RA spam filter logic

5 years agoFix compilation on 64-bit platforms
Steven Barth [Wed, 23 Oct 2013 17:28:52 +0000 (19:28 +0200)]
Fix compilation on 64-bit platforms

5 years agoodhpc6c: status code support in reply
Hans Dedecker [Wed, 23 Oct 2013 12:04:38 +0000 (12:04 +0000)]
odhpc6c: status code support in reply

The patch implements support for status code handling in
reply messages as described in RFC3313 paragraph 18.1.8.
The client will
*log the status codes returned by the client
*send a request if no binding status code is returned for
a given IA
*send further renew/rebind if the IA was not present in
the reply
*terminate message exchange when no prefix/no address
status code is returned in reponse to a request
*terminate message exchange when unspec fail status code
is returned
*calculate t1/t2/t3 when all IA's have been processed and
based on recorded t1/t2/valid timer values per IA

Without this patch I have seen issues with request messages
send without any IA_PD/IA_NA and t1/t2/t3 timer values which
were not correct. These changes have been tested intensive
against an ISC DHCPv6 server

Signed-off-by: Hans Dedecker <hans.dedecker@gmail.com>
5 years agoodhcp6c: preference and status code support in advertise
Hans Dedecker [Wed, 23 Oct 2013 12:04:27 +0000 (12:04 +0000)]
odhcp6c: preference and status code support in advertise

The patch implements handling of advertise messages
as described in RFC3315 paragraph 17.1.2. Client will
stop collecting advertise messages if preference option
is equal to 255 or if the first RT has elapsed. Status
codes are handled in the advertise message depending on
the startup parameters

Signed-off-by: Hans Dedecker <hans.dedecker@gmail.com>
5 years agoodhcp6c: message retransmission count support
Hans Dedecker [Wed, 23 Oct 2013 12:04:01 +0000 (12:04 +0000)]
odhcp6c: message retransmission count support

The patch implements message retransmission count (MRC) support as
described in RFC3315 paragraphs 5.5 and 14 for DHCPv6 request/release/
decline messages. Patch also disables multicast packets loopback.

Signed-off-by: Hans Dedecker <hans.dedecker@gmail.com>
5 years agoAvoid updating too often if ISP spams RAs
Steven Barth [Wed, 23 Oct 2013 08:13:00 +0000 (10:13 +0200)]
Avoid updating too often if ISP spams RAs

5 years agoFix handling of PD-Advertisements
Steven Barth [Thu, 17 Oct 2013 07:19:01 +0000 (09:19 +0200)]
Fix handling of PD-Advertisements

5 years agoMake SOL_MAX_RT configurable and default to 120
Steven Barth [Mon, 14 Oct 2013 13:29:39 +0000 (15:29 +0200)]
Make SOL_MAX_RT configurable and default to 120

5 years agoPrefer servers with bigger prefixes
Steven Barth [Mon, 14 Oct 2013 12:14:15 +0000 (14:14 +0200)]
Prefer servers with bigger prefixes

5 years agoDon't hang indefinitely if REQUEST is never answered
Steven Barth [Fri, 11 Oct 2013 07:33:00 +0000 (09:33 +0200)]
Don't hang indefinitely if REQUEST is never answered

5 years agoodhcp6c: improve server selection
Steven Barth [Mon, 7 Oct 2013 08:21:34 +0000 (10:21 +0200)]
odhcp6c: improve server selection

5 years agoCheck for local addr more often
Steven Barth [Fri, 4 Oct 2013 06:26:38 +0000 (08:26 +0200)]
Check for local addr more often

5 years agora: validate hop-limit
Steven Barth [Wed, 2 Oct 2013 14:10:43 +0000 (16:10 +0200)]
ra: validate hop-limit

6 years agoHandle NoAddrsAvail IA-status
Steven Barth [Sat, 21 Sep 2013 10:49:05 +0000 (12:49 +0200)]
Handle NoAddrsAvail IA-status

6 years agoRestart transaction if server returns IAID error code
Steven Barth [Wed, 18 Sep 2013 10:25:20 +0000 (12:25 +0200)]
Restart transaction if server returns IAID error code

6 years agoAdd default T1, T2, T3 for buggy servers
Steven Barth [Thu, 12 Sep 2013 12:48:57 +0000 (14:48 +0200)]
Add default T1, T2, T3 for buggy servers

6 years agoMerge preliminary prefix class support
Steven Barth [Sat, 31 Aug 2013 08:48:56 +0000 (10:48 +0200)]
Merge preliminary prefix class support

6 years agoMerge branch 'hnet'
Steven Barth [Sat, 31 Aug 2013 08:11:15 +0000 (10:11 +0200)]
Merge branch 'hnet'

Conflicts:
src/ra.c

6 years agoUpdate README
Steven Barth [Fri, 30 Aug 2013 14:57:23 +0000 (16:57 +0200)]
Update README

6 years agoRemove DAD for now due to kernel issues
Steven Barth [Fri, 30 Aug 2013 15:41:55 +0000 (17:41 +0200)]
Remove DAD for now due to kernel issues

6 years agoMerge remote-tracking branch 'up/master' into hnet
Markus Stenberg [Thu, 1 Aug 2013 09:05:56 +0000 (11:05 +0200)]
Merge remote-tracking branch 'up/master' into hnet

6 years agoFix including PD in request
Steven Barth [Thu, 1 Aug 2013 07:28:27 +0000 (09:28 +0200)]
Fix including PD in request

6 years agoMerge remote-tracking branch 'up/master' into hnet
Markus Stenberg [Wed, 31 Jul 2013 21:58:33 +0000 (23:58 +0200)]
Merge remote-tracking branch 'up/master' into hnet

6 years agoInclude IAs in Request to be more compatible with some servers
Steven Barth [Wed, 31 Jul 2013 17:05:55 +0000 (19:05 +0200)]
Include IAs in Request to be more compatible with some servers

6 years agoAdd support for colored address in IA_NA
Maico Le Pape [Tue, 30 Jul 2013 21:10:54 +0000 (23:10 +0200)]
Add support for colored address in IA_NA

Signed-off-by: Maico Le Pape <mlepape@cisco.com>
6 years agoAdd better overflow safety in resend
Steven Barth [Wed, 3 Jul 2013 17:15:36 +0000 (19:15 +0200)]
Add better overflow safety in resend

6 years agoMerge branch 'master' into hnet
Markus Stenberg [Mon, 24 Jun 2013 10:53:03 +0000 (13:53 +0300)]
Merge branch 'master' into hnet

Conflicts:
README
src/dhcpv6.c
src/odhcp6c.h

6 years agoAllow overriding the interface-identifier for public addresses
Steven Barth [Tue, 18 Jun 2013 12:44:43 +0000 (14:44 +0200)]
Allow overriding the interface-identifier for public addresses

6 years agoAdd sanity checks for NDP and MTU parameters from RAs
Steven Barth [Thu, 13 Jun 2013 06:36:31 +0000 (08:36 +0200)]
Add sanity checks for NDP and MTU parameters from RAs

6 years agoUpdate README
Steven Barth [Fri, 31 May 2013 14:05:00 +0000 (16:05 +0200)]
Update README

6 years agoWork around false-positive DAD-hits
Steven Barth [Fri, 31 May 2013 13:45:42 +0000 (15:45 +0200)]
Work around false-positive DAD-hits

6 years agoFix handling of multiple RAs in a row.
Steven Barth [Fri, 31 May 2013 09:27:48 +0000 (11:27 +0200)]
Fix handling of multiple RAs in a row.

The default route-entry was not correctly reinitialized.
Thanks to pmarks-net for the detailed bugreport.

6 years agoAdd more sanity checks and logging to DAD
Steven Barth [Tue, 28 May 2013 16:26:34 +0000 (18:26 +0200)]
Add more sanity checks and logging to DAD

6 years agoHonor T1 and T2 from server better
Steven Barth [Tue, 21 May 2013 10:10:37 +0000 (12:10 +0200)]
Honor T1 and T2 from server better

6 years agoFix reconfigure accept option transmission
Steven Barth [Tue, 21 May 2013 08:25:33 +0000 (10:25 +0200)]
Fix reconfigure accept option transmission

6 years agoFix IA expiring logic
Steven Barth [Mon, 20 May 2013 14:27:23 +0000 (16:27 +0200)]
Fix IA expiring logic

6 years agoscript: fix delay call handling
Steven Barth [Wed, 15 May 2013 11:06:29 +0000 (13:06 +0200)]
script: fix delay call handling