getport: RPC_PROGNOTREGISTERED is a permanent error
authorChuck Lever <chuck.lever@oracle.com>
Tue, 14 Jul 2009 20:21:01 +0000 (16:21 -0400)
committerSteve Dickson <steved@redhat.com>
Tue, 14 Jul 2009 20:21:01 +0000 (16:21 -0400)
rpcbind returns RPC_PROGNOTREGISTERED if it knows for certain that an
RPC program is not supported for a given transport.  This is a
permanent and authoritative error, so the library's rpcbind query API
should never retry the query -- it will only get the same answer.

A similar change was submitted for libtirpc.  Unlike rpcb_getaddr(3t),
mount.nfs's rpcbind client only retries once (with RPCB3PROC_GETADDR),
but an extra TCP socket in this case would leave another port in
TIME_WAIT.  It's infrequent enough, but might as well get rid of it.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
support/nfs/getport.c

index bc0f121..71f02f3 100644 (file)
@@ -469,7 +469,7 @@ static unsigned short nfs_gp_rpcb_getaddr(CLIENT *client,
                case RPC_SUCCESS:
                        if ((uaddr == NULL) || (uaddr[0] == '\0')) {
                                rpc_createerr.cf_stat = RPC_PROGNOTREGISTERED;
-                               continue;
+                               return 0;
                        }
 
                        port = nfs_universal2port(uaddr);