Stop segfaults on amd64 during warnings messages by creating

a second va_list in xlog_backend() and then use that va_list
to print messages on stderr.

Signed-off-by: Steinar H. Gunderson <sesse@debian.org>
Signed-off-by: Steve Langasek <vorlon@debian.org>
Signed-off-by: Steve Dickson <steved@dickson.boston.devel.redhat.com>

diff --git a/support/nfs/xlog.c b/support/nfs/xlog.c
index 26123c597a849a9cdd146923f0e3b74b757f1a3f..6820346494862775d8108bd5a49e19ed303ca0db 100644 (file)
--- a/support/nfs/xlog.c
+++ b/support/nfs/xlog.c
@@ -133,9 +133,14 @@ xlog_enabled(int fac)
 void
 xlog_backend(int kind, const char *fmt, va_list args)
 {
+       va_list args2;
+
        if (!(kind & (L_ALL)) && !(logging && (kind & logmask)))
                return;
 
+       if (log_stderr)
+               va_copy(args2, args);
+
        if (log_syslog) {
                switch (kind) {
                case L_FATAL:
@@ -171,9 +176,9 @@ xlog_backend(int kind, const char *fmt, va_list args)
 #else
                fprintf(stderr, "%s: ", log_name);
 #endif
-
-               vfprintf(stderr, fmt, args);
+               vfprintf(stderr, fmt, args2);
                fprintf(stderr, "\n");
+               va_end(args2);
        }
 
        if (kind == L_FATAL)