In recent Fedora builds, the '-D _FORTIFY_SOURCE=2' compile

[nfs-utils.git] / utils / statd / statd.c

diff --git a/utils/statd/statd.c b/utils/statd/statd.c
index 8337b64b993918fb8704daeb49cae711447779d3..1c5247ea2365aa0112ecda69956b95e04862d014 100644 (file)
--- a/utils/statd/statd.c
+++ b/utils/statd/statd.c
@@ -75,7 +75,6 @@ static struct option longopts[] =
 };
 
 extern void sm_prog_1 (struct svc_req *, register SVCXPRT *);
-extern int statd_get_socket(void);
 static void load_state_number(void);
 
 #ifdef SIMULATIONS
@@ -89,9 +88,11 @@ extern void simulator (int, char **);
 static void 
 sm_prog_1_wrapper (struct svc_req *rqstp, register SVCXPRT *transp)
 {
+       struct sockaddr_in *sin = nfs_getrpccaller_in(transp);
+
        /* remote host authorization check */
-       if (!check_default("statd", svc_getcaller(transp),
-                                rqstp->rq_proc, SM_PROG)) {
+       if (sin->sin_family == AF_INET &&
+           !check_default("statd", sin, rqstp->rq_proc, SM_PROG)) {
                svcerr_auth (transp, AUTH_FAILED);
                return;
        }
@@ -148,7 +149,7 @@ static void log_modes(void)
  * help the occasional admin. 
  */
 static void 
-usage()
+usage(void)
 {
        fprintf(stderr,"usage: %s [options]\n", name_p);
        fprintf(stderr,"      -h, -?, --help       Print this help screen.\n");
@@ -178,14 +179,20 @@ static void create_pidfile(void)
                    pidfile, strerror(errno));
        fprintf(fp, "%d\n", getpid());
        pidfd = dup(fileno(fp));
-       if (fclose(fp) < 0)
-               note(N_WARNING, "Flushing pid file failed.\n");
+       if (fclose(fp) < 0) {
+               note(N_WARNING, "Flushing pid file failed: errno %d (%s)\n",
+                       errno, strerror(errno));
+       }
 }
 
 static void truncate_pidfile(void)
 {
-       if (pidfd >= 0)
-               ftruncate(pidfd, 0);
+       if (pidfd >= 0) {
+               if (ftruncate(pidfd, 0) < 0) {
+                       note(N_WARNING, "truncating pid file failed: errno %d (%s)\n",
+                               errno, strerror(errno));
+               }
+       }
 }
 
 static void drop_privs(void)
@@ -206,9 +213,12 @@ static void drop_privs(void)
        /* better chown the pid file before dropping, as if it
         * if over nfs we might loose access
         */
-       if (pidfd >= 0)
-               fchown(pidfd, st.st_uid, st.st_gid);
-
+       if (pidfd >= 0) {
+               if (fchown(pidfd, st.st_uid, st.st_gid) < 0) {
+                       note(N_ERROR, "Unable to change owner of %s: %d (%s)",
+                                       SM_DIR, strerror (errno));
+               }
+       }
        setgroups(0, NULL);
        if (setgid(st.st_gid) == -1
            || setuid(st.st_uid) == -1) {
@@ -445,7 +455,7 @@ int main (int argc, char **argv)
 
        /* Child. */
 
-       log_init (name_p,version_p);
+       log_init (/*name_p,version_p*/);
 
        log_modes();
 
@@ -477,7 +487,8 @@ int main (int argc, char **argv)
                }
 
        /* Make sure we have a privilege port for calling into the kernel */
-       statd_get_socket();
+       if (statd_get_socket() < 0)
+               exit(1);
 
        /* If sm-notify didn't take all the state files, load
         * state information into our notify-list so we can
@@ -493,7 +504,10 @@ int main (int argc, char **argv)
        /* If we got this far, we have successfully started, so notify parent */
        if (pipefds[1] > 0) {
                status = 0;
-               write(pipefds[1], &status, 1);
+               if (write(pipefds[1], &status, 1) != 1) {
+                       note(N_WARNING, "writing to parent pipe failed: errno %d (%s)\n",
+                               errno, strerror(errno));
+               }
                close(pipefds[1]);
                pipefds[1] = -1;
        }
@@ -532,17 +546,23 @@ static void
 load_state_number(void)
 {
        int fd;
+       const char *file = "/proc/sys/fs/nfs/nsm_local_state";
 
        if ((fd = open(SM_STAT_PATH, O_RDONLY)) == -1)
                return;
 
-       read(fd, &MY_STATE, sizeof(MY_STATE));
+       if (read(fd, &MY_STATE, sizeof(MY_STATE)) != sizeof(MY_STATE)) {
+               note(N_WARNING, "Unable to read state from '%s': errno %d (%s)",
+                               SM_STAT_PATH, errno, strerror(errno));
+       }
        close(fd);
-       fd = open("/proc/sys/fs/nfs/nsm_local_state",O_WRONLY);
+       fd = open(file, O_WRONLY);
        if (fd >= 0) {
                char buf[20];
                snprintf(buf, sizeof(buf), "%d", MY_STATE);
-               write(fd, buf, strlen(buf));
+               if (write(fd, buf, strlen(buf)) != strlen(buf))
+                       note(N_WARNING, "Writing to '%s' failed: errno %d (%s)",
+                               file, errno, strerror(errno));
                close(fd);
        }