Fix various issues discovered by Coverity

[nfs-utils.git] / utils / statd / notlist.c

diff --git a/utils/statd/notlist.c b/utils/statd/notlist.c
index 4f52b1deccb3c41ab6e7550baf3324bebaeb26ad..98aa6e2fa3a2571871f148cef70e27e284076db7 100644 (file)
--- a/utils/statd/notlist.c
+++ b/utils/statd/notlist.c
@@ -61,8 +61,12 @@ nlist_new(char *my_name, char *mon_name, int state)
        NL_TIMES(new) = MAX_TRIES;
        NL_STATE(new) = state;
        if (!(NL_MY_NAME(new) = xstrdup(my_name))
        NL_TIMES(new) = MAX_TRIES;
        NL_STATE(new) = state;
        if (!(NL_MY_NAME(new) = xstrdup(my_name))

-                       || !(NL_MON_NAME(new) = xstrdup(mon_name)))
+           || !(NL_MON_NAME(new) = xstrdup(mon_name))) {
+               if (NL_MY_NAME(new))
+                       free(NL_MY_NAME(new));
+               free(new);

                return NULL;
                return NULL;

+       }

 
        return new;
 }
 
        return new;
 }