]> git.decadent.org.uk Git - nfs-utils.git/blobdiff - utils/statd/monitor.c
statd - remove a pointless if
[nfs-utils.git] / utils / statd / monitor.c
index 88b33db0ab478ac22a4bd33384a4cb204a244665..5fcab1d424247711070db3c2bbcc612b34a798d2 100644 (file)
@@ -7,7 +7,9 @@
  * NSM for Linux.
  */
 
-#include "config.h"
+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
 
 #include <fcntl.h>
 #include <limits.h>
@@ -15,7 +17,9 @@
 #include <string.h>
 #include <unistd.h>
 #include <sys/stat.h>
+#include <errno.h>
 #include <arpa/inet.h>
+#include <dirent.h>
 #include "misc.h"
 #include "statd.h"
 #include "notlist.h"
@@ -23,6 +27,7 @@
 
 notify_list *          rtnl = NULL;    /* Run-time notify list. */
 
+#define LINELEN (4*(8+1)+SM_PRIV_SIZE*2+1)
 
 /*
  * Services SM_MON requests.
@@ -39,7 +44,7 @@ sm_mon_1_svc(struct mon *argp, struct svc_req *rqstp)
        notify_list     *clnt;
        struct in_addr  my_addr;
 #ifdef RESTRICTED_STATD
-       struct in_addr  mon_addr, caller;
+       struct in_addr  caller;
 #else
        struct hostent  *hostinfo = NULL;
 #endif
@@ -84,6 +89,11 @@ sm_mon_1_svc(struct mon *argp, struct svc_req *rqstp)
                goto failure;
        }
 
+#if 0
+       This is not usable anymore.  Linux-kernel can be configured to use
+       host names with NSM so that multi-homed hosts are handled properly.
+               NeilBrown 15mar2007
+
        /* 3.   mon_name must be an address in dotted quad.
         *      Again, specific to the linux kernel lockd.
         */
@@ -93,22 +103,25 @@ sm_mon_1_svc(struct mon *argp, struct svc_req *rqstp)
                        mon_name);
                goto failure;
        }
-#else
+#endif
+#endif
        /*
         * Check hostnames.  If I can't look them up, I won't monitor.  This
         * might not be legal, but it adds a little bit of safety and sanity.
         */
 
        /* must check for /'s in hostname!  See CERT's CA-96.09 for details. */
-       if (strchr(mon_name, '/')) {
-               note(N_CRIT, "SM_MON request for hostname containing '/': %s",
-                       mon_name);
+       if (strchr(mon_name, '/') || mon_name[0] == '.') {
+               note(N_CRIT, "SM_MON request for hostname containing '/' "
+                    "or starting '.': %s", mon_name);
                note(N_CRIT, "POSSIBLE SPOOF/ATTACK ATTEMPT!");
                goto failure;
        } else if (gethostbyname(mon_name) == NULL) {
                note(N_WARNING, "gethostbyname error for %s", mon_name);
                goto failure;
-       } else if (!(hostinfo = gethostbyname(my_name))) {
+       }
+#ifndef RESTRICTED_STATD
+       if (!(hostinfo = gethostbyname(my_name))) {
                note(N_WARNING, "gethostbyname error for %s", my_name);
                goto failure;
        } else
@@ -126,27 +139,25 @@ sm_mon_1_svc(struct mon *argp, struct svc_req *rqstp)
         * I'll just do a quickie success return and things should
         * be happy.
         */
-       if (rtnl) {
-               notify_list    *temp = rtnl;
-
-               while ((temp = nlist_gethost(temp, mon_name, 0))) {
-                       if (matchhostname(NL_MY_NAME(temp), my_name) &&
-                               NL_MY_PROC(temp) == id->my_proc &&
-                               NL_MY_PROG(temp) == id->my_prog &&
-                               NL_MY_VERS(temp) == id->my_vers) {
-                               /* Hey!  We already know you guys! */
-                               dprintf(N_DEBUG,
-                                       "Duplicate SM_MON request for %s "
-                                       "from procedure on %s",
-                                       mon_name, my_name);
+       clnt = rtnl;
 
-                               /* But we'll let you pass anyway. */
-                               result.res_stat = STAT_SUCC;
-                               result.state = MY_STATE;
-                               return (&result);
-                       }
-                       temp = NL_NEXT(temp);
+       while ((clnt = nlist_gethost(clnt, mon_name, 0))) {
+               if (matchhostname(NL_MY_NAME(clnt), my_name) &&
+                   NL_MY_PROC(clnt) == id->my_proc &&
+                   NL_MY_PROG(clnt) == id->my_prog &&
+                   NL_MY_VERS(clnt) == id->my_vers) {
+                       /* Hey!  We already know you guys! */
+                       dprintf(N_DEBUG,
+                               "Duplicate SM_MON request for %s "
+                               "from procedure on %s",
+                               mon_name, my_name);
+
+                       /* But we'll let you pass anyway. */
+                       result.res_stat = STAT_SUCC;
+                       result.state = MY_STATE;
+                       return (&result);
                }
+               clnt = NL_NEXT(clnt);
        }
 
        /*
@@ -170,13 +181,28 @@ sm_mon_1_svc(struct mon *argp, struct svc_req *rqstp)
 
        path=xmalloc(strlen(SM_DIR)+strlen(mon_name)+2);
        sprintf(path, "%s/%s", SM_DIR, mon_name);
-       if ((fd = open(path, O_WRONLY|O_SYNC|O_CREAT, S_IRUSR|S_IWUSR)) < 0) {
+       if ((fd = open(path, O_WRONLY|O_SYNC|O_CREAT|O_APPEND,
+                      S_IRUSR|S_IWUSR)) < 0) {
                /* Didn't fly.  We won't monitor. */
-               note(N_ERROR, "creat(%s) failed: %m", path);
+               note(N_ERROR, "creat(%s) failed: %s", path, strerror (errno));
                nlist_free(NULL, clnt);
                free(path);
                goto failure;
        }
+       {
+               char buf[LINELEN + 1 + SM_MAXSTRLEN + 2];
+               char *e;
+               int i;
+               e = buf + sprintf(buf, "%08x %08x %08x %08x ",
+                                 my_addr.s_addr, id->my_prog,
+                                 id->my_vers, id->my_proc);
+               for (i=0; i<SM_PRIV_SIZE; i++)
+                       e += sprintf(e, "%02x", 0xff & (argp->priv[i]));
+               if (e+1-buf != LINELEN) abort();
+               e += sprintf(e, " %s\n", mon_name);
+               write(fd, buf, e-buf);
+       }
+
        free(path);
        /* PRC: do the HA callout: */
        ha_callout("add-client", mon_name, my_name, -1);
@@ -193,6 +219,64 @@ failure:
        return (&result);
 }
 
+void load_state(void)
+{
+       DIR *d;
+       struct dirent *de;
+       char buf[LINELEN + 1 + SM_MAXSTRLEN + 2];
+
+       d = opendir(SM_DIR);
+       if (!d)
+               return;
+       while ((de = readdir(d))) {
+               char *path;
+               FILE *f;
+               int p;
+
+               if (de->d_name[0] == '.')
+                       continue;
+               path = xmalloc(strlen(SM_DIR)+strlen(de->d_name)+2);
+               sprintf(path, "%s/%s", SM_DIR, de->d_name);
+               f = fopen(path, "r");
+               free(path);
+               if (f == NULL)
+                       continue;
+               while (fgets(buf, sizeof(buf), f) != NULL) {
+                       int addr, proc, prog, vers;
+                       char priv[SM_PRIV_SIZE];
+                       char *b;
+                       int i;
+                       notify_list     *clnt;
+
+                       buf[sizeof(buf)-1] = 0;
+                       b = strchr(buf, '\n');
+                       if (b) *b = 0;
+                       sscanf(buf, "%x %x %x %x ",
+                              &addr, &prog, &vers, &proc);
+                       b = buf+36;
+                       for (i=0; i<SM_PRIV_SIZE; i++) {
+                               sscanf(b, "%2x", &p);
+                               priv[i] = p;
+                               b += 2;
+                       }
+                       b++;
+                       clnt = nlist_new("127.0.0.1", b, 0);
+                       if (!clnt)
+                               break;
+                       NL_ADDR(clnt).s_addr = addr;
+                       NL_MY_PROG(clnt) = prog;
+                       NL_MY_VERS(clnt) = vers;
+                       NL_MY_PROC(clnt) = proc;
+                       memcpy(NL_PRIV(clnt), priv, SM_PRIV_SIZE);
+                       nlist_insert(&rtnl, clnt);
+               }
+               fclose(f);
+       }
+       closedir(d);
+}
+
+
+
 
 /*
  * Services SM_UNMON requests.
@@ -265,7 +349,9 @@ sm_unmon_1_svc(struct mon_id *argp, struct svc_req *rqstp)
                        clnt = NL_NEXT(clnt);
        }
 
+#ifdef RESTRICTED_STATD
  failure:
+#endif
        note(N_WARNING, "Received erroneous SM_UNMON request from %s for %s",
                my_name, mon_name);
        return (&result);
@@ -333,6 +419,8 @@ sm_unmon_all_1_svc(struct my_id *argp, struct svc_req *rqstp)
                dprintf(N_DEBUG, "SM_UNMON_ALL request from %s with no "
                        "SM_MON requests from it.", my_name);
        }
+#ifdef RESTRICTED_STATD
  failure:
+#endif
        return (&result);
 }