libexport.a: Add helpers to manage DNS lookups

[nfs-utils.git] / utils / mountd / rmtab.c

diff --git a/utils/mountd/rmtab.c b/utils/mountd/rmtab.c
index b028529f4b274e9f2fcfa5f61b70110934483680..ba0fcf6f6814ec9bb105f62022454fad34149d60 100644 (file)
--- a/utils/mountd/rmtab.c
+++ b/utils/mountd/rmtab.c
@@ -24,6 +24,7 @@
 #include "ha-callout.h"
 
 #include <limits.h> /* PATH_MAX */
+#include <errno.h>
 
 extern int reverse_resolve;
 
@@ -132,8 +133,7 @@ mountlist_del(char *hname, const char *path)
 void
 mountlist_del_all(struct sockaddr_in *sin)
 {
-       struct in_addr  addr = sin->sin_addr;
-       struct hostent  *hp;
+       char            *hostname;
        struct rmtabent *rep;
        nfs_export      *exp;
        FILE            *fp;
@@ -141,11 +141,13 @@ mountlist_del_all(struct sockaddr_in *sin)
 
        if ((lockid = xflock(_PATH_RMTABLCK, "w")) < 0)
                return;
-       if (!(hp = gethostbyaddr((char *)&addr, sizeof(addr), AF_INET))) {
-               xlog(L_ERROR, "can't get hostname of %s", inet_ntoa(addr));
+       hostname = host_canonname((struct sockaddr *)sin);
+       if (hostname == NULL) {
+               char buf[INET_ADDRSTRLEN];
+               xlog(L_ERROR, "can't get hostname of %s",
+                       host_ntop((struct sockaddr *)sin, buf, sizeof(buf)));
                goto out_unlock;
        }
-       hp = hostent_dup (hp);
 
        if (!setrmtabent("r"))
                goto out_free;
@@ -154,7 +156,7 @@ mountlist_del_all(struct sockaddr_in *sin)
                goto out_close;
 
        while ((rep = getrmtabent(1, NULL)) != NULL) {
-               if (strcmp(rep->r_client, hp->h_name) == 0 &&
+               if (strcmp(rep->r_client, hostname) == 0 &&
                    (exp = auth_authenticate("umountall", sin, rep->r_path)))
                        continue;
                fputrmtabent(fp, rep, NULL);
@@ -167,7 +169,7 @@ mountlist_del_all(struct sockaddr_in *sin)
 out_close:
        endrmtabent();  /* close & unlink */
 out_free:
-       free (hp);
+       free(hostname);
 out_unlock:
        xfunlock(lockid);
 }
@@ -187,7 +189,9 @@ mountlist_list(void)
        if ((lockid = xflock(_PATH_RMTABLCK, "r")) < 0)
                return NULL;
        if (stat(_PATH_RMTAB, &stb) < 0) {
-               xlog(L_ERROR, "can't stat %s", _PATH_RMTAB);
+               xlog(L_ERROR, "can't stat %s: %s",
+                               _PATH_RMTAB, strerror(errno));
+               xfunlock(lockid);
                return NULL;
        }
        if (stb.st_mtime != last_mtime) {