nfs-utils: dont leak fd in mountlist_list

[nfs-utils.git] / utils / mountd / rmtab.c

diff --git a/utils/mountd/rmtab.c b/utils/mountd/rmtab.c
index 5787ed6a0bebacdc9f4bb270d933833e28f425bf..19b22eea280d2028dd607ae5911c9687e91fc588 100644 (file)
--- a/utils/mountd/rmtab.c
+++ b/utils/mountd/rmtab.c
@@ -24,6 +24,7 @@
 #include "ha-callout.h"
 
 #include <limits.h> /* PATH_MAX */
+#include <errno.h>
 
 extern int reverse_resolve;
 
@@ -58,7 +59,7 @@ mountlist_add(char *host, const char *path)
        int             lockid;
        long            pos;
 
-       if ((lockid = xflock(_PATH_RMTAB, "a")) < 0)
+       if ((lockid = xflock(_PATH_RMTABLCK, "a")) < 0)
                return;
        setrmtabent("r+");
        while ((rep = getrmtabent(1, &pos)) != NULL) {
@@ -98,7 +99,7 @@ mountlist_del(char *hname, const char *path)
        int             lockid;
        int             match;
 
-       if ((lockid = xflock(_PATH_RMTAB, "w")) < 0)
+       if ((lockid = xflock(_PATH_RMTABLCK, "w")) < 0)
                return;
        if (!setrmtabent("r")) {
                xfunlock(lockid);
@@ -139,27 +140,20 @@ mountlist_del_all(struct sockaddr_in *sin)
        FILE            *fp;
        int             lockid;
 
-       if ((lockid = xflock(_PATH_RMTAB, "w")) < 0)
+       if ((lockid = xflock(_PATH_RMTABLCK, "w")) < 0)
                return;
        if (!(hp = gethostbyaddr((char *)&addr, sizeof(addr), AF_INET))) {
                xlog(L_ERROR, "can't get hostname of %s", inet_ntoa(addr));
-               xfunlock(lockid);
-               return;
+               goto out_unlock;
        }
-       else
-               hp = hostent_dup (hp);
+       hp = hostent_dup (hp);
+
+       if (!setrmtabent("r"))
+               goto out_free;
+
+       if (!(fp = fsetrmtabent(_PATH_RMTABTMP, "w")))
+               goto out_close;
 
-       if (!setrmtabent("r")) {
-               xfunlock(lockid);
-               free (hp);
-               return;
-       }
-       if (!(fp = fsetrmtabent(_PATH_RMTABTMP, "w"))) {
-               endrmtabent();
-               xfunlock(lockid);
-               free (hp);
-               return;
-       }
        while ((rep = getrmtabent(1, NULL)) != NULL) {
                if (strcmp(rep->r_client, hp->h_name) == 0 &&
                    (exp = auth_authenticate("umountall", sin, rep->r_path)))
@@ -170,10 +164,13 @@ mountlist_del_all(struct sockaddr_in *sin)
                xlog(L_ERROR, "couldn't rename %s to %s",
                                _PATH_RMTABTMP, _PATH_RMTAB);
        }
-       endrmtabent();  /* close & unlink */
        fendrmtabent(fp);
-       xfunlock(lockid);
+out_close:
+       endrmtabent();  /* close & unlink */
+out_free:
        free (hp);
+out_unlock:
+       xfunlock(lockid);
 }
 
 mountlist
@@ -188,10 +185,12 @@ mountlist_list(void)
        struct in_addr          addr;
        struct hostent          *he;
 
-       if ((lockid = xflock(_PATH_RMTAB, "r")) < 0)
+       if ((lockid = xflock(_PATH_RMTABLCK, "r")) < 0)
                return NULL;
        if (stat(_PATH_RMTAB, &stb) < 0) {
-               xlog(L_ERROR, "can't stat %s", _PATH_RMTAB);
+               xlog(L_ERROR, "can't stat %s: %s",
+                               _PATH_RMTAB, strerror(errno));
+               xfunlock(lockid);
                return NULL;
        }
        if (stb.st_mtime != last_mtime) {