mountd: Avoid unnecessary type conversions

[nfs-utils.git] / utils / mountd / cache.c

diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c
index 57a3fedaa78ee2f5ba88712feced07c9e9193b0e..e950ec6a2adda66e49f0dbfaeb8e5105ce51f608 100644 (file)
--- a/utils/mountd/cache.c
+++ b/utils/mountd/cache.c
@@ -238,17 +238,17 @@ static const char *get_uuid_blkdev(char *path)
 #define get_uuid_blkdev(path) (NULL)
 #endif
 
-static int get_uuid(const char *val, int uuidlen, char *u)
+static int get_uuid(const char *val, size_t uuidlen, char *u)
 {
        /* extract hex digits from uuidstr and compose a uuid
         * of the given length (max 16), xoring bytes to make
         * a smaller uuid.
         */
-       int i = 0;
+       size_t i = 0;
        
        memset(u, 0, uuidlen);
        for ( ; *val ; val++) {
-               char c = *val;
+               int c = *val;
                if (!isxdigit(c))
                        continue;
                if (isalpha(c)) {
@@ -260,7 +260,7 @@ static int get_uuid(const char *val, int uuidlen, char *u)
                        c = c - '0' + 0;
                if ((i&1) == 0)
                        c <<= 4;
-               u[i/2] ^= c;
+               u[i/2] ^= (char)c;
                i++;
                if (i == uuidlen*2)
                        i = 0;
@@ -268,7 +268,7 @@ static int get_uuid(const char *val, int uuidlen, char *u)
        return 1;
 }
 
-static int uuid_by_path(char *path, int type, int uuidlen, char *uuid)
+static int uuid_by_path(char *path, int type, size_t uuidlen, char *uuid)
 {
        /* get a uuid for the filesystem found at 'path'.
         * There are several possible ways of generating the
@@ -366,7 +366,7 @@ struct parsed_fsid {
        unsigned int minor;
        unsigned int major;
        unsigned int fsidnum;
-       int uuidlen;
+       size_t uuidlen;
        char *fhuuid;
 };
 
@@ -758,7 +758,7 @@ static int dump_to_cache(FILE *f, char *domain, char *path, struct exportent *ex
 
 static int is_subdirectory(char *child, char *parent)
 {
-       int l = strlen(parent);
+       size_t l = strlen(parent);
 
        return strcmp(child, parent) == 0
                || (strncmp(child, parent, l) == 0 && child[l] == '/');