umount.nfs: Make do_nfs_mount use conventional EX_ style return codes

[nfs-utils.git] / utils / mount / nfsumount.c

diff --git a/utils/mount/nfsumount.c b/utils/mount/nfsumount.c
index 9b7c44d167688d072347643edf15d36db06c7e88..fd4194faf6d196e1e572e53beeadf29a50dec718 100644 (file)
--- a/utils/mount/nfsumount.c
+++ b/utils/mount/nfsumount.c
@@ -53,7 +53,7 @@ int force;
 int lazy;
 int remount;
 
-int del_mtab(const char *spec, const char *node)
+static int del_mtab(const char *spec, const char *node)
 {
        int umnt_err, res;
 
@@ -121,10 +121,7 @@ int del_mtab(const char *spec, const char *node)
         return EX_FILEIO;
 }
 
-/*
- * Returns 1 if everything went well, else 0.
- */
-int _nfsumount(const char *spec, char *opts)
+static int do_nfs_umount(const char *spec, char *opts)
 {
        char *hostname;
        char *dirname;
@@ -133,10 +130,20 @@ int _nfsumount(const char *spec, char *opts)
        struct pmap *pmap = &mnt_server.pmap;
        char *p;
 
-       if (spec == NULL || (p = strchr(spec,':')) == NULL)
-               goto out_bad;
-       hostname = xstrndup(spec, p-spec);
-       dirname = xstrdup(p+1);
+       if (spec == NULL) {
+               nfs_error(_("%s: No NFS export name was provided"),
+                               progname);
+               return EX_USAGE;
+       }
+       
+       p = strchr(spec, ':');
+       if (p == NULL) {
+               nfs_error(_("%s: '%s' is not a legal NFS export name"),
+                               progname, spec);
+               return EX_USAGE;
+       }
+       hostname = xstrndup(spec, p - spec);
+       dirname = xstrdup(p + 1);
 #ifdef NFS_MOUNT_DEBUG
        printf(_("host: %s, directory: %s\n"), hostname, dirname);
 #endif
@@ -180,11 +187,18 @@ int _nfsumount(const char *spec, char *opts)
        if (opts && (hasmntopt(&mnt, "udp") || hasmntopt(&mnt, "proto=udp")))
                pmap->pm_prot = IPPROTO_UDP;
 
-       if (!nfs_gethostbyname(hostname, &mnt_server.saddr))
-               goto out_bad;
-       return nfs_call_umount(&mnt_server, &dirname);
- out_bad:
-       nfs_error(_("%s: %s: not found or not mounted"), progname, spec);
+       if (!nfs_gethostbyname(hostname, &mnt_server.saddr)) {
+               nfs_error(_("%s: '%s' does not contain a recognized hostname"),
+                               progname, spec);
+               return EX_USAGE;
+       }
+
+       if (!nfs_call_umount(&mnt_server, &dirname)) {
+               nfs_error(_("%s: Server failed to unmount '%s'"),
+                               progname, spec);
+               return EX_USAGE;
+       }
+
        return 0;
 }
 
@@ -312,11 +326,11 @@ int nfsumount(int argc, char *argv[])
        ret = 0;
        if (mc) {
                if (!lazy)
-                       _nfsumount(mc->m.mnt_fsname, mc->m.mnt_opts);
+                       do_nfs_umount(mc->m.mnt_fsname, mc->m.mnt_opts);
                ret = del_mtab(mc->m.mnt_fsname, mc->m.mnt_dir);
        } else if (*spec != '/') {
                if (!lazy)
-                       _nfsumount(spec, "tcp,v3");
+                       do_nfs_umount(spec, "tcp,v3");
        } else
                ret = del_mtab(NULL, spec);