support: Introduce sockaddr helpers to get and set IP port numbers

[nfs-utils.git] / support / nfs / getport.c

diff --git a/support/nfs/getport.c b/support/nfs/getport.c
index bc0f1211d6354c66279b23f5c305e8b3bec2f549..4d4b1c446b6c755c0eec56193aa122ab20614ccb 100644 (file)
--- a/support/nfs/getport.c
+++ b/support/nfs/getport.c
@@ -65,6 +65,26 @@ static const rpcvers_t default_rpcb_version = RPCBVERS_4;
 static const rpcvers_t default_rpcb_version = PMAPVERS;
 #endif /* !HAVE_LIBTIRPC */
 
+/*
+ * Historical: Map TCP connect timeouts to timeout
+ * error code used by UDP.
+ */
+static void
+nfs_gp_map_tcp_errorcodes(const unsigned short protocol)
+{
+       if (protocol != IPPROTO_TCP)
+               return;
+
+       switch (rpc_createerr.cf_error.re_errno) {
+       case ETIMEDOUT:
+               rpc_createerr.cf_stat = RPC_TIMEDOUT;
+               break;
+       case ECONNREFUSED:
+               rpc_createerr.cf_stat = RPC_CANTRECV;
+               break;
+       }
+}
+
 /*
  * There's no easy way to tell how the local system's networking
  * and rpcbind is configured (ie. whether we want to use IPv6 or
@@ -92,24 +112,6 @@ static int nfs_gp_loopback_address(struct sockaddr *sap, socklen_t *salen)
        return ret;
 }
 
-/*
- * Plant port number in @sap.  @port is already in network byte order.
- */
-static void nfs_gp_set_port(struct sockaddr *sap, const in_port_t port)
-{
-       struct sockaddr_in *sin = (struct sockaddr_in *)sap;
-       struct sockaddr_in6 *sin6 = (struct sockaddr_in6 *)sap;
-
-       switch (sap->sa_family) {
-       case AF_INET:
-               sin->sin_port = port;
-               break;
-       case AF_INET6:
-               sin6->sin6_port = port;
-               break;
-       }
-}
-
 /*
  * Look up a network service in /etc/services and return the
  * network-order port number of that service.
@@ -188,10 +190,13 @@ static CLIENT *nfs_gp_get_rpcbclient(struct sockaddr *sap,
                NULL,
        };
        rpcprog_t rpcb_prog = nfs_getrpcbyname(RPCBPROG, rpcb_pgmtbl);
+       CLIENT *clnt;
 
-       nfs_gp_set_port(sap, nfs_gp_get_rpcb_port(transport));
-       return nfs_get_rpcclient(sap, salen, transport, rpcb_prog,
-                                       version, timeout);
+       nfs_set_port(sap, ntohs(nfs_gp_get_rpcb_port(transport)));
+       clnt = nfs_get_rpcclient(sap, salen, transport, rpcb_prog,
+                                                       version, timeout);
+       nfs_gp_map_tcp_errorcodes(transport);
+       return clnt;
 }
 
 /*
@@ -469,7 +474,7 @@ static unsigned short nfs_gp_rpcb_getaddr(CLIENT *client,
                case RPC_SUCCESS:
                        if ((uaddr == NULL) || (uaddr[0] == '\0')) {
                                rpc_createerr.cf_stat = RPC_PROGNOTREGISTERED;
-                               continue;
+                               return 0;
                        }
 
                        port = nfs_universal2port(uaddr);
@@ -627,11 +632,14 @@ int nfs_rpc_ping(const struct sockaddr *sap, const socklen_t salen,
        if (timeout != NULL)
                tout = *timeout;
 
+       nfs_clear_rpc_createerr();
+
        memcpy(saddr, sap, (size_t)salen);
        client = nfs_get_rpcclient(saddr, salen, protocol,
                                                program, version, &tout);
        if (client != NULL) {
                result = nfs_gp_ping(client, tout);
+               nfs_gp_map_tcp_errorcodes(protocol);
                CLNT_DESTROY(client);
        }
 
@@ -690,6 +698,8 @@ unsigned short nfs_getport(const struct sockaddr *sap,
        unsigned short port = 0;
        CLIENT *client;
 
+       nfs_clear_rpc_createerr();
+
        memcpy(saddr, sap, (size_t)salen);
        client = nfs_gp_get_rpcbclient(saddr, salen, protocol,
                                                default_rpcb_version, &timeout);
@@ -729,6 +739,8 @@ int nfs_getport_ping(struct sockaddr *sap, const socklen_t salen,
        CLIENT *client;
        int result = 0;
        
+       nfs_clear_rpc_createerr();
+
        client = nfs_gp_get_rpcbclient(sap, salen, protocol,
                                                default_rpcb_version, &timeout);
        if (client != NULL) {
@@ -743,18 +755,21 @@ int nfs_getport_ping(struct sockaddr *sap, const socklen_t salen,
                struct sockaddr *saddr = (struct sockaddr *)&address;
 
                memcpy(saddr, sap, (size_t)salen);
-               nfs_gp_set_port(saddr, htons(port));
+               nfs_set_port(saddr, port);
+
+               nfs_clear_rpc_createerr();
 
                client = nfs_get_rpcclient(saddr, salen, protocol,
                                                program, version, &timeout);
                if (client != NULL) {
                        result = nfs_gp_ping(client, timeout);
+                       nfs_gp_map_tcp_errorcodes(protocol);
                        CLNT_DESTROY(client);
                }
        }
 
        if (result)
-               nfs_gp_set_port(sap, htons(port));
+               nfs_set_port(sap, port);
 
        return result;
 }
@@ -803,6 +818,8 @@ unsigned short nfs_getlocalport(const rpcprot_t program,
        CLIENT *client;
        struct timeval timeout = { -1, 0 };
 
+       nfs_clear_rpc_createerr();
+
        client = nfs_gp_get_rpcbclient(sap, salen, 0, RPCBVERS_4, &timeout);
        if (client != NULL) {
                struct rpcb parms;
@@ -817,6 +834,8 @@ unsigned short nfs_getlocalport(const rpcprot_t program,
 #endif /* NFS_GP_LOCAL */
 
        if (port == 0) {
+               nfs_clear_rpc_createerr();
+
                if (nfs_gp_loopback_address(lb_addr, &lb_len)) {
                        port = nfs_getport(lb_addr, lb_len,
                                                program, version, protocol);
@@ -878,6 +897,8 @@ unsigned short nfs_rpcb_getaddr(const struct sockaddr *sap,
        if (timeout != NULL)
                tout = *timeout;
 
+       nfs_clear_rpc_createerr();
+
        memcpy(saddr, sap, (size_t)salen);
        client = nfs_gp_get_rpcbclient(saddr, salen, transport,
                                                        RPCBVERS_4, &tout);
@@ -904,6 +925,8 @@ unsigned short nfs_rpcb_getaddr(__attribute__((unused)) const struct sockaddr *s
                                __attribute__((unused)) const unsigned short protocol,
                                __attribute__((unused)) const struct timeval *timeout)
 {
+       nfs_clear_rpc_createerr();
+
        rpc_createerr.cf_stat = RPC_UNKNOWNADDR;
        return 0;
 }
@@ -959,6 +982,8 @@ unsigned long nfs_pmap_getport(const struct sockaddr_in *sin,
        if (timeout != NULL)
                tout = *timeout;
 
+       nfs_clear_rpc_createerr();
+
        memcpy(saddr, sin, sizeof(address));
        client = nfs_gp_get_rpcbclient(saddr, (socklen_t)sizeof(*sin),
                                        transport, PMAPVERS, &tout);