]> git.decadent.org.uk Git - nfs-utils.git/blobdiff - support/nfs/exports.c
Fix handling of explicit uuid
[nfs-utils.git] / support / nfs / exports.c
index 0baa5d05efd006a55233d2ca6fc486fd51a17d7e..334c08e1642051210c10f35a1137b9ae5999e8fd 100644 (file)
 #include "xmalloc.h"
 #include "xlog.h"
 #include "xio.h"
+#include "pseudoflavors.h"
 
 #define EXPORT_DEFAULT_FLAGS   \
   (NFSEXP_READONLY|NFSEXP_ROOTSQUASH|NFSEXP_GATHERED_WRITES|NFSEXP_NOSUBTREECHECK)
 
+struct flav_info flav_map[] = {
+       { "krb5",       RPC_AUTH_GSS_KRB5       },
+       { "krb5i",      RPC_AUTH_GSS_KRB5I      },
+       { "krb5p",      RPC_AUTH_GSS_KRB5P      },
+       { "lipkey",     RPC_AUTH_GSS_LKEY       },
+       { "lipkey-i",   RPC_AUTH_GSS_LKEYI      },
+       { "lipkey-p",   RPC_AUTH_GSS_LKEYP      },
+       { "spkm3",      RPC_AUTH_GSS_SPKM       },
+       { "spkm3i",     RPC_AUTH_GSS_SPKMI      },
+       { "spkm3p",     RPC_AUTH_GSS_SPKMP      },
+       { "unix",       AUTH_UNIX               },
+       { "sys",        AUTH_SYS                },
+       { "null",       AUTH_NULL               },
+       { "none",       AUTH_NONE               },
+};
+
+const int flav_map_size = sizeof(flav_map)/sizeof(flav_map[0]);
+
 int export_errno;
 
 static char    *efname = NULL;
@@ -100,6 +119,7 @@ getexportent(int fromkernel, int fromexports)
                def_ee.e_mountpoint = NULL;
                def_ee.e_fslocmethod = FSLOC_NONE;
                def_ee.e_fslocdata = NULL;
+               def_ee.e_secinfo[0].flav = NULL;
                def_ee.e_nsquids = 0;
                def_ee.e_nsqgids = 0;
 
@@ -156,13 +176,8 @@ getexportent(int fromkernel, int fromexports)
                if (!has_default_opts)
                        xlog(L_WARNING, "No options for %s %s: suggest %s(sync) to avoid warning", ee.e_path, exp, exp);
        }
-       if (strlen(hostname) >= sizeof(ee.e_hostname)) {
-               syntaxerr("client name too long");
-               export_errno = EINVAL;
-               return NULL;
-       }
-       strncpy(ee.e_hostname, hostname, sizeof (ee.e_hostname) - 1);
-       ee.e_hostname[sizeof (ee.e_hostname) - 1] = '\0';
+       xfree(ee.e_hostname);
+       ee.e_hostname = xstrdup(hostname);
 
        if (parseopts(opt, &ee, fromexports && !has_default_subtree_opts, NULL) < 0)
                return NULL;
@@ -179,6 +194,27 @@ getexportent(int fromkernel, int fromexports)
        return &ee;
 }
 
+void secinfo_show(FILE *fp, struct exportent *ep)
+{
+       struct sec_entry *p1, *p2;
+       int flags;
+
+       for (p1=ep->e_secinfo; p1->flav; p1=p2) {
+
+               fprintf(fp, ",sec=%s", p1->flav->flavour);
+               for (p2=p1+1; (p2->flav != NULL) && (p1->flags == p2->flags);
+                                                               p2++) {
+                       fprintf(fp, ":%s", p2->flav->flavour);
+               }
+               flags = p1->flags;
+               fprintf(fp, ",%s", (flags & NFSEXP_READONLY) ? "ro" : "rw");
+               fprintf(fp, ",%sroot_squash", (flags & NFSEXP_ROOTSQUASH)?
+                               "" : "no_");
+               fprintf(fp, ",%sall_squash", (flags & NFSEXP_ALLSQUASH)?
+                               "" : "no_");
+       }
+}
+
 void
 putexportent(struct exportent *ep)
 {
@@ -259,7 +295,9 @@ putexportent(struct exportent *ep)
                        else
                                fprintf(fp, "%d,", id[i]);
        }
-       fprintf(fp, "anonuid=%d,anongid=%d)\n", ep->e_anonuid, ep->e_anongid);
+       fprintf(fp, "anonuid=%d,anongid=%d", ep->e_anonuid, ep->e_anongid);
+       secinfo_show(fp, ep);
+       fprintf(fp, ")\n");
 }
 
 void
@@ -292,6 +330,7 @@ dupexportent(struct exportent *dst, struct exportent *src)
                dst->e_mountpoint = strdup(src->e_mountpoint);
        if (src->e_fslocdata)
                dst->e_fslocdata = strdup(src->e_fslocdata);
+       dst->e_hostname = NULL;
 }
 
 struct exportent *
@@ -307,16 +346,14 @@ mkexportent(char *hname, char *path, char *options)
        ee.e_mountpoint = NULL;
        ee.e_fslocmethod = FSLOC_NONE;
        ee.e_fslocdata = NULL;
+       ee.e_secinfo[0].flav = NULL;
        ee.e_nsquids = 0;
        ee.e_nsqgids = 0;
        ee.e_uuid = NULL;
 
-       if (strlen(hname) >= sizeof(ee.e_hostname)) {
-               xlog(L_WARNING, "client name %s too long", hname);
-               return NULL;
-       }
-       strncpy(ee.e_hostname, hname, sizeof (ee.e_hostname) - 1);
-       ee.e_hostname[sizeof (ee.e_hostname) - 1] = '\0';
+       xfree(ee.e_hostname);
+       ee.e_hostname = xstrdup(hname);
+
        if (strlen(path) >= sizeof(ee.e_path)) {
                xlog(L_WARNING, "path name %s too long", path);
                return NULL;
@@ -349,19 +386,111 @@ static int valid_uuid(char *uuid)
        return cnt == 32;
 }
 
+/*
+ * Append the given flavor to the exportent's e_secinfo array, or
+ * do nothing if it's already there.  Returns the index of flavor
+ * in the resulting array in any case.
+ */
+static int secinfo_addflavor(struct flav_info *flav, struct exportent *ep)
+{
+       struct sec_entry *p;
+
+       for (p=ep->e_secinfo; p->flav; p++) {
+               if (p->flav == flav)
+                       return p - ep->e_secinfo;
+       }
+       if (p - ep->e_secinfo >= SECFLAVOR_COUNT) {
+               xlog(L_ERROR, "more than %d security flavors on an export\n",
+                       SECFLAVOR_COUNT);
+               return -1;
+       }
+       p->flav = flav;
+       p->flags = ep->e_flags;
+       (p+1)->flav = NULL;
+       return p - ep->e_secinfo;
+}
+
+static struct flav_info *find_flavor(char *name)
+{
+       struct flav_info *flav;
+       for (flav = flav_map; flav < flav_map + flav_map_size; flav++)
+               if (strcmp(flav->flavour, name) == 0)
+                       return flav;
+       return NULL;
+}
+
+/* @str is a colon seperated list of security flavors.  Their order
+ * is recorded in @ep, and a bitmap corresponding to the list is returned.
+ * A zero return indicates an error.
+ */
+static unsigned int parse_flavors(char *str, struct exportent *ep)
+{
+       unsigned int out=0;
+       char *flavor;
+       int bit;
+
+       while ( (flavor=strsep(&str, ":")) ) {
+               struct flav_info *flav = find_flavor(flavor);
+               if (flav == NULL) {
+                       xlog(L_ERROR, "unknown flavor %s\n", flavor);
+                       return 0;
+               }
+               bit = secinfo_addflavor(flav, ep);
+               if (bit < 0)
+                       return 0;
+               out |= 1<<bit;
+       }
+       return out;
+}
+
+/* Sets the bits in @mask for the appropriate security flavor flags. */
+static void setflags(int mask, unsigned int active, struct exportent *ep)
+{
+       int bit=0;
+
+       ep->e_flags |= mask;
+
+       while (active) {
+               if (active & 1)
+                       ep->e_secinfo[bit].flags |= mask;
+               bit++;
+               active >>= 1;
+       }
+}
+
+/* Clears the bits in @mask for the appropriate security flavor flags. */
+static void clearflags(int mask, unsigned int active, struct exportent *ep)
+{
+       int bit=0;
+
+       ep->e_flags &= ~mask;
+
+       while (active) {
+               if (active & 1)
+                       ep->e_secinfo[bit].flags &= ~mask;
+               bit++;
+               active >>= 1;
+       }
+}
+
+/* options that can vary per flavor: */
+#define NFSEXP_SECINFO_FLAGS (NFSEXP_READONLY | NFSEXP_ROOTSQUASH \
+                                       | NFSEXP_ALLSQUASH)
+
 /*
  * Parse option string pointed to by cp and set mount options accordingly.
  */
 static int
 parseopts(char *cp, struct exportent *ep, int warn, int *had_subtree_opt_ptr)
 {
+       struct sec_entry *p;
        int     had_subtree_opt = 0;
        char    *flname = efname?efname:"command line";
        int     flline = efp?efp->x_line:0;
+       unsigned int active = 0;
 
        squids = ep->e_squids; nsquids = ep->e_nsquids;
        sqgids = ep->e_sqgids; nsqgids = ep->e_nsqgids;
-
        if (!cp)
                goto out;
 
@@ -380,9 +509,9 @@ parseopts(char *cp, struct exportent *ep, int warn, int *had_subtree_opt_ptr)
 
                /* process keyword */
                if (strcmp(opt, "ro") == 0)
-                       ep->e_flags |= NFSEXP_READONLY;
+                       setflags(NFSEXP_READONLY, active, ep);
                else if (strcmp(opt, "rw") == 0)
-                       ep->e_flags &= ~NFSEXP_READONLY;
+                       clearflags(NFSEXP_READONLY, active, ep);
                else if (!strcmp(opt, "secure"))
                        ep->e_flags &= ~NFSEXP_INSECURE_PORT;
                else if (!strcmp(opt, "insecure"))
@@ -404,13 +533,13 @@ parseopts(char *cp, struct exportent *ep, int warn, int *had_subtree_opt_ptr)
                else if (!strcmp(opt, "no_wdelay"))
                        ep->e_flags &= ~NFSEXP_GATHERED_WRITES;
                else if (strcmp(opt, "root_squash") == 0)
-                       ep->e_flags |= NFSEXP_ROOTSQUASH;
+                       setflags(NFSEXP_ROOTSQUASH, active, ep);
                else if (!strcmp(opt, "no_root_squash"))
-                       ep->e_flags &= ~NFSEXP_ROOTSQUASH;
+                       clearflags(NFSEXP_ROOTSQUASH, active, ep);
                else if (strcmp(opt, "all_squash") == 0)
-                       ep->e_flags |= NFSEXP_ALLSQUASH;
+                       setflags(NFSEXP_ALLSQUASH, active, ep);
                else if (strcmp(opt, "no_all_squash") == 0)
-                       ep->e_flags &= ~NFSEXP_ALLSQUASH;
+                       clearflags(NFSEXP_ALLSQUASH, active, ep);
                else if (strcmp(opt, "subtree_check") == 0) {
                        had_subtree_opt = 1;
                        ep->e_flags &= ~NFSEXP_NOSUBTREECHECK;
@@ -466,7 +595,7 @@ bad_option:
                                if (opt[5]!='\0' && *oe == '\0') 
                                        ep->e_flags |= NFSEXP_FSID;
                                else if (valid_uuid(opt+5))
-                                       ep->e_uuid = strdup(opt+7);
+                                       ep->e_uuid = strdup(opt+5);
                                else {
                                        xlog(L_ERROR, "%s: %d: bad fsid \"%s\"\n",
                                             flname, flline, opt);      
@@ -498,6 +627,10 @@ bad_option:
                } else if (strncmp(opt, "replicas=", 9) == 0) {
                        ep->e_fslocmethod = FSLOC_REPLICA;
                        ep->e_fslocdata = strdup(opt+9);
+               } else if (strncmp(opt, "sec=", 4) == 0) {
+                       active = parse_flavors(opt+4, ep);
+                       if (!active)
+                               goto bad_option;
                } else {
                        xlog(L_ERROR, "%s:%d: unknown keyword \"%s\"\n",
                                        flname, flline, opt);
@@ -508,7 +641,15 @@ bad_option:
                while (isblank(*cp))
                        cp++;
        }
-
+       /*
+        * Turn on nohide which will allow this export to cross over
+        * the 'mount --bind' mount point.
+        */
+       if (ep->e_fslocdata)
+               ep->e_flags |= NFSEXP_NOHIDE;
+
+       for (p = ep->e_secinfo; p->flav; p++)
+               p->flags |= ep->e_flags & ~NFSEXP_SECINFO_FLAGS;
        ep->e_squids = squids;
        ep->e_sqgids = sqgids;
        ep->e_nsquids = nsquids;