+ fix #7917 - use correct template if object creation fails

+ fix #7930 - handle Class::DBI constraint failures
+ assign bug id to relevant changes

git-svn-id: http://svn.maypole.perl.org/Maypole/trunk@320 48953598-375a-da11-a14b-00016c27c3ee

diff --git a/Changes b/Changes
index 2fee5bca430a87b6f64305222249fd2fe21e1fe2..7444732f280035e4a3d92118ab01e39d39f793aa 100644 (file)
--- a/Changes
+++ b/Changes
@@ -16,13 +16,17 @@ Revision history for Perl extension Maypole
       (Dagfinn Ilmari Mannsåker)
     - Added $r->headers_in & $r->headers_out (request & response headers)
     - Split the meat of the view template off to a view_item macro.
-    - Prefix warn() in M::V::Base with error description
+    - #7643 - improve M::V::Base's error() messages. prefix error with label,
+      and carp()
     - #7651 - minor POD improvements in M::M::CDBI (Dave Howorth)
     - #7834 - minor POD update in M::M::CDBI (Kevin Connor)
     - default search action removes empty fields from search parameters
-    - Maypole::Application will create a separate Maypole::Config for each
-      application (instead of the current workaround for multiple apps under
-      mod_perl)
+    - #6622 - Maypole::Application will create a separate Maypole::Config for
+      each application (instead of the current workaround for multiple apps
+      under mod_perl)
+    - #7917 - if do_edit fails for object creation, try again with the correct
+      template (addnew)
+    - #7930 - handle Class::DBI constraint failures in do_edit. 
     - classmetadata template variables can now be overriden individually
     - Template toolkit objects are configured with Maypole::Config->view_options
     - Make test suite work with DBD::SQLite2

diff --git a/ex/BeerDB.pm b/ex/BeerDB.pm
index e276830c4e10d18620783e10cecb6b937a9cc634..6d90b2eb7828f1c1566a1f25f3bfa443414a5d32 100644 (file)
--- a/ex/BeerDB.pm
+++ b/ex/BeerDB.pm
@@ -16,7 +16,7 @@ BEGIN {
             unless -e DATASOURCE;
         eval "require DBD::SQLite";
         if ($@) {
-            eval "require DBD::SQLite2" && dbi_driver = 'SQLite2';
+            eval "require DBD::SQLite2" and $dbi_driver = 'SQLite2';
         }
     }
     BeerDB->setup(join ':', "dbi", $dbi_driver, DATASOURCE);

diff --git a/lib/Maypole/Model/CDBI.pm b/lib/Maypole/Model/CDBI.pm
index 2d309904c015270349044a5b90da40014aee7b1d..37b133549ab316dfee9b246ab8124f2eea35e9d0 100644 (file)
--- a/lib/Maypole/Model/CDBI.pm
+++ b/lib/Maypole/Model/CDBI.pm
@@ -97,27 +97,38 @@ sub do_edit : Exported {
     my $h        = CGI::Untaint->new( %{ $r->{params} } );
     my $creating = 0;
     my ($obj) = @{ $r->objects || [] };
+    my $fatal;
     if ($obj) {
-
         # We have something to edit
-        $obj->update_from_cgi( $h =>
-              { required => $r->{config}{ $r->{table} }{required_cols} || [], }
-        );
+        eval {
+            $obj->update_from_cgi( $h =>
+                { required => $r->{config}{ $r->{table} }{required_cols} || [], }
+            );
+        };
+        $fatal = $@;
     }
     else {
-        $obj =
-          $self->create_from_cgi( $h =>
-              { required => $r->{config}{ $r->{table} }{required_cols} || [], }
-          );
+        eval {
+            $obj =
+                $self->create_from_cgi( $h =>
+                    { required => $r->{config}{ $r->{table} }{required_cols} || [], }
+            );
+        };
+        $fatal = $@;
         $creating++;
     }
-    if ( my %errors = $obj->cgi_update_errors ) {
+    if ( my %errors = $fatal ? (FATAL => $fatal) : $obj->cgi_update_errors ) {
 
         # Set it up as it was:
         $r->{template_args}{cgi_params} = $r->{params};
         $r->{template_args}{errors}     = \%errors;
-        $r->{template}                  = "edit";
-        undef $obj if $creating;    # Couldn't create
+
+        if ($creating) {
+            undef $obj;
+            $r->template("addnew");
+        } else {
+            $r->template("edit");
+        }
     }
     else {
         $r->{template} = "view";

diff --git a/lib/Maypole/View/Base.pm b/lib/Maypole/View/Base.pm
index c56ee51b1bb320ed2dd16c857506a3b1ff367256..6c6b63c5a8886dc47e85e0452e8ca79c1d5a44c2 100644 (file)
--- a/lib/Maypole/View/Base.pm
+++ b/lib/Maypole/View/Base.pm
@@ -3,6 +3,7 @@ use File::Spec;
 use UNIVERSAL::moniker;
 use strict;
 use Maypole::Constants;
+use Carp;
 
 sub new { bless {}, shift }    # By default, do nothing.
 
@@ -74,7 +75,7 @@ sub process {
 sub error {
     my ( $self, $r, $desc ) = @_;
     $desc = $desc ? "$desc: " : "";
-    warn $desc . $r->{error} ."\n";
+    carp $desc . $r->{error};
     if ( $r->{error} =~ /not found$/ ) {
 
         # This is a rough test to see whether or not we're a template or