Merge remote-tracking branch 'ansgar/control-suite-sort-by-version' into merge

* ansgar/control-suite-sort-by-version:
  control-suite: sort list of desired packages as intended

Signed-off-by: Joerg Jaspert <joerg@debian.org>

Merge remote-tracking branch 'ansgar/rm' into merge

* ansgar/rm:
  Use sub-SELECT instead of LEFT OUTER JOIN.
  Check broken dependencies for arch-all packages only once.
  Get rid of WITH.

Signed-off-by: Joerg Jaspert <joerg@debian.org>

And one more lintian reject, nonfatal

added bad-perm-for-file-in-etc-sudoers.d to nonfatal rejects, (Closes: #632466)

Signed-off-by: Joerg Jaspert <joerg@debian.org>

add a fatal lintian tag. closes #637389

add udeb-uses-non-gzip-data-tarball as a fatal lintian tag, which closes #637389

Signed-off-by: Joerg Jaspert <joerg@debian.org>

Enhance source package/version handling when adding a binary deb

Signed-off-by: Mark Hymers <mhy@debian.org>

Make permissions cascade properly

Signed-off-by: Mark Hymers <mhy@debian.org>

Add missing python-debian dependency

Signed-off-by: Mark Hymers <mhy@debian.org>

Update current schema dump to v68

Signed-off-by: Mark Hymers <mhy@debian.org>

Fix incorrect update number

Signed-off-by: Mark Hymers <mhy@debian.org>

Clean out unused languages

Signed-off-by: Mark Hymers <mhy@debian.org>

Don't use old style exception syntax

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'ansgar/clean-suites'

Signed-off-by: Mark Hymers <mhy@debian.org>

Use sub-SELECT instead of LEFT OUTER JOIN.

Check broken dependencies for arch-all packages only once.

Get rid of WITH.

Merge remote branch 'ansgar/auditpackages'

Signed-off-by: Mark Hymers <mhy@debian.org>

Replace deprecated sys.exc_type and sys.exc_value.

This is deprecated since Python 1.5!

Signed-off-by: Torsten Werner <twerner@debian.org>

Remove deprecated xreadlines().

Signed-off-by: Torsten Werner <twerner@debian.org>

Convert raise statement to Python 2.6.

Signed-off-by: Torsten Werner <twerner@debian.org>

Don't import with_statement from __future__.

Signed-off-by: Torsten Werner <twerner@debian.org>

Convert octal literals to Python 2.6 syntax.

Signed-off-by: Torsten Werner <twerner@debian.org>

Convert exception handling to Python3 syntax.

That works in Python >= 2.6.

Signed-off-by: Torsten Werner <twerner@debian.org>

String exceptions do not work in Python >= 2.6.

Signed-off-by: Torsten Werner <twerner@debian.org>

Merge remote-tracking branch 'origin/master' into auditpackages

Conflicts:
dak/update_db.py

rename update66.py to update67.py

Merge remote-tracking branch 'drkranz/rm' into merge

* drkranz/rm:
  rm.py: ignore binNMU versions

Signed-off-by: Joerg Jaspert <joerg@debian.org>

rm.py: ignore binNMU versions

dak rm sometimes complains when closing bugs for
packages with multiple package versions.
Most of the times this is due to binNMUs, so don't
consider their versions.

Signed-off-by: Luca Falavigna <dktrkranz@debian.org>

clean-suites: preserve source packages referenced in extra_src_references

control-suite: sort list of desired packages as intended

The list of desired packages contained a string of the form
"package-name version architecture".  Sorting with cmp_package_version
would sort this my the first two characters of the package name which is
not what was intended.

With this patch, the list instead contains tuples which means
cmp_package_version can now sort the list as intended.

Merge remote-tracking branch 'ansgar/control-suite-sort-by-version' into merge

* ansgar/control-suite-sort-by-version:
  admin: fix a typo
  control-suite: remove packages after adding new ones
  control-suite: sort list by (package-name, version)

Signed-off-by: Joerg Jaspert <joerg@debian.org>

admin: fix a typo

control-suite: remove packages after adding new ones

We have to add package before removing those no longer wanted. Otherwise
an old version could enter a suite without us noticing (as the old
version would already be gone and thus no version check violated).

control-suite: sort list by (package-name, version)

Having multiple versions of the same package in a suite should be
possible, but we need to add the package with the lower version first to
ensure that version checks are not violated.

Set search_path to a secure value.

Add 2 partial indexes to db to speed up dak rm.

Signed-off-by: Torsten Werner <twerner@debian.org>

Rewrite trigger functions in plpgsql.

Signed-off-by: Ansgar Burchardt <ansgar@debian.org>

Merge remote-tracking branch 'ansgar/rm' into merge

* ansgar/rm:
  Use WITH statement instead of a temporary table

Signed-off-by: Joerg Jaspert <joerg@debian.org>

Log updates more sanely and give appropriate warnings

Signed-off-by: Mark Hymers <mhy@debian.org>

Add SQL triggers for package audits

Signed-off-by: Mark Hymers <mhy@debian.org>

copyoverrides

we do want to work with the basename, not the full path of the file here

Signed-off-by: Joerg Jaspert <joerg@debian.org>

copyoverrides

make copyoverrides() function MUCH simpler and let it export all
the overrides, it was missing stuff which let to problems with
security archive.

Signed-off-by: Joerg Jaspert <joerg@debian.org>

Merge remote-tracking branch 'drkranz/mail' into merge

* drkranz/mail:
  Check whether GPG key has a @debian.org uid, and use it
  Make sure uid_email is a valid email address

Signed-off-by: Joerg Jaspert <joerg@debian.org>

Use WITH statement instead of a temporary table

Merge branch 'master' into rm

add primary key

Signed-off-by: Torsten Werner <twerner@debian.org>

yet another fix

Signed-off-by: Torsten Werner <twerner@debian.org>

fix sql statement in rm.py

Signed-off-by: Torsten Werner <twerner@debian.org>

Check whether GPG key has a @debian.org uid, and use it

Signed-off-by: Luca Falavigna <dktrkranz@debian.org>

Make sure uid_email is a valid email address

Signed-off-by: Luca Falavigna <dktrkranz@debian.org>

Update schema to 65

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'ftpmaster/master'

Make suite.announce an ARRAY

Signed-off-by: Mark Hymers <mhy@debian.org>

fix last commit: return [] instead of None

Signed-off-by: Torsten Werner <twerner@debian.org>

get_suite_architectures() can return None

Signed-off-by: Torsten Werner <twerner@debian.org>

Set overridecodename by default

Signed-off-by: Mark Hymers <mhy@debian.org>

Give slightly nicer error message on db conn failure

Signed-off-by: Mark Hymers <mhy@debian.org>

Fix NoMail case

Signed-off-by: Mark Hymers <mhy@debian.org>

Document Depends more clearly

Signed-off-by: Mark Hymers <mhy@debian.org>

Make it easier to spot if psql fails

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'ftpmaster/master'

Bail out earlier

Signed-off-by: Mark Hymers <mhy@debian.org>

Don't say we're sending mail when we're not

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'ftpmaster/master'

Add docs that the secret key only needs to be able to sign

Signed-off-by: Mark Hymers <mhy@debian.org>

Ensure we have a session so that we can look up srcformats

Signed-off-by: Mark Hymers <mhy@debian.org>

Simplify src_format handling

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'ftpmaster/master'

Use /bin/bash as dak's shell

Signed-off-by: Mark Hymers <mhy@debian.org>

Clean up account creation instructions

Signed-off-by: Mark Hymers <mhy@debian.org>

Use --system

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'mhy/master'

Cope with missing suite

Signed-off-by: Mark Hymers <mhy@debian.org>

Remove unreferenced variable from config

Signed-off-by: Mark Hymers <mhy@debian.org>

Remove unused template

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'mhy/master'

Enhance setup and getting started instructions

Thanks to Julien Cristau for initial testing and feedback.

Signed-off-by: Mark Hymers <mhy@debian.org>

Add src_formats by default

Signed-off-by: Mark Hymers <mhy@debian.org>

Improve lock fallbacks

If Process-New doesn't have specific lock configuration,
fall back to some saneish defaults.

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'mhy/master'

Give exception information

Signed-off-by: Mark Hymers <mhy@debian.org>

Add missing import

Signed-off-by: Mark Hymers <mhy@debian.org>

Add missing variable

Signed-off-by: Mark Hymers <mhy@debian.org>

Add missing /

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'mhy/master'

Tidy up dependencies

Signed-off-by: Mark Hymers <mhy@debian.org>

Merge remote branch 'mhy/master'

Add documentation for setting up keyrings

Signed-off-by: Mark Hymers <mhy@debian.org>

Create keyrings if necessary

Signed-off-by: Mark Hymers <mhy@debian.org>

Remove unused variable

Signed-off-by: Mark Hymers <mhy@debian.org>

Add signingkey option to suite add command

Signed-off-by: Mark Hymers <mhy@debian.org>

dak rm: read binary metadata from db

Signed-off-by: Torsten Werner <twerner@debian.org>

Skip project trace dir

Signed-off-by: Mark Hymers <mhy@debian.org>

Add missing import

Signed-off-by: Mark Hymers <mhy@debian.org>

Fix thinko regarding ctime and datetime

Signed-off-by: Mark Hymers <mhy@debian.org>

Fix path existance check

Signed-off-by: Mark Hymers <mhy@debian.org>

Add error handling to find-null-maintainers

Signed-off-by: Mark Hymers <mhy@debian.org>

Add logger.close routine

Signed-off-by: Mark Hymers <mhy@debian.org>

dak rm: improve checking of reverse Build-Depends

Signed-off-by: Torsten Werner <twerner@debian.org>

Remove 'poolize' command from dak.py; it hasn't been there for ages

Signed-off-by: Mark Hymers <mhy@debian.org>

Remove utils. qualifications

Signed-off-by: Mark Hymers <mhy@debian.org>