]> git.decadent.org.uk Git - dak.git/log
dak.git
10 years agodaklib/gpg.py: Ignore POLICY_URL keyword.
Ansgar Burchardt [Sun, 26 Oct 2014 09:01:34 +0000 (10:01 +0100)]
daklib/gpg.py: Ignore POLICY_URL keyword.

10 years agodaklib/command.py: Add Cc option.
Ansgar Burchardt [Thu, 23 Oct 2014 18:31:57 +0000 (20:31 +0200)]
daklib/command.py: Add Cc option.

10 years agoREADME.stable-point-release: Update for 7.7
Ansgar Burchardt [Sun, 19 Oct 2014 08:56:48 +0000 (10:56 +0200)]
README.stable-point-release: Update for 7.7

Add copy & paste snippets for propups.

10 years agosecurity NEW processing: add dak admin forget-signature
Ansgar Burchardt [Wed, 15 Oct 2014 19:00:38 +0000 (21:00 +0200)]
security NEW processing: add dak admin forget-signature

10 years agoHandle packages with overrides in multiple components
Ansgar Burchardt [Tue, 7 Oct 2014 19:18:52 +0000 (21:18 +0200)]
Handle packages with overrides in multiple components

This should make moving packages between components (e.g. packages
moving from non-free to main) less painful.

Bug: https://bugs.debian.org/690444

10 years agodaklib/checks.py: check timestamp of .changes signature
Ansgar Burchardt [Thu, 11 Sep 2014 23:24:24 +0000 (01:24 +0200)]
daklib/checks.py: check timestamp of .changes signature

This allows to eventually drop old entries from the signature_history
table.

10 years agodak make-pkg-file-mapping: do not include sources from other archives
Ansgar Burchardt [Thu, 11 Sep 2014 18:30:18 +0000 (20:30 +0200)]
dak make-pkg-file-mapping: do not include sources from other archives

Include only information about a source package's files if its .dsc is
in the requested archive.

Previously when xy_1.0-1 was in the requested archive and xy_1.0-2
using the same upstream tarball in a different archive, dak would
still include information about xy_1.0-2's upstream tarball resulting
in confusing entries on snapshot.d.o.

Reported-by: Salvatore Bonaccorso <carnil@debian.org>
10 years agodak make-pkg-file-mapping: ensure stable order
Ansgar Burchardt [Thu, 11 Sep 2014 18:29:11 +0000 (20:29 +0200)]
dak make-pkg-file-mapping: ensure stable order

Include component and filename in the ORDER BY clause to ensure the
output order does not change.

10 years agotest_gpg.py: test PGP messages and plaintext
Ansgar Burchardt [Tue, 2 Sep 2014 23:29:30 +0000 (01:29 +0200)]
test_gpg.py: test PGP messages and plaintext

10 years agotest_gpg.py: also check signature timestamp
Ansgar Burchardt [Tue, 2 Sep 2014 22:12:13 +0000 (00:12 +0200)]
test_gpg.py: also check signature timestamp

10 years agoAdd first unit tests for GnuPG wrapper.
Ansgar Burchardt [Tue, 2 Sep 2014 21:55:22 +0000 (23:55 +0200)]
Add first unit tests for GnuPG wrapper.

10 years agodm-migrate: list source packages for which permissions were migrated.
Ansgar Burchardt [Tue, 2 Sep 2014 08:11:26 +0000 (10:11 +0200)]
dm-migrate: list source packages for which permissions were migrated.

10 years agocron.unchecked: drop unused do_dists function.
Ansgar Burchardt [Tue, 26 Aug 2014 20:17:28 +0000 (22:17 +0200)]
cron.unchecked: drop unused do_dists function.

10 years agocron.unchecked: stop bothering with override files.
Ansgar Burchardt [Tue, 26 Aug 2014 20:16:38 +0000 (22:16 +0200)]
cron.unchecked: stop bothering with override files.

10 years agoMerge remote-tracking branch 'paultag/paultag/bugfix/import-errno'
Ansgar Burchardt [Mon, 25 Aug 2014 20:25:55 +0000 (22:25 +0200)]
Merge remote-tracking branch 'paultag/paultag/bugfix/import-errno'

10 years agoImport errno, used in Exception handling.
Paul Tagliamonte [Mon, 25 Aug 2014 16:59:46 +0000 (12:59 -0400)]
Import errno, used in Exception handling.

From a reject exception:

|   File "/srv/ftp-master.debian.org/dak/dak/daklib/upload.py", line 155, in check
|     if e.errno == errno.ENOENT:
| NameError: global name 'errno' is not defined

10 years agoHashedFile: Raise FileDoesNotExist if referring to a non-existing file
Ansgar Burchardt [Fri, 22 Aug 2014 19:51:02 +0000 (21:51 +0200)]
HashedFile: Raise FileDoesNotExist if referring to a non-existing file

A custom exception is nicer to handle in the caller.

10 years agodaklib/upload.py: Use common base class for all exception.
Ansgar Burchardt [Fri, 22 Aug 2014 19:49:28 +0000 (21:49 +0200)]
daklib/upload.py: Use common base class for all exception.

10 years agoMerge branch 'master' of /srv/ftp.debian.org/git/dak
Mark Hymers [Sun, 17 Aug 2014 22:46:17 +0000 (22:46 +0000)]
Merge branch 'master' of /srv/ftp.debian.org/git/dak

10 years agoAdd ppc64el
Mark Hymers [Sun, 17 Aug 2014 22:46:12 +0000 (22:46 +0000)]
Add ppc64el

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agocron.daily: Don't allow ssh trigger to run arbitrary SQL
Ansgar Burchardt [Sun, 17 Aug 2014 18:22:24 +0000 (20:22 +0200)]
cron.daily: Don't allow ssh trigger to run arbitrary SQL

10 years agoRemove apache.conf-incoming.
Ansgar Burchardt [Sun, 17 Aug 2014 15:53:35 +0000 (17:53 +0200)]
Remove apache.conf-incoming.

incoming.d.o is no longer hosted on ftp-master.d.o.

10 years agoShow last updated time on i.d.o
Mark Hymers [Sat, 16 Aug 2014 21:48:21 +0000 (21:48 +0000)]
Show last updated time on i.d.o

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoRemove old (and slow) code
Mark Hymers [Sat, 16 Aug 2014 21:25:10 +0000 (21:25 +0000)]
Remove old (and slow) code

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoRemove code working around an old issue
Mark Hymers [Sat, 16 Aug 2014 21:24:18 +0000 (21:24 +0000)]
Remove code working around an old issue

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoStop generating old incoming.debian.org
Mark Hymers [Sat, 16 Aug 2014 21:12:26 +0000 (21:12 +0000)]
Stop generating old incoming.debian.org

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoDon't use privacy temporarily to work out which buildds need reconfiguring
Mark Hymers [Sat, 16 Aug 2014 17:00:27 +0000 (17:00 +0000)]
Don't use privacy temporarily to work out which buildds need reconfiguring

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoDon't break on too many links
Mark Hymers [Sat, 16 Aug 2014 16:14:29 +0000 (16:14 +0000)]
Don't break on too many links

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoRemove old variables
Mark Hymers [Sat, 16 Aug 2014 16:10:49 +0000 (16:10 +0000)]
Remove old variables

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoUse chronic
Mark Hymers [Sat, 16 Aug 2014 11:42:25 +0000 (11:42 +0000)]
Use chronic

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoDrop created and modified columns from bin_contents and src_contents
Ansgar Burchardt [Fri, 15 Aug 2014 20:29:19 +0000 (22:29 +0200)]
Drop created and modified columns from bin_contents and src_contents

10 years agoDebian_arch_to_Debian_triplet: handle linux-${arch}
Ansgar Burchardt [Fri, 15 Aug 2014 08:16:47 +0000 (10:16 +0200)]
Debian_arch_to_Debian_triplet: handle linux-${arch}

10 years agoFix DirectoryMatch
Mark Hymers [Tue, 12 Aug 2014 20:50:48 +0000 (20:50 +0000)]
Fix DirectoryMatch

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoWe don't want emails every 15 minutes
Mark Hymers [Tue, 12 Aug 2014 20:38:59 +0000 (20:38 +0000)]
We don't want emails every 15 minutes

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoDon't sync incoming - there's no point
Mark Hymers [Tue, 12 Aug 2014 20:25:44 +0000 (20:25 +0000)]
Don't sync incoming - there's no point

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoUse the right option
Mark Hymers [Tue, 12 Aug 2014 19:39:20 +0000 (19:39 +0000)]
Use the right option

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoChange how we generate incoming.debian.org
Mark Hymers [Tue, 12 Aug 2014 19:29:36 +0000 (19:29 +0000)]
Change how we generate incoming.debian.org

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoMove canonical incoming.debian.org location
Mark Hymers [Tue, 12 Aug 2014 19:26:42 +0000 (19:26 +0000)]
Move canonical incoming.debian.org location

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoexport-suite: Add --relative option.
Ansgar Burchardt [Mon, 11 Aug 2014 20:19:41 +0000 (22:19 +0200)]
export-suite: Add --relative option.

10 years agoapache.conf-incoming: Grant access to home.mraw.org
Ansgar Burchardt [Sun, 10 Aug 2014 18:31:00 +0000 (20:31 +0200)]
apache.conf-incoming: Grant access to home.mraw.org

10 years agoprocess-new: Indicate which packages were not include in upload
Ansgar Burchardt [Sun, 10 Aug 2014 17:31:26 +0000 (19:31 +0200)]
process-new: Indicate which packages were not include in upload

Show "NOT UPLOADED" besides overrides for packages that were not
included in the upload.

10 years agoOnly inject processed uploads into signature_history
Ansgar Burchardt [Sun, 10 Aug 2014 16:22:01 +0000 (18:22 +0200)]
Only inject processed uploads into signature_history

Uploads that were 'skipped' should not be recorded in
signature_history as they will be repeocessed later.

10 years agodaklib/regexes.py: Do not allow colons in filenames.
Ansgar Burchardt [Fri, 8 Aug 2014 08:38:15 +0000 (10:38 +0200)]
daklib/regexes.py: Do not allow colons in filenames.

Colons should not be used anywhere as the epoch part of versions is
not included in the filename.

10 years agodaklib/checks.py: Add instructions how to get an upload processed again.
Ansgar Burchardt [Tue, 5 Aug 2014 21:53:15 +0000 (23:53 +0200)]
daklib/checks.py: Add instructions how to get an upload processed again.

10 years agodaklib/gpg.py: Ignore SIGEXPIRED and KEYEXPIRED
Ansgar Burchardt [Mon, 4 Aug 2014 19:18:56 +0000 (21:18 +0200)]
daklib/gpg.py: Ignore SIGEXPIRED and KEYEXPIRED

10 years agoapache.conf-incoming: Grant access to mahler.debian.net
Ansgar Burchardt [Sun, 3 Aug 2014 20:35:42 +0000 (22:35 +0200)]
apache.conf-incoming: Grant access to mahler.debian.net

Bug: https://bugs.debian.org/754742

10 years agodaklib/gpg.py: Ignore NOTATION_{NAME,DATA} keywords.
Ansgar Burchardt [Sun, 3 Aug 2014 19:13:55 +0000 (21:13 +0200)]
daklib/gpg.py: Ignore NOTATION_{NAME,DATA} keywords.

10 years agoshow-deferred: Do not require a valid signature.
Ansgar Burchardt [Sun, 3 Aug 2014 18:11:51 +0000 (20:11 +0200)]
show-deferred: Do not require a valid signature.

10 years agodaklib/gpg.py: Also handle SIGEXPIRED keyword.
Ansgar Burchardt [Sun, 3 Aug 2014 17:16:35 +0000 (19:16 +0200)]
daklib/gpg.py: Also handle SIGEXPIRED keyword.

10 years agodaklib/gpg.py: Handle a few more keywords for invalid or and expired signatures.
Ansgar Burchardt [Sun, 3 Aug 2014 16:42:42 +0000 (18:42 +0200)]
daklib/gpg.py: Handle a few more keywords for invalid or and expired signatures.

10 years agoDrop unique .changes name requirement and allow ftpteam to forget seen files.
Ansgar Burchardt [Sun, 3 Aug 2014 15:04:41 +0000 (17:04 +0200)]
Drop unique .changes name requirement and allow ftpteam to forget seen files.

10 years agodak admin: add forget-signature subcommand
Ansgar Burchardt [Sun, 3 Aug 2014 15:03:32 +0000 (17:03 +0200)]
dak admin: add forget-signature subcommand

The forget-signature command removes the entry for a given file from
the signature_history. This allows reprocessing the file.

10 years agoAdd replay protection for uploaded changes files.
Ansgar Burchardt [Sun, 3 Aug 2014 15:02:26 +0000 (17:02 +0200)]
Add replay protection for uploaded changes files.

Look in signature_history table if the changes was already seen to
prevent re-uploading old changes files.

10 years agodaklib/gpg.py: Use timestamp instead of just date.
Ansgar Burchardt [Sun, 3 Aug 2014 15:01:20 +0000 (17:01 +0200)]
daklib/gpg.py: Use timestamp instead of just date.

10 years agodaklib/gpg.py: Raise an error if we see unexpected output from gpg.
Ansgar Burchardt [Sun, 3 Aug 2014 15:01:00 +0000 (17:01 +0200)]
daklib/gpg.py: Raise an error if we see unexpected output from gpg.

10 years agoFix breakage on missing w-b dump for an arch
Joerg Jaspert [Sun, 3 Aug 2014 11:53:43 +0000 (13:53 +0200)]
Fix breakage on missing w-b dump for an arch

The w-b admins may take some time until they have a new architecture all
set up. And until they do generate the buildd.d.o/stats/$arch-all.txt we shouldn't
break on it missing.

Signed-off-by: Joerg Jaspert <joerg@debian.org>
10 years agoAdd arm64 keyring to queued configuration
Mark Hymers [Sat, 2 Aug 2014 08:49:50 +0000 (08:49 +0000)]
Add arm64 keyring to queued configuration

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agoAdd arm64
Mark Hymers [Sat, 2 Aug 2014 08:47:46 +0000 (08:47 +0000)]
Add arm64

Signed-off-by: Mark Hymers <mhy@debian.org>
10 years agobuilt_in_suite: Do not consider architecture 'source'
Ansgar Burchardt [Fri, 1 Aug 2014 17:40:05 +0000 (19:40 +0200)]
built_in_suite: Do not consider architecture 'source'

daklib.architecture.match_architecture would consider 'source' as an
invalid architecture name.

10 years agomatch_architecture: Fix raising exception if an architecture is unknown
Ansgar Burchardt [Fri, 1 Aug 2014 17:38:28 +0000 (19:38 +0200)]
match_architecture: Fix raising exception if an architecture is unknown

10 years agoprocess-new: Make again use of Package-List field.
Ansgar Burchardt [Fri, 1 Aug 2014 17:03:01 +0000 (19:03 +0200)]
process-new: Make again use of Package-List field.

10 years agodaklib/dbconn.py: Add MetadataProxy that behaves like a dict
Ansgar Burchardt [Fri, 1 Aug 2014 17:01:58 +0000 (19:01 +0200)]
daklib/dbconn.py: Add MetadataProxy that behaves like a dict

10 years agoscripts/debian/moveftp.sh: use mv --no-clobber
Ansgar Burchardt [Fri, 1 Aug 2014 16:21:09 +0000 (18:21 +0200)]
scripts/debian/moveftp.sh: use mv --no-clobber

10 years agoconfig/debian/dak.conf: Allow some source-only uploads.
Ansgar Burchardt [Thu, 31 Jul 2014 23:01:11 +0000 (01:01 +0200)]
config/debian/dak.conf: Allow some source-only uploads.

10 years agoPackageList: use correct values for section and component
Ansgar Burchardt [Thu, 31 Jul 2014 22:51:57 +0000 (00:51 +0200)]
PackageList: use correct values for section and component

10 years agoAdd more fine-grained options for source-only uploads.
Ansgar Burchardt [Thu, 31 Jul 2014 22:04:35 +0000 (00:04 +0200)]
Add more fine-grained options for source-only uploads.

10 years agoUse Package-List to look for NEW binaries.
Ansgar Burchardt [Thu, 31 Jul 2014 22:03:02 +0000 (00:03 +0200)]
Use Package-List to look for NEW binaries.

10 years agodaklib.upload.Source: expose Package-List.
Ansgar Burchardt [Thu, 31 Jul 2014 22:02:19 +0000 (00:02 +0200)]
daklib.upload.Source: expose Package-List.

10 years agodaklib.upload.Binary: add name property.
Ansgar Burchardt [Thu, 31 Jul 2014 22:01:52 +0000 (00:01 +0200)]
daklib.upload.Binary: add name property.

10 years agoPackageListEntry: Rename package_type to type.
Ansgar Burchardt [Thu, 31 Jul 2014 22:00:53 +0000 (00:00 +0200)]
PackageListEntry: Rename package_type to type.

PackageListEntry should be similar to daklib.upload.Binary.

10 years agoThe Binary field of source packages is comma-seperated.
Ansgar Burchardt [Thu, 31 Jul 2014 21:23:35 +0000 (23:23 +0200)]
The Binary field of source packages is comma-seperated.

10 years agodaklib/packagelist.py: Additional sanity checks.
Ansgar Burchardt [Thu, 31 Jul 2014 21:16:48 +0000 (23:16 +0200)]
daklib/packagelist.py: Additional sanity checks.

10 years agoextract_component_from_section: avoid unneeded database lookup
Ansgar Burchardt [Thu, 31 Jul 2014 19:21:23 +0000 (21:21 +0200)]
extract_component_from_section: avoid unneeded database lookup

10 years agoAdd parser for Package-List field.
Ansgar Burchardt [Sun, 22 Jun 2014 20:27:37 +0000 (22:27 +0200)]
Add parser for Package-List field.

10 years agodaklib/gpg.py: Pass a few more options to gpg.
Ansgar Burchardt [Tue, 29 Jul 2014 17:41:28 +0000 (19:41 +0200)]
daklib/gpg.py: Pass a few more options to gpg.

10 years agoMerge remote-tracking branch 'alteholz/alteholz/bugfix/tracker' into merge
Joerg Jaspert [Mon, 28 Jul 2014 20:16:00 +0000 (22:16 +0200)]
Merge remote-tracking branch 'alteholz/alteholz/bugfix/tracker' into merge

This (closes: 754805)
* alteholz/alteholz/bugfix/tracker:
  fix for #754805

10 years agoWe are in srv now, no longer org
Joerg Jaspert [Sun, 27 Jul 2014 19:37:09 +0000 (21:37 +0200)]
We are in srv now, no longer org

Signed-off-by: Joerg Jaspert <joerg@debian.org>
10 years agoAllow coccia, remove morricone, dont try to important if variable is empty
Joerg Jaspert [Sun, 27 Jul 2014 19:23:20 +0000 (21:23 +0200)]
Allow coccia, remove morricone, dont try to important if variable is empty

Signed-off-by: Joerg Jaspert <joerg@debian.org>
10 years agodak.conf: Reject uploads to Debian 6 (Squeeze).
Ansgar Burchardt [Sat, 19 Jul 2014 10:21:42 +0000 (12:21 +0200)]
dak.conf: Reject uploads to Debian 6 (Squeeze).

10 years agofix for #754805
Thorsten Alteholz [Fri, 18 Jul 2014 08:29:42 +0000 (08:29 +0000)]
fix for #754805

10 years agodak ls: document --format=control-suite option
Ansgar Burchardt [Sun, 13 Jul 2014 07:37:34 +0000 (09:37 +0200)]
dak ls: document --format=control-suite option

10 years agoUpdate for 7.6.
Ansgar Burchardt [Sat, 12 Jul 2014 11:09:06 +0000 (13:09 +0200)]
Update for 7.6.

10 years agoRemove mail-archiving code, mail is no longer on ftp-master
Joerg Jaspert [Sun, 6 Jul 2014 10:42:09 +0000 (12:42 +0200)]
Remove mail-archiving code, mail is no longer on ftp-master

10 years agoAdd change-component command.
Ansgar Burchardt [Wed, 25 Jun 2014 19:29:53 +0000 (21:29 +0200)]
Add change-component command.

10 years agoImplement architecture matching rules.
Ansgar Burchardt [Thu, 19 Jun 2014 14:34:09 +0000 (16:34 +0200)]
Implement architecture matching rules.

10 years agoRevert "Add a deb822 for the backports NEW queue (Closes: #749102)"
Ansgar Burchardt [Wed, 18 Jun 2014 18:54:36 +0000 (20:54 +0200)]
Revert "Add a deb822 for the backports NEW queue (Closes: #749102)"

This reverts commit cda77ad8e9f59752b615ec9a647848d05362a47d.

10 years agoview src_associations_full: include sources for all binaries
Ansgar Burchardt [Wed, 18 Jun 2014 18:53:09 +0000 (20:53 +0200)]
view src_associations_full: include sources for all binaries

The src_associations_full now includes sources for all binaries in a
suite. This includes old versions of source packages if old binary
packages are still around.

10 years agocron.hourly: Include backports-new queue in new.822.
Ansgar Burchardt [Mon, 16 Jun 2014 17:45:32 +0000 (19:45 +0200)]
cron.hourly: Include backports-new queue in new.822.

10 years agodak queue-report: --822 outputs to stdout if no other location is given
Ansgar Burchardt [Mon, 16 Jun 2014 17:34:29 +0000 (19:34 +0200)]
dak queue-report: --822 outputs to stdout if no other location is given

10 years agoAdd a deb822 for the backports NEW queue (Closes: #749102)
Paul Wise [Sun, 25 May 2014 01:06:51 +0000 (09:06 +0800)]
Add a deb822 for the backports NEW queue (Closes: #749102)

10 years agoMerge remote-tracking branch 'helmut/fix-gpg_get_key_addresses'
Ansgar Burchardt [Mon, 26 May 2014 07:55:42 +0000 (09:55 +0200)]
Merge remote-tracking branch 'helmut/fix-gpg_get_key_addresses'

10 years agofix gpg_get_key_addresses
Helmut Grohne [Mon, 26 May 2014 05:47:07 +0000 (07:47 +0200)]
fix gpg_get_key_addresses

Do not use codecs.decode(s, "unicode_escape"). It has two issues:
 * When being passed a bytes literal, the returned value becomes a str
   and the decoding operation is locale specific on Python3.
 * When passing a unicode literal, it implicitly encodes to
   sys.getdefaultencoding() (locale specific) on Python2.
Thus "unicode_escape" is a bad choice in all cases.

For Python2 string_escape works with str, but it hinders a potential
Python3 port of dak. Use it now, because Python3 is totally broken.

10 years agoMerge remote-tracking branch 'helmut/smallthings' into merge
Joerg Jaspert [Sun, 25 May 2014 12:38:56 +0000 (14:38 +0200)]
Merge remote-tracking branch 'helmut/smallthings' into merge

* helmut/smallthings:
  rewrite daklib.utils.gpg_get_key_addresses
  convert daklib.dbconn from os.popen to subprocess
  put Python's with statement to good use

Signed-off-by: Joerg Jaspert <joerg@debian.org>
10 years agorewrite daklib.utils.gpg_get_key_addresses
Helmut Grohne [Thu, 22 May 2014 17:08:40 +0000 (19:08 +0200)]
rewrite daklib.utils.gpg_get_key_addresses

 * No longer uses the deprecated commands module.
 * No longer invokes gpg via a shell.
 * Passes --with-colons to gpg now.
 * No longer depends on the current locale (since --with-colons forces
   UTF-8 output).

Signed-off-by: Helmut Grohne <helmut@subdivi.de>
10 years agoconvert daklib.dbconn from os.popen to subprocess
Helmut Grohne [Sat, 17 May 2014 19:31:47 +0000 (21:31 +0200)]
convert daklib.dbconn from os.popen to subprocess

It now explicitly closes the filedescriptors opened (by calling wait)
and checks the return code of gpg.

10 years agoput Python's with statement to good use
Helmut Grohne [Thu, 15 May 2014 21:36:51 +0000 (23:36 +0200)]
put Python's with statement to good use

Rather than using try-finally blocks or even failing to close files in
the event of an exception, open files in with blocks where feasible.

Signed-off-by: Helmut Grohne <helmut@subdivi.de>
10 years agoread file once in HashedFile.check
Helmut Grohne [Thu, 15 May 2014 19:09:19 +0000 (21:09 +0200)]
read file once in HashedFile.check

Reading the file to check once rather than three times is both faster
and shorter.

Signed-off-by: Helmut Grohne <helmut@subdivi.de>
Signed-off-by: Helmut Grohne <helmut@subdivi.de>
10 years agovisually fix daklib.utils.parse_wnpp_bug_file
Helmut Grohne [Thu, 15 May 2014 18:34:25 +0000 (20:34 +0200)]
visually fix daklib.utils.parse_wnpp_bug_file

The file asks Vim to set tabstop=4. So the "lines = []" line formerly
being indented with a tab appears to be executed unconditionally whereas
it really only is executed in the exception handler.

Signed-off-by: Helmut Grohne <helmut@subdivi.de>
Signed-off-by: Helmut Grohne <helmut@subdivi.de>
10 years agotell the uninitiated that 2 is ENOENT
Helmut Grohne [Thu, 15 May 2014 18:32:30 +0000 (20:32 +0200)]
tell the uninitiated that 2 is ENOENT

Signed-off-by: Helmut Grohne <helmut@subdivi.de>
Signed-off-by: Helmut Grohne <helmut@subdivi.de>
10 years agotighten source format check for 1.0
Helmut Grohne [Thu, 15 May 2014 18:30:31 +0000 (20:30 +0200)]
tighten source format check for 1.0

The regular expression used a ".", so it would accept "1-0" or even
"120" for source format 1.0.

Signed-off-by: Helmut Grohne <helmut@subdivi.de>
Signed-off-by: Helmut Grohne <helmut@subdivi.de>