]> git.decadent.org.uk Git - dak.git/log
dak.git
15 years agoAdd doc why we are monkeypatching commands.getstatusoutput
Chris Lamb [Wed, 28 Oct 2009 08:50:38 +0000 (08:50 +0000)]
Add doc why we are monkeypatching commands.getstatusoutput

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years ago"Fully" ported to SQLAlchemy-based daklib.dbconn; remove database.py
Chris Lamb [Tue, 27 Oct 2009 21:59:57 +0000 (21:59 +0000)]
"Fully" ported to SQLAlchemy-based daklib.dbconn; remove database.py

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoPort new_security_install to DBConn and friends.
Chris Lamb [Tue, 27 Oct 2009 21:58:58 +0000 (21:58 +0000)]
Port new_security_install to DBConn and friends.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoMove get_queue => get_or_set_queue
Chris Lamb [Tue, 27 Oct 2009 21:57:08 +0000 (21:57 +0000)]
Move get_queue => get_or_set_queue

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoFix log messages
Chris Lamb [Tue, 27 Oct 2009 21:34:10 +0000 (21:34 +0000)]
Fix log messages

15 years agoMerge branch 'master' of ssh://ftp-master.debian.org/srv/ftp.debian.org/git/dak
Joerg Jaspert [Tue, 27 Oct 2009 21:20:29 +0000 (22:20 +0100)]
Merge branch 'master' of ssh://ftp-master.debian.org/srv/ftp.debian.org/git/dak

* 'master' of ssh://ftp-master.debian.org/srv/ftp.debian.org/git/dak:
  PASS

15 years agoMerge commit 'lamby/master' into merge
Joerg Jaspert [Tue, 27 Oct 2009 21:20:04 +0000 (22:20 +0100)]
Merge commit 'lamby/master' into merge

* commit 'lamby/master':
  Add fixes for broken prefix_multi_line_string calls.
  Remove unused imports from daklib.
  Use more Pythonic "".join over str.join

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoAdd fixes for broken prefix_multi_line_string calls.
Chris Lamb [Tue, 27 Oct 2009 21:19:33 +0000 (21:19 +0000)]
Add fixes for broken prefix_multi_line_string calls.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoPASS
Mark Hymers [Tue, 27 Oct 2009 21:05:24 +0000 (21:05 +0000)]
PASS

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agoMerge branch 'master' of ries.debian.org:/srv/ftp.debian.org/git/dak
Chris Lamb [Tue, 27 Oct 2009 21:04:44 +0000 (21:04 +0000)]
Merge branch 'master' of ries.debian.org:/srv/ftp.debian.org/git/dak

* 'master' of ries.debian.org:/srv/ftp.debian.org/git/dak:
  Disable check_lintian for now.
  clean-queues: Add proper logging
  Only lintian reject uploads to unstable or experimental
  Fix use of "wayout" name.
  dict[k] raises IndexError if does not exist - check with infix 'in' instead.
  Actually add a seperator to our --tags-from-file input.
  lintian YAML has a "lintian" root element.
  Close sourcefile.
  Dedent again by returning if lintian doesn't return any content.
  Return all the lintian-related rejections, not just the first one.
  It's called 'next', not 'continue'. =)
  Dedent again by using continue.
  Remove one level of indentation by using continue
  Simple check for lintian regex
  Use set() instead of Perlesque hash[key] = 1
  autoreject
  Add lintian tags file

15 years agoMerge branch 'master' into merge
Joerg Jaspert [Tue, 27 Oct 2009 20:48:23 +0000 (21:48 +0100)]
Merge branch 'master' into merge

* master:
  let's not reset last_used every time...
  old

15 years agoMerge commit 'djpig/djpig' into merge
Joerg Jaspert [Tue, 27 Oct 2009 20:48:13 +0000 (21:48 +0100)]
Merge commit 'djpig/djpig' into merge

* commit 'djpig/djpig':
  clean-queues: Add proper logging
  use the id, not the object
  add regex import
  file -> f
  we're already in the changes object
  use isinstance
  fixup

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoMerge branch 'master' of ssh://ftp-master.debian.org/srv/ftp.debian.org/git/dak
Joerg Jaspert [Tue, 27 Oct 2009 20:46:57 +0000 (21:46 +0100)]
Merge branch 'master' of ssh://ftp-master.debian.org/srv/ftp.debian.org/git/dak

* 'master' of ssh://ftp-master.debian.org/srv/ftp.debian.org/git/dak:
  let's not reset last_used every time...

15 years agoMerge branch 'merge'
Joerg Jaspert [Tue, 27 Oct 2009 20:46:42 +0000 (21:46 +0100)]
Merge branch 'merge'

* merge:
  Disable check_lintian for now.
  Only lintian reject uploads to unstable or experimental
  Fix use of "wayout" name.
  dict[k] raises IndexError if does not exist - check with infix 'in' instead.
  Actually add a seperator to our --tags-from-file input.
  lintian YAML has a "lintian" root element.
  Close sourcefile.
  Dedent again by returning if lintian doesn't return any content.
  Return all the lintian-related rejections, not just the first one.
  It's called 'next', not 'continue'. =)
  Dedent again by using continue.
  Remove one level of indentation by using continue
  Simple check for lintian regex
  Use set() instead of Perlesque hash[key] = 1
  autoreject
  Add lintian tags file

15 years agoMerge commit 'lamby/lintian_autoreject' into merge
Joerg Jaspert [Tue, 27 Oct 2009 20:46:30 +0000 (21:46 +0100)]
Merge commit 'lamby/lintian_autoreject' into merge

* commit 'lamby/lintian_autoreject':
  Disable check_lintian for now.
  Only lintian reject uploads to unstable or experimental
  Fix use of "wayout" name.
  dict[k] raises IndexError if does not exist - check with infix 'in' instead.
  Actually add a seperator to our --tags-from-file input.
  lintian YAML has a "lintian" root element.
  Close sourcefile.
  Dedent again by returning if lintian doesn't return any content.
  Return all the lintian-related rejections, not just the first one.
  It's called 'next', not 'continue'. =)
  Dedent again by using continue.
  Remove one level of indentation by using continue
  Simple check for lintian regex
  Use set() instead of Perlesque hash[key] = 1
  autoreject
  Add lintian tags file

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoDisable check_lintian for now.
Chris Lamb [Tue, 27 Oct 2009 20:38:34 +0000 (20:38 +0000)]
Disable check_lintian for now.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoclean-queues: Add proper logging
Frank Lichtenheld [Tue, 27 Oct 2009 20:28:53 +0000 (20:28 +0000)]
clean-queues: Add proper logging

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoMerge branch 'master' of ries.debian.org:/srv/ftp.debian.org/git/dak
Chris Lamb [Tue, 27 Oct 2009 20:37:50 +0000 (20:37 +0000)]
Merge branch 'master' of ries.debian.org:/srv/ftp.debian.org/git/dak

* 'master' of ries.debian.org:/srv/ftp.debian.org/git/dak:
  let's not reset last_used every time...
  old
  use the id, not the object
  add regex import
  clean-suites: Remove trailing whitespace
  file -> f
  we're already in the changes object
  use isinstance
  fixup
  clean-suites: Fix logic error in during source cleaning
  clean-suites: Fix SQLA usage
  Fix SQL syntax errors
  clean-suites: Use utils.warn for warnings about orphaned files
  clean-suites: Add proper logging
  daklog: Add username in every log line

15 years agolet's not reset last_used every time...
Mark Hymers [Tue, 27 Oct 2009 20:27:13 +0000 (20:27 +0000)]
let's not reset last_used every time...

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agoOnly lintian reject uploads to unstable or experimental
Chris Lamb [Tue, 27 Oct 2009 20:17:52 +0000 (20:17 +0000)]
Only lintian reject uploads to unstable or experimental

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoFix use of "wayout" name.
Chris Lamb [Tue, 27 Oct 2009 20:02:53 +0000 (20:02 +0000)]
Fix use of "wayout" name.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agodict[k] raises IndexError if does not exist - check with infix 'in' instead.
Chris Lamb [Tue, 27 Oct 2009 20:02:27 +0000 (20:02 +0000)]
dict[k] raises IndexError if does not exist - check with infix 'in' instead.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoActually add a seperator to our --tags-from-file input.
Chris Lamb [Tue, 27 Oct 2009 19:53:15 +0000 (19:53 +0000)]
Actually add a seperator to our --tags-from-file input.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agolintian YAML has a "lintian" root element.
Chris Lamb [Tue, 27 Oct 2009 19:52:54 +0000 (19:52 +0000)]
lintian YAML has a "lintian" root element.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoold
Joerg Jaspert [Tue, 27 Oct 2009 19:57:09 +0000 (20:57 +0100)]
old

removing a check against an AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAANCIENT dpkg version

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoClose sourcefile.
Chris Lamb [Tue, 27 Oct 2009 19:42:02 +0000 (19:42 +0000)]
Close sourcefile.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoDedent again by returning if lintian doesn't return any content.
Chris Lamb [Tue, 27 Oct 2009 19:44:29 +0000 (19:44 +0000)]
Dedent again by returning if lintian doesn't return any content.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoReturn all the lintian-related rejections, not just the first one.
Chris Lamb [Tue, 27 Oct 2009 19:41:13 +0000 (19:41 +0000)]
Return all the lintian-related rejections, not just the first one.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoIt's called 'next', not 'continue'. =)
Chris Lamb [Tue, 27 Oct 2009 19:38:49 +0000 (19:38 +0000)]
It's called 'next', not 'continue'. =)

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoDedent again by using continue.
Chris Lamb [Tue, 27 Oct 2009 19:38:18 +0000 (19:38 +0000)]
Dedent again by using continue.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoRemove one level of indentation by using continue
Chris Lamb [Tue, 27 Oct 2009 19:37:44 +0000 (19:37 +0000)]
Remove one level of indentation by using continue

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoSimple check for lintian regex
Chris Lamb [Tue, 27 Oct 2009 19:43:57 +0000 (19:43 +0000)]
Simple check for lintian regex

15 years agouse the id, not the object
Mark Hymers [Tue, 27 Oct 2009 19:43:32 +0000 (19:43 +0000)]
use the id, not the object

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agoUse set() instead of Perlesque hash[key] = 1
Chris Lamb [Tue, 27 Oct 2009 19:36:51 +0000 (19:36 +0000)]
Use set() instead of Perlesque hash[key] = 1

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoadd regex import
Mark Hymers [Tue, 27 Oct 2009 19:34:28 +0000 (19:34 +0000)]
add regex import

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agoMerge branch 'merge'
Joerg Jaspert [Tue, 27 Oct 2009 16:51:01 +0000 (17:51 +0100)]
Merge branch 'merge'

* merge:
  clean-suites: Remove trailing whitespace
  clean-suites: Fix logic error in during source cleaning
  clean-suites: Fix SQLA usage
  Fix SQL syntax errors
  clean-suites: Use utils.warn for warnings about orphaned files
  clean-suites: Add proper logging
  daklog: Add username in every log line

15 years agoMerge commit 'djpig/djpig' into merge
Joerg Jaspert [Tue, 27 Oct 2009 16:50:53 +0000 (17:50 +0100)]
Merge commit 'djpig/djpig' into merge

* commit 'djpig/djpig':
  clean-suites: Remove trailing whitespace
  clean-suites: Fix logic error in during source cleaning
  clean-suites: Fix SQLA usage
  Fix SQL syntax errors
  clean-suites: Use utils.warn for warnings about orphaned files
  clean-suites: Add proper logging
  daklog: Add username in every log line

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoclean-suites: Remove trailing whitespace
Frank Lichtenheld [Tue, 27 Oct 2009 16:43:25 +0000 (16:43 +0000)]
clean-suites: Remove trailing whitespace

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoRemove unused imports from daklib.
Chris Lamb [Tue, 27 Oct 2009 16:35:26 +0000 (16:35 +0000)]
Remove unused imports from daklib.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoMerge branch 'merge'
Joerg Jaspert [Tue, 27 Oct 2009 16:28:57 +0000 (17:28 +0100)]
Merge branch 'merge'

* merge:
  Monkeypatch commands.getstatusoutput to work around Python Popen issue.
  drop unused imports

15 years agoMerge commit 'lamby/master' into merge
Joerg Jaspert [Tue, 27 Oct 2009 16:28:44 +0000 (17:28 +0100)]
Merge commit 'lamby/master' into merge

* commit 'lamby/master':
  Monkeypatch commands.getstatusoutput to work around Python Popen issue.
  drop unused imports

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoUse more Pythonic "".join over str.join
Chris Lamb [Tue, 27 Oct 2009 16:28:44 +0000 (16:28 +0000)]
Use more Pythonic "".join over str.join

15 years agoMonkeypatch commands.getstatusoutput to work around Python Popen issue.
Chris Lamb [Tue, 27 Oct 2009 16:26:26 +0000 (16:26 +0000)]
Monkeypatch commands.getstatusoutput to work around Python Popen issue.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agodrop unused imports
Chris Lamb [Tue, 27 Oct 2009 16:20:27 +0000 (16:20 +0000)]
drop unused imports

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agofile -> f
Mark Hymers [Tue, 27 Oct 2009 15:35:15 +0000 (15:35 +0000)]
file -> f

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agowe're already in the changes object
Mark Hymers [Tue, 27 Oct 2009 15:33:09 +0000 (15:33 +0000)]
we're already in the changes object

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agouse isinstance
Mark Hymers [Tue, 27 Oct 2009 15:32:34 +0000 (15:32 +0000)]
use isinstance

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agofixup
Mark Hymers [Tue, 27 Oct 2009 15:28:20 +0000 (15:28 +0000)]
fixup

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agoMerge commit 'lamby/master' into merge
Joerg Jaspert [Tue, 27 Oct 2009 15:26:20 +0000 (16:26 +0100)]
Merge commit 'lamby/master' into merge

* commit 'lamby/master':
  If positional argument is None, modify it.s

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoIf positional argument is None, modify it.s
Chris Lamb [Tue, 27 Oct 2009 15:26:01 +0000 (15:26 +0000)]
If positional argument is None, modify it.s

15 years agoMerge commit 'lamby/master' into merge
Joerg Jaspert [Tue, 27 Oct 2009 15:19:27 +0000 (16:19 +0100)]
Merge commit 'lamby/master' into merge

* commit 'lamby/master':
  If None is passed in.
  let there be referential integrity

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoIf None is passed in.
Chris Lamb [Tue, 27 Oct 2009 15:18:11 +0000 (15:18 +0000)]
If None is passed in.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agolet there be referential integrity
Mark Hymers [Tue, 27 Oct 2009 15:12:14 +0000 (15:12 +0000)]
let there be referential integrity

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agoclean-suites: Fix logic error in during source cleaning
Frank Lichtenheld [Tue, 27 Oct 2009 15:02:18 +0000 (15:02 +0000)]
clean-suites: Fix logic error in during source cleaning

We need to remove all the entries in dsc_files(sic) for a given
source before we can remove the source.

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoMerge commit 'lamby/deb-src-3.0-sqla' into merge
Joerg Jaspert [Tue, 27 Oct 2009 14:57:08 +0000 (15:57 +0100)]
Merge commit 'lamby/deb-src-3.0-sqla' into merge

* commit 'lamby/deb-src-3.0-sqla':
  Add missing for loop.

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoAdd missing for loop.
Chris Lamb [Tue, 27 Oct 2009 14:55:35 +0000 (14:55 +0000)]
Add missing for loop.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoMerge commit 'lamby/deb-src-3.0-sqla' into merge
Joerg Jaspert [Tue, 27 Oct 2009 14:54:24 +0000 (15:54 +0100)]
Merge commit 'lamby/deb-src-3.0-sqla' into merge

* commit 'lamby/deb-src-3.0-sqla':
  This is SQL, not Python.

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoThis is SQL, not Python.
Chris Lamb [Tue, 27 Oct 2009 14:53:01 +0000 (14:53 +0000)]
This is SQL, not Python.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoMerge commit 'lamby/deb-src-3.0-sqla' into merge
Joerg Jaspert [Tue, 27 Oct 2009 14:51:48 +0000 (15:51 +0100)]
Merge commit 'lamby/deb-src-3.0-sqla' into merge

* commit 'lamby/deb-src-3.0-sqla':
  Use the format id. not its name.
  Interpolate values properly.

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoUse the format id. not its name.
Chris Lamb [Tue, 27 Oct 2009 14:51:21 +0000 (14:51 +0000)]
Use the format id. not its name.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoInterpolate values properly.
Chris Lamb [Tue, 27 Oct 2009 14:50:49 +0000 (14:50 +0000)]
Interpolate values properly.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoMerge commit 'lamby/deb-src-3.0-sqla' into merge
Joerg Jaspert [Tue, 27 Oct 2009 14:47:18 +0000 (15:47 +0100)]
Merge commit 'lamby/deb-src-3.0-sqla' into merge

* commit 'lamby/deb-src-3.0-sqla':
  Actually select some rows.

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoActually select some rows.
Chris Lamb [Tue, 27 Oct 2009 14:44:57 +0000 (14:44 +0000)]
Actually select some rows.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoMerge commit 'lamby/deb-src-3.0-sqla' into merge
Joerg Jaspert [Tue, 27 Oct 2009 14:41:19 +0000 (15:41 +0100)]
Merge commit 'lamby/deb-src-3.0-sqla' into merge

* commit 'lamby/deb-src-3.0-sqla': (29 commits)
  Drop lzma support.
  Only enable not-"1.0" formats on t-p-u and unstable and experimental.
  Reject uploads that contain a native tarball and a diff.
  dak heresy
  Fix reference to cls.requires.
  Add unittest.main() to test_regexes.
  Add shebang to regex tests.
  Simplify rejecting logic
  Avoid if/elif/elif.. with lookup table.
  Use loop to check for illegal duplication of file types in .dsc
  Use a collections.defaultdict to avoid boilerplate definitions.
  Correct grammar when rejecting a package with insufficient files.
  Require source formats to have a name and interpolate it when returning msgs
  Compare with None using "is", not "=="
  Remove has_ prefix inside srcformats.
  Don't pass dsc_filename to reject_msgs; prepend it in check_dsc_files.
  Move rejection message generation into srcformats
  Add regex to match .dsc "Format: lala" value and compile it on creation.
  Add SourceFormat class and track definitions with metaclass
  Make dbconn.get_suite_src_formats use @session_wrapper.
  ...

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoDrop lzma support.
Chris Lamb [Tue, 27 Oct 2009 14:40:49 +0000 (14:40 +0000)]
Drop lzma support.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoOnly enable not-"1.0" formats on t-p-u and unstable and experimental.
Chris Lamb [Tue, 27 Oct 2009 14:40:15 +0000 (14:40 +0000)]
Only enable not-"1.0" formats on t-p-u and unstable and experimental.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoclean-suites: Fix SQLA usage
Frank Lichtenheld [Tue, 27 Oct 2009 14:37:23 +0000 (14:37 +0000)]
clean-suites: Fix SQLA usage

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoFix SQL syntax errors
Frank Lichtenheld [Tue, 27 Oct 2009 14:28:04 +0000 (14:28 +0000)]
Fix SQL syntax errors

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoclean-suites: Use utils.warn for warnings about orphaned files
Frank Lichtenheld [Tue, 27 Oct 2009 14:27:30 +0000 (14:27 +0000)]
clean-suites: Use utils.warn for warnings about orphaned files

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoMerge branch 'master' into deb-src-3.0-sqla
Chris Lamb [Tue, 27 Oct 2009 14:25:37 +0000 (14:25 +0000)]
Merge branch 'master' into deb-src-3.0-sqla

* master:
  Use session.commit_or_flush in some more functions.
  Attach commit_or_flush to session object to call either .commit() or .flush()
  Add doc for session_wrapper.
  process-new: Fix BCC and X-Katie handling
  Fix various small bugs
  Re-enable BXA notifications
  queue: Fix typo
  Convert process_new to new APIs
  Print a warning if a trainee tries to do something he's not allowed to do
  Documentation fixes

Conflicts:
daklib/queue.py

15 years agoMerge commit 'lamby/master' into merge
Joerg Jaspert [Tue, 27 Oct 2009 14:09:16 +0000 (15:09 +0100)]
Merge commit 'lamby/master' into merge

* commit 'lamby/master':
  Use session.commit_or_flush in some more functions.
  Attach commit_or_flush to session object to call either .commit() or .flush()
  Add doc for session_wrapper.

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoautoreject
Joerg Jaspert [Tue, 27 Oct 2009 14:08:09 +0000 (15:08 +0100)]
autoreject

add a lintian autoreject function

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoclean-suites: Add proper logging
Frank Lichtenheld [Tue, 27 Oct 2009 14:06:21 +0000 (14:06 +0000)]
clean-suites: Add proper logging

Also move some SQL queries to ORM API where useful and/or easy.

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agodaklog: Add username in every log line
Frank Lichtenheld [Tue, 27 Oct 2009 14:05:09 +0000 (14:05 +0000)]
daklog: Add username in every log line

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoUse session.commit_or_flush in some more functions.
Chris Lamb [Tue, 27 Oct 2009 09:19:24 +0000 (09:19 +0000)]
Use session.commit_or_flush in some more functions.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoAttach commit_or_flush to session object to call either .commit() or .flush()
Chris Lamb [Tue, 27 Oct 2009 09:19:00 +0000 (09:19 +0000)]
Attach commit_or_flush to session object to call either .commit() or .flush()

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoAdd doc for session_wrapper.
Chris Lamb [Tue, 27 Oct 2009 08:55:06 +0000 (08:55 +0000)]
Add doc for session_wrapper.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoReject uploads that contain a native tarball and a diff.
Chris Lamb [Tue, 27 Oct 2009 13:30:29 +0000 (13:30 +0000)]
Reject uploads that contain a native tarball and a diff.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agodak heresy
Chris Lamb [Tue, 27 Oct 2009 13:29:51 +0000 (13:29 +0000)]
dak heresy

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoFix reference to cls.requires.
Chris Lamb [Tue, 27 Oct 2009 13:06:15 +0000 (13:06 +0000)]
Fix reference to cls.requires.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoAdd unittest.main() to test_regexes.
Chris Lamb [Tue, 27 Oct 2009 13:00:50 +0000 (13:00 +0000)]
Add unittest.main() to test_regexes.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoAdd shebang to regex tests.
Chris Lamb [Tue, 27 Oct 2009 11:57:56 +0000 (11:57 +0000)]
Add shebang to regex tests.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoSimplify rejecting logic
Chris Lamb [Tue, 27 Oct 2009 11:51:40 +0000 (11:51 +0000)]
Simplify rejecting logic

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoAvoid if/elif/elif.. with lookup table.
Chris Lamb [Tue, 27 Oct 2009 11:11:05 +0000 (11:11 +0000)]
Avoid if/elif/elif.. with lookup table.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoUse loop to check for illegal duplication of file types in .dsc
Chris Lamb [Tue, 27 Oct 2009 10:56:45 +0000 (10:56 +0000)]
Use loop to check for illegal duplication of file types in .dsc

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoUse a collections.defaultdict to avoid boilerplate definitions.
Chris Lamb [Tue, 27 Oct 2009 10:52:33 +0000 (10:52 +0000)]
Use a collections.defaultdict to avoid boilerplate definitions.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoCorrect grammar when rejecting a package with insufficient files.
Chris Lamb [Tue, 27 Oct 2009 10:41:14 +0000 (10:41 +0000)]
Correct grammar when rejecting a package with insufficient files.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoRequire source formats to have a name and interpolate it when returning msgs
Chris Lamb [Tue, 27 Oct 2009 10:40:10 +0000 (10:40 +0000)]
Require source formats to have a name and interpolate it when returning msgs

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoCompare with None using "is", not "=="
Chris Lamb [Tue, 27 Oct 2009 10:36:26 +0000 (10:36 +0000)]
Compare with None using "is", not "=="

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoRemove has_ prefix inside srcformats.
Chris Lamb [Tue, 27 Oct 2009 10:35:22 +0000 (10:35 +0000)]
Remove has_ prefix inside srcformats.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoDon't pass dsc_filename to reject_msgs; prepend it in check_dsc_files.
Chris Lamb [Tue, 27 Oct 2009 10:33:40 +0000 (10:33 +0000)]
Don't pass dsc_filename to reject_msgs; prepend it in check_dsc_files.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoMove rejection message generation into srcformats
Chris Lamb [Tue, 27 Oct 2009 10:31:22 +0000 (10:31 +0000)]
Move rejection message generation into srcformats

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoAdd regex to match .dsc "Format: lala" value and compile it on creation.
Chris Lamb [Tue, 27 Oct 2009 10:28:59 +0000 (10:28 +0000)]
Add regex to match .dsc "Format: lala" value and compile it on creation.

This forces every format to have a regex too as it will blow up otherwise.

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoAdd SourceFormat class and track definitions with metaclass
Chris Lamb [Tue, 27 Oct 2009 10:25:59 +0000 (10:25 +0000)]
Add SourceFormat class and track definitions with metaclass

Signed-off-by: Chris Lamb <lamby@debian.org>
15 years agoAdd lintian tags file
Joerg Jaspert [Tue, 27 Oct 2009 10:15:01 +0000 (11:15 +0100)]
Add lintian tags file

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoMerge commit 'mhy/master' into merge
Joerg Jaspert [Tue, 27 Oct 2009 10:05:04 +0000 (11:05 +0100)]
Merge commit 'mhy/master' into merge

* commit 'mhy/master':
  process-new: Fix BCC and X-Katie handling
  Fix various small bugs
  Re-enable BXA notifications
  queue: Fix typo
  Convert process_new to new APIs
  Print a warning if a trainee tries to do something he's not allowed to do
  Documentation fixes

Signed-off-by: Joerg Jaspert <joerg@debian.org>
15 years agoMerge commit 'djpig/djpig'
Mark Hymers [Tue, 27 Oct 2009 10:04:35 +0000 (10:04 +0000)]
Merge commit 'djpig/djpig'

Conflicts:
daklib/dbconn.py

Signed-off-by: Mark Hymers <mhy@debian.org>
15 years agoprocess-new: Fix BCC and X-Katie handling
Frank Lichtenheld [Tue, 27 Oct 2009 09:57:05 +0000 (09:57 +0000)]
process-new: Fix BCC and X-Katie handling

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoFix various small bugs
Frank Lichtenheld [Tue, 27 Oct 2009 09:56:06 +0000 (09:56 +0000)]
Fix various small bugs

Signed-off-by: Frank Lichtenheld <djpig@debian.org>
15 years agoMake dbconn.get_suite_src_formats use @session_wrapper.
Chris Lamb [Tue, 27 Oct 2009 09:49:00 +0000 (09:49 +0000)]
Make dbconn.get_suite_src_formats use @session_wrapper.

Signed-off-by: Chris Lamb <lamby@debian.org>