]> git.decadent.org.uk Git - dak.git/log
dak.git
16 years agoimplement sensible handling of checksum fields in .changes and .dsc
Philipp Kern [Thu, 28 Aug 2008 20:47:22 +0000 (22:47 +0200)]
implement sensible handling of checksum fields in .changes and .dsc

2008-08-28  Philipp Kern  <pkern@debian.org>

* daklib/utils.py (check_hashes): adapt to different API, check
sizes separately

* daklib/utils.py (parse_changes, parse_deb822): refactor
the string-based logic of parse_changes into a new function
parse_deb822; parse_changes itself remains file-based

* daklib/utils.py (hash_key): gives the key of a hash in the
files dict

* daklib/utils.py (create_hash, check_size): made more readable

* daklib/utils.py (check_hash): just check the hashes and complain
about missing checksums

* daklib/utils.py (check_hash_fields): function to reject unknown
checksums fields

* daklib/utils.py (_ensure_changes_hash, _ensure_dsc_hash): helper
functions for ensure_hashes; check their corresponding manifests'
hashes

* daklib/utils.py (ensure_hashes): retrieve the checksums fields
from the original filecontents blob so that they do not need to
be present in the .dak; refactored the actual checks by calling
the aforementioned helper functions

* daklib/utils.py (parse_checksums): parse a given checksums field
in a manifest and insert the values found into the files dict,
checking the file sizes on the way

16 years agouse correct field names
Mark Hymers [Sat, 16 Aug 2008 04:53:33 +0000 (04:53 +0000)]
use correct field names

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agofix set_files_id routine
Mark Hymers [Sat, 16 Aug 2008 04:51:44 +0000 (04:51 +0000)]
fix set_files_id routine

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoanother attempt to add these damned hashes
Mark Hymers [Sat, 16 Aug 2008 04:16:20 +0000 (04:16 +0000)]
another attempt to add these damned hashes

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoI hate it when Ganneff is right
Mark Hymers [Sat, 16 Aug 2008 03:48:55 +0000 (03:48 +0000)]
I hate it when Ganneff is right

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agodon't assume we can check for the checksums fields
Mark Hymers [Sat, 16 Aug 2008 03:47:16 +0000 (03:47 +0000)]
don't assume we can check for the checksums fields

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agomisc fixes
Mark Hymers [Sat, 16 Aug 2008 03:36:22 +0000 (03:36 +0000)]
misc fixes

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoActually import a module before using it.
Mark Hymers [Sat, 16 Aug 2008 03:22:24 +0000 (03:22 +0000)]
Actually import a module before using it.

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoactually check the type of basedict before trying to use it
Mark Hymers [Sat, 16 Aug 2008 03:20:19 +0000 (03:20 +0000)]
actually check the type of basedict before trying to use it

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agorevert change to get_files_id
Mark Hymers [Sat, 16 Aug 2008 03:14:11 +0000 (03:14 +0000)]
revert change to get_files_id

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoexpand check_archive.py to cope with extra checksums
Mark Hymers [Sat, 16 Aug 2008 02:01:47 +0000 (02:01 +0000)]
expand check_archive.py to cope with extra checksums

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoadd changelog to keep Ganneff happy
Mark Hymers [Sat, 16 Aug 2008 01:50:26 +0000 (01:50 +0000)]
add changelog to keep Ganneff happy

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoadd sha1sum and sha256sum columns
Mark Hymers [Sat, 16 Aug 2008 01:50:15 +0000 (01:50 +0000)]
add sha1sum and sha256sum columns

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agofix typos
Mark Hymers [Fri, 8 Aug 2008 20:12:38 +0000 (20:12 +0000)]
fix typos

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agomake process accepted not die with old .dak files
Mark Hymers [Fri, 8 Aug 2008 20:10:22 +0000 (20:10 +0000)]
make process accepted not die with old .dak files

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoan attempt to move the functionaliity into a module
Mark Hymers [Fri, 8 Aug 2008 20:10:08 +0000 (20:10 +0000)]
an attempt to move the functionaliity into a module

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agolet's store the known_hashes information centrally
Mark Hymers [Fri, 8 Aug 2008 19:40:22 +0000 (19:40 +0000)]
let's store the known_hashes information centrally

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agofirst attempt at bodging in support for sha1sum and sha256sum
Mark Hymers [Thu, 7 Aug 2008 13:38:38 +0000 (13:38 +0000)]
first attempt at bodging in support for sha1sum and sha256sum

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoWe dont care about the stuff they print out here, we just want the return value....
Joerg Jaspert [Thu, 14 Aug 2008 12:22:59 +0000 (14:22 +0200)]
We dont care about the stuff they print out here, we just want the return value. Remove $(). (Aua)

16 years agoAdded i18n package description sync foo.
Joerg Jaspert [Wed, 13 Aug 2008 23:17:09 +0000 (01:17 +0200)]
Added i18n package description sync foo.

Arf.

16 years ago * config/debian/cron.dinstall: Complicate the i18n export a little
Joerg Jaspert [Tue, 12 Aug 2008 14:12:34 +0000 (16:12 +0200)]
   * config/debian/cron.dinstall: Complicate the i18n export a little
       by using date/hour based directories which we then link into the
       web view. They contain a signed timestamp file now, which means
       the i18n people can take a long time to generate files, yet we
       still know exactly on which dataset their data is based on, and
       can then verify it with that. Ensures we only get descriptions for
       packages we know off (or knew of in the past 2 days).

16 years agoAdd a file
Joerg Jaspert [Mon, 11 Aug 2008 19:03:03 +0000 (21:03 +0200)]
Add a file

16 years agoDamn oldtimers
Joerg Jaspert [Mon, 11 Aug 2008 03:44:14 +0000 (05:44 +0200)]
Damn oldtimers

16 years agoRemove pgp keyring
Joerg Jaspert [Sat, 9 Aug 2008 16:20:55 +0000 (18:20 +0200)]
Remove pgp keyring

16 years agorm md5sum
Joerg Jaspert [Sat, 9 Aug 2008 02:35:16 +0000 (04:35 +0200)]
rm md5sum

16 years agoGenerate the i18n foo
Joerg Jaspert [Sat, 9 Aug 2008 02:32:14 +0000 (04:32 +0200)]
Generate the i18n foo

16 years agoMerge commit 'pkern/master'
Joerg Jaspert [Fri, 8 Aug 2008 18:50:12 +0000 (20:50 +0200)]
Merge commit 'pkern/master'

* commit 'pkern/master':
  dak/process_new.py: fix up binary diversion into various queues
  dak/process_new.py: handle uploads to (oldstable)-proposed-updates differently

16 years agodak/process_new.py: fix up binary diversion into various queues
Philipp Kern [Fri, 8 Aug 2008 15:01:15 +0000 (12:01 -0300)]
dak/process_new.py: fix up binary diversion into various queues

16 years agoCreate a hardlinked tree for the buildds
Joerg Jaspert [Fri, 8 Aug 2008 13:30:46 +0000 (15:30 +0200)]
Create a hardlinked tree for the buildds

16 years agoGah, apt is a piece of shit. Well, it expects the uncompressed
Joerg Jaspert [Fri, 8 Aug 2008 12:24:41 +0000 (12:24 +0000)]
Gah, apt is a piece of shit. Well, it expects the uncompressed
Packages files in the Release file to appear, so lets generate them.
Also make sure we dont have empty release files listed...

16 years agoindicate to britney whether or not the Packages update was successful
Mark Hymers [Fri, 8 Aug 2008 02:21:35 +0000 (02:21 +0000)]
indicate to britney whether or not the Packages update was successful

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoWe also want a -T there, stupid ln, could figure it out itself, never
Joerg Jaspert [Fri, 8 Aug 2008 01:55:33 +0000 (01:55 +0000)]
We also want a -T there, stupid ln, could figure it out itself, never
heard of AI, eh?

16 years agoIm a moron and ln is a pain
Joerg Jaspert [Fri, 8 Aug 2008 01:40:14 +0000 (03:40 +0200)]
Im a moron and ln is a pain

16 years agoAdded signing of buildd incoming
Joerg Jaspert [Thu, 7 Aug 2008 23:06:10 +0000 (01:06 +0200)]
Added signing of buildd incoming

16 years agodak/process_new.py: handle uploads to (oldstable)-proposed-updates differently
Philipp Kern [Thu, 7 Aug 2008 22:57:11 +0000 (19:57 -0300)]
dak/process_new.py: handle uploads to (oldstable)-proposed-updates differently

Uploads targetting proposed-updates used to hit NEW first and were going
to proposed-updates without further review by SRM afterwards.  This patch
fixes this behaviour by sending the upload to p-u-new after NEW processing.

If an upload is sourceful it is moved right away.  If it is not its
corresponding source is searched in p-u holding, new, accepted and
in the archive and moved appropriately into the right queue.

16 years agoAnd another place to kick nfu
Joerg Jaspert [Thu, 7 Aug 2008 14:18:26 +0000 (16:18 +0200)]
And another place to kick nfu

16 years agoFix a number of bugs, some introduced long ago, some introduced yesterday.
Joerg Jaspert [Thu, 7 Aug 2008 14:15:24 +0000 (16:15 +0200)]
Fix a number of bugs, some introduced long ago, some introduced yesterday.

16 years agoAdd changelog entry Signed-off-by: Stephen Gran <steve@lobefin.net>
Stephen Gran [Thu, 7 Aug 2008 01:04:26 +0000 (02:04 +0100)]
Add changelog entry Signed-off-by: Stephen Gran <steve@lobefin.net>

16 years agoThis really does not have to be quite this unreadable Signed-off-by: Stephen Gran...
Stephen Gran [Thu, 7 Aug 2008 00:58:24 +0000 (01:58 +0100)]
This really does not have to be quite this unreadable Signed-off-by: Stephen Gran <steve@lobefin.net>

16 years agoMerge from Joachim
Joerg Jaspert [Wed, 6 Aug 2008 23:20:23 +0000 (01:20 +0200)]
Merge from Joachim

16 years agoError out when we are unable to find a source id for a file we want to install. Shoul...
Joerg Jaspert [Wed, 6 Aug 2008 22:31:06 +0000 (00:31 +0200)]
Error out when we are unable to find a source id for a file we want to install. Shouldnt happen.

16 years agoRemoved ssh-move
Joerg Jaspert [Tue, 5 Aug 2008 17:46:11 +0000 (19:46 +0200)]
Removed ssh-move

16 years agoRemove trailing / from path
Joachim Breitner [Tue, 5 Aug 2008 15:46:57 +0000 (12:46 -0300)]
Remove trailing / from path

16 years agoGet wanna-build-database in cron.weekly
Joachim Breitner [Tue, 5 Aug 2008 15:43:15 +0000 (12:43 -0300)]
Get wanna-build-database in cron.weekly

Add a script to fetch the wanna-build-database from
http://buildd.debian.org/stats/, call this script from cron.weekly, and
document this change in the ChangeLog.

16 years agoChange wanna-build-dump path
Joachim Breitner [Tue, 5 Aug 2008 15:42:07 +0000 (12:42 -0300)]
Change wanna-build-dump path

...to /srv/ftp.debian.org/scripts/nfu/, as requested

16 years agoWarn about missing wanna-build dumps
Joachim Breitner [Tue, 5 Aug 2008 15:36:46 +0000 (12:36 -0300)]
Warn about missing wanna-build dumps

armel is actually available, but the script should still not fail
for missing wanna build dumps, but print warnings.

16 years agoReplace a 128 line NIH syndrom with one of those new-fangled sarge-and-later options...
Joerg Jaspert [Tue, 5 Aug 2008 15:21:29 +0000 (17:21 +0200)]
Replace a 128 line NIH syndrom with one of those new-fangled sarge-and-later options in rsync :)

16 years agoDeactivate the ssh-move
Joerg Jaspert [Tue, 5 Aug 2008 01:42:47 +0000 (03:42 +0200)]
Deactivate the ssh-move

16 years agoAdd Not-For-Us checking to cruft_report
Joachim Breitner [Mon, 4 Aug 2008 23:07:01 +0000 (20:07 -0300)]
Add Not-For-Us checking to cruft_report

This patch reports all binary packages that are out of date on
an architecture where the buildd admin has marked it as Not-For-Us.

It needs a copy of http://buildd.debian.org/stats/*-all.txt somewhere.
This somewhere is configurable by a configuration/command-line flag.

The report, named "nfu", is added to the "full" set of reports.

16 years agowording change
Mark Hymers [Sun, 3 Aug 2008 18:56:46 +0000 (18:56 +0000)]
wording change

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoadd changelog entry for jvw's patch
Mark Hymers [Sun, 3 Aug 2008 18:38:33 +0000 (18:38 +0000)]
add changelog entry for jvw's patch

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agomerge Jeroen's lisa_existing_sources_first_and_mtime patch
Mark Hymers [Sat, 2 Aug 2008 23:14:07 +0000 (23:14 +0000)]
merge Jeroen's lisa_existing_sources_first_and_mtime patch

Signed-off-by: Mark Hymers <mhy@debian.org>
16 years agoAdd patch by luk from #438899
Joerg Jaspert [Sat, 26 Jul 2008 10:10:49 +0000 (12:10 +0200)]
Add patch by luk from #438899

16 years agois r4 now (do we need this still?)
Joerg Jaspert [Sat, 26 Jul 2008 09:28:05 +0000 (11:28 +0200)]
is r4 now (do we need this still?)

16 years agono m68k in testing, so not mentioning it for t-p-u
Joerg Jaspert [Fri, 25 Jul 2008 22:41:29 +0000 (00:41 +0200)]
no m68k in testing, so not mentioning it for t-p-u

16 years agocatch more UnknownFormatError
Thomas Viehmann [Thu, 19 Jun 2008 19:05:54 +0000 (19:05 +0000)]
catch more UnknownFormatError

16 years agoIts dsc_filename
Joerg Jaspert [Thu, 19 Jun 2008 18:50:52 +0000 (20:50 +0200)]
Its dsc_filename

16 years agocatch UnknownFormatError in process-unchecked/check_dsc
Thomas Viehmann [Thu, 19 Jun 2008 18:20:02 +0000 (18:20 +0000)]
catch UnknownFormatError in process-unchecked/check_dsc

16 years agoWork around a git bug
Joerg Jaspert [Sun, 15 Jun 2008 21:10:31 +0000 (23:10 +0200)]
Work around a git bug

16 years agodebianqueued: Fix a brown-paper-bag bug (we just dont know who to assign tthe month...
Joerg Jaspert [Sun, 15 Jun 2008 20:40:55 +0000 (22:40 +0200)]
debianqueued: Fix a brown-paper-bag bug (we just dont know who to assign tthe month name.he bag too). strftime %b is better than %B for

16 years agoTo avoid dangling current symlink and have the latest dump easily readable - compress...
Joerg Jaspert [Sun, 15 Jun 2008 01:36:09 +0000 (03:36 +0200)]
To avoid dangling current symlink and have the latest dump easily readable - compress only psql dumps older than a day, ie keep todays ones uncompressed

16 years agoIgnore if ldap server is down
Joerg Jaspert [Sat, 14 Jun 2008 23:51:49 +0000 (01:51 +0200)]
Ignore if ldap server is down

16 years agoFix my mail address. Contrary to common belief i am not ganneff@debian.org :)
Joerg Jaspert [Sat, 14 Jun 2008 23:50:13 +0000 (01:50 +0200)]
Fix my mail address. Contrary to common belief i am not ganneff@debian.org :)

16 years agos/troup/dak/
Joerg Jaspert [Sat, 14 Jun 2008 23:37:01 +0000 (01:37 +0200)]
s/troup/dak/

16 years agoMake the ssh calls a bit more robust
Joerg Jaspert [Sat, 14 Jun 2008 23:34:18 +0000 (01:34 +0200)]
Make the ssh calls a bit more robust

16 years agoUpdated mailinglist location
Joerg Jaspert [Sat, 14 Jun 2008 23:06:06 +0000 (01:06 +0200)]
Updated mailinglist location

16 years agoMerge branch 'master' of git://git.debian.org/git/users/otavio/dak into small_fixes
Joerg Jaspert [Sat, 14 Jun 2008 22:32:42 +0000 (00:32 +0200)]
Merge branch 'master' of git://git.debian.org/git/users/otavio/dak into small_fixes

* 'master' of git://git.debian.org/git/users/otavio/dak:
  docs/manpages/clean-suites.1.sgml: Minor typo fix
  dak/import_archive.py: Add support to udeb packages
  dak/control_suite.py (main): Handle SystemError exception in case of a incompatible commandline parameter
  dak/check_overrides.py (main): Use case-insensitive comparing for codename

16 years ago docs/manpages/clean-suites.1.sgml: Minor typo fix
Otavio Salvador [Sat, 14 Jun 2008 18:19:37 +0000 (15:19 -0300)]
 docs/manpages/clean-suites.1.sgml: Minor typo fix

16 years agodak/import_archive.py: Add support to udeb packages
Otavio Salvador [Sat, 14 Jun 2008 18:11:31 +0000 (15:11 -0300)]
dak/import_archive.py: Add support to udeb packages

16 years agodak/control_suite.py (main): Handle SystemError exception in case of a incompatible...
Otavio Salvador [Sat, 14 Jun 2008 18:00:41 +0000 (15:00 -0300)]
dak/control_suite.py (main): Handle SystemError exception in case of a incompatible commandline parameter

16 years agodak/check_overrides.py (main): Use case-insensitive comparing for codename
Otavio Salvador [Sat, 14 Jun 2008 17:56:02 +0000 (14:56 -0300)]
dak/check_overrides.py (main): Use case-insensitive comparing for codename

16 years agoAdd a note that people should use dcut for commands files
Joerg Jaspert [Sat, 14 Jun 2008 18:15:47 +0000 (20:15 +0200)]
Add a note that people should use dcut for commands files

16 years agoMerged a patch from Frans Pop making byhand-task fail on uploads to anything other...
Joerg Jaspert [Sat, 14 Jun 2008 17:48:06 +0000 (19:48 +0200)]
Merged a patch from Frans Pop making byhand-task fail on uploads to anything other than sid

16 years agoRemove .bzrignore and do a little git housekeeping in cron.weekly
Joerg Jaspert [Sat, 14 Jun 2008 16:05:29 +0000 (18:05 +0200)]
Remove .bzrignore and do a little git housekeeping in cron.weekly

16 years agoAdd batchmode and also Connect/SetupTimeout parameters to ssh
Joerg Jaspert [Sat, 14 Jun 2008 15:52:27 +0000 (17:52 +0200)]
Add batchmode and also Connect/SetupTimeout parameters to ssh

16 years agoAdd a gitignore file and also the daklib symlink we basically always use anyways
Joerg Jaspert [Sat, 14 Jun 2008 15:47:47 +0000 (17:47 +0200)]
Add a gitignore file and also the daklib symlink we basically always use anyways

16 years agoCompress all pgsql backups
Joerg Jaspert [Sat, 14 Jun 2008 15:02:25 +0000 (17:02 +0200)]
Compress all pgsql backups

16 years agoMerge from otavio
Joerg Jaspert [Sat, 7 Jun 2008 23:22:16 +0000 (01:22 +0200)]
Merge from otavio

16 years agoMerge from otavio
Joerg Jaspert [Sat, 7 Jun 2008 23:22:01 +0000 (01:22 +0200)]
Merge from otavio

16 years agoLowercase urgency a little earlier
Joerg Jaspert [Sat, 7 Jun 2008 23:18:40 +0000 (01:18 +0200)]
Lowercase urgency a little earlier

16 years ago* daklib/queue.py (check_valid): allow debian-installer specific sources to have...
Otavio Salvador [Mon, 2 Jun 2008 02:16:25 +0000 (23:16 -0300)]
* daklib/queue.py (check_valid): allow debian-installer specific sources to have 'debian-installer' section.

16 years agoMerge autobyhand for tasks
Joerg Jaspert [Thu, 29 May 2008 21:12:26 +0000 (23:12 +0200)]
Merge autobyhand for tasks

16 years agoMerge autobyhand change from frans
Joerg Jaspert [Thu, 29 May 2008 21:11:41 +0000 (23:11 +0200)]
Merge autobyhand change from frans

16 years agoAdd autobyhand support for task overrides (from tasksel)
Frans Pop [Wed, 28 May 2008 16:32:00 +0000 (18:32 +0200)]
Add autobyhand support for task overrides (from tasksel)

16 years agoChange ftp.debian.org pseudopackage maintainer name.
Joerg Jaspert [Tue, 27 May 2008 19:16:39 +0000 (21:16 +0200)]
Change ftp.debian.org pseudopackage maintainer name.

16 years agoMerge transitions fix to work around a syck dump bug
Joerg Jaspert [Mon, 12 May 2008 12:14:14 +0000 (14:14 +0200)]
Merge transitions fix to work around a syck dump bug

16 years agoAlso replace dump
Joerg Jaspert [Mon, 12 May 2008 12:06:28 +0000 (14:06 +0200)]
Also replace dump

16 years agoFix yaml dump bug in syck by using yaml instead
Joerg Jaspert [Mon, 12 May 2008 11:34:17 +0000 (13:34 +0200)]
Fix yaml dump bug in syck by using yaml instead

16 years agoMerge from sgran, so we add the date header, as the exim setup debian uses doesnt...
Joerg Jaspert [Sat, 10 May 2008 20:17:57 +0000 (22:17 +0200)]
Merge from sgran, so we add the date header, as the exim setup debian uses doesnt do that for us

16 years agoAdd Date: header manually
Stephen Gran [Sat, 10 May 2008 20:00:52 +0000 (21:00 +0100)]
Add Date: header manually

16 years agoMerge mailtags again
Joerg Jaspert [Sat, 10 May 2008 18:43:10 +0000 (20:43 +0200)]
Merge mailtags again

16 years agoMerge from sgran
Joerg Jaspert [Sat, 10 May 2008 18:42:50 +0000 (20:42 +0200)]
Merge from sgran

16 years agoReadd 'Archive Administrator' at Ganneff's request (picky, picky, picky)
Stephen Gran [Sat, 10 May 2008 18:38:54 +0000 (19:38 +0100)]
Readd 'Archive Administrator' at Ganneff's request (picky, picky, picky)

16 years agoQuiet perl warnings. Ganneff: this means changing config - I tried to stay
Stephen Gran [Sat, 10 May 2008 18:08:15 +0000 (19:08 +0100)]
Quiet perl warnings.  Ganneff: this means changing config - I tried to stay
away from that the first time around, since I wanted to ignore some values
that no longer matter, but now I'm reusing them so we don't get 'variable
only used once' warnings.

16 years agoMerge mailtags
Joerg Jaspert [Sat, 10 May 2008 17:54:08 +0000 (19:54 +0200)]
Merge mailtags

16 years agoMerge from sgran
Joerg Jaspert [Sat, 10 May 2008 17:53:49 +0000 (19:53 +0200)]
Merge from sgran

16 years agoReadd signature, and use tabs like the rest of the script
Stephen Gran [Sat, 10 May 2008 17:43:11 +0000 (18:43 +0100)]
Readd signature, and use tabs like the rest of the script

16 years agoSigh, I should test a bit more thoroughly occasionally
Stephen Gran [Sat, 10 May 2008 16:42:25 +0000 (17:42 +0100)]
Sigh, I should test a bit more thoroughly occasionally

16 years agoUpdate debian/control to reflect new perl dependency
Stephen Gran [Sat, 10 May 2008 14:40:26 +0000 (15:40 +0100)]
Update debian/control to reflect new perl dependency

16 years agoAvoid possible undefined variable complaint with length function.
Stephen Gran [Sat, 10 May 2008 14:37:50 +0000 (15:37 +0100)]
Avoid possible undefined variable complaint with length function.