Merge commit 'lamby/master' into merge

* commit 'lamby/master':
  Alter get_maintainer API to return Maintainer object or None
  Fix get_maintainer

Signed-off-by: Joerg Jaspert <joerg@debian.org>

diff --git a/dak/rm.py b/dak/rm.py
index 1b6dfe1f4aaa4788993a23ca23283fe25210bcb4..c2a07e8ae1e800a183e5b75a772fbd596261b2ed 100755 (executable)
--- a/dak/rm.py
+++ b/dak/rm.py
@@ -457,7 +457,7 @@ def main ():
 
     maintainer_list = []
     for maintainer_id in maintainers.keys():
-        maintainer_list.append(get_maintainer(maintainer_id))
+        maintainer_list.append(get_maintainer(maintainer_id).name)
     summary = ""
     removals = d.keys()
     removals.sort()

diff --git a/daklib/dbconn.py b/daklib/dbconn.py
index b63b4a9380d1fed873d0031e25dd1286e08055cc..23aeda6fdad5ae52109eac5fb4f5989d2eb28463 100755 (executable)
--- a/daklib/dbconn.py
+++ b/daklib/dbconn.py
@@ -1095,15 +1095,16 @@ def get_or_set_maintainer(name, session=None):
 
 __all__.append('get_or_set_maintainer')
 
-def get_maintainer(maintainer_id, session=True):
+def get_maintainer(maintainer_id, session=None):
     """
-    Return the name of the maintainer behind C{maintainer_id}.
+    Return the name of the maintainer behind C{maintainer_id} or None if that
+    maintainer_id is invalid.
 
     @type maintainer_id: int
     @param maintainer_id: the id of the maintainer
 
-    @rtype: string
-    @return: the name of the maintainer
+    @rtype: Maintainer
+    @return: the Maintainer with this C{maintainer_id}
     """
 
     privatetrans = False
@@ -1112,7 +1113,7 @@ def get_maintainer(maintainer_id, session=True):
         privatetrans = True
 
     try:
-        return session.query(Maintainer).get(maintainer_id).name
+        return session.query(Maintainer).get(maintainer_id)
     finally:
         if privatetrans:
             session.close()