]> git.decadent.org.uk Git - nfs-utils.git/commit
mount.nfs: No need to return nfs_mount_data structs
authorChuck Lever <chuck.lever@oracle.com>
Mon, 16 Jul 2007 20:29:01 +0000 (16:29 -0400)
committerNeil Brown <neilb@suse.de>
Fri, 20 Jul 2007 06:10:55 +0000 (16:10 +1000)
commit14f4a50b4b51bc4bdf56cfd43d8ae598579c4e6d
treeb664579f2051c2f7bb3d141e91ccbf7c4fb53546
parentc0f7366f3ae8de8a62e3cc6824080e02e780f3b2
mount.nfs: No need to return nfs_mount_data structs

Refactor mount processing slightly to remove an output parameter and an
unnecessary type cast.  The mount syscall is now made from inside
nfs_mount or nfs4mount, rather than in common code after those are called.

Code review suggests that EX_BG was never returned by mount.nfs because the
logic I just replaced was always returning EX_FAIL.  The new logic should
properly return EX_BG when appropriate.

However, it is unclear whether /bin/mount handles backgrounding the mount
request, or whether mount.nfs should.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Neil Brown <neilb@suse.de>
utils/mount/mount.c
utils/mount/nfs4_mount.h
utils/mount/nfs4mount.c
utils/mount/nfs_mount.h
utils/mount/nfsmount.c