Accessors for everything

[maypole.git] / lib / Maypole.pm

diff --git a/lib/Maypole.pm b/lib/Maypole.pm
index 29c8917d81022b5ed699c76c8f0b196677fd6d3f..dd9ff770a1827ca393dd4361509222461135f1b7 100644 (file)
--- a/lib/Maypole.pm
+++ b/lib/Maypole.pm
@@ -1,15 +1,15 @@
 package Maypole;
-use base qw(Class::Accessor Class::Data::Inheritable);
+use base qw(Class::Accessor::Fast Class::Data::Inheritable);
 use attributes ();
 use UNIVERSAL::require;
 use strict;
 use warnings;
 use Maypole::Config;
-our $VERSION = "1.8";
+our $VERSION = '2.0';
 __PACKAGE__->mk_classdata($_) for qw( config init_done view_object );
 __PACKAGE__->mk_accessors(
-    qw( ar params query objects model_class
-      args action template )
+    qw( ar params query objects model_class template_args output path
+      args action template error document_encoding content_type table)
 );
 __PACKAGE__->config( Maypole::Config->new() );
 __PACKAGE__->init_done(0);
@@ -45,8 +45,9 @@ sub init {
     my $config = $class->config;
     $config->view || $config->view("Maypole::View::TT");
     $config->view->require;
-    die "Couldn't load the view class ".$config->view.": $@" if $@;
-    $config->display_tables || $config->display_tables([ $class->config->tables ]);
+    die "Couldn't load the view class " . $config->view . ": $@" if $@;
+    $config->display_tables
+      || $config->display_tables( [ $class->config->tables ] );
     $class->view_object( $class->config->view->new );
     $class->init_done(1);
 
@@ -66,6 +67,7 @@ sub handler {
     return $status;
 }
 
+# The root of all evil
 sub handler_guts {
     my $r = shift;
     $r->model_class( $r->config->model->class_of( $r, $r->{table} ) );
@@ -111,7 +113,7 @@ sub handler_guts {
         if ( my $error = $@ ) {
             $status = $r->call_exception($error);
             if ( $status != OK ) {
-                warn "caught view error: $error";
+                warn "caught view error: $error" if $r->debug;
                 return $r->debug ? $r->view_object->error( $r, $error ) : ERROR;
             }
         }
@@ -123,8 +125,8 @@ sub handler_guts {
 sub is_applicable {
     my $self   = shift;
     my $config = $self->config;
-    $config->ok_tables || $config->ok_tables($config->display_tables);
-    $config->ok_tables ({ map { $_ => 1 } @{ $config->ok_tables } })
+    $config->ok_tables || $config->ok_tables( $config->display_tables );
+    $config->ok_tables( { map { $_ => 1 } @{ $config->ok_tables } } )
       if ref $config->ok_tables eq "ARRAY";
     warn "We don't have that table ($self->{table})"
       if $self->debug
@@ -219,7 +221,7 @@ for the designers to customize, and then write an Apache handler like
 this:
 
     package ProductDatabase;
-    use base 'Apache::MVC';
+    use base 'Maypole::Application';
     __PACKAGE__->set_database("dbi:mysql:products");
     ProductDatabase->config->uri_base = "http://your.site/catalogue/";
     ProductDatabase::Product->has_a("category" => ProductDatabase::Category); 
@@ -303,7 +305,8 @@ You should probably not use Maypole directly. Maypole is an abstract
 class which does not specify how to communicate with the outside world.
 The most popular subclass of Maypole is L<Apache::MVC>, which interfaces
 the Maypole framework to Apache mod_perl; another important one is
-L<CGI::Maypole>.
+L<CGI::Maypole>. However, if you just don't care, use Maypole::Application,
+and it will choose the right one for you.
 
 If you are implementing Maypole subclasses, you need to provide at least
 the C<parse_location> and C<send_output> methods. You may also want to
@@ -329,7 +332,7 @@ There's more documentation, examples, and a wiki at the Maypole web site:
 
 http://maypole.simon-cozens.org/
 
-L<Apache::MVC>, L<CGI::Maypole>.
+L<Maypole::Application>,L<Apache::MVC>, L<CGI::Maypole>.
 
 =head1 MAINTAINER
 
@@ -341,8 +344,8 @@ Simon Cozens, C<simon@cpan.org>
 
 =head1 THANK YOU
 
-Jesse Scheidlower, Jody Belka, Markus Ramberg, Mickael Joanne, Simon Flack,
-Veljko Vidovic and all the others who've helped.
+Danijel Milicevic, Jesse Scheidlower, Jody Belka, Marcus Ramberg,
+Mickael Joanne, Simon Flack, Veljko Vidovic and all the others who've helped.
 
 =head1 LICENSE