]> git.decadent.org.uk Git - nfs-utils.git/commit
libnfs.a: move mnt_{open, close}clnt calls to utils/mount/network.c
authorChuck Lever <chuck.lever@oracle.com>
Sat, 28 Jul 2007 21:50:30 +0000 (17:50 -0400)
committerNeil Brown <neilb@suse.de>
Mon, 30 Jul 2007 06:12:53 +0000 (16:12 +1000)
commit3eb619857b2f2fe896877c903a2c2eb28b632945
tree60026acb3f9a7413e88e8f0b544f5ead25b7d548
parent7b763f58bb882caf4fbe44d9668237c4d3e77728
libnfs.a: move mnt_{open, close}clnt calls to utils/mount/network.c

It turns out that get_socket() accesses a global variable, "verbose," that
is only available in the mount command; yet it's in libnfs.a.  This creates
an undocumented API dependency that will bite someone someday.  This
mount-specific functionality doesn't really belong in libnfs.a anyway.

The simplest way to resolve this is to move all of the functions in
support/nfs/conn.c into utils/mount.  network.c seems like the logical
place to put these.  An added benefit is we eventually get to make
get_socket() static.

Let's start with the mnt_{open,close}clnt functions.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Neil Brown <neilb@suse.de>
support/include/conn.h
support/nfs/conn.c
utils/mount/network.c
utils/mount/network.h