From ff82d8688cd096f3983532e8aa5cbfe46780d45a Mon Sep 17 00:00:00 2001 From: Jeff Layton Date: Tue, 7 Aug 2007 08:01:08 -0400 Subject: [PATCH] nfs-utils: specify a create mode with open(...O_CREAT) call in xflock The xflock function can create a file via open() with O_CREAT, but does not specify the create mode when it does so. I think 0644 should be appropriate given the current usage of this function. Signed-off-by: Jeff Layton Signed-off-by: Neil Brown --- support/nfs/xio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/support/nfs/xio.c b/support/nfs/xio.c index 221cce6..0453ca7 100644 --- a/support/nfs/xio.c +++ b/support/nfs/xio.c @@ -57,7 +57,7 @@ xflock(char *fname, char *type) struct flock fl = { readonly? F_RDLCK : F_WRLCK, SEEK_SET, 0, 0, 0 }; int fd; - if ((fd = open(fname, readonly? O_RDONLY : (O_RDWR|O_CREAT))) < 0) { + if ((fd = open(fname, readonly? O_RDONLY : (O_RDWR|O_CREAT), 0644)) < 0) { xlog(L_WARNING, "could not open %s for locking", fname); return -1; } -- 2.39.2