From 399cc3dad0cdfe8dca4a0ae9035a0554d7223eb2 Mon Sep 17 00:00:00 2001 From: Steve Dickson Date: Thu, 17 Jan 2008 11:25:37 -0500 Subject: [PATCH] Stop segfaults on amd64 during warnings messages by creating a second va_list in xlog_backend() and then use that va_list to print messages on stderr. Signed-off-by: Steinar H. Gunderson Signed-off-by: Steve Langasek Signed-off-by: Steve Dickson --- support/nfs/xlog.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/support/nfs/xlog.c b/support/nfs/xlog.c index 26123c5..6820346 100644 --- a/support/nfs/xlog.c +++ b/support/nfs/xlog.c @@ -133,9 +133,14 @@ xlog_enabled(int fac) void xlog_backend(int kind, const char *fmt, va_list args) { + va_list args2; + if (!(kind & (L_ALL)) && !(logging && (kind & logmask))) return; + if (log_stderr) + va_copy(args2, args); + if (log_syslog) { switch (kind) { case L_FATAL: @@ -171,9 +176,9 @@ xlog_backend(int kind, const char *fmt, va_list args) #else fprintf(stderr, "%s: ", log_name); #endif - - vfprintf(stderr, fmt, args); + vfprintf(stderr, fmt, args2); fprintf(stderr, "\n"); + va_end(args2); } if (kind == L_FATAL) -- 2.39.2