From 29637ac0140db80744b24b0c5d655d435b69ba35 Mon Sep 17 00:00:00 2001 From: Chuck Lever Date: Tue, 21 Aug 2007 12:19:08 -0400 Subject: [PATCH] mount.nfs: Replace fork() with daemon() for backgrounding mounts Neil recommended this change to address a problem with background mount processes handling signals properly during an init level change. It is also useful for preventing background mount processes from reporting progress on the parent's tty, which is generally just annoying noise. Signed-off-by: Chuck Lever Signed-off-by: Neil Brown --- utils/mount/mount.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/utils/mount/mount.c b/utils/mount/mount.c index 4b78021..2513943 100644 --- a/utils/mount/mount.c +++ b/utils/mount/mount.c @@ -550,14 +550,19 @@ int main(int argc, char *argv[]) mnt_err = try_mount(spec, mount_point, flags, fs_type, &extra_opts, mount_opts, fake, nomtab, FOREGROUND); if (mnt_err == EX_BG) { - printf(_("mount: backgrounding \"%s\"\n"), spec); + printf(_("%s: backgrounding \"%s\"\n"), + progname, spec); fflush(stdout); /* * Parent exits immediately with success. */ - if (fork() > 0) - exit(0); + if (daemon(0, 0)) { + nfs_error(_("%s: failed to start " + "background process: %s\n"), + progname, strerror(errno)); + exit(EX_FAIL); + } mnt_err = try_mount(spec, mount_point, flags, fs_type, &extra_opts, mount_opts, fake, -- 2.39.2