From: J. Bruce Fields Date: Mon, 6 Aug 2012 12:55:45 +0000 (-0400) Subject: rpc.gssd: don't call printerr from signal handler X-Git-Tag: debian/1%1.2.8-1~11^2^2~99 X-Git-Url: https://git.decadent.org.uk/gitweb/?p=nfs-utils.git;a=commitdiff_plain;h=d9f51f267e459c975833ac853ce41809ca492ab0;hp=6019ff50055ee189557b55aad781bb12beb95e19 rpc.gssd: don't call printerr from signal handler From: "J. Bruce Fields" printerr() isn't actually safe to call from a signal handler. It might be possible to make it so, but I think this is the only case in nfs-utils where we try to, and I'm not convince it's worth it. This fixes a bug that would eventually cause mounts to hang when gssd is run with -vv. Signed-off-by: J. Bruce Fields Signed-off-by: Steve Dickson --- diff --git a/utils/gssd/gssd_main_loop.c b/utils/gssd/gssd_main_loop.c index 9954ffb..6914687 100644 --- a/utils/gssd/gssd_main_loop.c +++ b/utils/gssd/gssd_main_loop.c @@ -61,10 +61,8 @@ extern int pollsize; static volatile int dir_changed = 1; -static void dir_notify_handler(int sig) +static void dir_notify_handler(__attribute__((unused))int sig) { - printerr(2, "dir_notify_handler: sig %d\n", sig); - dir_changed = 1; }