From: Masatake YAMATO <yamato@redhat.com>
Date: Tue, 12 Jul 2011 14:00:01 +0000 (-0400)
Subject: exportfs: closing fd associated with /proc/fs/nfsd/export_features
X-Git-Tag: nfs-utils-1-2-5-rc1~7
X-Git-Url: https://git.decadent.org.uk/gitweb/?p=nfs-utils.git;a=commitdiff_plain;h=c4c6126f05713afe46c0e99647d7a07dd1fc2ebb

exportfs: closing fd associated with /proc/fs/nfsd/export_features

The fd associated with /proc/fs/nfsd/export_features opened in
get_export_features is not closed.

Acked-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Steve Dickson <steved@redhat.com>
---

diff --git a/support/nfs/exports.c b/support/nfs/exports.c
index c250383..c96500f 100644
--- a/support/nfs/exports.c
+++ b/support/nfs/exports.c
@@ -784,8 +784,9 @@ struct export_features *get_export_features(void)
 	fd = open(path, O_RDONLY);
 	if (fd == -1)
 		goto good;
-	fd = read(fd, buf, 50);
-	if (fd == -1)
+	c = read(fd, buf, 50);
+	close(fd);
+	if (c == -1)
 		goto err;
 	c = sscanf(buf, "%x %x", &ef.flags, &ef.secinfo_flags);
 	if (c != 2)