From: Neil Brown <neilb@suse.de>
Date: Mon, 19 Mar 2007 23:14:44 +0000 (+1100)
Subject: statd - delay drop-privs until sockets have been setup.
X-Git-Tag: nfs-utils-1-1-0-rc1~33
X-Git-Url: https://git.decadent.org.uk/gitweb/?p=nfs-utils.git;a=commitdiff_plain;h=3482b1145c2c9a39f1dcaabc32e36eb234b91447

statd - delay drop-privs until sockets have been setup.

Registering sockets with portmap might require root privs,
so don't drop privs until that has been done.
---

diff --git a/utils/statd/statd.c b/utils/statd/statd.c
index 17e2947..157de85 100644
--- a/utils/statd/statd.c
+++ b/utils/statd/statd.c
@@ -251,6 +251,7 @@ int main (int argc, char **argv)
 	int arg;
 	int port = 0, out_port = 0;
 	struct rlimit rlim;
+	int once = 1;
 
 	int pipefds[2] = { -1, -1};
 	char status;
@@ -474,7 +475,6 @@ int main (int argc, char **argv)
 			waitpid(pid, NULL, 0);
 		}
 
-	drop_privs();
 
 	for (;;) {
 		pmap_unset (SM_PROG, SM_VERS);
@@ -490,6 +490,10 @@ int main (int argc, char **argv)
 		/* this registers both UDP and TCP services */
 		rpc_init("statd", SM_PROG, SM_VERS, sm_prog_1, port);
 
+		if (once) {
+			once = 0;
+			drop_privs();
+		}
 		/*
 		 * Handle incoming requests:  SM_NOTIFY socket requests, as
 		 * well as callbacks from lockd.