mount.nfs: add EX_SUCCESS exit code

We've had some recent trouble, especially in the umount code, that appears
to be due to functions returning a 1 or a 0 return code when they should be
returning a mount exit code (such as EX_FAIL) or a 0.

To help clearly distinguish these two classes of functions, define an
EX_SUCCESS exit code, which is equal to zero.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Neil Brown <neilb@suse.de>

diff --git a/support/include/xcommon.h b/support/include/xcommon.h
index 9e23d12fb77c7465028eb9e62d7d1729532c447e..d1a4b18cae655611e8fbba8d7f5d62432f129a74 100644 (file)
--- a/support/include/xcommon.h
+++ b/support/include/xcommon.h
@@ -36,6 +36,7 @@ extern void die(int err, const char *fmt, ...);
 extern void (*at_die)(void);
 
 /* exit status - bits below are ORed */
+#define EX_SUCCESS     0       /* no failure occurred */
 #define EX_USAGE       1       /* incorrect invocation or permission */
 #define EX_SYSERR      2       /* out of memory, cannot fork, ... */
 #define EX_SOFTWARE    4       /* internal mount bug or wrong version */